From bd038e1b61fd717567ac84186229ad328fe5f8aa Mon Sep 17 00:00:00 2001 From: Jingchen Date: Tue, 14 Jul 2026 13:59:47 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com> --- src/libxrpl/tx/invariants/VaultInvariant.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libxrpl/tx/invariants/VaultInvariant.cpp b/src/libxrpl/tx/invariants/VaultInvariant.cpp index c3dd5c5754..e9306b7e4d 100644 --- a/src/libxrpl/tx/invariants/VaultInvariant.cpp +++ b/src/libxrpl/tx/invariants/VaultInvariant.cpp @@ -479,7 +479,11 @@ ValidVault::finalize( // pending loan (Borrower present, CounterpartySignature absent). if (afterVault.assetsReserved != beforeVault.assetsReserved) { - bool const pendingLoanSet = txnType == ttLOAN_SET && tx.isFieldPresent(sfBorrower) && + bool const pendingLoanSet = txnType == ttLOAN_SET && + tx.isFieldPresent(sfBorrower) && + tx.isFieldPresent(sfStartDate) && + !tx.isFieldPresent(sfCounterpartySignature) && + !tx.isFieldPresent(sfCounterparty); !tx.isFieldPresent(sfCounterpartySignature); if (txnType != ttLOAN_DELETE && txnType != ttLOAN_ACCEPT && !pendingLoanSet) {