Review feedback from @dangell7 and @mvadari

- Rewrite isTesSuccess to use TERSubset::operator bool
- Add Transactor::preflightSigValidated for expensive operations that
  should be done after signature validation. These things would have
  been done after preflight2 before this refactor.
- Split Batch and EscrowFinish preflight to use preflightSigValidated, too.
This commit is contained in:
Ed Hennis
2025-09-03 20:51:40 -04:00
parent 11b8f9978e
commit bb491431bd
7 changed files with 52 additions and 3 deletions

View File

@@ -673,7 +673,8 @@ isTerRetry(TER x) noexcept
inline bool
isTesSuccess(TER x) noexcept
{
return (x == tesSUCCESS);
// Makes use of TERSubset::operator bool()
return !(x);
}
inline bool