diff --git a/src/xrpld/app/main/Application.cpp b/src/xrpld/app/main/Application.cpp index cad96f382b..29fb2dd0e9 100644 --- a/src/xrpld/app/main/Application.cpp +++ b/src/xrpld/app/main/Application.cpp @@ -79,6 +79,7 @@ #include #include #include +#include #include #include #include diff --git a/src/xrpld/app/main/GRPCServer.cpp b/src/xrpld/app/main/GRPCServer.cpp index 7e5ee166a9..eeb4797b19 100644 --- a/src/xrpld/app/main/GRPCServer.cpp +++ b/src/xrpld/app/main/GRPCServer.cpp @@ -50,6 +50,7 @@ #include #include #include +#include #include #include diff --git a/src/xrpld/app/main/GrpcSpanNames.h b/src/xrpld/app/main/GrpcSpanNames.h index bea632fdfc..869d5628aa 100644 --- a/src/xrpld/app/main/GrpcSpanNames.h +++ b/src/xrpld/app/main/GrpcSpanNames.h @@ -20,9 +20,7 @@ #include -namespace xrpl { -namespace telemetry { -namespace grpc_span { +namespace xrpl::telemetry::grpc_span { // ===== Span prefixes ======================================================= @@ -59,6 +57,4 @@ inline constexpr auto resourceExhausted = makeStr("resource_exhausted"); inline constexpr auto failedPrecondition = makeStr("failed_precondition"); } // namespace val -} // namespace grpc_span -} // namespace telemetry -} // namespace xrpl +} // namespace xrpl::telemetry::grpc_span diff --git a/src/xrpld/rpc/detail/RPCHandler.cpp b/src/xrpld/rpc/detail/RPCHandler.cpp index d64c890c89..b7968ab070 100644 --- a/src/xrpld/rpc/detail/RPCHandler.cpp +++ b/src/xrpld/rpc/detail/RPCHandler.cpp @@ -215,11 +215,19 @@ doCommand(RPC::JsonContext& context, Json::Value& result) Handler const* handler = nullptr; if (auto error = fillHandler(context, handler)) { - std::string cmdName = "unknown"; + std::string cmdName; if (context.params.isMember(jss::command)) + { cmdName = context.params[jss::command].asString(); + } else if (context.params.isMember(jss::method)) + { cmdName = context.params[jss::method].asString(); + } + else + { + cmdName = "unknown"; + } auto span = SpanGuard::span( TraceCategory::Rpc, rpc_span::prefix::command, rpc_span::val::unknownCommand); span.setAttribute(rpc_span::attr::command, cmdName.c_str()); diff --git a/src/xrpld/rpc/detail/ServerHandler.cpp b/src/xrpld/rpc/detail/ServerHandler.cpp index 9c9b34ec6e..85454e4a29 100644 --- a/src/xrpld/rpc/detail/ServerHandler.cpp +++ b/src/xrpld/rpc/detail/ServerHandler.cpp @@ -8,7 +8,7 @@ #include #include #include -#include +#include // IWYU pragma: keep #include #include