diff --git a/OpenTelemetryPlan/02-design-decisions.md b/OpenTelemetryPlan/02-design-decisions.md index 09484baaae..974a5fb698 100644 --- a/OpenTelemetryPlan/02-design-decisions.md +++ b/OpenTelemetryPlan/02-design-decisions.md @@ -246,7 +246,6 @@ keys (the dotted form is reserved for resource scope per §2.3.3). | `tx_result` | string | `"tesSUCCESS"`, `"tecPATH_DRY"`, etc. | | `current_ledger_seq` | int64 | Open ledger the transaction targeted | | `relay_count` | int64 | Peers the transaction was relayed to | -| `suppressed` | bool | `true` when HashRouter dropped a dup | > **Note:** `current_ledger_seq` and `ledger_seq` are the same concept — a ledger's sequence number — but they name different ledgers, so the design keeps two keys rather than one. `current_ledger_seq` is the open or in-flight ledger a transaction's work was applied into; it is named after the RPC field `ledger_current_index`. `ledger_seq` (see [Ledger & Job Attributes](#ledger--job-attributes)) is a closed or validated ledger, set by the ledger and consensus spans. Neither is spelled `ledger_index`: per rule 2 of [Telemetry span attribute naming](../CONTRIBUTING.md#telemetry-span-attribute-naming), one concept gets one key reused verbatim, and a different referent is disambiguated with a prefix rather than a synonym. diff --git a/OpenTelemetryPlan/06-implementation-phases.md b/OpenTelemetryPlan/06-implementation-phases.md index c7fc9af1e2..9f80259bd4 100644 --- a/OpenTelemetryPlan/06-implementation-phases.md +++ b/OpenTelemetryPlan/06-implementation-phases.md @@ -444,13 +444,13 @@ Clear, measurable criteria for each phase. ### 6.10.3 Phase 3: Transaction Tracing -| Criterion | Measurement | Target | -| ---------------- | ------------------------------- | ---------------------------------- | -| Local Trace | Submit → validate → TxQ traced | Single-node test passes | -| Cross-Node | Context propagates via protobuf | Multi-node test passes | -| Relay Visibility | relay_count attribute correct | Spot check 100 txs | -| HashRouter | Deduplication visible in trace | Duplicate txs show suppressed=true | -| Performance | TX throughput overhead | <5% degradation | +| Criterion | Measurement | Target | +| ---------------- | ------------------------------- | -------------------------- | +| Local Trace | Submit → validate → TxQ traced | Single-node test passes | +| Cross-Node | Context propagates via protobuf | Multi-node test passes | +| Relay Visibility | relay_count attribute correct | Spot check 100 txs | +| HashRouter | Deduplication visible | Duplicates produce no span | +| Performance | TX throughput overhead | <5% degradation | **Definition of Done**: Transaction traces span 3+ nodes in test network, performance within bounds.