From c6be7cf83a626ea3c0ae3272acb28c356969ebf1 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Wed, 8 Jul 2026 15:17:58 +0100 Subject: [PATCH] fix(telemetry): resolve clang-tidy CI errors (include-cleaner, braces) Add missing include for std::uint32_t in Telemetry.h. Add braces around single-line if bodies in Telemetry.cpp. Co-Authored-By: Claude Opus 4.6 --- include/xrpl/telemetry/Telemetry.h | 1 + src/libxrpl/telemetry/Telemetry.cpp | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/include/xrpl/telemetry/Telemetry.h b/include/xrpl/telemetry/Telemetry.h index f6d2528795..3a2e5d8885 100644 --- a/include/xrpl/telemetry/Telemetry.h +++ b/include/xrpl/telemetry/Telemetry.h @@ -75,6 +75,7 @@ #include #include +#include #include #include #include diff --git a/src/libxrpl/telemetry/Telemetry.cpp b/src/libxrpl/telemetry/Telemetry.cpp index b23ac9e83b..aa6447c5bb 100644 --- a/src/libxrpl/telemetry/Telemetry.cpp +++ b/src/libxrpl/telemetry/Telemetry.cpp @@ -273,7 +273,9 @@ public: otlp_http::OtlpHttpExporterOptions exporterOpts; exporterOpts.url = setup_.exporterEndpoint; if (setup_.useTls) + { exporterOpts.ssl_ca_cert_path = setup_.tlsCertPath; + } auto exporter = otlp_http::OtlpHttpExporterFactory::Create(exporterOpts); @@ -392,7 +394,9 @@ public: getTracer(std::string_view name = kTracerName) override { if (!sdkProvider_) + { return trace_api::Provider::GetTracerProvider()->GetTracer(std::string(name)); + } return sdkProvider_->GetTracer(std::string(name)); } @@ -425,7 +429,9 @@ std::unique_ptr makeTelemetry(Telemetry::Setup const& setup, beast::Journal journal) { if (setup.enabled) + { return std::make_unique(setup, journal); + } return std::make_unique(setup); }