diff --git a/include/xrpl/ledger/helpers/EscrowHelpers.h b/include/xrpl/ledger/helpers/EscrowHelpers.h index bdb83230eb..dc7c479c42 100644 --- a/include/xrpl/ledger/helpers/EscrowHelpers.h +++ b/include/xrpl/ledger/helpers/EscrowHelpers.h @@ -42,7 +42,7 @@ escrowUnlockApplyHelper( beast::Journal journal) { Issue const& issue = amount.get(); - Keylet const trustLineKey = keylet::line(receiver, issue); + Keylet const trustLineKey = keylet::trustLine(receiver, issue); bool const recvLow = issuer > receiver; bool const senderIssuer = issuer == sender; bool const receiverIssuer = issuer == receiver; @@ -175,7 +175,7 @@ escrowUnlockApplyHelper( bool const receiverIssuer = issuer == receiver; auto const mptID = amount.get().getMptID(); - auto const issuanceKey = keylet::mptIssuance(mptID); + auto const issuanceKey = keylet::mptokenIssuance(mptID); if (!view.exists(keylet::mptoken(issuanceKey.key, receiver)) && createAsset && !receiverIssuer) { if (std::uint32_t const ownerCount = {sleDest->at(sfOwnerCount)}; diff --git a/include/xrpl/protocol/Indexes.h b/include/xrpl/protocol/Indexes.h index 887a208ec6..75a2335f6f 100644 --- a/include/xrpl/protocol/Indexes.h +++ b/include/xrpl/protocol/Indexes.h @@ -68,21 +68,15 @@ skip(LedgerIndex ledger) noexcept; /** The (fixed) index of the object containing the ledger fees. */ Keylet const& -fees() noexcept; +feeSettings() noexcept; /** The (fixed) index of the object containing the ledger negativeUNL. */ Keylet const& negativeUNL() noexcept; /** The beginning of an order book */ -struct BookT -{ - explicit BookT() = default; - - Keylet - operator()(Book const& b) const; -}; -static BookT const kBook{}; +Keylet +book(Book const& b); /** The index of a trust line for a given currency @@ -93,12 +87,12 @@ static BookT const kBook{}; */ /** @{ */ Keylet -line(AccountID const& id0, AccountID const& id1, Currency const& currency) noexcept; +trustLine(AccountID const& id0, AccountID const& id1, Currency const& currency) noexcept; inline Keylet -line(AccountID const& id, Issue const& issue) noexcept +trustLine(AccountID const& id, Issue const& issue) noexcept { - return line(id, issue.account, issue.currency); + return trustLine(id, issue.account, issue.currency); } /** @} */ @@ -119,37 +113,27 @@ Keylet quality(Keylet const& k, std::uint64_t q) noexcept; /** The directory for the next lower quality */ -struct NextT -{ - explicit NextT() = default; - - Keylet - operator()(Keylet const& k) const; -}; -static NextT const kNext{}; +Keylet +next(Keylet const& k); /** A ticket belonging to an account */ -struct TicketT +/** @{ */ +Keylet +ticket(AccountID const& id, std::uint32_t ticketSeq); + +Keylet +ticket(AccountID const& id, SeqProxy ticketSeq); + +inline Keylet +ticket(uint256 const& key) { - explicit TicketT() = default; - - Keylet - operator()(AccountID const& id, std::uint32_t ticketSeq) const; - - Keylet - operator()(AccountID const& id, SeqProxy ticketSeq) const; - - Keylet - operator()(uint256 const& key) const - { - return {ltTICKET, key}; - } -}; -static TicketT const kTicket{}; + return {ltTICKET, key}; +} +/** @} */ /** A SignerList */ Keylet -signers(AccountID const& account) noexcept; +signerList(AccountID const& account) noexcept; /** A Check */ /** @{ */ @@ -209,7 +193,7 @@ escrow(AccountID const& src, std::uint32_t seq) noexcept; /** A PaymentChannel */ Keylet -payChan(AccountID const& src, AccountID const& dst, std::uint32_t seq) noexcept; +payChannel(AccountID const& src, AccountID const& dst, std::uint32_t seq) noexcept; /** NFT page keylets @@ -221,22 +205,22 @@ payChan(AccountID const& src, AccountID const& dst, std::uint32_t seq) noexcept; /** @{ */ /** A keylet for the owner's first possible NFT page. */ Keylet -nftpageMin(AccountID const& owner); +nftokenPageMin(AccountID const& owner); /** A keylet for the owner's last possible NFT page. */ Keylet -nftpageMax(AccountID const& owner); +nftokenPageMax(AccountID const& owner); Keylet -nftpage(Keylet const& k, uint256 const& token); +nftokenPage(Keylet const& k, uint256 const& token); /** @} */ /** An offer from an account to buy or sell an NFT */ Keylet -nftoffer(AccountID const& owner, std::uint32_t seq); +nftokenOffer(AccountID const& owner, std::uint32_t seq); inline Keylet -nftoffer(uint256 const& offer) +nftokenOffer(uint256 const& offer) { return {ltNFTOKEN_OFFER, offer}; } @@ -287,13 +271,13 @@ credential(uint256 const& key) noexcept } Keylet -mptIssuance(std::uint32_t seq, AccountID const& issuer) noexcept; +mptokenIssuance(std::uint32_t seq, AccountID const& issuer) noexcept; Keylet -mptIssuance(MPTID const& issuanceID) noexcept; +mptokenIssuance(MPTID const& issuanceID) noexcept; inline Keylet -mptIssuance(uint256 const& issuanceKey) +mptokenIssuance(uint256 const& issuanceKey) { return {ltMPTOKEN_ISSUANCE, issuanceKey}; } @@ -320,10 +304,10 @@ vault(uint256 const& vaultKey) } Keylet -loanbroker(AccountID const& owner, std::uint32_t seq) noexcept; +loanBroker(AccountID const& owner, std::uint32_t seq) noexcept; inline Keylet -loanbroker(uint256 const& key) +loanBroker(uint256 const& key) { return {ltLOAN_BROKER, key}; } @@ -376,11 +360,15 @@ struct KeyletDesc std::array, 6> const kDirectAccountKeylets{ {{.function = &keylet::account, .expectedLEName = jss::AccountRoot, .includeInTests = false}, {.function = &keylet::ownerDir, .expectedLEName = jss::DirectoryNode, .includeInTests = true}, - {.function = &keylet::signers, .expectedLEName = jss::SignerList, .includeInTests = true}, + {.function = &keylet::signerList, .expectedLEName = jss::SignerList, .includeInTests = true}, // It's normally impossible to create an item at nftpage_min, but // test it anyway, since the invariant checks for it. - {.function = &keylet::nftpageMin, .expectedLEName = jss::NFTokenPage, .includeInTests = true}, - {.function = &keylet::nftpageMax, .expectedLEName = jss::NFTokenPage, .includeInTests = true}, + {.function = &keylet::nftokenPageMin, + .expectedLEName = jss::NFTokenPage, + .includeInTests = true}, + {.function = &keylet::nftokenPageMax, + .expectedLEName = jss::NFTokenPage, + .includeInTests = true}, {.function = &keylet::did, .expectedLEName = jss::DID, .includeInTests = true}}}; MPTID diff --git a/include/xrpl/protocol/detail/ledger_entries.macro b/include/xrpl/protocol/detail/ledger_entries.macro index 632038a9c5..e0ea1a61c3 100644 --- a/include/xrpl/protocol/detail/ledger_entries.macro +++ b/include/xrpl/protocol/detail/ledger_entries.macro @@ -21,7 +21,7 @@ /** A ledger object which identifies an offer to buy or sell an NFT. - \sa keylet::nftoffer + \sa keylet::nftokenOffer */ LEDGER_ENTRY(ltNFTOKEN_OFFER, 0x0037, NFTokenOffer, nft_offer, ({ {sfOwner, SoeRequired}, @@ -84,7 +84,7 @@ LEDGER_ENTRY(ltNEGATIVE_UNL, 0x004e, NegativeUNL, nunl, ({ /** A ledger object which contains a list of NFTs - \sa keylet::nftpageMin, keylet::nftpageMax, keylet::nftpage + \sa keylet::nftokenPageMin, keylet::nftokenPageMax, keylet::nftokenPage */ LEDGER_ENTRY(ltNFTOKEN_PAGE, 0x0050, NFTokenPage, nft_page, ({ {sfPreviousPageMin, SoeOptional}, @@ -96,7 +96,7 @@ LEDGER_ENTRY(ltNFTOKEN_PAGE, 0x0050, NFTokenPage, nft_page, ({ /** A ledger object which contains a signer list for an account. - \sa keylet::signers + \sa keylet::signerList */ // All fields are SoeRequired because there is always a SignerEntries. // If there are no SignerEntries the node is deleted. @@ -112,7 +112,7 @@ LEDGER_ENTRY(ltSIGNER_LIST, 0x0053, SignerList, signer_list, ({ /** A ledger object which describes a ticket. - \sa keylet::kTicket + \sa keylet::ticket */ LEDGER_ENTRY(ltTICKET, 0x0054, Ticket, ticket, ({ {sfAccount, SoeRequired}, @@ -272,7 +272,7 @@ LEDGER_ENTRY(ltXCHAIN_OWNED_CLAIM_ID, 0x0071, XChainOwnedClaimID, xchain_owned_c @note Per Vinnie Falco this should be renamed to ltTRUST_LINE - \sa keylet::line + \sa keylet::trustLine */ LEDGER_ENTRY(ltRIPPLE_STATE, 0x0072, RippleState, state, ({ {sfBalance, SoeRequired}, @@ -292,7 +292,7 @@ LEDGER_ENTRY(ltRIPPLE_STATE, 0x0072, RippleState, state, ({ \note This is a singleton: only one such object exists in the ledger. - \sa keylet::fees + \sa keylet::feeSettings */ LEDGER_ENTRY(ltFEE_SETTINGS, 0x0073, FeeSettings, fee, ({ // Old version uses raw numbers @@ -346,7 +346,7 @@ LEDGER_ENTRY(ltESCROW, 0x0075, Escrow, escrow, ({ /** A ledger object describing a single unidirectional XRP payment channel. - \sa keylet::payChan + \sa keylet::payChannel */ LEDGER_ENTRY(ltPAYCHAN, 0x0078, PayChannel, payment_channel, ({ {sfAccount, SoeRequired}, @@ -384,7 +384,7 @@ LEDGER_ENTRY(ltAMM, 0x0079, AMM, amm, ({ })) /** A ledger object which tracks MPTokenIssuance - \sa keylet::mptIssuance + \sa keylet::mptokenIssuance */ LEDGER_ENTRY(ltMPTOKEN_ISSUANCE, 0x007e, MPTokenIssuance, mpt_issuance, ({ {sfIssuer, SoeRequired}, @@ -499,7 +499,7 @@ LEDGER_ENTRY(ltVAULT, 0x0084, Vault, vault, ({ /** A ledger object representing a loan broker - \sa keylet::loanbroker + \sa keylet::loanBroker */ LEDGER_ENTRY(ltLOAN_BROKER, 0x0088, LoanBroker, loan_broker, ({ {sfPreviousTxnID, SoeRequired}, diff --git a/include/xrpl/protocol/nft.h b/include/xrpl/protocol/nft.h index 1e79b3f285..54227dd1ea 100644 --- a/include/xrpl/protocol/nft.h +++ b/include/xrpl/protocol/nft.h @@ -52,7 +52,7 @@ getTransferFee(uint256 const& id) } inline std::uint32_t -getSerial(uint256 const& id) +getSequence(uint256 const& id) { std::uint32_t seq = 0; memcpy(&seq, id.begin() + 28, 4); @@ -92,7 +92,7 @@ getTaxon(uint256 const& id) // The taxon cipher is just an XOR, so it is reversible by applying the // XOR a second time. - return cipheredTaxon(getSerial(id), toTaxon(taxon)); + return cipheredTaxon(getSequence(id), toTaxon(taxon)); } inline AccountID diff --git a/include/xrpl/tx/paths/detail/StepChecks.h b/include/xrpl/tx/paths/detail/StepChecks.h index fea9f90a31..4955c4f8e6 100644 --- a/include/xrpl/tx/paths/detail/StepChecks.h +++ b/include/xrpl/tx/paths/detail/StepChecks.h @@ -27,7 +27,7 @@ checkFreeze( } } - if (auto sle = view.read(keylet::line(src, dst, currency))) + if (auto sle = view.read(keylet::trustLine(src, dst, currency))) { if (sle->isFlag((dst > src) ? lsfHighFreeze : lsfLowFreeze)) { @@ -71,8 +71,8 @@ checkNoRipple( beast::Journal j) { // fetch the ripple lines into and out of this node - auto sleIn = view.read(keylet::line(prev, cur, currency)); - auto sleOut = view.read(keylet::line(cur, next, currency)); + auto sleIn = view.read(keylet::trustLine(prev, cur, currency)); + auto sleOut = view.read(keylet::trustLine(cur, next, currency)); if (!sleIn || !sleOut) return terNO_LINE; diff --git a/src/libxrpl/ledger/Ledger.cpp b/src/libxrpl/ledger/Ledger.cpp index 82956650e2..188fb3cd2c 100644 --- a/src/libxrpl/ledger/Ledger.cpp +++ b/src/libxrpl/ledger/Ledger.cpp @@ -180,7 +180,7 @@ Ledger::Ledger( } { - auto sle = std::make_shared(keylet::fees()); + auto sle = std::make_shared(keylet::feeSettings()); // Whether featureXRPFees is supported will depend on startup options. if (std::ranges::find(amendments, featureXRPFees) != amendments.end()) { @@ -560,7 +560,7 @@ Ledger::setup() try { - if (auto const sle = read(keylet::fees())) + if (auto const sle = read(keylet::feeSettings())) { bool oldFees = false; bool newFees = false; diff --git a/src/libxrpl/ledger/View.cpp b/src/libxrpl/ledger/View.cpp index fdd7998609..ebac76a754 100644 --- a/src/libxrpl/ledger/View.cpp +++ b/src/libxrpl/ledger/View.cpp @@ -70,7 +70,7 @@ isVaultPseudoAccountFrozen( // LCOV_EXCL_STOP } - auto const mptIssuance = view.read(keylet::mptIssuance(mptShare.getMptID())); + auto const mptIssuance = view.read(keylet::mptokenIssuance(mptShare.getMptID())); if (mptIssuance == nullptr) return false; // zero MPToken won't block deletion of MPTokenIssuance diff --git a/src/libxrpl/ledger/helpers/AMMHelpers.cpp b/src/libxrpl/ledger/helpers/AMMHelpers.cpp index cacbfc9d58..7cd27a1f34 100644 --- a/src/libxrpl/ledger/helpers/AMMHelpers.cpp +++ b/src/libxrpl/ledger/helpers/AMMHelpers.cpp @@ -555,7 +555,7 @@ ammLPHolds( auto const currency = ammLPTCurrency(asset1, asset2); STAmount amount; - auto const sle = view.read(keylet::line(lpAccount, ammAccount, currency)); + auto const sle = view.read(keylet::trustLine(lpAccount, ammAccount, currency)); if (!sle) { amount.clear(Issue{currency, ammAccount}); @@ -647,7 +647,7 @@ ammAccountHolds(ReadView const& view, AccountID const& ammAccountID, Asset const } else if ( auto const sle = - view.read(keylet::line(ammAccountID, issue.account, issue.currency)); + view.read(keylet::trustLine(ammAccountID, issue.account, issue.currency)); sle && !isFrozen(view, ammAccountID, issue.currency, issue.account)) { STAmount amount = (*sle)[sfBalance]; diff --git a/src/libxrpl/ledger/helpers/MPTokenHelpers.cpp b/src/libxrpl/ledger/helpers/MPTokenHelpers.cpp index 8b3385471d..a1af63a80f 100644 --- a/src/libxrpl/ledger/helpers/MPTokenHelpers.cpp +++ b/src/libxrpl/ledger/helpers/MPTokenHelpers.cpp @@ -40,7 +40,7 @@ namespace xrpl { bool isGlobalFrozen(ReadView const& view, MPTIssue const& mptIssue) { - if (auto const sle = view.read(keylet::mptIssuance(mptIssue.getMptID()))) + if (auto const sle = view.read(keylet::mptokenIssuance(mptIssue.getMptID()))) return sle->isFlag(lsfMPTLocked); return false; } @@ -95,7 +95,7 @@ transferRate(ReadView const& view, MPTID const& issuanceID) // fee is 0-50,000 (0-50%), rate is 1,000,000,000-2,000,000,000 // For example, if transfer fee is 50% then 10,000 * 50,000 = 500,000 // which represents 50% of 1,000,000,000 - if (auto const sle = view.read(keylet::mptIssuance(issuanceID)); + if (auto const sle = view.read(keylet::mptokenIssuance(issuanceID)); sle && sle->isFieldPresent(sfTransferFee)) { auto const fee = sle->getFieldU16(sfTransferFee); @@ -110,7 +110,7 @@ transferRate(ReadView const& view, MPTID const& issuanceID) canAddHolding(ReadView const& view, MPTIssue const& mptIssue) { auto mptID = mptIssue.getMptID(); - auto issuance = view.read(keylet::mptIssuance(mptID)); + auto issuance = view.read(keylet::mptokenIssuance(mptID)); if (!issuance) { return tecOBJECT_NOT_FOUND; @@ -132,7 +132,7 @@ addEmptyHolding( beast::Journal journal) { auto const& mptID = mptIssue.getMptID(); - auto const mpt = view.peek(keylet::mptIssuance(mptID)); + auto const mpt = view.peek(keylet::mptokenIssuance(mptID)); if (!mpt) return tefINTERNAL; // LCOV_EXCL_LINE if (mpt->isFlag(lsfMPTLocked)) @@ -204,7 +204,7 @@ authorizeMPToken( return tecINSUFFICIENT_RESERVE; // Defensive check before we attempt to create MPToken for the issuer - auto const mpt = view.read(keylet::mptIssuance(mptIssuanceID)); + auto const mpt = view.read(keylet::mptokenIssuance(mptIssuanceID)); if (!mpt || mpt->getAccountID(sfIssuer) == account) { // LCOV_EXCL_START @@ -230,7 +230,7 @@ authorizeMPToken( return tesSUCCESS; } - auto const sleMptIssuance = view.read(keylet::mptIssuance(mptIssuanceID)); + auto const sleMptIssuance = view.read(keylet::mptokenIssuance(mptIssuanceID)); if (!sleMptIssuance) return tecINTERNAL; // LCOV_EXCL_LINE @@ -308,7 +308,7 @@ requireAuth( AuthType authType, std::uint8_t depth) { - auto const mptID = keylet::mptIssuance(mptIssue.getMptID()); + auto const mptID = keylet::mptokenIssuance(mptIssue.getMptID()); auto const sleIssuance = view.read(mptID); if (!sleIssuance) return tecOBJECT_NOT_FOUND; @@ -406,7 +406,7 @@ enforceMPTokenAuthorization( XRPAmount const& priorBalance, // for MPToken authorization beast::Journal j) { - auto const sleIssuance = view.read(keylet::mptIssuance(mptIssuanceID)); + auto const sleIssuance = view.read(keylet::mptokenIssuance(mptIssuanceID)); if (!sleIssuance) return tefINTERNAL; // LCOV_EXCL_LINE @@ -530,7 +530,7 @@ canTransfer( WaiveMPTCanTransfer waive, std::uint8_t depth) { - auto const mptID = keylet::mptIssuance(mptIssue.getMptID()); + auto const mptID = keylet::mptokenIssuance(mptIssue.getMptID()); auto const sleIssuance = view.read(mptID); if (!sleIssuance) return tecOBJECT_NOT_FOUND; @@ -584,7 +584,7 @@ canTrade(ReadView const& view, Asset const& asset, std::uint8_t depth) return asset.visit( [&](Issue const&) -> TER { return tesSUCCESS; }, [&](MPTIssue const& mptIssue) -> TER { - auto const sleIssuance = view.read(keylet::mptIssuance(mptIssue.getMptID())); + auto const sleIssuance = view.read(keylet::mptokenIssuance(mptIssue.getMptID())); if (!sleIssuance) return tecOBJECT_NOT_FOUND; if (!sleIssuance->isFlag(lsfMPTCanTrade)) @@ -638,7 +638,7 @@ TER lockEscrowMPT(ApplyView& view, AccountID const& sender, STAmount const& amount, beast::Journal j) { auto const mptIssue = amount.get(); - auto const mptID = keylet::mptIssuance(mptIssue.getMptID()); + auto const mptID = keylet::mptokenIssuance(mptIssue.getMptID()); auto sleIssuance = view.peek(mptID); if (!sleIssuance) { // LCOV_EXCL_START @@ -743,7 +743,7 @@ unlockEscrowMPT( auto const& issuer = netAmount.getIssuer(); auto const& mptIssue = netAmount.get(); - auto const mptID = keylet::mptIssuance(mptIssue.getMptID()); + auto const mptID = keylet::mptokenIssuance(mptIssue.getMptID()); auto sleIssuance = view.peek(mptID); if (!sleIssuance) { // LCOV_EXCL_START @@ -927,7 +927,7 @@ checkCreateMPT( if (mptIssue.getIssuer() == holder) return tesSUCCESS; - auto const mptIssuanceID = keylet::mptIssuance(mptIssue.getMptID()); + auto const mptIssuanceID = keylet::mptokenIssuance(mptIssue.getMptID()); auto const mptokenID = keylet::mptoken(mptIssuanceID.key, holder); if (!view.exists(mptokenID)) { @@ -963,7 +963,7 @@ availableMPTAmount(SLE const& sleIssuance) std::int64_t availableMPTAmount(ReadView const& view, MPTID const& mptID) { - auto const sle = view.read(keylet::mptIssuance(mptID)); + auto const sle = view.read(keylet::mptokenIssuance(mptID)); if (!sle) Throw(transHuman(tecINTERNAL)); return availableMPTAmount(*sle); @@ -987,7 +987,7 @@ issuerFundsToSelfIssue(ReadView const& view, MPTIssue const& issue) { STAmount amount{issue}; - auto const sle = view.read(keylet::mptIssuance(issue)); + auto const sle = view.read(keylet::mptokenIssuance(issue)); if (!sle) return amount; auto const available = availableMPTAmount(*sle); diff --git a/src/libxrpl/ledger/helpers/NFTokenHelpers.cpp b/src/libxrpl/ledger/helpers/NFTokenHelpers.cpp index 5b467db796..af429358bb 100644 --- a/src/libxrpl/ledger/helpers/NFTokenHelpers.cpp +++ b/src/libxrpl/ledger/helpers/NFTokenHelpers.cpp @@ -44,8 +44,8 @@ namespace xrpl::nft { static SLE::const_pointer locatePage(ReadView const& view, AccountID const& owner, uint256 const& id) { - auto const first = keylet::nftpage(keylet::nftpageMin(owner), id); - auto const last = keylet::nftpageMax(owner); + auto const first = keylet::nftokenPage(keylet::nftokenPageMin(owner), id); + auto const last = keylet::nftokenPageMax(owner); // This NFT can only be found in the first page with a key that's strictly // greater than `first`, so look for that, up until the maximum possible @@ -57,8 +57,8 @@ locatePage(ReadView const& view, AccountID const& owner, uint256 const& id) static SLE::pointer locatePage(ApplyView& view, AccountID const& owner, uint256 const& id) { - auto const first = keylet::nftpage(keylet::nftpageMin(owner), id); - auto const last = keylet::nftpageMax(owner); + auto const first = keylet::nftokenPage(keylet::nftokenPageMin(owner), id); + auto const last = keylet::nftokenPageMax(owner); // This NFT can only be found in the first page with a key that's strictly // greater than `first`, so look for that, up until the maximum possible @@ -74,9 +74,9 @@ getPageForToken( uint256 const& id, std::function const& createCallback) { - auto const base = keylet::nftpageMin(owner); - auto const first = keylet::nftpage(base, id); - auto const last = keylet::nftpageMax(owner); + auto const base = keylet::nftokenPageMin(owner); + auto const first = keylet::nftokenPage(base, id); + auto const last = keylet::nftokenPageMax(owner); // This NFT can only be found in the first page with a key that's strictly // greater than `first`, so look for that, up until the maximum possible @@ -182,7 +182,7 @@ getPageForToken( ? narr[kDirMaxTokensPerPage - 1].getFieldH256(sfNFTokenID).next() : carr[0].getFieldH256(sfNFTokenID); - auto np = std::make_shared(keylet::nftpage(base, tokenIDForNewPage)); + auto np = std::make_shared(keylet::nftokenPage(base, tokenIDForNewPage)); XRPL_ASSERT(np->key() > base.key, "xrpl::nft::getPageForToken : valid NFT page index"); np->setFieldArray(sfNFTokens, narr); np->setFieldH256(sfNextPageMin, cp->key()); @@ -597,7 +597,7 @@ removeTokenOffersWithLimit(ApplyView& view, Keylet const& directory, std::size_t // deleting during iteration. for (int i = offerIndexes.size() - 1; i >= 0; --i) { - if (auto const offer = view.peek(keylet::nftoffer(offerIndexes[i]))) + if (auto const offer = view.peek(keylet::nftokenOffer(offerIndexes[i]))) { if (deleteTokenOffer(view, offer)) { @@ -651,11 +651,11 @@ repairNFTokenDirectoryLinks(ApplyView& view, AccountID const& owner) { bool didRepair = false; - auto const last = keylet::nftpageMax(owner); + auto const last = keylet::nftokenPageMax(owner); SLE::pointer page = view.peek(Keylet( ltNFTOKEN_PAGE, - view.succ(keylet::nftpageMin(owner).key, last.key.next()).value_or(last.key))); + view.succ(keylet::nftokenPageMin(owner).key, last.key.next()).value_or(last.key))); if (!page) return didRepair; @@ -839,10 +839,10 @@ tokenOfferCreatePreclaim( if (view.rules().enabled(featureNFTokenMintOffer)) { if (nftIssuer != amount.getIssuer() && - !view.read(keylet::line(nftIssuer, amount.get()))) + !view.read(keylet::trustLine(nftIssuer, amount.get()))) return tecNO_LINE; } - else if (!view.exists(keylet::line(nftIssuer, amount.get()))) + else if (!view.exists(keylet::trustLine(nftIssuer, amount.get()))) { return tecNO_LINE; } @@ -934,7 +934,7 @@ tokenOfferCreateApply( priorBalance < view.fees().accountReserve((*acct)[sfOwnerCount] + 1)) return tecINSUFFICIENT_RESERVE; - auto const offerID = keylet::nftoffer(acctID, seqProxy.value()); + auto const offerID = keylet::nftokenOffer(acctID, seqProxy.value()); // Create the offer: { @@ -1020,7 +1020,7 @@ checkTrustlineAuthorized( if (issuerAccount->isFlag(lsfRequireAuth)) { - auto const trustLine = view.read(keylet::line(id, issue.account, issue.currency)); + auto const trustLine = view.read(keylet::trustLine(id, issue.account, issue.currency)); if (!trustLine) { @@ -1070,7 +1070,7 @@ checkTrustlineDeepFrozen( return tesSUCCESS; } - auto const trustLine = view.read(keylet::line(id, issue.account, issue.currency)); + auto const trustLine = view.read(keylet::trustLine(id, issue.account, issue.currency)); if (!trustLine) { diff --git a/src/libxrpl/ledger/helpers/RippleStateHelpers.cpp b/src/libxrpl/ledger/helpers/RippleStateHelpers.cpp index 7ed7ab8fc4..5a2995c030 100644 --- a/src/libxrpl/ledger/helpers/RippleStateHelpers.cpp +++ b/src/libxrpl/ledger/helpers/RippleStateHelpers.cpp @@ -47,7 +47,7 @@ creditLimit( { STAmount result(Issue{currency, account}); - auto sleRippleState = view.read(keylet::line(account, issuer, currency)); + auto sleRippleState = view.read(keylet::trustLine(account, issuer, currency)); if (sleRippleState) { @@ -78,7 +78,7 @@ creditBalance( { STAmount result(Issue{currency, account}); - auto sleRippleState = view.read(keylet::line(account, issuer, currency)); + auto sleRippleState = view.read(keylet::trustLine(account, issuer, currency)); if (sleRippleState) { @@ -114,7 +114,7 @@ isIndividualFrozen( if (issuer != account) { // Check if the issuer froze the line - auto const sle = view.read(keylet::line(account, issuer, currency)); + auto const sle = view.read(keylet::trustLine(account, issuer, currency)); if (sle && sle->isFlag((issuer > account) ? lsfHighFreeze : lsfLowFreeze)) return true; } @@ -138,7 +138,7 @@ isFrozen( if (issuer != account) { // Check if the issuer froze the line - sle = view.read(keylet::line(account, issuer, currency)); + sle = view.read(keylet::trustLine(account, issuer, currency)); if (sle && sle->isFlag((issuer > account) ? lsfHighFreeze : lsfLowFreeze)) return true; } @@ -162,7 +162,7 @@ isDeepFrozen( return false; } - auto const sle = view.read(keylet::line(account, issuer, currency)); + auto const sle = view.read(keylet::trustLine(account, issuer, currency)); if (!sle) { return false; @@ -403,7 +403,7 @@ issueIOU( bool const bSenderHigh = issue.account > account; - auto const index = keylet::line(issue.account, account, issue.currency); + auto const index = keylet::trustLine(issue.account, account, issue.currency); if (auto state = view.peek(index)) { @@ -497,7 +497,7 @@ redeemIOU( bool const bSenderHigh = account > issue.account; - if (auto state = view.peek(keylet::line(account, issue.account, issue.currency))) + if (auto state = view.peek(keylet::trustLine(account, issue.account, issue.currency))) { STAmount finalBalance = state->getFieldAmount(sfBalance); @@ -558,7 +558,7 @@ requireAuth(ReadView const& view, Issue const& issue, AccountID const& account, if (isXRP(issue) || issue.account == account) return tesSUCCESS; - auto const trustLine = view.read(keylet::line(account, issue.account, issue.currency)); + auto const trustLine = view.read(keylet::trustLine(account, issue.account, issue.currency)); // If account has no line, and this is a strong check, fail if (!trustLine && authType == AuthType::StrongAuth) return tecNO_LINE; @@ -596,7 +596,7 @@ canTransfer(ReadView const& view, Issue const& issue, AccountID const& from, Acc auto const isRippleDisabled = [&](AccountID account) -> bool { // Line might not exist, but some transfers can create it. If this // is the case, just check the default ripple on the issuer account. - auto const line = view.read(keylet::line(account, issue)); + auto const line = view.read(keylet::trustLine(account, issue)); if (line) { bool const issuerHigh = issuerId > account; @@ -638,7 +638,7 @@ addEmptyHolding( auto const& srcId = issuerId; auto const& dstId = accountID; auto const high = srcId > dstId; - auto const index = keylet::line(srcId, dstId, currency); + auto const index = keylet::trustLine(srcId, dstId, currency); auto const sleSrc = view.peek(keylet::account(srcId)); auto const sleDst = view.peek(keylet::account(dstId)); if (!sleDst || !sleSrc) @@ -696,7 +696,7 @@ removeEmptyHolding( // If the account is the issuer, then no line should exist. Check anyway. // If a line does exist, it will get deleted. If not, return success. bool const accountIsIssuer = accountID == issue.account; - auto const line = view.peek(keylet::line(accountID, issue)); + auto const line = view.peek(keylet::trustLine(accountID, issue)); if (!line) return accountIsIssuer ? (TER)tesSUCCESS : (TER)tecOBJECT_NOT_FOUND; if (!accountIsIssuer && line->at(sfBalance)->iou() != beast::kZero) diff --git a/src/libxrpl/ledger/helpers/TokenHelpers.cpp b/src/libxrpl/ledger/helpers/TokenHelpers.cpp index 7191456868..f0a0220e1e 100644 --- a/src/libxrpl/ledger/helpers/TokenHelpers.cpp +++ b/src/libxrpl/ledger/helpers/TokenHelpers.cpp @@ -179,7 +179,7 @@ getLineIfUsable( FreezeHandling zeroIfFrozen, beast::Journal j) { - auto sle = view.read(keylet::line(account, issuer, currency)); + auto sle = view.read(keylet::trustLine(account, issuer, currency)); if (!sle) { @@ -320,7 +320,7 @@ accountHolds( { // if the account is the issuer, and the issuance exists, their limit is // the issuance limit minus the outstanding value - auto const issuance = view.read(keylet::mptIssuance(mptIssue.getMptID())); + auto const issuance = view.read(keylet::mptokenIssuance(mptIssue.getMptID())); if (!issuance) { @@ -357,7 +357,7 @@ accountHolds( } else if (zeroIfUnauthorized == AuthHandling::ZeroIfUnauthorized) { - auto const sleIssuance = view.read(keylet::mptIssuance(mptIssue.getMptID())); + auto const sleIssuance = view.read(keylet::mptokenIssuance(mptIssue.getMptID())); // if auth is enabled on the issuance and mpt is not authorized, // clear amount @@ -568,7 +568,7 @@ directSendNoFeeIOU( XRPL_ASSERT(uSenderID != uReceiverID, "xrpl::directSendNoFeeIOU : sender is not receiver"); bool const bSenderHigh = uSenderID > uReceiverID; - auto const index = keylet::line(uSenderID, uReceiverID, currency); + auto const index = keylet::trustLine(uSenderID, uReceiverID, currency); XRPL_ASSERT( !isXRP(uSenderID) && uSenderID != noAccount(), @@ -1066,7 +1066,7 @@ directSendNoFeeMPT( beast::Journal j) { // Do not check MPT authorization here - it must have been checked earlier - auto const mptID = keylet::mptIssuance(saAmount.get().getMptID()); + auto const mptID = keylet::mptokenIssuance(saAmount.get().getMptID()); auto const& issuer = saAmount.getIssuer(); auto sleIssuance = view.peek(mptID); if (!sleIssuance) @@ -1158,7 +1158,7 @@ directSendNoLimitMPT( // Safe to get MPT since directSendNoLimitMPT is only called by accountSendMPT auto const& issuer = saAmount.getIssuer(); - auto const sle = view.read(keylet::mptIssuance(saAmount.get().getMptID())); + auto const sle = view.read(keylet::mptokenIssuance(saAmount.get().getMptID())); if (!sle) return tecOBJECT_NOT_FOUND; @@ -1215,7 +1215,7 @@ directSendNoLimitMultiMPT( { auto const& issuer = mptIssue.getIssuer(); - auto const sle = view.read(keylet::mptIssuance(mptIssue.getMptID())); + auto const sle = view.read(keylet::mptokenIssuance(mptIssue.getMptID())); if (!sle) return tecOBJECT_NOT_FOUND; diff --git a/src/libxrpl/protocol/Indexes.cpp b/src/libxrpl/protocol/Indexes.cpp index ae29bd3297..a49f7b85ee 100644 --- a/src/libxrpl/protocol/Indexes.cpp +++ b/src/libxrpl/protocol/Indexes.cpp @@ -218,7 +218,7 @@ amendments() noexcept } Keylet const& -fees() noexcept +feeSettings() noexcept { static Keylet const kRet{ltFEE_SETTINGS, indexHash(LedgerNameSpace::FeeSettings)}; return kRet; @@ -232,18 +232,18 @@ negativeUNL() noexcept } Keylet -BookT::operator()(Book const& b) const +book(Book const& b) { return {ltDIR_NODE, getBookBase(b)}; } Keylet -line(AccountID const& id0, AccountID const& id1, Currency const& currency) noexcept +trustLine(AccountID const& id0, AccountID const& id1, Currency const& currency) noexcept { // There is code in TrustSet that calls us with id0 == id1, to allow users // to locate and delete such "weird" trustlines. If we remove that code, we // could enable this assert: - // XRPL_ASSERT(id0 != id1, "xrpl::keylet::line : accounts must be + // XRPL_ASSERT(id0 != id1, "xrpl::keylet::trustLine : accounts must be // different"); // A trust line is shared between two accounts; while we typically think @@ -285,20 +285,20 @@ quality(Keylet const& k, std::uint64_t q) noexcept } Keylet -NextT::operator()(Keylet const& k) const +next(Keylet const& k) { - XRPL_ASSERT(k.type == ltDIR_NODE, "xrpl::keylet::NextT::operator() : valid input type"); + XRPL_ASSERT(k.type == ltDIR_NODE, "xrpl::keylet::next : valid input type"); return {ltDIR_NODE, getQualityNext(k.key)}; } Keylet -TicketT::operator()(AccountID const& id, std::uint32_t ticketSeq) const +ticket(AccountID const& id, std::uint32_t ticketSeq) { return {ltTICKET, getTicketIndex(id, ticketSeq)}; } Keylet -TicketT::operator()(AccountID const& id, SeqProxy ticketSeq) const +ticket(AccountID const& id, SeqProxy ticketSeq) { return {ltTICKET, getTicketIndex(id, ticketSeq)}; } @@ -307,15 +307,15 @@ TicketT::operator()(AccountID const& id, SeqProxy ticketSeq) const // else. If we ever support multiple pages of signer lists, this would be the // keylet used to locate them. static Keylet -signers(AccountID const& account, std::uint32_t page) noexcept +signerList(AccountID const& account, std::uint32_t page) noexcept { return {ltSIGNER_LIST, indexHash(LedgerNameSpace::SignerList, account, page)}; } Keylet -signers(AccountID const& account) noexcept +signerList(AccountID const& account) noexcept { - return signers(account, 0); + return signerList(account, 0); } Keylet @@ -375,13 +375,13 @@ escrow(AccountID const& src, std::uint32_t seq) noexcept } Keylet -payChan(AccountID const& src, AccountID const& dst, std::uint32_t seq) noexcept +payChannel(AccountID const& src, AccountID const& dst, std::uint32_t seq) noexcept { return {ltPAYCHAN, indexHash(LedgerNameSpace::XRPPaymentChannel, src, dst, seq)}; } Keylet -nftpageMin(AccountID const& owner) +nftokenPageMin(AccountID const& owner) { std::array buf{}; std::memcpy(buf.data(), owner.data(), owner.size()); @@ -389,7 +389,7 @@ nftpageMin(AccountID const& owner) } Keylet -nftpageMax(AccountID const& owner) +nftokenPageMax(AccountID const& owner) { uint256 id = nft::kPageMask; std::memcpy(id.data(), owner.data(), owner.size()); @@ -397,14 +397,14 @@ nftpageMax(AccountID const& owner) } Keylet -nftpage(Keylet const& k, uint256 const& token) +nftokenPage(Keylet const& k, uint256 const& token) { - XRPL_ASSERT(k.type == ltNFTOKEN_PAGE, "xrpl::keylet::nftpage : valid input type"); + XRPL_ASSERT(k.type == ltNFTOKEN_PAGE, "xrpl::keylet::nftokenPage : valid input type"); return {ltNFTOKEN_PAGE, (k.key & ~nft::kPageMask) + (token & nft::kPageMask)}; } Keylet -nftoffer(AccountID const& owner, std::uint32_t seq) +nftokenOffer(AccountID const& owner, std::uint32_t seq) { return {ltNFTOKEN_OFFER, indexHash(LedgerNameSpace::NftokenOffer, owner, seq)}; } @@ -518,13 +518,13 @@ oracle(AccountID const& account, std::uint32_t const& documentID) noexcept } Keylet -mptIssuance(std::uint32_t seq, AccountID const& issuer) noexcept +mptokenIssuance(std::uint32_t seq, AccountID const& issuer) noexcept { - return mptIssuance(makeMptID(seq, issuer)); + return mptokenIssuance(makeMptID(seq, issuer)); } Keylet -mptIssuance(MPTID const& issuanceID) noexcept +mptokenIssuance(MPTID const& issuanceID) noexcept { return {ltMPTOKEN_ISSUANCE, indexHash(LedgerNameSpace::MPTokenIssuance, issuanceID)}; } @@ -532,7 +532,7 @@ mptIssuance(MPTID const& issuanceID) noexcept Keylet mptoken(MPTID const& issuanceID, AccountID const& holder) noexcept { - return mptoken(mptIssuance(issuanceID).key, holder); + return mptoken(mptokenIssuance(issuanceID).key, holder); } Keylet @@ -554,9 +554,9 @@ vault(AccountID const& owner, std::uint32_t seq) noexcept } Keylet -loanbroker(AccountID const& owner, std::uint32_t seq) noexcept +loanBroker(AccountID const& owner, std::uint32_t seq) noexcept { - return loanbroker(indexHash(LedgerNameSpace::LoanBroker, owner, seq)); + return loanBroker(indexHash(LedgerNameSpace::LoanBroker, owner, seq)); } Keylet diff --git a/src/libxrpl/tx/Transactor.cpp b/src/libxrpl/tx/Transactor.cpp index 2ff24d92b5..3a10b7124f 100644 --- a/src/libxrpl/tx/Transactor.cpp +++ b/src/libxrpl/tx/Transactor.cpp @@ -528,7 +528,7 @@ Transactor::checkSeqProxy(ReadView const& view, STTx const& tx, beast::Journal j } // Transaction can never succeed if the Ticket is not in the ledger. - if (!view.exists(keylet::kTicket(id, tSeqProx))) + if (!view.exists(keylet::ticket(id, tSeqProx))) { JLOG(j.trace()) << "applyTransaction: ticket already used or never created " << "a_seq=" << aSeq << " t_seq=" << tSeqProx; @@ -593,7 +593,7 @@ Transactor::ticketDelete( { // Delete the Ticket, adjust the account root ticket count, and // reduce the owner count. - SLE::pointer const sleTicket = view.peek(keylet::kTicket(ticketIndex)); + SLE::pointer const sleTicket = view.peek(keylet::ticket(ticketIndex)); if (!sleTicket) { // LCOV_EXCL_START @@ -851,7 +851,7 @@ Transactor::checkMultiSign( beast::Journal const j) { // Get id's SignerList and Quorum. - STLedgerEntry::const_pointer const sleAccountSigners = view.read(keylet::signers(id)); + STLedgerEntry::const_pointer const sleAccountSigners = view.read(keylet::signerList(id)); // If the signer list doesn't exist the account is not multi-signing. if (!sleAccountSigners) { @@ -1031,7 +1031,7 @@ removeExpiredNFTokenOffers( for (auto const& index : offers) { - if (auto const offer = view.peek(keylet::nftoffer(index))) + if (auto const offer = view.peek(keylet::nftokenOffer(index))) { nft::deleteTokenOffer(view, offer); if (++removed == kExpiredOfferRemoveLimit) diff --git a/src/libxrpl/tx/invariants/InvariantCheck.cpp b/src/libxrpl/tx/invariants/InvariantCheck.cpp index e29a9fe661..231705efaf 100644 --- a/src/libxrpl/tx/invariants/InvariantCheck.cpp +++ b/src/libxrpl/tx/invariants/InvariantCheck.cpp @@ -518,8 +518,8 @@ AccountRootsDeletedClean::finalize( // checked above as entries in directAccountKeylets. This uses // view.succ() to check for any NFT pages in between the two // endpoints. - Keylet const first = keylet::nftpageMin(accountID); - Keylet const last = keylet::nftpageMax(accountID); + Keylet const first = keylet::nftokenPageMin(accountID); + Keylet const last = keylet::nftokenPageMax(accountID); std::optional key = view.succ(first.key, last.key.next()); diff --git a/src/libxrpl/tx/invariants/LoanBrokerInvariant.cpp b/src/libxrpl/tx/invariants/LoanBrokerInvariant.cpp index 8586a27be3..d239acd417 100644 --- a/src/libxrpl/tx/invariants/LoanBrokerInvariant.cpp +++ b/src/libxrpl/tx/invariants/LoanBrokerInvariant.cpp @@ -130,7 +130,7 @@ ValidLoanBroker::finalize( for (auto const& [brokerID, broker] : brokers_) { auto const& after = - broker.brokerAfter ? broker.brokerAfter : view.read(keylet::loanbroker(brokerID)); + broker.brokerAfter ? broker.brokerAfter : view.read(keylet::loanBroker(brokerID)); if (!after) { diff --git a/src/libxrpl/tx/invariants/MPTInvariant.cpp b/src/libxrpl/tx/invariants/MPTInvariant.cpp index a2369cc1b9..1176594bbf 100644 --- a/src/libxrpl/tx/invariants/MPTInvariant.cpp +++ b/src/libxrpl/tx/invariants/MPTInvariant.cpp @@ -551,7 +551,7 @@ ValidMPTTransfer::finalize( std::uint16_t senders = 0; std::uint16_t receivers = 0; bool invalidTransfer = false; - auto const sleIssuance = view.read(keylet::mptIssuance(mptID)); + auto const sleIssuance = view.read(keylet::mptokenIssuance(mptID)); if (!sleIssuance) { continue; diff --git a/src/libxrpl/tx/invariants/VaultInvariant.cpp b/src/libxrpl/tx/invariants/VaultInvariant.cpp index 80b8f36bd9..84814977db 100644 --- a/src/libxrpl/tx/invariants/VaultInvariant.cpp +++ b/src/libxrpl/tx/invariants/VaultInvariant.cpp @@ -199,7 +199,7 @@ ValidVault::deltaAssets(AccountID const& id) const { if (isXRP(issue)) return lookup(keylet::account(id).key); - auto result = lookup(keylet::line(id, issue).key); + auto result = lookup(keylet::trustLine(id, issue).key); // Trust-line balance is stored from the low-account's perspective; // negate if id is the high account so the delta is in id's terms. if (result && id > issue.getIssuer()) @@ -238,7 +238,7 @@ ValidVault::deltaShares(AccountID const& id) const auto const& afterVault = afterVault_[0]; auto const it = [&]() { if (id == afterVault.pseudoId) - return deltas_.find(keylet::mptIssuance(afterVault.shareMPTID).key); + return deltas_.find(keylet::mptokenIssuance(afterVault.shareMPTID).key); return deltas_.find(keylet::mptoken(afterVault.shareMPTID, id).key); }(); @@ -411,7 +411,7 @@ ValidVault::finalize( return e; } - auto const sleShares = view.read(keylet::mptIssuance(afterVault.shareMPTID)); + auto const sleShares = view.read(keylet::mptokenIssuance(afterVault.shareMPTID)); return sleShares ? std::optional(Shares::make(*sleShares)) : std::nullopt; }(); diff --git a/src/libxrpl/tx/paths/BookStep.cpp b/src/libxrpl/tx/paths/BookStep.cpp index 448172872a..adb73f126e 100644 --- a/src/libxrpl/tx/paths/BookStep.cpp +++ b/src/libxrpl/tx/paths/BookStep.cpp @@ -1359,7 +1359,7 @@ BookStep::check(StrandContext const& ctx) const auto const err = book_.in.visit( [&](Issue const& issue) -> std::optional { - auto sle = view.read(keylet::line(*prev, cur, issue.currency)); + auto sle = view.read(keylet::trustLine(*prev, cur, issue.currency)); if (!sle) return terNO_LINE; if (sle->isFlag((cur > *prev) ? lsfHighNoRipple : lsfLowNoRipple)) diff --git a/src/libxrpl/tx/paths/DirectStep.cpp b/src/libxrpl/tx/paths/DirectStep.cpp index cc6e75ea3d..f8f12bd421 100644 --- a/src/libxrpl/tx/paths/DirectStep.cpp +++ b/src/libxrpl/tx/paths/DirectStep.cpp @@ -344,7 +344,7 @@ DirectIPaymentStep::quality(ReadView const& sb, QualityDirection qDir) const if (src_ == dst_) return QUALITY_ONE; - auto const sle = sb.read(keylet::line(dst_, src_, currency_)); + auto const sle = sb.read(keylet::trustLine(dst_, src_, currency_)); if (!sle) return QUALITY_ONE; @@ -420,7 +420,7 @@ DirectIPaymentStep::check(StrandContext const& ctx, SLE::const_ref sleSrc) const // Since this is a payment a trust line must be present. Perform all // trust line related checks. { - auto const sleLine = ctx.view.read(keylet::line(src_, dst_, currency_)); + auto const sleLine = ctx.view.read(keylet::trustLine(src_, dst_, currency_)); if (!sleLine) { JLOG(j_.trace()) << "DirectStepI: No credit line. " << *this; diff --git a/src/libxrpl/tx/paths/MPTEndpointStep.cpp b/src/libxrpl/tx/paths/MPTEndpointStep.cpp index 7dcd6d9241..a47cfa15a5 100644 --- a/src/libxrpl/tx/paths/MPTEndpointStep.cpp +++ b/src/libxrpl/tx/paths/MPTEndpointStep.cpp @@ -434,7 +434,7 @@ MPTEndpointStep::maxPaymentFlow(ReadView const& sb) const return {toAmount(maxFlow), DebtDirection::Redeems}; // From an issuer to a holder - if (auto const sle = sb.read(keylet::mptIssuance(mptIssue_))) + if (auto const sle = sb.read(keylet::mptokenIssuance(mptIssue_))) { // If issuer is the source account, and it is direct payment then // MPTEndpointStep is the only step. Provide available maxFlow. diff --git a/src/libxrpl/tx/paths/XRPEndpointStep.cpp b/src/libxrpl/tx/paths/XRPEndpointStep.cpp index efdad92791..05d893a50d 100644 --- a/src/libxrpl/tx/paths/XRPEndpointStep.cpp +++ b/src/libxrpl/tx/paths/XRPEndpointStep.cpp @@ -203,7 +203,7 @@ private: { return ctx.strandDeliver.visit( [&](Issue const& issue) { - if (!ctx.view.exists(keylet::line(acc, issue))) + if (!ctx.view.exists(keylet::trustLine(acc, issue))) return -1; return 0; }, diff --git a/src/libxrpl/tx/transactors/account/AccountDelete.cpp b/src/libxrpl/tx/transactors/account/AccountDelete.cpp index 833f1c8b25..254733a618 100644 --- a/src/libxrpl/tx/transactors/account/AccountDelete.cpp +++ b/src/libxrpl/tx/transactors/account/AccountDelete.cpp @@ -260,8 +260,8 @@ AccountDelete::preclaim(PreclaimContext const& ctx) return tecHAS_OBLIGATIONS; // If the account owns any NFTs it cannot be deleted. - Keylet const first = keylet::nftpageMin(account); - Keylet const last = keylet::nftpageMax(account); + Keylet const first = keylet::nftokenPageMin(account); + Keylet const last = keylet::nftokenPageMax(account); auto const cp = ctx.view.read( Keylet(ltNFTOKEN_PAGE, ctx.view.succ(first.key, last.key.next()).value_or(last.key))); diff --git a/src/libxrpl/tx/transactors/account/AccountSet.cpp b/src/libxrpl/tx/transactors/account/AccountSet.cpp index 36a7e7419f..dfe7ec5b5f 100644 --- a/src/libxrpl/tx/transactors/account/AccountSet.cpp +++ b/src/libxrpl/tx/transactors/account/AccountSet.cpp @@ -315,7 +315,7 @@ AccountSet::doApply() return tecNEED_MASTER_KEY; } - if ((!sle->isFieldPresent(sfRegularKey)) && (!view().peek(keylet::signers(accountID_)))) + if ((!sle->isFieldPresent(sfRegularKey)) && (!view().peek(keylet::signerList(accountID_)))) { // Account has no regular key or multi-signer signer list. return tecNO_ALTERNATIVE_KEY; diff --git a/src/libxrpl/tx/transactors/account/SetRegularKey.cpp b/src/libxrpl/tx/transactors/account/SetRegularKey.cpp index 08ccf5e7ab..f408f31690 100644 --- a/src/libxrpl/tx/transactors/account/SetRegularKey.cpp +++ b/src/libxrpl/tx/transactors/account/SetRegularKey.cpp @@ -67,7 +67,7 @@ SetRegularKey::doApply() else { // Account has disabled master key and no multi-signer signer list. - if (sle->isFlag(lsfDisableMaster) && !view().peek(keylet::signers(accountID_))) + if (sle->isFlag(lsfDisableMaster) && !view().peek(keylet::signerList(accountID_))) return tecNO_ALTERNATIVE_KEY; sle->makeFieldAbsent(sfRegularKey); diff --git a/src/libxrpl/tx/transactors/account/SignerListSet.cpp b/src/libxrpl/tx/transactors/account/SignerListSet.cpp index cedb9ace78..2f95d32664 100644 --- a/src/libxrpl/tx/transactors/account/SignerListSet.cpp +++ b/src/libxrpl/tx/transactors/account/SignerListSet.cpp @@ -232,7 +232,7 @@ SignerListSet::removeFromLedger( { auto const accountKeylet = keylet::account(account); auto const ownerDirKeylet = keylet::ownerDir(account); - auto const signerListKeylet = keylet::signers(account); + auto const signerListKeylet = keylet::signerList(account); return removeSignersFromLedger( registry, view, accountKeylet, ownerDirKeylet, signerListKeylet, j); @@ -302,7 +302,7 @@ SignerListSet::replaceSignerList() { auto const accountKeylet = keylet::account(accountID_); auto const ownerDirKeylet = keylet::ownerDir(accountID_); - auto const signerListKeylet = keylet::signers(accountID_); + auto const signerListKeylet = keylet::signerList(accountID_); // This may be either a create or a replace. Preemptively remove any // old signer list. May reduce the reserve, so this is done before @@ -367,7 +367,7 @@ SignerListSet::destroySignerList() return tecNO_ALTERNATIVE_KEY; auto const ownerDirKeylet = keylet::ownerDir(accountID_); - auto const signerListKeylet = keylet::signers(accountID_); + auto const signerListKeylet = keylet::signerList(accountID_); return removeSignersFromLedger( ctx_.registry, view(), accountKeylet, ownerDirKeylet, signerListKeylet, j_); } diff --git a/src/libxrpl/tx/transactors/bridge/XChainBridge.cpp b/src/libxrpl/tx/transactors/bridge/XChainBridge.cpp index 273beaea0f..1e9e0bfc61 100644 --- a/src/libxrpl/tx/transactors/bridge/XChainBridge.cpp +++ b/src/libxrpl/tx/transactors/bridge/XChainBridge.cpp @@ -759,7 +759,7 @@ getSignersListAndQuorum(ReadView const& view, SLE const& sleBridge, beast::Journ return {r, q, tecINTERNAL}; } - auto const sleS = view.read(keylet::signers(sleBridge[sfAccount])); + auto const sleS = view.read(keylet::signerList(sleBridge[sfAccount])); if (!sleS) { return {r, q, tecXCHAIN_NO_SIGNERS_LIST}; diff --git a/src/libxrpl/tx/transactors/check/CheckCash.cpp b/src/libxrpl/tx/transactors/check/CheckCash.cpp index c5813ae42d..80ef742f52 100644 --- a/src/libxrpl/tx/transactors/check/CheckCash.cpp +++ b/src/libxrpl/tx/transactors/check/CheckCash.cpp @@ -192,7 +192,7 @@ CheckCash::preclaim(PreclaimContext const& ctx) [&](Issue const& issue) -> TER { Currency const currency{issue.currency}; auto const sleTrustLine = - ctx.view.read(keylet::line(dstId, issuerId, currency)); + ctx.view.read(keylet::trustLine(dstId, issuerId, currency)); auto const sleIssuer = ctx.view.read(keylet::account(issuerId)); if (!sleIssuer) @@ -411,7 +411,7 @@ CheckCash::doApply() // If a trust line does not exist yet create one. Issue const& trustLineIssue = issue; AccountID const truster = deliverIssuer == accountID_ ? srcId : accountID_; - trustLineKey = keylet::line(truster, trustLineIssue); + trustLineKey = keylet::trustLine(truster, trustLineIssue); destLow = deliverIssuer > accountID_; if (!psb.exists(*trustLineKey)) diff --git a/src/libxrpl/tx/transactors/check/CheckCreate.cpp b/src/libxrpl/tx/transactors/check/CheckCreate.cpp index ff82912a1f..595bcc4ab1 100644 --- a/src/libxrpl/tx/transactors/check/CheckCreate.cpp +++ b/src/libxrpl/tx/transactors/check/CheckCreate.cpp @@ -127,7 +127,7 @@ CheckCreate::preclaim(PreclaimContext const& ctx) { // Check if the issuer froze the line auto const sleTrust = - ctx.view.read(keylet::line(srcId, issuerId, issue.currency)); + ctx.view.read(keylet::trustLine(srcId, issuerId, issue.currency)); if (sleTrust && sleTrust->isFlag((issuerId > srcId) ? lsfHighFreeze : lsfLowFreeze)) { @@ -139,7 +139,7 @@ CheckCreate::preclaim(PreclaimContext const& ctx) { // Check if dst froze the line. auto const sleTrust = - ctx.view.read(keylet::line(issuerId, dstId, issue.currency)); + ctx.view.read(keylet::trustLine(issuerId, dstId, issue.currency)); if (sleTrust && sleTrust->isFlag((dstId > issuerId) ? lsfHighFreeze : lsfLowFreeze)) { diff --git a/src/libxrpl/tx/transactors/dex/AMMClawback.cpp b/src/libxrpl/tx/transactors/dex/AMMClawback.cpp index 0cc2be381f..c1ef9f875e 100644 --- a/src/libxrpl/tx/transactors/dex/AMMClawback.cpp +++ b/src/libxrpl/tx/transactors/dex/AMMClawback.cpp @@ -136,7 +136,7 @@ AMMClawback::preclaim(PreclaimContext const& ctx) !sleIssuer->isFlag(lsfNoFreeze); }, [&](MPTIssue const& issue) { - auto const sleIssuance = ctx.view.read(keylet::mptIssuance(issue.getMptID())); + auto const sleIssuance = ctx.view.read(keylet::mptokenIssuance(issue.getMptID())); return sleIssuance && sleIssuance->isFlag(lsfMPTCanClawback) && sleIssuance->getAccountID(sfIssuer) == ctx.tx[sfAccount]; diff --git a/src/libxrpl/tx/transactors/dex/AMMCreate.cpp b/src/libxrpl/tx/transactors/dex/AMMCreate.cpp index 9c1a5cfacb..ef271ba362 100644 --- a/src/libxrpl/tx/transactors/dex/AMMCreate.cpp +++ b/src/libxrpl/tx/transactors/dex/AMMCreate.cpp @@ -212,7 +212,7 @@ AMMCreate::preclaim(PreclaimContext const& ctx) auto clawbackDisabled = [&](Asset const& asset) -> TER { return asset.visit( [&](MPTIssue const& issue) -> TER { - auto const sle = ctx.view.read(keylet::mptIssuance(issue.getMptID())); + auto const sle = ctx.view.read(keylet::mptokenIssuance(issue.getMptID())); if (!sle) return tecINTERNAL; // LCOV_EXCL_LINE if (sle->isFlag(lsfMPTCanClawback)) @@ -260,7 +260,7 @@ applyCreate(ApplyContext& ctx, Sandbox& sb, AccountID const& account, beast::Jou // LP Token already exists. (should not happen) auto const lptIss = ammLPTIssue(amount.asset(), amount2.asset(), accountId); - if (sb.read(keylet::line(accountId, lptIss))) + if (sb.read(keylet::trustLine(accountId, lptIss))) { JLOG(j.error()) << "AMM Instance: LP Token already exists."; return {tecDUPLICATE, false}; @@ -330,7 +330,8 @@ applyCreate(ApplyContext& ctx, Sandbox& sb, AccountID const& account, beast::Jou // Set AMM flag on AMM trustline if (!isXRP(amount)) { - SLE::pointer const sleRippleState = sb.peek(keylet::line(accountId, issue)); + SLE::pointer const sleRippleState = + sb.peek(keylet::trustLine(accountId, issue)); if (!sleRippleState) { return tecINTERNAL; // LCOV_EXCL_LINE @@ -364,7 +365,7 @@ applyCreate(ApplyContext& ctx, Sandbox& sb, AccountID const& account, beast::Jou << lpTokens << " " << amount << " " << amount2; auto addOrderBook = [&](Asset const& assetIn, Asset const& assetOut, std::uint64_t uRate) { Book const book{assetIn, assetOut, std::nullopt}; - auto const dir = keylet::quality(keylet::kBook(book), uRate); + auto const dir = keylet::quality(keylet::book(book), uRate); if (auto const bookExisted = static_cast(sb.read(dir)); !bookExisted) ctx.registry.get().getOrderBookDB().addOrderBook(book); }; diff --git a/src/libxrpl/tx/transactors/dex/AMMDeposit.cpp b/src/libxrpl/tx/transactors/dex/AMMDeposit.cpp index 653e8c6961..3665850f2d 100644 --- a/src/libxrpl/tx/transactors/dex/AMMDeposit.cpp +++ b/src/libxrpl/tx/transactors/dex/AMMDeposit.cpp @@ -233,7 +233,7 @@ AMMDeposit::preclaim(PreclaimContext const& ctx) auto const lpIssue = (*ammSle)[sfLPTokenBalance].get(); // Adjust the reserve if LP doesn't have LPToken trustline auto const sle = - ctx.view.read(keylet::line(accountID, lpIssue.account, lpIssue.currency)); + ctx.view.read(keylet::trustLine(accountID, lpIssue.account, lpIssue.currency)); if (xrpLiquid(ctx.view, accountID, !sle, ctx.j) >= deposit) return TER(tesSUCCESS); if (sle) @@ -532,7 +532,8 @@ AMMDeposit::deposit( { auto const& lpIssue = lpTokensDeposit.get(); // Adjust the reserve if LP doesn't have LPToken trustline - auto const sle = view.read(keylet::line(accountID_, lpIssue.account, lpIssue.currency)); + auto const sle = + view.read(keylet::trustLine(accountID_, lpIssue.account, lpIssue.currency)); if (xrpLiquid(view, accountID_, !sle, j_) >= depositAmount) return tesSUCCESS; } diff --git a/src/libxrpl/tx/transactors/dex/AMMWithdraw.cpp b/src/libxrpl/tx/transactors/dex/AMMWithdraw.cpp index 17ce1a6b83..6cbcfb1e50 100644 --- a/src/libxrpl/tx/transactors/dex/AMMWithdraw.cpp +++ b/src/libxrpl/tx/transactors/dex/AMMWithdraw.cpp @@ -615,8 +615,8 @@ AMMWithdraw::withdraw( bool const isIssue = asset.holds(); bool const assetNotExists = [&] { if (isIssue) - return !view.exists(keylet::line(account, asset.get())); - auto const issuanceKey = keylet::mptIssuance(asset.get()); + return !view.exists(keylet::trustLine(account, asset.get())); + auto const issuanceKey = keylet::mptokenIssuance(asset.get()); mptokenKey = keylet::mptoken(issuanceKey.key, account); if (!view.exists(*mptokenKey)) return true; diff --git a/src/libxrpl/tx/transactors/dex/OfferCreate.cpp b/src/libxrpl/tx/transactors/dex/OfferCreate.cpp index 547d40e7b8..ed5a22e3db 100644 --- a/src/libxrpl/tx/transactors/dex/OfferCreate.cpp +++ b/src/libxrpl/tx/transactors/dex/OfferCreate.cpp @@ -284,7 +284,7 @@ OfferCreate::checkAcceptAsset( auto const& issuer = issue.getIssuer(); if (issuerAccount->isFlag(lsfRequireAuth)) { - auto const trustLine = view.read(keylet::line(id, issuer, issue.currency)); + auto const trustLine = view.read(keylet::trustLine(id, issuer, issue.currency)); if (!trustLine) { @@ -308,7 +308,7 @@ OfferCreate::checkAcceptAsset( } } - auto const trustLine = view.read(keylet::line(id, issue.account, issue.currency)); + auto const trustLine = view.read(keylet::trustLine(id, issue.account, issue.currency)); if (!trustLine) { @@ -575,7 +575,7 @@ OfferCreate::applyHybrid( // if offer is hybrid, need to also place into open offer dir Book const book{saTakerPays.asset(), saTakerGets.asset(), std::nullopt}; - auto dir = keylet::quality(keylet::kBook(book), openRate); + auto dir = keylet::quality(keylet::book(book), openRate); bool const bookExists = sb.exists(dir); auto const bookNode = sb.dirAppend(dir, offerKey, [&](SLE::ref sle) { @@ -887,7 +887,7 @@ OfferCreate::applyGuts(Sandbox& sb, Sandbox& sbCancel) // Hybrid domain offer - BookDirectory points to domain directory, // and AdditionalBooks field stores one entry that points to the open // directory - auto dir = keylet::quality(keylet::kBook(book), uRate); + auto dir = keylet::quality(keylet::book(book), uRate); bool const bookExisted = static_cast(sb.peek(dir)); auto setBookDir = [&](SLE::ref sle, std::optional const& maybeDomain) { diff --git a/src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp b/src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp index b8f4604d73..55a9133e1e 100644 --- a/src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp +++ b/src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp @@ -72,7 +72,7 @@ escrowCancelPreclaimHelper( return tecINTERNAL; // LCOV_EXCL_LINE // If the mpt does not exist, return tecOBJECT_NOT_FOUND - auto const issuanceKey = keylet::mptIssuance(amount.get().getMptID()); + auto const issuanceKey = keylet::mptokenIssuance(amount.get().getMptID()); auto const sleIssuance = ctx.view.read(issuanceKey); if (!sleIssuance) return tecOBJECT_NOT_FOUND; diff --git a/src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp b/src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp index 0a12e2d1bc..0d83885349 100644 --- a/src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp +++ b/src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp @@ -208,7 +208,7 @@ escrowCreatePreclaimHelper( return tecNO_PERMISSION; // If the account does not have a trustline to the issuer, return tecNO_LINE - auto const sleRippleState = ctx.view.read(keylet::line(account, issuer, issue.currency)); + auto const sleRippleState = ctx.view.read(keylet::trustLine(account, issuer, issue.currency)); if (!sleRippleState) return tecNO_LINE; @@ -271,7 +271,7 @@ escrowCreatePreclaimHelper( return tecNO_PERMISSION; // If the mpt does not exist, return tecOBJECT_NOT_FOUND - auto const issuanceKey = keylet::mptIssuance(amount.get().getMptID()); + auto const issuanceKey = keylet::mptokenIssuance(amount.get().getMptID()); auto const sleIssuance = ctx.view.read(issuanceKey); if (!sleIssuance) return tecOBJECT_NOT_FOUND; diff --git a/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp b/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp index 4cda867b48..7f1f9ec078 100644 --- a/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp +++ b/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp @@ -172,7 +172,7 @@ escrowFinishPreclaimHelper( return tesSUCCESS; // If the mpt does not exist, return tecOBJECT_NOT_FOUND - auto const issuanceKey = keylet::mptIssuance(amount.get().getMptID()); + auto const issuanceKey = keylet::mptokenIssuance(amount.get().getMptID()); auto const sleIssuance = ctx.view.read(issuanceKey); if (!sleIssuance) return tecOBJECT_NOT_FOUND; diff --git a/src/libxrpl/tx/transactors/lending/LoanBrokerCoverClawback.cpp b/src/libxrpl/tx/transactors/lending/LoanBrokerCoverClawback.cpp index 041bf73abf..9bb84e878e 100644 --- a/src/libxrpl/tx/transactors/lending/LoanBrokerCoverClawback.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanBrokerCoverClawback.cpp @@ -218,7 +218,7 @@ preclaimHelper( SLE const& sleIssuer, STAmount const& clawAmount) { - auto const issuanceKey = keylet::mptIssuance(clawAmount.get().getMptID()); + auto const issuanceKey = keylet::mptokenIssuance(clawAmount.get().getMptID()); auto const sleIssuance = ctx.view.read(issuanceKey); if (!sleIssuance) return tecOBJECT_NOT_FOUND; @@ -245,7 +245,7 @@ LoanBrokerCoverClawback::preclaim(PreclaimContext const& ctx) auto const brokerID = *findBrokerID; auto const amount = tx[~sfAmount]; - auto const sleBroker = ctx.view.read(keylet::loanbroker(brokerID)); + auto const sleBroker = ctx.view.read(keylet::loanBroker(brokerID)); if (!sleBroker) { JLOG(ctx.j.warn()) << "LoanBroker does not exist."; @@ -344,7 +344,7 @@ LoanBrokerCoverClawback::doApply() auto const brokerID = *findBrokerID; auto const amount = tx[~sfAmount]; - auto sleBroker = view().peek(keylet::loanbroker(brokerID)); + auto sleBroker = view().peek(keylet::loanBroker(brokerID)); if (!sleBroker) return tecINTERNAL; // LCOV_EXCL_LINE diff --git a/src/libxrpl/tx/transactors/lending/LoanBrokerCoverDeposit.cpp b/src/libxrpl/tx/transactors/lending/LoanBrokerCoverDeposit.cpp index 537996ba57..76a5493a73 100644 --- a/src/libxrpl/tx/transactors/lending/LoanBrokerCoverDeposit.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanBrokerCoverDeposit.cpp @@ -49,7 +49,7 @@ LoanBrokerCoverDeposit::preclaim(PreclaimContext const& ctx) auto const brokerID = tx[sfLoanBrokerID]; auto const amount = tx[sfAmount]; - auto const sleBroker = ctx.view.read(keylet::loanbroker(brokerID)); + auto const sleBroker = ctx.view.read(keylet::loanBroker(brokerID)); if (!sleBroker) { JLOG(ctx.j.warn()) << "LoanBroker does not exist."; @@ -129,7 +129,7 @@ LoanBrokerCoverDeposit::doApply() auto const& tx = ctx_.tx; auto const brokerID = tx[sfLoanBrokerID]; - auto broker = view().peek(keylet::loanbroker(brokerID)); + auto broker = view().peek(keylet::loanBroker(brokerID)); if (!broker) return tecINTERNAL; // LCOV_EXCL_LINE diff --git a/src/libxrpl/tx/transactors/lending/LoanBrokerCoverWithdraw.cpp b/src/libxrpl/tx/transactors/lending/LoanBrokerCoverWithdraw.cpp index fea6f3b9cb..426f77cc70 100644 --- a/src/libxrpl/tx/transactors/lending/LoanBrokerCoverWithdraw.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanBrokerCoverWithdraw.cpp @@ -68,7 +68,7 @@ LoanBrokerCoverWithdraw::preclaim(PreclaimContext const& ctx) JLOG(ctx.j.warn()) << "Trying to withdraw into a pseudo-account."; return tecPSEUDO_ACCOUNT; } - auto const sleBroker = ctx.view.read(keylet::loanbroker(brokerID)); + auto const sleBroker = ctx.view.read(keylet::loanBroker(brokerID)); if (!sleBroker) { JLOG(ctx.j.warn()) << "LoanBroker does not exist."; @@ -180,7 +180,7 @@ LoanBrokerCoverWithdraw::doApply() auto const amount = tx[sfAmount]; auto const dstAcct = tx[~sfDestination].value_or(accountID_); - auto broker = view().peek(keylet::loanbroker(brokerID)); + auto broker = view().peek(keylet::loanBroker(brokerID)); if (!broker) return tecINTERNAL; // LCOV_EXCL_LINE diff --git a/src/libxrpl/tx/transactors/lending/LoanBrokerDelete.cpp b/src/libxrpl/tx/transactors/lending/LoanBrokerDelete.cpp index f3c000bf0b..141cc2cf56 100644 --- a/src/libxrpl/tx/transactors/lending/LoanBrokerDelete.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanBrokerDelete.cpp @@ -43,7 +43,7 @@ LoanBrokerDelete::preclaim(PreclaimContext const& ctx) auto const account = tx[sfAccount]; auto const brokerID = tx[sfLoanBrokerID]; - auto const sleBroker = ctx.view.read(keylet::loanbroker(brokerID)); + auto const sleBroker = ctx.view.read(keylet::loanBroker(brokerID)); if (!sleBroker) { JLOG(ctx.j.warn()) << "LoanBroker does not exist."; @@ -129,7 +129,7 @@ LoanBrokerDelete::doApply() auto const brokerID = tx[sfLoanBrokerID]; // Delete the loan broker - auto broker = view().peek(keylet::loanbroker(brokerID)); + auto broker = view().peek(keylet::loanBroker(brokerID)); if (!broker) return tefBAD_LEDGER; // LCOV_EXCL_LINE auto const vaultID = broker->at(sfVaultID); diff --git a/src/libxrpl/tx/transactors/lending/LoanBrokerSet.cpp b/src/libxrpl/tx/transactors/lending/LoanBrokerSet.cpp index 2dc003eb7f..ab1c8f22dc 100644 --- a/src/libxrpl/tx/transactors/lending/LoanBrokerSet.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanBrokerSet.cpp @@ -114,7 +114,7 @@ LoanBrokerSet::preclaim(PreclaimContext const& ctx) { // Updating an existing Broker - auto const sleBroker = ctx.view.read(keylet::loanbroker(*brokerID)); + auto const sleBroker = ctx.view.read(keylet::loanBroker(*brokerID)); if (!sleBroker) { JLOG(ctx.j.warn()) << "LoanBroker does not exist."; @@ -178,7 +178,7 @@ LoanBrokerSet::doApply() if (auto const brokerID = tx[~sfLoanBrokerID]) { // Modify an existing LoanBroker - auto broker = view.peek(keylet::loanbroker(*brokerID)); + auto broker = view.peek(keylet::loanBroker(*brokerID)); if (!broker) { // This should be impossible @@ -229,7 +229,7 @@ LoanBrokerSet::doApply() return tefBAD_LEDGER; // LCOV_EXCL_STOP } - auto broker = std::make_shared(keylet::loanbroker(accountID_, sequence)); + auto broker = std::make_shared(keylet::loanBroker(accountID_, sequence)); if (auto const ter = dirLink(view, accountID_, broker)) return ter; // LCOV_EXCL_LINE diff --git a/src/libxrpl/tx/transactors/lending/LoanDelete.cpp b/src/libxrpl/tx/transactors/lending/LoanDelete.cpp index d4ec92a9fb..3459119379 100644 --- a/src/libxrpl/tx/transactors/lending/LoanDelete.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanDelete.cpp @@ -54,7 +54,7 @@ LoanDelete::preclaim(PreclaimContext const& ctx) } auto const loanBrokerID = loanSle->at(sfLoanBrokerID); - auto const loanBrokerSle = ctx.view.read(keylet::loanbroker(loanBrokerID)); + auto const loanBrokerSle = ctx.view.read(keylet::loanBroker(loanBrokerID)); if (!loanBrokerSle) { // should be impossible @@ -85,7 +85,7 @@ LoanDelete::doApply() return tefBAD_LEDGER; // LCOV_EXCL_LINE auto const brokerID = loanSle->at(sfLoanBrokerID); - auto const brokerSle = view.peek(keylet::loanbroker(brokerID)); + auto const brokerSle = view.peek(keylet::loanBroker(brokerID)); if (!brokerSle) return tefBAD_LEDGER; // LCOV_EXCL_LINE auto const brokerPseudoAccount = brokerSle->at(sfAccount); diff --git a/src/libxrpl/tx/transactors/lending/LoanManage.cpp b/src/libxrpl/tx/transactors/lending/LoanManage.cpp index 2b5c9d25f6..830eb30272 100644 --- a/src/libxrpl/tx/transactors/lending/LoanManage.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanManage.cpp @@ -111,7 +111,7 @@ LoanManage::preclaim(PreclaimContext const& ctx) } auto const loanBrokerID = loanSle->at(sfLoanBrokerID); - auto const loanBrokerSle = ctx.view.read(keylet::loanbroker(loanBrokerID)); + auto const loanBrokerSle = ctx.view.read(keylet::loanBroker(loanBrokerID)); if (!loanBrokerSle) { // should be impossible @@ -398,7 +398,7 @@ LoanManage::doApply() return tefBAD_LEDGER; // LCOV_EXCL_LINE auto const brokerID = loanSle->at(sfLoanBrokerID); - auto const brokerSle = view.peek(keylet::loanbroker(brokerID)); + auto const brokerSle = view.peek(keylet::loanBroker(brokerID)); if (!brokerSle) return tefBAD_LEDGER; // LCOV_EXCL_LINE diff --git a/src/libxrpl/tx/transactors/lending/LoanPay.cpp b/src/libxrpl/tx/transactors/lending/LoanPay.cpp index 5c0b46de42..fcda2a9fff 100644 --- a/src/libxrpl/tx/transactors/lending/LoanPay.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanPay.cpp @@ -110,7 +110,7 @@ LoanPay::calculateBaseFee(ReadView const& view, STTx const& tx) return normalCost; } - auto const brokerSle = view.read(keylet::loanbroker(loanSle->at(sfLoanBrokerID))); + auto const brokerSle = view.read(keylet::loanBroker(loanSle->at(sfLoanBrokerID))); if (!brokerSle) { // Let preclaim worry about the error for this @@ -213,7 +213,7 @@ LoanPay::preclaim(PreclaimContext const& ctx) } auto const loanBrokerID = loanSle->at(sfLoanBrokerID); - auto const loanBrokerSle = ctx.view.read(keylet::loanbroker(loanBrokerID)); + auto const loanBrokerSle = ctx.view.read(keylet::loanBroker(loanBrokerID)); if (!loanBrokerSle) { // This should be impossible @@ -293,7 +293,7 @@ LoanPay::doApply() std::int32_t const loanScale = loanSle->at(sfLoanScale); auto const brokerID = loanSle->at(sfLoanBrokerID); - auto const brokerSle = view.peek(keylet::loanbroker(brokerID)); + auto const brokerSle = view.peek(keylet::loanBroker(brokerID)); if (!brokerSle) return tefBAD_LEDGER; // LCOV_EXCL_LINE auto const brokerOwner = brokerSle->at(sfOwner); diff --git a/src/libxrpl/tx/transactors/lending/LoanSet.cpp b/src/libxrpl/tx/transactors/lending/LoanSet.cpp index 573f700f51..903707320b 100644 --- a/src/libxrpl/tx/transactors/lending/LoanSet.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanSet.cpp @@ -150,7 +150,7 @@ LoanSet::checkSign(PreclaimContext const& ctx) if (auto const c = ctx.tx.at(~sfCounterparty)) return c; - if (auto const broker = ctx.view.read(keylet::loanbroker(ctx.tx[sfLoanBrokerID]))) + if (auto const broker = ctx.view.read(keylet::loanBroker(ctx.tx[sfLoanBrokerID]))) return broker->at(sfOwner); return std::nullopt; }(); @@ -268,7 +268,7 @@ LoanSet::preclaim(PreclaimContext const& ctx) auto const account = tx[sfAccount]; auto const brokerID = tx[sfLoanBrokerID]; - auto const brokerSle = ctx.view.read(keylet::loanbroker(brokerID)); + auto const brokerSle = ctx.view.read(keylet::loanBroker(brokerID)); if (!brokerSle) { // This can only be hit if there's a counterparty specified, otherwise @@ -373,7 +373,7 @@ LoanSet::doApply() auto const brokerID = tx[sfLoanBrokerID]; - auto const brokerSle = view.peek(keylet::loanbroker(brokerID)); + auto const brokerSle = view.peek(keylet::loanBroker(brokerID)); if (!brokerSle) return tefBAD_LEDGER; // LCOV_EXCL_LINE auto const brokerOwner = brokerSle->at(sfOwner); diff --git a/src/libxrpl/tx/transactors/nft/NFTokenAcceptOffer.cpp b/src/libxrpl/tx/transactors/nft/NFTokenAcceptOffer.cpp index 6a82a15044..1d303b7141 100644 --- a/src/libxrpl/tx/transactors/nft/NFTokenAcceptOffer.cpp +++ b/src/libxrpl/tx/transactors/nft/NFTokenAcceptOffer.cpp @@ -60,7 +60,7 @@ NFTokenAcceptOffer::preclaim(PreclaimContext const& ctx) if (id->isZero()) return {nullptr, tecOBJECT_NOT_FOUND}; - auto offerSLE = ctx.view.read(keylet::nftoffer(*id)); + auto offerSLE = ctx.view.read(keylet::nftokenOffer(*id)); if (!offerSLE) return {nullptr, tecOBJECT_NOT_FOUND}; @@ -307,7 +307,7 @@ NFTokenAcceptOffer::preclaim(PreclaimContext const& ctx) if (ctx.view.rules().enabled(fixEnforceNFTokenTrustline) && (nft::getFlags(tokenID) & nft::kFlagCreateTrustLines) == 0 && nftMinter != amount.getIssuer() && - !ctx.view.read(keylet::line(nftMinter, amount.get()))) + !ctx.view.read(keylet::trustLine(nftMinter, amount.get()))) return tecNO_LINE; // Check that the issuer is allowed to receive IOUs. @@ -442,7 +442,7 @@ NFTokenAcceptOffer::doApply() auto const loadToken = [this](std::optional const& id) { SLE::pointer sle; if (id) - sle = view().peek(keylet::nftoffer(*id)); + sle = view().peek(keylet::nftokenOffer(*id)); return sle; }; diff --git a/src/libxrpl/tx/transactors/nft/NFTokenCancelOffer.cpp b/src/libxrpl/tx/transactors/nft/NFTokenCancelOffer.cpp index d04714907e..6c6f7d4e8b 100644 --- a/src/libxrpl/tx/transactors/nft/NFTokenCancelOffer.cpp +++ b/src/libxrpl/tx/transactors/nft/NFTokenCancelOffer.cpp @@ -88,7 +88,7 @@ NFTokenCancelOffer::doApply() { for (auto const& id : ctx_.tx[sfNFTokenOffers]) { - if (auto offer = view().peek(keylet::nftoffer(id)); + if (auto offer = view().peek(keylet::nftokenOffer(id)); offer && !nft::deleteTokenOffer(view(), offer)) { // LCOV_EXCL_START diff --git a/src/libxrpl/tx/transactors/payment_channel/PaymentChannelCreate.cpp b/src/libxrpl/tx/transactors/payment_channel/PaymentChannelCreate.cpp index 63dbe01944..977da56861 100644 --- a/src/libxrpl/tx/transactors/payment_channel/PaymentChannelCreate.cpp +++ b/src/libxrpl/tx/transactors/payment_channel/PaymentChannelCreate.cpp @@ -137,7 +137,7 @@ PaymentChannelCreate::doApply() // // Note that we use the value from the sequence or ticket as the // payChan sequence. For more explanation see comments in SeqProxy.h. - Keylet const payChanKeylet = keylet::payChan(account, dst, ctx_.tx.getSeqValue()); + Keylet const payChanKeylet = keylet::payChannel(account, dst, ctx_.tx.getSeqValue()); auto const slep = std::make_shared(payChanKeylet); // Funds held in this channel diff --git a/src/libxrpl/tx/transactors/system/Change.cpp b/src/libxrpl/tx/transactors/system/Change.cpp index 38fee5bf92..f27855a5c8 100644 --- a/src/libxrpl/tx/transactors/system/Change.cpp +++ b/src/libxrpl/tx/transactors/system/Change.cpp @@ -254,7 +254,7 @@ Change::applyAmendment() TER Change::applyFee() { - auto const k = keylet::fees(); + auto const k = keylet::feeSettings(); SLE::pointer feeObject = view().peek(k); diff --git a/src/libxrpl/tx/transactors/system/TicketCreate.cpp b/src/libxrpl/tx/transactors/system/TicketCreate.cpp index be24b6326a..73a72c217d 100644 --- a/src/libxrpl/tx/transactors/system/TicketCreate.cpp +++ b/src/libxrpl/tx/transactors/system/TicketCreate.cpp @@ -100,7 +100,7 @@ TicketCreate::doApply() for (std::uint32_t i = 0; i < ticketCount; ++i) { std::uint32_t const curTicketSeq = firstTicketSeq + i; - Keylet const ticketKeylet = keylet::kTicket(accountID_, curTicketSeq); + Keylet const ticketKeylet = keylet::ticket(accountID_, curTicketSeq); SLE::pointer const sleTicket = std::make_shared(ticketKeylet); sleTicket->setAccountID(sfAccount, accountID_); diff --git a/src/libxrpl/tx/transactors/token/Clawback.cpp b/src/libxrpl/tx/transactors/token/Clawback.cpp index 06132c1c97..64457a3b5f 100644 --- a/src/libxrpl/tx/transactors/token/Clawback.cpp +++ b/src/libxrpl/tx/transactors/token/Clawback.cpp @@ -109,7 +109,7 @@ preclaimHelper( return tecNO_PERMISSION; auto const sleRippleState = - ctx.view.read(keylet::line(holder, issuer, clawAmount.get().currency)); + ctx.view.read(keylet::trustLine(holder, issuer, clawAmount.get().currency)); if (!sleRippleState) return tecNO_LINE; @@ -153,7 +153,7 @@ preclaimHelper( AccountID const& holder, STAmount const& clawAmount) { - auto const issuanceKey = keylet::mptIssuance(clawAmount.get().getMptID()); + auto const issuanceKey = keylet::mptokenIssuance(clawAmount.get().getMptID()); auto const sleIssuance = ctx.view.read(issuanceKey); if (!sleIssuance) return tecOBJECT_NOT_FOUND; diff --git a/src/libxrpl/tx/transactors/token/MPTokenAuthorize.cpp b/src/libxrpl/tx/transactors/token/MPTokenAuthorize.cpp index 332d160cac..e1d9daaada 100644 --- a/src/libxrpl/tx/transactors/token/MPTokenAuthorize.cpp +++ b/src/libxrpl/tx/transactors/token/MPTokenAuthorize.cpp @@ -64,7 +64,7 @@ MPTokenAuthorize::preclaim(PreclaimContext const& ctx) if ((*sleMpt)[sfMPTAmount] != 0) { auto const sleMptIssuance = - ctx.view.read(keylet::mptIssuance(ctx.tx[sfMPTokenIssuanceID])); + ctx.view.read(keylet::mptokenIssuance(ctx.tx[sfMPTokenIssuanceID])); if (!sleMptIssuance) return tefINTERNAL; // LCOV_EXCL_LINE @@ -74,7 +74,7 @@ MPTokenAuthorize::preclaim(PreclaimContext const& ctx) if ((*sleMpt)[~sfLockedAmount].value_or(0) != 0) { auto const sleMptIssuance = - ctx.view.read(keylet::mptIssuance(ctx.tx[sfMPTokenIssuanceID])); + ctx.view.read(keylet::mptokenIssuance(ctx.tx[sfMPTokenIssuanceID])); if (!sleMptIssuance) return tefINTERNAL; // LCOV_EXCL_LINE @@ -87,7 +87,8 @@ MPTokenAuthorize::preclaim(PreclaimContext const& ctx) } // Now test when the holder wants to hold/create/authorize a new MPT - auto const sleMptIssuance = ctx.view.read(keylet::mptIssuance(ctx.tx[sfMPTokenIssuanceID])); + auto const sleMptIssuance = + ctx.view.read(keylet::mptokenIssuance(ctx.tx[sfMPTokenIssuanceID])); if (!sleMptIssuance) return tecOBJECT_NOT_FOUND; @@ -106,7 +107,7 @@ MPTokenAuthorize::preclaim(PreclaimContext const& ctx) if (!sleHolder) return tecNO_DST; - auto const sleMptIssuance = ctx.view.read(keylet::mptIssuance(ctx.tx[sfMPTokenIssuanceID])); + auto const sleMptIssuance = ctx.view.read(keylet::mptokenIssuance(ctx.tx[sfMPTokenIssuanceID])); if (!sleMptIssuance) return tecOBJECT_NOT_FOUND; diff --git a/src/libxrpl/tx/transactors/token/MPTokenIssuanceCreate.cpp b/src/libxrpl/tx/transactors/token/MPTokenIssuanceCreate.cpp index 90e33d3a70..68956a533d 100644 --- a/src/libxrpl/tx/transactors/token/MPTokenIssuanceCreate.cpp +++ b/src/libxrpl/tx/transactors/token/MPTokenIssuanceCreate.cpp @@ -112,7 +112,7 @@ MPTokenIssuanceCreate::create(ApplyView& view, beast::Journal journal, MPTCreate return std::unexpected(tecINSUFFICIENT_RESERVE); auto const mptId = makeMptID(args.sequence, args.account); - auto const mptIssuanceKeylet = keylet::mptIssuance(mptId); + auto const mptIssuanceKeylet = keylet::mptokenIssuance(mptId); // create the MPTokenIssuance { diff --git a/src/libxrpl/tx/transactors/token/MPTokenIssuanceDestroy.cpp b/src/libxrpl/tx/transactors/token/MPTokenIssuanceDestroy.cpp index 1029c25813..c56697767b 100644 --- a/src/libxrpl/tx/transactors/token/MPTokenIssuanceDestroy.cpp +++ b/src/libxrpl/tx/transactors/token/MPTokenIssuanceDestroy.cpp @@ -21,7 +21,7 @@ TER MPTokenIssuanceDestroy::preclaim(PreclaimContext const& ctx) { // ensure that issuance exists - auto const sleMPT = ctx.view.read(keylet::mptIssuance(ctx.tx[sfMPTokenIssuanceID])); + auto const sleMPT = ctx.view.read(keylet::mptokenIssuance(ctx.tx[sfMPTokenIssuanceID])); if (!sleMPT) return tecOBJECT_NOT_FOUND; @@ -42,7 +42,7 @@ MPTokenIssuanceDestroy::preclaim(PreclaimContext const& ctx) TER MPTokenIssuanceDestroy::doApply() { - auto const mpt = view().peek(keylet::mptIssuance(ctx_.tx[sfMPTokenIssuanceID])); + auto const mpt = view().peek(keylet::mptokenIssuance(ctx_.tx[sfMPTokenIssuanceID])); if (accountID_ != mpt->getAccountID(sfIssuer)) return tecINTERNAL; // LCOV_EXCL_LINE diff --git a/src/libxrpl/tx/transactors/token/MPTokenIssuanceSet.cpp b/src/libxrpl/tx/transactors/token/MPTokenIssuanceSet.cpp index 1cb12709d5..e200c9762a 100644 --- a/src/libxrpl/tx/transactors/token/MPTokenIssuanceSet.cpp +++ b/src/libxrpl/tx/transactors/token/MPTokenIssuanceSet.cpp @@ -127,7 +127,7 @@ TER MPTokenIssuanceSet::preclaim(PreclaimContext const& ctx) { // ensure that issuance exists - auto const sleMptIssuance = ctx.view.read(keylet::mptIssuance(ctx.tx[sfMPTokenIssuanceID])); + auto const sleMptIssuance = ctx.view.read(keylet::mptokenIssuance(ctx.tx[sfMPTokenIssuanceID])); if (!sleMptIssuance) return tecOBJECT_NOT_FOUND; @@ -222,7 +222,7 @@ MPTokenIssuanceSet::doApply() } else { - sle = view().peek(keylet::mptIssuance(mptIssuanceID)); + sle = view().peek(keylet::mptokenIssuance(mptIssuanceID)); } if (!sle) diff --git a/src/libxrpl/tx/transactors/token/TrustSet.cpp b/src/libxrpl/tx/transactors/token/TrustSet.cpp index 7838b212b2..151e82bab9 100644 --- a/src/libxrpl/tx/transactors/token/TrustSet.cpp +++ b/src/libxrpl/tx/transactors/token/TrustSet.cpp @@ -129,7 +129,7 @@ TrustSet::checkGranularSemantics( { auto const saLimitAmount = tx.getFieldAmount(sfLimitAmount); auto const sleRippleState = view.read( - keylet::line( + keylet::trustLine( tx[sfAccount], saLimitAmount.getIssuer(), saLimitAmount.get().currency)); // granular permissions are not allowed to create a trustline @@ -192,7 +192,7 @@ TrustSet::preclaim(PreclaimContext const& ctx) // o The trust line already exists // Then allow the TrustSet. if (ctx.view.rules().enabled(fixDisallowIncomingV1) && - ctx.view.exists(keylet::line(id, uDstAccountID, currency))) + ctx.view.exists(keylet::trustLine(id, uDstAccountID, currency))) { // pass } @@ -212,7 +212,7 @@ TrustSet::preclaim(PreclaimContext const& ctx) // TrustSet if the asset is AMM LP token and AMM is not in empty state. if (sleDst->isFieldPresent(sfAMMID)) { - if (ctx.view.exists(keylet::line(id, uDstAccountID, currency))) + if (ctx.view.exists(keylet::trustLine(id, uDstAccountID, currency))) { // pass } @@ -235,7 +235,7 @@ TrustSet::preclaim(PreclaimContext const& ctx) } else if (sleDst->isFieldPresent(sfVaultID) || sleDst->isFieldPresent(sfLoanBrokerID)) { - if (!ctx.view.exists(keylet::line(id, uDstAccountID, currency))) + if (!ctx.view.exists(keylet::trustLine(id, uDstAccountID, currency))) return tecNO_PERMISSION; // else pass } @@ -269,7 +269,7 @@ TrustSet::preclaim(PreclaimContext const& ctx) bool const bHigh = id > uDstAccountID; // Fetching current state of trust line - auto const sleRippleState = ctx.view.read(keylet::line(id, uDstAccountID, currency)); + auto const sleRippleState = ctx.view.read(keylet::trustLine(id, uDstAccountID, currency)); std::uint32_t uFlags = sleRippleState ? sleRippleState->getFieldU32(sfFlags) : 0u; // Computing expected trust line state uFlags = computeFreezeFlags( @@ -361,7 +361,7 @@ TrustSet::doApply() saLimitAllow.get().account = accountID_; SLE::pointer const sleRippleState = - view().peek(keylet::line(accountID_, uDstAccountID, currency)); + view().peek(keylet::trustLine(accountID_, uDstAccountID, currency)); if (sleRippleState) { @@ -609,7 +609,7 @@ TrustSet::doApply() // Zero balance in currency. STAmount const saBalance(Issue{currency, noAccount()}); - auto const k = keylet::line(accountID_, uDstAccountID, currency); + auto const k = keylet::trustLine(accountID_, uDstAccountID, currency); JLOG(j_.trace()) << "doTrustSet: Creating ripple line: " << to_string(k.key); diff --git a/src/libxrpl/tx/transactors/vault/VaultClawback.cpp b/src/libxrpl/tx/transactors/vault/VaultClawback.cpp index a8587feaeb..541660c98f 100644 --- a/src/libxrpl/tx/transactors/vault/VaultClawback.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultClawback.cpp @@ -86,7 +86,7 @@ VaultClawback::preclaim(PreclaimContext const& ctx) auto const holder = ctx.tx[sfHolder]; auto const maybeAmount = ctx.tx[~sfAmount]; auto const mptIssuanceID = vault->at(sfShareMPTID); - auto const sleShareIssuance = ctx.view.read(keylet::mptIssuance(mptIssuanceID)); + auto const sleShareIssuance = ctx.view.read(keylet::mptokenIssuance(mptIssuanceID)); if (!sleShareIssuance) { // LCOV_EXCL_START @@ -180,7 +180,7 @@ VaultClawback::preclaim(PreclaimContext const& ctx) return vaultAsset.visit( [&](MPTIssue const& issue) -> TER { - auto const mptIssue = ctx.view.read(keylet::mptIssuance(issue.getMptID())); + auto const mptIssue = ctx.view.read(keylet::mptokenIssuance(issue.getMptID())); if (mptIssue == nullptr) return tecOBJECT_NOT_FOUND; @@ -337,7 +337,7 @@ VaultClawback::doApply() return tefINTERNAL; // LCOV_EXCL_LINE auto const mptIssuanceID = *vault->at(sfShareMPTID); - auto const sleIssuance = view().read(keylet::mptIssuance(mptIssuanceID)); + auto const sleIssuance = view().read(keylet::mptokenIssuance(mptIssuanceID)); if (!sleIssuance) { // LCOV_EXCL_START diff --git a/src/libxrpl/tx/transactors/vault/VaultCreate.cpp b/src/libxrpl/tx/transactors/vault/VaultCreate.cpp index 4163753014..d262132b6f 100644 --- a/src/libxrpl/tx/transactors/vault/VaultCreate.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultCreate.cpp @@ -194,7 +194,7 @@ VaultCreate::doApply() return std::nullopt; return asset.holds() ? keylet::mptoken(asset.get().getMptID(), pseudoId).key - : keylet::line(pseudoId, asset.get()).key; + : keylet::trustLine(pseudoId, asset.get()).key; }(); auto const maybeShare = MPTokenIssuanceCreate::create( view(), diff --git a/src/libxrpl/tx/transactors/vault/VaultDelete.cpp b/src/libxrpl/tx/transactors/vault/VaultDelete.cpp index 030a7e971c..0550f08b17 100644 --- a/src/libxrpl/tx/transactors/vault/VaultDelete.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultDelete.cpp @@ -57,7 +57,7 @@ VaultDelete::preclaim(PreclaimContext const& ctx) } // Verify we can destroy MPTokenIssuance - auto const sleMPT = ctx.view.read(keylet::mptIssuance(vault->at(sfShareMPTID))); + auto const sleMPT = ctx.view.read(keylet::mptokenIssuance(vault->at(sfShareMPTID))); if (!sleMPT) { @@ -110,7 +110,7 @@ VaultDelete::doApply() // Destroy the share issuance. Do not use MPTokenIssuanceDestroy for this, // no special logic needed. First run few checks, duplicated from preclaim. auto const shareMPTID = *vault->at(sfShareMPTID); - auto const mpt = view().peek(keylet::mptIssuance(shareMPTID)); + auto const mpt = view().peek(keylet::mptokenIssuance(shareMPTID)); if (!mpt) { // LCOV_EXCL_START diff --git a/src/libxrpl/tx/transactors/vault/VaultDeposit.cpp b/src/libxrpl/tx/transactors/vault/VaultDeposit.cpp index c08d1e957c..b70543d280 100644 --- a/src/libxrpl/tx/transactors/vault/VaultDeposit.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultDeposit.cpp @@ -90,7 +90,7 @@ VaultDeposit::preclaim(PreclaimContext const& ctx) // LCOV_EXCL_STOP } - auto const sleIssuance = ctx.view.read(keylet::mptIssuance(mptIssuanceID)); + auto const sleIssuance = ctx.view.read(keylet::mptokenIssuance(mptIssuanceID)); if (!sleIssuance) { // LCOV_EXCL_START @@ -206,7 +206,7 @@ VaultDeposit::doApply() // Make sure the depositor can hold shares. auto const mptIssuanceID = (*vault)[sfShareMPTID]; - auto const sleIssuance = view().read(keylet::mptIssuance(mptIssuanceID)); + auto const sleIssuance = view().read(keylet::mptokenIssuance(mptIssuanceID)); if (!sleIssuance) { // LCOV_EXCL_START diff --git a/src/libxrpl/tx/transactors/vault/VaultSet.cpp b/src/libxrpl/tx/transactors/vault/VaultSet.cpp index 6d0ade6e52..c71e84858a 100644 --- a/src/libxrpl/tx/transactors/vault/VaultSet.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultSet.cpp @@ -75,7 +75,7 @@ VaultSet::preclaim(PreclaimContext const& ctx) } auto const mptIssuanceID = (*vault)[sfShareMPTID]; - auto const sleIssuance = ctx.view.read(keylet::mptIssuance(mptIssuanceID)); + auto const sleIssuance = ctx.view.read(keylet::mptokenIssuance(mptIssuanceID)); if (!sleIssuance) { // LCOV_EXCL_START @@ -130,7 +130,7 @@ VaultSet::doApply() auto const vaultAsset = vault->at(sfAsset); auto const mptIssuanceID = (*vault)[sfShareMPTID]; - auto const sleIssuance = view().peek(keylet::mptIssuance(mptIssuanceID)); + auto const sleIssuance = view().peek(keylet::mptokenIssuance(mptIssuanceID)); if (!sleIssuance) { // LCOV_EXCL_START diff --git a/src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp b/src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp index 05dcfea506..815d8ccd5b 100644 --- a/src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp @@ -106,7 +106,7 @@ VaultWithdraw::preclaim(PreclaimContext const& ctx) // to the equivalent asset amount before checking withdrawal // limits. Pre-amendment the limit check was skipped for // share-denominated withdrawals. - auto const sleIssuance = ctx.view.read(keylet::mptIssuance(vaultShare)); + auto const sleIssuance = ctx.view.read(keylet::mptokenIssuance(vaultShare)); if (!sleIssuance) { // LCOV_EXCL_START @@ -180,7 +180,7 @@ VaultWithdraw::doApply() return tefINTERNAL; // LCOV_EXCL_LINE auto const mptIssuanceID = *((*vault)[sfShareMPTID]); - auto const sleIssuance = view().read(keylet::mptIssuance(mptIssuanceID)); + auto const sleIssuance = view().read(keylet::mptokenIssuance(mptIssuanceID)); if (!sleIssuance) { // LCOV_EXCL_START diff --git a/src/test/app/AccountDelete_test.cpp b/src/test/app/AccountDelete_test.cpp index 65ff9ed839..399696ec0d 100644 --- a/src/test/app/AccountDelete_test.cpp +++ b/src/test/app/AccountDelete_test.cpp @@ -215,8 +215,8 @@ public: BEAST_EXPECT(env.closed()->exists(keylet::ownerDir(carol.id()))); BEAST_EXPECT(env.closed()->exists(keylet::depositPreauth(carol.id(), becky.id()))); BEAST_EXPECT(env.closed()->exists(keylet::offer(carol.id(), carolOfferSeq))); - BEAST_EXPECT(env.closed()->exists(keylet::kTicket(carol.id(), carolTicketSeq))); - BEAST_EXPECT(env.closed()->exists(keylet::signers(carol.id()))); + BEAST_EXPECT(env.closed()->exists(keylet::ticket(carol.id(), carolTicketSeq))); + BEAST_EXPECT(env.closed()->exists(keylet::signerList(carol.id()))); // Delete carol's account even with stuff in her directory. Show // that multisigning for the delete does not increase carol's fee. @@ -229,8 +229,8 @@ public: BEAST_EXPECT(!env.closed()->exists(keylet::ownerDir(carol.id()))); BEAST_EXPECT(!env.closed()->exists(keylet::depositPreauth(carol.id(), becky.id()))); BEAST_EXPECT(!env.closed()->exists(keylet::offer(carol.id(), carolOfferSeq))); - BEAST_EXPECT(!env.closed()->exists(keylet::kTicket(carol.id(), carolTicketSeq))); - BEAST_EXPECT(!env.closed()->exists(keylet::signers(carol.id()))); + BEAST_EXPECT(!env.closed()->exists(keylet::ticket(carol.id(), carolTicketSeq))); + BEAST_EXPECT(!env.closed()->exists(keylet::signerList(carol.id()))); // Verify that Carol's XRP, minus the fee, was transferred to becky. BEAST_EXPECT(env.balance(becky) == carolOldBalance + beckyOldBalance - acctDelFee); @@ -386,7 +386,7 @@ public: env(escrow::cancel(becky, alice, escrowSeq)); env.close(); - Keylet const alicePayChanKey{keylet::payChan(alice, becky, env.seq(alice))}; + Keylet const alicePayChanKey{keylet::payChannel(alice, becky, env.seq(alice))}; env(payChanCreate(alice, becky, XRP(57), 4s, env.now() + 2s, alice.pk())); env.close(); @@ -417,7 +417,7 @@ public: // gw creates a PayChannel with alice as the destination, this should // prevent alice from deleting her account. - Keylet const gwPayChanKey{keylet::payChan(gw, alice, env.seq(gw))}; + Keylet const gwPayChanKey{keylet::payChannel(gw, alice, env.seq(gw))}; env(payChanCreate(gw, alice, XRP(68), 4s, env.now() + 2s, alice.pk())); env.close(); @@ -662,7 +662,7 @@ public: BEAST_EXPECT(closed->exists(keylet::account(bob.id()))); for (std::uint32_t i = 0; i < 250; ++i) { - BEAST_EXPECT(closed->exists(keylet::kTicket(bob.id(), ticketSeq + i))); + BEAST_EXPECT(closed->exists(keylet::ticket(bob.id(), ticketSeq + i))); } } @@ -681,7 +681,7 @@ public: BEAST_EXPECT(!closed->exists(keylet::account(bob.id()))); for (std::uint32_t i = 0; i < 250; ++i) { - BEAST_EXPECT(!closed->exists(keylet::kTicket(bob.id(), ticketSeq + i))); + BEAST_EXPECT(!closed->exists(keylet::ticket(bob.id(), ticketSeq + i))); } } } diff --git a/src/test/app/Batch_test.cpp b/src/test/app/Batch_test.cpp index 47f9a84fb9..6aaae62155 100644 --- a/src/test/app/Batch_test.cpp +++ b/src/test/app/Batch_test.cpp @@ -3040,7 +3040,7 @@ class Batch_test : public beast::unit_test::Suite env(vault.deposit({.depositor = lender, .id = vaultKeylet.key, .amount = deposit})); env.close(); - auto const brokerKeylet = keylet::loanbroker(lender.id(), env.seq(lender)); + auto const brokerKeylet = keylet::loanBroker(lender.id(), env.seq(lender)); { using namespace loanBroker; diff --git a/src/test/app/Check_test.cpp b/src/test/app/Check_test.cpp index 9b814a24b1..3ad1e3fa4e 100644 --- a/src/test/app/Check_test.cpp +++ b/src/test/app/Check_test.cpp @@ -1951,8 +1951,8 @@ class Check_test : public beast::unit_test::Suite Account const& acct2, IOU const& offerIou, IOU const& checkIou) { - auto const offerLine = env.le(keylet::line(acct1, acct2, offerIou.currency)); - auto const checkLine = env.le(keylet::line(acct1, acct2, checkIou.currency)); + auto const offerLine = env.le(keylet::trustLine(acct1, acct2, offerIou.currency)); + auto const checkLine = env.le(keylet::trustLine(acct1, acct2, checkIou.currency)); if (offerLine == nullptr || checkLine == nullptr) { BEAST_EXPECT(offerLine == nullptr && checkLine == nullptr); @@ -2023,7 +2023,7 @@ class Check_test : public beast::unit_test::Suite IOU const oF1 = gw1["OF1"]; env(offer(gw1, XRP(98), oF1(98))); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, oF1.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, oF1.currency)) == nullptr); env(offer(alice, oF1(98), XRP(98))); ++alice.owners; env.close(); @@ -2041,7 +2041,7 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(gw1, env.seq(gw1))}; env(check::create(gw1, alice, cK1(98))); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, cK1.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, cK1.currency)) == nullptr); env(check::cash(alice, chkId, cK1(98))); ++alice.owners; verifyDeliveredAmount(env, cK1(98)); @@ -2070,7 +2070,7 @@ class Check_test : public beast::unit_test::Suite IOU const oF1 = gw1["OF1"]; env(offer(alice, XRP(97), oF1(97))); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, oF1.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, oF1.currency)) == nullptr); env(offer(bob, oF1(97), XRP(97))); ++bob.owners; env.close(); @@ -2094,12 +2094,12 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(alice, env.seq(alice))}; env(check::create(alice, bob, cK1(97))); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, cK1.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, cK1.currency)) == nullptr); env(check::cash(bob, chkId, cK1(97)), Ter(terNO_RIPPLE)); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, bob, oF1.currency)) != nullptr); - BEAST_EXPECT(env.le(keylet::line(gw1, bob, cK1.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, bob, oF1.currency)) != nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, bob, cK1.currency)) == nullptr); // Delete alice's check since it is no longer needed. env(check::cancel(alice, chkId)); @@ -2123,7 +2123,7 @@ class Check_test : public beast::unit_test::Suite IOU const oF2 = gw1["OF2"]; env(offer(gw1, XRP(96), oF2(96))); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, oF2.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, oF2.currency)) == nullptr); env(offer(alice, oF2(96), XRP(96))); ++alice.owners; env.close(); @@ -2141,7 +2141,7 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(gw1, env.seq(gw1))}; env(check::create(gw1, alice, cK2(96))); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, cK2.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, cK2.currency)) == nullptr); env(check::cash(alice, chkId, cK2(96))); ++alice.owners; verifyDeliveredAmount(env, cK2(96)); @@ -2167,7 +2167,7 @@ class Check_test : public beast::unit_test::Suite IOU const oF2 = gw1["OF2"]; env(offer(alice, XRP(95), oF2(95))); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, oF2.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, oF2.currency)) == nullptr); env(offer(bob, oF2(95), XRP(95))); ++bob.owners; env.close(); @@ -2182,7 +2182,7 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(alice, env.seq(alice))}; env(check::create(alice, bob, cK2(95))); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, cK2.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, cK2.currency)) == nullptr); env(check::cash(bob, chkId, cK2(95))); ++bob.owners; verifyDeliveredAmount(env, cK2(95)); @@ -2214,7 +2214,7 @@ class Check_test : public beast::unit_test::Suite IOU const oF3 = gw1["OF3"]; env(offer(gw1, XRP(94), oF3(94))); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, oF3.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, oF3.currency)) == nullptr); env(offer(alice, oF3(94), XRP(94))); ++alice.owners; env.close(); @@ -2232,7 +2232,7 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(gw1, env.seq(gw1))}; env(check::create(gw1, alice, cK3(94))); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, cK3.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, cK3.currency)) == nullptr); env(check::cash(alice, chkId, cK3(94))); ++alice.owners; verifyDeliveredAmount(env, cK3(94)); @@ -2258,7 +2258,7 @@ class Check_test : public beast::unit_test::Suite IOU const oF3 = gw1["OF3"]; env(offer(alice, XRP(93), oF3(93))); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, oF3.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, oF3.currency)) == nullptr); env(offer(bob, oF3(93), XRP(93))); ++bob.owners; env.close(); @@ -2273,7 +2273,7 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(alice, env.seq(alice))}; env(check::create(alice, bob, cK3(93))); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, cK3.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, cK3.currency)) == nullptr); env(check::cash(bob, chkId, cK3(93))); ++bob.owners; verifyDeliveredAmount(env, cK3(93)); @@ -2299,7 +2299,7 @@ class Check_test : public beast::unit_test::Suite IOU const oF4 = gw1["OF4"]; env(offer(gw1, XRP(92), oF4(92)), Ter(tecFROZEN)); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, oF4.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, oF4.currency)) == nullptr); env(offer(alice, oF4(92), XRP(92)), Ter(tecFROZEN)); env.close(); @@ -2313,7 +2313,7 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(gw1, env.seq(gw1))}; env(check::create(gw1, alice, cK4(92)), Ter(tecFROZEN)); env.close(); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, cK4.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, cK4.currency)) == nullptr); env(check::cash(alice, chkId, cK4(92)), Ter(tecNO_ENTRY)); env.close(); @@ -2324,8 +2324,8 @@ class Check_test : public beast::unit_test::Suite // Because gw1 has set lsfGlobalFreeze, neither trust line // is created. - BEAST_EXPECT(env.le(keylet::line(gw1, alice, oF4.currency)) == nullptr); - BEAST_EXPECT(env.le(keylet::line(gw1, alice, cK4.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, oF4.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, alice, cK4.currency)) == nullptr); } //------------ lsfGlobalFreeze, check written by non-issuer ------------ { @@ -2337,7 +2337,7 @@ class Check_test : public beast::unit_test::Suite IOU const oF4 = gw1["OF4"]; env(offer(alice, XRP(91), oF4(91)), Ter(tecFROZEN)); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, oF4.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, oF4.currency)) == nullptr); env(offer(bob, oF4(91), XRP(91)), Ter(tecFROZEN)); env.close(); @@ -2351,7 +2351,7 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(alice, env.seq(alice))}; env(check::create(alice, bob, cK4(91)), Ter(tecFROZEN)); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, cK4.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, cK4.currency)) == nullptr); env(check::cash(bob, chkId, cK4(91)), Ter(tecNO_ENTRY)); env.close(); @@ -2362,8 +2362,8 @@ class Check_test : public beast::unit_test::Suite // Because gw1 has set lsfGlobalFreeze, neither trust line // is created. - BEAST_EXPECT(env.le(keylet::line(gw1, bob, oF4.currency)) == nullptr); - BEAST_EXPECT(env.le(keylet::line(gw1, bob, cK4.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, bob, oF4.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw1, bob, cK4.currency)) == nullptr); } //-------------- lsfRequireAuth, check written by issuer --------------- @@ -2387,7 +2387,7 @@ class Check_test : public beast::unit_test::Suite env(offer(gw2, XRP(92), oF5(92))); ++gw2.owners; env.close(); - BEAST_EXPECT(env.le(keylet::line(gw2, alice, oF5.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw2, alice, oF5.currency)) == nullptr); env(offer(alice, oF5(92), XRP(92)), Ter(tecNO_LINE)); env.close(); @@ -2409,7 +2409,7 @@ class Check_test : public beast::unit_test::Suite env(check::create(gw2, alice, cK5(92))); ++gw2.owners; env.close(); - BEAST_EXPECT(env.le(keylet::line(gw2, alice, cK5.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw2, alice, cK5.currency)) == nullptr); env(check::cash(alice, chkId, cK5(92)), Ter(tecNO_AUTH)); env.close(); @@ -2421,8 +2421,8 @@ class Check_test : public beast::unit_test::Suite // Because gw2 has set lsfRequireAuth, neither trust line // is created. - BEAST_EXPECT(env.le(keylet::line(gw2, alice, oF5.currency)) == nullptr); - BEAST_EXPECT(env.le(keylet::line(gw2, alice, cK5.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw2, alice, oF5.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw2, alice, cK5.currency)) == nullptr); // Since we don't need it any more, remove gw2's check. env(check::cancel(gw2, chkId)); @@ -2441,7 +2441,7 @@ class Check_test : public beast::unit_test::Suite env(offer(alice, XRP(91), oF5(91)), Ter(tecUNFUNDED_OFFER)); env.close(); env(offer(bob, oF5(91), XRP(91)), Ter(tecNO_LINE)); - BEAST_EXPECT(env.le(keylet::line(gw2, bob, oF5.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw2, bob, oF5.currency)) == nullptr); env.close(); gw2.verifyOwners(__LINE__); @@ -2453,7 +2453,7 @@ class Check_test : public beast::unit_test::Suite uint256 const chkId{getCheckIndex(alice, env.seq(alice))}; env(check::create(alice, bob, cK5(91))); env.close(); - BEAST_EXPECT(env.le(keylet::line(alice, bob, cK5.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(alice, bob, cK5.currency)) == nullptr); env(check::cash(bob, chkId, cK5(91)), Ter(tecPATH_PARTIAL)); env.close(); @@ -2468,8 +2468,8 @@ class Check_test : public beast::unit_test::Suite // Because gw2 has set lsfRequireAuth, neither trust line // is created. - BEAST_EXPECT(env.le(keylet::line(gw2, bob, oF5.currency)) == nullptr); - BEAST_EXPECT(env.le(keylet::line(gw2, bob, cK5.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw2, bob, oF5.currency)) == nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(gw2, bob, cK5.currency)) == nullptr); } } diff --git a/src/test/app/Clawback_test.cpp b/src/test/app/Clawback_test.cpp index 5d0ecf022d..b1a756382d 100644 --- a/src/test/app/Clawback_test.cpp +++ b/src/test/app/Clawback_test.cpp @@ -53,7 +53,7 @@ class Clawback_test : public beast::unit_test::Suite test::jtx::Account const& dst, Currency const& cur) { - if (auto sle = env.le(keylet::line(src, dst, cur))) + if (auto sle = env.le(keylet::trustLine(src, dst, cur))) { auto const useHigh = src.id() > dst.id(); return sle->isFlag(useHigh ? lsfHighFreeze : lsfLowFreeze); diff --git a/src/test/app/EscrowToken_test.cpp b/src/test/app/EscrowToken_test.cpp index 5bb1303dba..666ee498bd 100644 --- a/src/test/app/EscrowToken_test.cpp +++ b/src/test/app/EscrowToken_test.cpp @@ -57,7 +57,7 @@ struct EscrowToken_test : public beast::unit_test::Suite static uint64_t issuerMPTEscrowed(jtx::Env const& env, jtx::MPT const& mpt) { - auto const sle = env.le(keylet::mptIssuance(mpt.mpt())); + auto const sle = env.le(keylet::mptokenIssuance(mpt.mpt())); if (sle && sle->isFieldPresent(sfLockedAmount)) return (*sle)[sfLockedAmount]; return 0; @@ -929,7 +929,7 @@ struct EscrowToken_test : public beast::unit_test::Suite env(trust(alice, usd(0))); env.close(); - auto const trustLineKey = keylet::line(alice.id(), gw.id(), usd.currency); + auto const trustLineKey = keylet::trustLine(alice.id(), gw.id(), usd.currency); BEAST_EXPECT(!env.current()->exists(trustLineKey)); env.close(); @@ -3177,7 +3177,8 @@ struct EscrowToken_test : public beast::unit_test::Suite BEAST_EXPECT(mptEscrowed(env, bob, mpt) == 0); BEAST_EXPECT(env.balance(gw, mpt) == outstandingMPT); BEAST_EXPECT(issuerMPTEscrowed(env, mpt) == 0); - BEAST_EXPECT(!env.le(keylet::mptIssuance(mpt.mpt()))->isFieldPresent(sfLockedAmount)); + BEAST_EXPECT( + !env.le(keylet::mptokenIssuance(mpt.mpt()))->isFieldPresent(sfLockedAmount)); } // Max MPT Amount Issued (Escrow Max MPT) diff --git a/src/test/app/FeeVote_test.cpp b/src/test/app/FeeVote_test.cpp index bf42e762c6..666dec1249 100644 --- a/src/test/app/FeeVote_test.cpp +++ b/src/test/app/FeeVote_test.cpp @@ -144,7 +144,7 @@ verifyFeeObject( Rules const& rules, FeeSettingsFields const& expected) { - auto const feeObject = ledger->read(keylet::fees()); + auto const feeObject = ledger->read(keylet::feeSettings()); if (!feeObject) return false; diff --git a/src/test/app/FixNFTokenPageLinks_test.cpp b/src/test/app/FixNFTokenPageLinks_test.cpp index cfe2fd1808..7b13fc060b 100644 --- a/src/test/app/FixNFTokenPageLinks_test.cpp +++ b/src/test/app/FixNFTokenPageLinks_test.cpp @@ -267,7 +267,7 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // Get the index of the middle page. uint256 const aliceMiddleNFTokenPageIndex = [&env, &alice]() { - auto lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + auto lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); return lastNFTokenPage->at(sfPreviousPageMin); }(); @@ -290,12 +290,12 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // Removing the last token from the last page deletes the last // page. This is a bug. The contents of the next-to-last page // should have been moved into the last page. - BEAST_EXPECT(!env.le(keylet::nftpageMax(alice))); + BEAST_EXPECT(!env.le(keylet::nftokenPageMax(alice))); // alice's "middle" page is still present, but has no links. { - auto aliceMiddleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), aliceMiddleNFTokenPageIndex)); + auto aliceMiddleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), aliceMiddleNFTokenPageIndex)); if (!BEAST_EXPECT(aliceMiddleNFTokenPage)) return; @@ -315,7 +315,7 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // Get the index of the middle page. uint256 const bobMiddleNFTokenPageIndex = [&env, &bob]() { - auto lastNFTokenPage = env.le(keylet::nftpageMax(bob)); + auto lastNFTokenPage = env.le(keylet::nftokenPageMax(bob)); return lastNFTokenPage->at(sfPreviousPageMin); }(); @@ -332,13 +332,13 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // Removing the last token from the last page deletes the last // page. This is a bug. The contents of the next-to-last page // should have been moved into the last page. - BEAST_EXPECT(!env.le(keylet::nftpageMax(bob))); + BEAST_EXPECT(!env.le(keylet::nftokenPageMax(bob))); // bob's "middle" page is still present, but has lost the // NextPageMin field. { auto bobMiddleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(bob), bobMiddleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(bob), bobMiddleNFTokenPageIndex)); if (!BEAST_EXPECT(bobMiddleNFTokenPage)) return; @@ -358,7 +358,7 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // Get the index of the middle page. uint256 const carolMiddleNFTokenPageIndex = [&env, &carol]() { - auto lastNFTokenPage = env.le(keylet::nftpageMax(carol)); + auto lastNFTokenPage = env.le(keylet::nftokenPageMax(carol)); return lastNFTokenPage->at(sfPreviousPageMin); }(); @@ -367,7 +367,7 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite dariaNFTs.reserve(32); for (int i = 0; i < 32; ++i) { - uint256 const offerIndex = keylet::nftoffer(carol, env.seq(carol)).key; + uint256 const offerIndex = keylet::nftokenOffer(carol, env.seq(carol)).key; env(token::createOffer(carol, carolNFTs.back(), XRP(0)), Txflags(tfSellNFToken)); env.close(); @@ -383,12 +383,12 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // Removing the last token from the last page deletes the last // page. This is a bug. The contents of the next-to-last page // should have been moved into the last page. - BEAST_EXPECT(!env.le(keylet::nftpageMax(carol))); + BEAST_EXPECT(!env.le(keylet::nftokenPageMax(carol))); // carol's "middle" page is still present, but has lost the // NextPageMin field. auto carolMiddleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(carol), carolMiddleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(carol), carolMiddleNFTokenPageIndex)); if (!BEAST_EXPECT(carolMiddleNFTokenPage)) return; @@ -401,7 +401,7 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // back from daria. for (uint256 const& nft : dariaNFTs) { - uint256 const offerIndex = keylet::nftoffer(carol, env.seq(carol)).key; + uint256 const offerIndex = keylet::nftokenOffer(carol, env.seq(carol)).key; env(token::createOffer(carol, nft, drops(1)), token::Owner(daria)); env.close(); @@ -418,8 +418,8 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // carol's "middle" page is present and still has no NextPageMin field. { - auto carolMiddleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(carol), carolMiddleNFTokenPageIndex)); + auto carolMiddleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(carol), carolMiddleNFTokenPageIndex)); if (!BEAST_EXPECT(carolMiddleNFTokenPage)) return; @@ -428,7 +428,7 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite } // carol has a "last" page again, but it has no PreviousPageMin field. { - auto carolLastNFTokenPage = env.le(keylet::nftpageMax(carol)); + auto carolLastNFTokenPage = env.le(keylet::nftokenPageMax(carol)); BEAST_EXPECT(!carolLastNFTokenPage->isFieldPresent(sfPreviousPageMin)); BEAST_EXPECT(!carolLastNFTokenPage->isFieldPresent(sfNextPageMin)); @@ -456,12 +456,12 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // Verify that alice's NFToken directory is still damaged. // alice's last page should still be missing. - BEAST_EXPECT(!env.le(keylet::nftpageMax(alice))); + BEAST_EXPECT(!env.le(keylet::nftokenPageMax(alice))); // alice's "middle" page is still present and has no links. { - auto aliceMiddleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), aliceMiddleNFTokenPageIndex)); + auto aliceMiddleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), aliceMiddleNFTokenPageIndex)); if (!BEAST_EXPECT(aliceMiddleNFTokenPage)) return; @@ -480,7 +480,7 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // alice's last page should now be present and include no links. { - auto aliceLastNFTokenPage = env.le(keylet::nftpageMax(alice)); + auto aliceLastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); if (!BEAST_EXPECT(aliceLastNFTokenPage)) return; @@ -489,8 +489,8 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite } // alice's middle page should be gone. - BEAST_EXPECT( - !env.le(keylet::nftpage(keylet::nftpageMin(alice), aliceMiddleNFTokenPageIndex))); + BEAST_EXPECT(!env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), aliceMiddleNFTokenPageIndex))); BEAST_EXPECT(nftCount(env, alice) == 32); BEAST_EXPECT(ownerCount(env, alice) == 1); @@ -502,12 +502,12 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // Verify that bob's NFToken directory is still damaged. // bob's last page should still be missing. - BEAST_EXPECT(!env.le(keylet::nftpageMax(bob))); + BEAST_EXPECT(!env.le(keylet::nftokenPageMax(bob))); // bob's "middle" page is still present and missing NextPageMin. { auto bobMiddleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(bob), bobMiddleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(bob), bobMiddleNFTokenPageIndex)); if (!BEAST_EXPECT(bobMiddleNFTokenPage)) return; @@ -522,7 +522,7 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // bob's last page should now be present and include a previous // link but no next link. { - auto const lastPageKeylet = keylet::nftpageMax(bob); + auto const lastPageKeylet = keylet::nftokenPageMax(bob); auto const bobLastNFTokenPage = env.le(lastPageKeylet); if (!BEAST_EXPECT(bobLastNFTokenPage)) return; @@ -532,8 +532,8 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite BEAST_EXPECT(!bobLastNFTokenPage->isFieldPresent(sfNextPageMin)); auto const bobNewFirstNFTokenPage = env.le( - keylet::nftpage( - keylet::nftpageMin(bob), bobLastNFTokenPage->at(sfPreviousPageMin))); + keylet::nftokenPage( + keylet::nftokenPageMin(bob), bobLastNFTokenPage->at(sfPreviousPageMin))); if (!BEAST_EXPECT(bobNewFirstNFTokenPage)) return; @@ -544,7 +544,8 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite } // bob's middle page should be gone. - BEAST_EXPECT(!env.le(keylet::nftpage(keylet::nftpageMin(bob), bobMiddleNFTokenPageIndex))); + BEAST_EXPECT( + !env.le(keylet::nftokenPage(keylet::nftokenPageMin(bob), bobMiddleNFTokenPageIndex))); BEAST_EXPECT(nftCount(env, bob) == 64); BEAST_EXPECT(ownerCount(env, bob) == 2); @@ -557,17 +558,16 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // carol's "middle" page is present and has no NextPageMin field. { - auto carolMiddleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(carol), carolMiddleNFTokenPageIndex)); + auto carolMiddleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(carol), carolMiddleNFTokenPageIndex)); if (!BEAST_EXPECT(carolMiddleNFTokenPage)) return; - BEAST_EXPECT(carolMiddleNFTokenPage->isFieldPresent(sfPreviousPageMin)); BEAST_EXPECT(!carolMiddleNFTokenPage->isFieldPresent(sfNextPageMin)); } // carol has a "last" page, but it has no PreviousPageMin field. { - auto carolLastNFTokenPage = env.le(keylet::nftpageMax(carol)); + auto carolLastNFTokenPage = env.le(keylet::nftokenPageMax(carol)); BEAST_EXPECT(!carolLastNFTokenPage->isFieldPresent(sfPreviousPageMin)); BEAST_EXPECT(!carolLastNFTokenPage->isFieldPresent(sfNextPageMin)); @@ -579,9 +579,9 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite { // carol's "middle" page is present and now has a NextPageMin field. - auto const lastPageKeylet = keylet::nftpageMax(carol); - auto carolMiddleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(carol), carolMiddleNFTokenPageIndex)); + auto const lastPageKeylet = keylet::nftokenPageMax(carol); + auto carolMiddleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(carol), carolMiddleNFTokenPageIndex)); if (!BEAST_EXPECT(carolMiddleNFTokenPage)) return; @@ -602,8 +602,8 @@ class FixNFTokenPageLinks_test : public beast::unit_test::Suite // carol also has a "first" page that includes a NextPageMin field. auto carolFirstNFTokenPage = env.le( - keylet::nftpage( - keylet::nftpageMin(carol), carolMiddleNFTokenPage->at(sfPreviousPageMin))); + keylet::nftokenPage( + keylet::nftokenPageMin(carol), carolMiddleNFTokenPage->at(sfPreviousPageMin))); if (!BEAST_EXPECT(carolFirstNFTokenPage)) return; diff --git a/src/test/app/Flow_test.cpp b/src/test/app/Flow_test.cpp index 5f56a0ceb1..72e39ab890 100644 --- a/src/test/app/Flow_test.cpp +++ b/src/test/app/Flow_test.cpp @@ -57,7 +57,7 @@ getNoRippleFlag( jtx::Account const& dst, Currency const& cur) { - if (auto sle = env.le(keylet::line(src, dst, cur))) + if (auto sle = env.le(keylet::trustLine(src, dst, cur))) { auto const flag = (src.id() > dst.id()) ? lsfHighNoRipple : lsfLowNoRipple; return sle->isFlag(flag); diff --git a/src/test/app/Freeze_test.cpp b/src/test/app/Freeze_test.cpp index 2b5ca831da..786f5b4680 100644 --- a/src/test/app/Freeze_test.cpp +++ b/src/test/app/Freeze_test.cpp @@ -1788,7 +1788,7 @@ class Freeze_test : public beast::unit_test::Suite env(token::mint(a2, 0), Txflags(tfTransferable)); env.close(); - auto const buyIdx = keylet::nftoffer(a1, env.seq(a1)).key; + auto const buyIdx = keylet::nftokenOffer(a1, env.seq(a1)).key; env(token::createOffer(a1, nftID, usd(10)), token::Owner(a2)); env.close(); @@ -1874,10 +1874,10 @@ class Freeze_test : public beast::unit_test::Suite env(token::mint(a2, 0), Txflags(tfTransferable)); env.close(); - uint256 const sellIdx = keylet::nftoffer(a2, env.seq(a2)).key; + uint256 const sellIdx = keylet::nftokenOffer(a2, env.seq(a2)).key; env(token::createOffer(a2, nftID, usd(10)), Txflags(tfSellNFToken)); env.close(); - auto const buyIdx = keylet::nftoffer(a1, env.seq(a1)).key; + auto const buyIdx = keylet::nftokenOffer(a1, env.seq(a1)).key; env(token::createOffer(a1, nftID, usd(11)), token::Owner(a2)); env.close(); @@ -1900,13 +1900,13 @@ class Freeze_test : public beast::unit_test::Suite env(token::mint(minter, 0), token::XferFee(1u), Txflags(tfTransferable)); env.close(); - uint256 const minterSellIdx = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterSellIdx = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, drops(1)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(a2, minterSellIdx)); env.close(); - uint256 const sellIdx = keylet::nftoffer(a2, env.seq(a2)).key; + uint256 const sellIdx = keylet::nftokenOffer(a2, env.seq(a2)).key; env(token::createOffer(a2, nftID, usd(100)), Txflags(tfSellNFToken)); env.close(); env(trust(g1, minter["USD"](1000), tfSetFreeze | tfSetDeepFreeze)); @@ -1960,7 +1960,7 @@ class Freeze_test : public beast::unit_test::Suite env(token::mint(account, 0), Txflags(tfTransferable)); env.close(); - uint256 const sellOfferIndex = keylet::nftoffer(account, env.seq(account)).key; + uint256 const sellOfferIndex = keylet::nftokenOffer(account, env.seq(account)).key; env(token::createOffer(account, nftID, currency), Txflags(tfSellNFToken)); env.close(); diff --git a/src/test/app/Invariants_test.cpp b/src/test/app/Invariants_test.cpp index e0c29ea72a..804cfaebfc 100644 --- a/src/test/app/Invariants_test.cpp +++ b/src/test/app/Invariants_test.cpp @@ -462,7 +462,7 @@ class Invariants_test : public beast::unit_test::Suite BEAST_EXPECT(sle->at(~sfAMMID) == ammKey); for (auto const& trustKeylet : - {keylet::line(ammAcctID, a1["USD"]), keylet::line(a1, ammIssue)}) + {keylet::trustLine(ammAcctID, a1["USD"]), keylet::trustLine(a1, ammIssue)}) { auto const line = ac.view().peek(trustKeylet); if (!line) @@ -563,7 +563,7 @@ class Invariants_test : public beast::unit_test::Suite [](Account const& a1, Account const& a2, ApplyContext& ac) { // create simple trust SLE with xrp currency auto const sleNew = - std::make_shared(keylet::line(a1, a2, xrpIssue().currency)); + std::make_shared(keylet::trustLine(a1, a2, xrpIssue().currency)); ac.view().insert(sleNew); return true; }); @@ -579,7 +579,8 @@ class Invariants_test : public beast::unit_test::Suite {{"a trust line with deep freeze flag without normal freeze was " "created"}}, [](Account const& a1, Account const& a2, ApplyContext& ac) { - auto const sleNew = std::make_shared(keylet::line(a1, a2, a1["USD"].currency)); + auto const sleNew = + std::make_shared(keylet::trustLine(a1, a2, a1["USD"].currency)); sleNew->setFieldAmount(sfLowLimit, a1["USD"](0)); sleNew->setFieldAmount(sfHighLimit, a1["USD"](0)); @@ -594,7 +595,8 @@ class Invariants_test : public beast::unit_test::Suite {{"a trust line with deep freeze flag without normal freeze was " "created"}}, [](Account const& a1, Account const& a2, ApplyContext& ac) { - auto const sleNew = std::make_shared(keylet::line(a1, a2, a1["USD"].currency)); + auto const sleNew = + std::make_shared(keylet::trustLine(a1, a2, a1["USD"].currency)); sleNew->setFieldAmount(sfLowLimit, a1["USD"](0)); sleNew->setFieldAmount(sfHighLimit, a1["USD"](0)); std::uint32_t uFlags = 0u; @@ -608,7 +610,8 @@ class Invariants_test : public beast::unit_test::Suite {{"a trust line with deep freeze flag without normal freeze was " "created"}}, [](Account const& a1, Account const& a2, ApplyContext& ac) { - auto const sleNew = std::make_shared(keylet::line(a1, a2, a1["USD"].currency)); + auto const sleNew = + std::make_shared(keylet::trustLine(a1, a2, a1["USD"].currency)); sleNew->setFieldAmount(sfLowLimit, a1["USD"](0)); sleNew->setFieldAmount(sfHighLimit, a1["USD"](0)); std::uint32_t uFlags = 0u; @@ -622,7 +625,8 @@ class Invariants_test : public beast::unit_test::Suite {{"a trust line with deep freeze flag without normal freeze was " "created"}}, [](Account const& a1, Account const& a2, ApplyContext& ac) { - auto const sleNew = std::make_shared(keylet::line(a1, a2, a1["USD"].currency)); + auto const sleNew = + std::make_shared(keylet::trustLine(a1, a2, a1["USD"].currency)); sleNew->setFieldAmount(sfLowLimit, a1["USD"](0)); sleNew->setFieldAmount(sfHighLimit, a1["USD"](0)); std::uint32_t uFlags = 0u; @@ -636,7 +640,8 @@ class Invariants_test : public beast::unit_test::Suite {{"a trust line with deep freeze flag without normal freeze was " "created"}}, [](Account const& a1, Account const& a2, ApplyContext& ac) { - auto const sleNew = std::make_shared(keylet::line(a1, a2, a1["USD"].currency)); + auto const sleNew = + std::make_shared(keylet::trustLine(a1, a2, a1["USD"].currency)); sleNew->setFieldAmount(sfLowLimit, a1["USD"](0)); sleNew->setFieldAmount(sfHighLimit, a1["USD"](0)); std::uint32_t uFlags = 0u; @@ -691,8 +696,8 @@ class Invariants_test : public beast::unit_test::Suite ApplyContext& ac, int a1Balance, int a2Balance) { - auto const sleA1 = ac.view().peek(keylet::line(a1, g1["USD"])); - auto const sleA2 = ac.view().peek(keylet::line(a2, g1["USD"])); + auto const sleA1 = ac.view().peek(keylet::trustLine(a1, g1["USD"])); + auto const sleA2 = ac.view().peek(keylet::trustLine(a2, g1["USD"])); sleA1->setFieldAmount(sfBalance, g1["USD"](a1Balance)); sleA2->setFieldAmount(sfBalance, g1["USD"](a2Balance)); @@ -961,7 +966,7 @@ class Invariants_test : public beast::unit_test::Suite return false; MPTIssue const mpt{makeMptID(1, AccountID(0x4985601))}; - auto sleNew = std::make_shared(keylet::mptIssuance(mpt.getMptID())); + auto sleNew = std::make_shared(keylet::mptokenIssuance(mpt.getMptID())); sleNew->setFieldU64(sfOutstandingAmount, -1); ac.view().insert(sleNew); return true; @@ -977,7 +982,7 @@ class Invariants_test : public beast::unit_test::Suite return false; MPTIssue const mpt{makeMptID(1, AccountID(0x4985601))}; - auto sleNew = std::make_shared(keylet::mptIssuance(mpt.getMptID())); + auto sleNew = std::make_shared(keylet::mptokenIssuance(mpt.getMptID())); sleNew->setFieldU64(sfLockedAmount, -1); ac.view().insert(sleNew); return true; @@ -993,7 +998,7 @@ class Invariants_test : public beast::unit_test::Suite return false; MPTIssue const mpt{makeMptID(1, AccountID(0x4985601))}; - auto sleNew = std::make_shared(keylet::mptIssuance(mpt.getMptID())); + auto sleNew = std::make_shared(keylet::mptokenIssuance(mpt.getMptID())); sleNew->setFieldU64(sfOutstandingAmount, 1); sleNew->setFieldU64(sfLockedAmount, 10); ac.view().insert(sleNew); @@ -1176,7 +1181,7 @@ class Invariants_test : public beast::unit_test::Suite doInvariantCheck( {{"NFT page has invalid size"}}, [&makeNFTokenIDs](Account const& a1, Account const&, ApplyContext& ac) { - auto nftPage = std::make_shared(keylet::nftpageMax(a1)); + auto nftPage = std::make_shared(keylet::nftokenPageMax(a1)); nftPage->setFieldArray(sfNFTokens, makeNFTokenIDs(0)); ac.view().insert(nftPage); @@ -1186,7 +1191,7 @@ class Invariants_test : public beast::unit_test::Suite doInvariantCheck( {{"NFT page has invalid size"}}, [&makeNFTokenIDs](Account const& a1, Account const&, ApplyContext& ac) { - auto nftPage = std::make_shared(keylet::nftpageMax(a1)); + auto nftPage = std::make_shared(keylet::nftokenPageMax(a1)); nftPage->setFieldArray(sfNFTokens, makeNFTokenIDs(33)); ac.view().insert(nftPage); @@ -1199,7 +1204,7 @@ class Invariants_test : public beast::unit_test::Suite STArray nfTokens = makeNFTokenIDs(2); std::iter_swap(nfTokens.begin(), nfTokens.begin() + 1); - auto nftPage = std::make_shared(keylet::nftpageMax(a1)); + auto nftPage = std::make_shared(keylet::nftokenPageMax(a1)); nftPage->setFieldArray(sfNFTokens, nfTokens); ac.view().insert(nftPage); @@ -1212,7 +1217,7 @@ class Invariants_test : public beast::unit_test::Suite STArray nfTokens = makeNFTokenIDs(1); nfTokens[0].setFieldVL(sfURI, Blob{}); - auto nftPage = std::make_shared(keylet::nftpageMax(a1)); + auto nftPage = std::make_shared(keylet::nftokenPageMax(a1)); nftPage->setFieldArray(sfNFTokens, nfTokens); ac.view().insert(nftPage); @@ -1222,9 +1227,9 @@ class Invariants_test : public beast::unit_test::Suite doInvariantCheck( {{"NFT page is improperly linked"}}, [&makeNFTokenIDs](Account const& a1, Account const&, ApplyContext& ac) { - auto nftPage = std::make_shared(keylet::nftpageMax(a1)); + auto nftPage = std::make_shared(keylet::nftokenPageMax(a1)); nftPage->setFieldArray(sfNFTokens, makeNFTokenIDs(1)); - nftPage->setFieldH256(sfPreviousPageMin, keylet::nftpageMax(a1).key); + nftPage->setFieldH256(sfPreviousPageMin, keylet::nftokenPageMax(a1).key); ac.view().insert(nftPage); return true; @@ -1233,9 +1238,9 @@ class Invariants_test : public beast::unit_test::Suite doInvariantCheck( {{"NFT page is improperly linked"}}, [&makeNFTokenIDs](Account const& a1, Account const& a2, ApplyContext& ac) { - auto nftPage = std::make_shared(keylet::nftpageMax(a1)); + auto nftPage = std::make_shared(keylet::nftokenPageMax(a1)); nftPage->setFieldArray(sfNFTokens, makeNFTokenIDs(1)); - nftPage->setFieldH256(sfPreviousPageMin, keylet::nftpageMin(a2).key); + nftPage->setFieldH256(sfPreviousPageMin, keylet::nftokenPageMin(a2).key); ac.view().insert(nftPage); return true; @@ -1244,7 +1249,7 @@ class Invariants_test : public beast::unit_test::Suite doInvariantCheck( {{"NFT page is improperly linked"}}, [&makeNFTokenIDs](Account const& a1, Account const&, ApplyContext& ac) { - auto nftPage = std::make_shared(keylet::nftpageMax(a1)); + auto nftPage = std::make_shared(keylet::nftokenPageMax(a1)); nftPage->setFieldArray(sfNFTokens, makeNFTokenIDs(1)); nftPage->setFieldH256(sfNextPageMin, nftPage->key()); @@ -1256,10 +1261,10 @@ class Invariants_test : public beast::unit_test::Suite {{"NFT page is improperly linked"}}, [&makeNFTokenIDs](Account const& a1, Account const& a2, ApplyContext& ac) { STArray nfTokens = makeNFTokenIDs(1); - auto nftPage = std::make_shared(keylet::nftpage( - keylet::nftpageMax(a1), ++(nfTokens[0].getFieldH256(sfNFTokenID)))); + auto nftPage = std::make_shared(keylet::nftokenPage( + keylet::nftokenPageMax(a1), ++(nfTokens[0].getFieldH256(sfNFTokenID)))); nftPage->setFieldArray(sfNFTokens, nfTokens); - nftPage->setFieldH256(sfNextPageMin, keylet::nftpageMax(a2).key); + nftPage->setFieldH256(sfNextPageMin, keylet::nftokenPageMax(a2).key); ac.view().insert(nftPage); return true; @@ -1269,8 +1274,8 @@ class Invariants_test : public beast::unit_test::Suite {{"NFT found in incorrect page"}}, [&makeNFTokenIDs](Account const& a1, Account const&, ApplyContext& ac) { STArray nfTokens = makeNFTokenIDs(2); - auto nftPage = std::make_shared(keylet::nftpage( - keylet::nftpageMax(a1), (nfTokens[1].getFieldH256(sfNFTokenID)))); + auto nftPage = std::make_shared(keylet::nftokenPage( + keylet::nftokenPageMax(a1), (nfTokens[1].getFieldH256(sfNFTokenID)))); nftPage->setFieldArray(sfNFTokens, nfTokens); ac.view().insert(nftPage); @@ -2129,7 +2134,7 @@ class Invariants_test : public beast::unit_test::Suite auto const getBookRootKey = [](Account const& account, std::uint64_t quality) { Book const book{xrpIssue(), account["USD"], std::nullopt}; - return keylet::quality(keylet::kBook(book), quality); + return keylet::quality(keylet::book(book), quality); }; // Root book-directory pages carry exchange-rate metadata that must @@ -2301,7 +2306,7 @@ class Invariants_test : public beast::unit_test::Suite // Create Loan Broker using namespace loanBroker; - auto const loanBrokerKeylet = keylet::loanbroker(a.id(), env.seq(a)); + auto const loanBrokerKeylet = keylet::loanBroker(a.id(), env.seq(a)); // Create a Loan Broker with all default values. env(set(a, vaultID), Fee(kIncrement)); @@ -2680,7 +2685,7 @@ class Invariants_test : public beast::unit_test::Suite return false; auto const mptIssuanceID = (*sleVault)[sfShareMPTID]; - auto sleShares = ac.peek(keylet::mptIssuance(mptIssuanceID)); + auto sleShares = ac.peek(keylet::mptokenIssuance(mptIssuanceID)); if (!sleShares) return false; @@ -2982,7 +2987,7 @@ class Invariants_test : public beast::unit_test::Suite auto sleVault = ac.view().peek(keylet); if (!sleVault) return false; - auto sleShares = ac.view().peek(keylet::mptIssuance((*sleVault)[sfShareMPTID])); + auto sleShares = ac.view().peek(keylet::mptokenIssuance((*sleVault)[sfShareMPTID])); if (!sleShares) return false; ac.view().erase(sleVault); @@ -3007,7 +3012,7 @@ class Invariants_test : public beast::unit_test::Suite auto sleVault = ac.view().peek(keylet); if (!sleVault) return false; - auto sleShares = ac.view().peek(keylet::mptIssuance((*sleVault)[sfShareMPTID])); + auto sleShares = ac.view().peek(keylet::mptokenIssuance((*sleVault)[sfShareMPTID])); if (!sleShares) return false; // Note, such an "orphaned" update of MPT issuance attached to a @@ -3097,7 +3102,7 @@ class Invariants_test : public beast::unit_test::Suite (*sleVault)[sfAssetsMaximum] = 200; ac.view().update(sleVault); - auto sleShares = ac.view().peek(keylet::mptIssuance((*sleVault)[sfShareMPTID])); + auto sleShares = ac.view().peek(keylet::mptokenIssuance((*sleVault)[sfShareMPTID])); if (!sleShares) return false; ac.view().erase(sleShares); @@ -3293,7 +3298,7 @@ class Invariants_test : public beast::unit_test::Suite if (!sleVault) return false; ac.view().update(sleVault); - auto sleShares = ac.view().peek(keylet::mptIssuance((*sleVault)[sfShareMPTID])); + auto sleShares = ac.view().peek(keylet::mptokenIssuance((*sleVault)[sfShareMPTID])); if (!sleShares) return false; (*sleShares)[sfOutstandingAmount] = 0; @@ -3313,7 +3318,7 @@ class Invariants_test : public beast::unit_test::Suite auto sleVault = ac.view().peek(keylet); if (!sleVault) return false; - auto sleShares = ac.view().peek(keylet::mptIssuance((*sleVault)[sfShareMPTID])); + auto sleShares = ac.view().peek(keylet::mptokenIssuance((*sleVault)[sfShareMPTID])); if (!sleShares) return false; (*sleShares)[sfMaximumAmount] = 10; @@ -3336,7 +3341,7 @@ class Invariants_test : public beast::unit_test::Suite auto sleVault = ac.view().peek(keylet); if (!sleVault) return false; - auto sleShares = ac.view().peek(keylet::mptIssuance((*sleVault)[sfShareMPTID])); + auto sleShares = ac.view().peek(keylet::mptokenIssuance((*sleVault)[sfShareMPTID])); if (!sleShares) return false; (*sleShares)[sfOutstandingAmount] = kMaxMpTokenAmount + 1; @@ -3438,7 +3443,7 @@ class Invariants_test : public beast::unit_test::Suite auto sleVault = ac.view().peek(keylet); if (!sleVault) return false; - auto sleShares = ac.view().peek(keylet::mptIssuance((*sleVault)[sfShareMPTID])); + auto sleShares = ac.view().peek(keylet::mptokenIssuance((*sleVault)[sfShareMPTID])); if (!sleShares) return false; ac.view().update(sleVault); @@ -3490,7 +3495,7 @@ class Invariants_test : public beast::unit_test::Suite auto sleVault = ac.view().peek(keylet); if (!sleVault) return false; - auto sleShares = ac.view().peek(keylet::mptIssuance((*sleVault)[sfShareMPTID])); + auto sleShares = ac.view().peek(keylet::mptokenIssuance((*sleVault)[sfShareMPTID])); if (!sleShares) return false; ac.view().update(sleVault); @@ -3537,7 +3542,7 @@ class Invariants_test : public beast::unit_test::Suite ac.view().insert(sleAccount); auto const sharesMptId = makeMptID(sequence, pseudoId); - auto const sharesKeylet = keylet::mptIssuance(sharesMptId); + auto const sharesKeylet = keylet::mptokenIssuance(sharesMptId); auto sleShares = std::make_shared(sharesKeylet); auto const sharesPage = ac.view().dirInsert( keylet::ownerDir(pseudoId), sharesKeylet, describeOwnerDir(pseudoId)); @@ -3595,7 +3600,7 @@ class Invariants_test : public beast::unit_test::Suite ac.view().insert(sleAccount); auto const sharesMptId = makeMptID(sequence, pseudoId); - auto const sharesKeylet = keylet::mptIssuance(sharesMptId); + auto const sharesKeylet = keylet::mptokenIssuance(sharesMptId); auto sleShares = std::make_shared(sharesKeylet); auto const sharesPage = ac.view().dirInsert( keylet::ownerDir(pseudoId), sharesKeylet, describeOwnerDir(pseudoId)); @@ -3637,7 +3642,7 @@ class Invariants_test : public beast::unit_test::Suite sleVault->setFieldU64(sfOwnerNode, *vaultPage); auto const sharesMptId = makeMptID(sequence, a2.id()); - auto const sharesKeylet = keylet::mptIssuance(sharesMptId); + auto const sharesKeylet = keylet::mptokenIssuance(sharesMptId); auto sleShares = std::make_shared(sharesKeylet); auto const sharesPage = ac.view().dirInsert( keylet::ownerDir(a2.id()), sharesKeylet, describeOwnerDir(a2.id())); @@ -4277,7 +4282,7 @@ class Invariants_test : public beast::unit_test::Suite return false; MPTIssue const mpt{makeMptID(sle->getFieldU32(sfSequence), a1)}; - auto sleNew = std::make_shared(keylet::mptIssuance(mpt.getMptID())); + auto sleNew = std::make_shared(keylet::mptokenIssuance(mpt.getMptID())); sleNew->setFieldU64(sfOutstandingAmount, 110); sleNew->setFieldU64(sfMaximumAmount, 100); ac.view().insert(sleNew); @@ -4294,7 +4299,7 @@ class Invariants_test : public beast::unit_test::Suite return false; MPTIssue const mpt{makeMptID(sle->getFieldU32(sfSequence), a1)}; - auto sleNew = std::make_shared(keylet::mptIssuance(mpt.getMptID())); + auto sleNew = std::make_shared(keylet::mptokenIssuance(mpt.getMptID())); sleNew->setFieldU64(sfOutstandingAmount, 100); sleNew->setFieldU64(sfMaximumAmount, 100); ac.view().insert(sleNew); @@ -4338,7 +4343,7 @@ class Invariants_test : public beast::unit_test::Suite }); testPayment( "OutstandingAmount overflow", [&](MPTID const& id, ApplyContext& ac, Account const&) { - auto sle = ac.view().peek(keylet::mptIssuance(id)); + auto sle = ac.view().peek(keylet::mptokenIssuance(id)); if (!sle) return false; sle->setFieldU64(sfOutstandingAmount, 101); @@ -4365,7 +4370,8 @@ class Invariants_test : public beast::unit_test::Suite for (int i = 0; i < nTokens; ++i) { MPTIssue const mpt{makeMptID(seq + i, a1)}; - auto sleNew = std::make_shared(keylet::mptIssuance(mpt.getMptID())); + auto sleNew = + std::make_shared(keylet::mptokenIssuance(mpt.getMptID())); ac.view().insert(sleNew); sleNew = std::make_shared(keylet::mptoken(mpt.getMptID(), a2)); @@ -4419,7 +4425,7 @@ class Invariants_test : public beast::unit_test::Suite if (!sleAcct) return false; MPTIssue const mpt{makeMptID(sleAcct->getFieldU32(sfSequence), a1)}; - auto sleNew = std::make_shared(keylet::mptIssuance(mpt.getMptID())); + auto sleNew = std::make_shared(keylet::mptokenIssuance(mpt.getMptID())); sleNew->setFieldH256(sfReferenceHolding, uint256{1}); ac.view().insert(sleNew); return true; @@ -4442,7 +4448,7 @@ class Invariants_test : public beast::unit_test::Suite if (!sleVault) return false; auto sleIssuance = - ac.view().peek(keylet::mptIssuance(sleVault->at(sfShareMPTID))); + ac.view().peek(keylet::mptokenIssuance(sleVault->at(sfShareMPTID))); if (!sleIssuance) return false; sleIssuance->setFieldH256(sfReferenceHolding, uint256{2}); @@ -4484,7 +4490,7 @@ class Invariants_test : public beast::unit_test::Suite if (!sleVault) return false; auto const sleIssuance = - ac.view().peek(keylet::mptIssuance(sleVault->at(sfShareMPTID))); + ac.view().peek(keylet::mptokenIssuance(sleVault->at(sfShareMPTID))); if (!sleIssuance || !sleIssuance->isFieldPresent(sfReferenceHolding)) return false; auto sleHolding = ac.view().peek( @@ -4550,7 +4556,7 @@ class Invariants_test : public beast::unit_test::Suite ac.view().update(sle); return true; }; - auto issuanceSle = ac.view().peek(keylet::mptIssuance(id)); + auto issuanceSle = ac.view().peek(keylet::mptokenIssuance(id)); if (!issuanceSle) return false; auto const flags = issuanceSle->at(sfFlags); @@ -4724,8 +4730,8 @@ class Invariants_test : public beast::unit_test::Suite auto const& goodConfig) { char const* const c1 = "USD"; char const* const c2 = "EUR"; - auto const k1 = keylet::line(a1, a2, a1[c1].currency); - auto const k2 = keylet::line(a1, a3, a1[c2].currency); + auto const k1 = keylet::trustLine(a1, a2, a1[c1].currency); + auto const k2 = keylet::trustLine(a1, a3, a1[c2].currency); bool const k1First = k1.key < k2.key; auto const& badKey = k1First ? k1 : k2; @@ -4820,7 +4826,7 @@ class Invariants_test : public beast::unit_test::Suite return false; MPTIssue const mpt{makeMptID(1, AccountID(0x4985601))}; - auto sleNew = std::make_shared(keylet::mptIssuance(mpt.getMptID())); + auto sleNew = std::make_shared(keylet::mptokenIssuance(mpt.getMptID())); // outstanding exceeds kMaxMpTokenAmount -> checkAmount sets bad_ sleNew->setFieldU64(sfOutstandingAmount, kMaxMpTokenAmount + 1); // locked is valid and <= outstanding -> must NOT clear bad_ diff --git a/src/test/app/LPTokenTransfer_test.cpp b/src/test/app/LPTokenTransfer_test.cpp index 4bf2db9515..2947b3a3ce 100644 --- a/src/test/app/LPTokenTransfer_test.cpp +++ b/src/test/app/LPTokenTransfer_test.cpp @@ -359,7 +359,7 @@ class LPTokenTransfer_test : public jtx::AMMTest env.close(); // bob_ creates a sell offer for lptoken - uint256 const sellOfferIndex = keylet::nftoffer(bob_, env.seq(bob_)).key; + uint256 const sellOfferIndex = keylet::nftokenOffer(bob_, env.seq(bob_)).key; env(token::createOffer(bob_, nftID, STAmount{lpIssue, 10}), Txflags(tfSellNFToken)); env.close(); @@ -420,7 +420,7 @@ class LPTokenTransfer_test : public jtx::AMMTest env.close(); // bob_ creates a buy offer with lptoken despite bob_'s USD is frozen - uint256 const buyOfferIndex = keylet::nftoffer(bob_, env.seq(bob_)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(bob_, env.seq(bob_)).key; env(token::createOffer(bob_, nftID, STAmount{lpIssue, 10}), token::Owner(carol_)); env.close(); diff --git a/src/test/app/LoanBroker_test.cpp b/src/test/app/LoanBroker_test.cpp index 0edb955b90..671f98a901 100644 --- a/src/test/app/LoanBroker_test.cpp +++ b/src/test/app/LoanBroker_test.cpp @@ -94,7 +94,7 @@ class LoanBroker_test : public beast::unit_test::Suite using namespace loanBroker; // Can't create a loan broker regardless of whether the vault exists env(set(alice, keylet.key), Ter(temDISABLED)); - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); // Other LoanBroker transactions are disabled, too. // 1. LoanBrokerCoverDeposit env(coverDeposit(alice, brokerKeylet.key, asset(1000)), Ter(temDISABLED)); @@ -180,7 +180,7 @@ class LoanBroker_test : public beast::unit_test::Suite static PrettyAsset const kGhostIouAsset = kNonExistent["GST"]; PrettyAsset const vaultPseudoIouAsset = vault.pseudoAccount["PSD"]; - auto const badKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const badKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); env(set(alice, badVault.vaultID)); env.close(); auto const badBrokerPseudo = [&]() { @@ -193,7 +193,7 @@ class LoanBroker_test : public beast::unit_test::Suite }(); PrettyAsset const badBrokerPseudoIouAsset = badBrokerPseudo["WAT"]; - auto const keylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const keylet = keylet::loanBroker(alice.id(), env.seq(alice)); { // Start with default values auto jtx = env.jt(set(alice, vault.vaultID)); @@ -736,7 +736,7 @@ class LoanBroker_test : public beast::unit_test::Suite // Modifications // Update the fields - auto const nextKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const nextKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); // fields that can't be changed // LoanBrokerID @@ -892,7 +892,7 @@ class LoanBroker_test : public beast::unit_test::Suite env(vault.deposit({.depositor = alice, .id = vaultKeylet.key, .amount = asset(50)})); env.close(); - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); env(set(alice, vaultInfo.vaultID)); env.close(); @@ -1231,7 +1231,7 @@ class LoanBroker_test : public beast::unit_test::Suite env.close(); // Predict LoanBroker key using alice's current sequence BEFORE submit - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); // Create LoanBroker pointing to the vault env(loanBroker::set(alice, vaultKeylet.key)); @@ -1250,7 +1250,7 @@ class LoanBroker_test : public beast::unit_test::Suite beast::Journal const jlog{sink}; ApplyContext ac{env.app(), ov, tx, tesSUCCESS, env.current()->fees().base, TapNone, jlog}; - if (auto sleBroker = ac.view().peek(keylet::loanbroker(brokerKeylet.key))) + if (auto sleBroker = ac.view().peek(keylet::loanBroker(brokerKeylet.key))) { auto const vaultID = (*sleBroker)[sfVaultID]; if (auto sleVault = ac.view().peek(keylet::vault(vaultID))) @@ -1337,7 +1337,7 @@ class LoanBroker_test : public beast::unit_test::Suite err); }); - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); // Can create LoanBroker if the vault owner is not authorized forUnauthAuth([&](auto) { env(set(alice, vaultInfo.vaultID)); }); @@ -1415,7 +1415,7 @@ class LoanBroker_test : public beast::unit_test::Suite env(vault.deposit({.depositor = alice, .id = vaultKeylet.key, .amount = asset(50)})); env.close(); - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); env(set(alice, vaultInfo.vaultID)); env.close(); @@ -1503,7 +1503,7 @@ class LoanBroker_test : public beast::unit_test::Suite Ter(err)); env.close(); - auto const brokerKeylet = keylet::loanbroker(broker, env.seq(broker)); + auto const brokerKeylet = keylet::loanBroker(broker, env.seq(broker)); env(loanBroker::set(broker, keylet.key)); env.close(); @@ -1617,7 +1617,7 @@ class LoanBroker_test : public beast::unit_test::Suite env.close(); // Create loan broker - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); env(set(alice, vaultKeylet.key)); env.close(); @@ -1734,7 +1734,7 @@ class LoanBroker_test : public beast::unit_test::Suite env.close(); // Create loan broker - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); env(set(alice, vaultKeylet.key)); env.close(); @@ -1876,7 +1876,7 @@ class LoanBroker_test : public beast::unit_test::Suite env(vault.withdraw({.depositor = broker, .id = keylet.key, .amount = token(1'000)})); // Test LoanBroker withdraw - auto const brokerKeylet = keylet::loanbroker(broker, env.seq(broker)); + auto const brokerKeylet = keylet::loanBroker(broker, env.seq(broker)); env(loanBroker::set(broker, keylet.key)); env.close(); @@ -2004,7 +2004,7 @@ class LoanBroker_test : public beast::unit_test::Suite } // Test LoanBroker withdraw - auto const brokerKeylet = keylet::loanbroker(broker, env.seq(broker)); + auto const brokerKeylet = keylet::loanBroker(broker, env.seq(broker)); env(loanBroker::set(broker, keylet.key)); env.close(); @@ -2068,7 +2068,7 @@ class LoanBroker_test : public beast::unit_test::Suite env(createTx); env.close(); - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); env(set(alice, vaultKeylet.key)); env.close(); @@ -2215,7 +2215,7 @@ class LoanBroker_test : public beast::unit_test::Suite env(createTx); env.close(); - auto const brokerKeylet = keylet::loanbroker(alice.id(), env.seq(alice)); + auto const brokerKeylet = keylet::loanBroker(alice.id(), env.seq(alice)); env(set(alice, vaultKeylet.key)); env.close(); diff --git a/src/test/app/Loan_test.cpp b/src/test/app/Loan_test.cpp index 2d70efd9b2..1b0dd414e1 100644 --- a/src/test/app/Loan_test.cpp +++ b/src/test/app/Loan_test.cpp @@ -127,7 +127,7 @@ protected: Account const bob{"bob"}; env.fund(XRP(10000), alice, bob); - auto const keylet = keylet::loanbroker(alice, env.seq(alice)); + auto const keylet = keylet::loanBroker(alice, env.seq(alice)); using namespace std::chrono_literals; using namespace loan; @@ -214,7 +214,7 @@ protected: [[nodiscard]] Keylet brokerKeylet() const { - return keylet::loanbroker(brokerID); + return keylet::loanBroker(brokerID); } [[nodiscard]] Keylet vaultKeylet() const @@ -371,7 +371,7 @@ protected: std::uint32_t ownerCount) const { using namespace jtx; - if (auto brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + if (auto brokerSle = env.le(keylet::loanBroker(broker.brokerID)); env.test.BEAST_EXPECT(brokerSle)) { TenthBips16 const managementFeeRate{brokerSle->at(sfManagementFeeRate)}; @@ -469,7 +469,7 @@ protected: paymentRemaining, 1); - if (auto brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + if (auto brokerSle = env.le(keylet::loanBroker(broker.brokerID)); env.test.BEAST_EXPECT(brokerSle)) { if (auto vaultSle = env.le(keylet::vault(brokerSle->at(sfVaultID))); @@ -538,7 +538,7 @@ protected: BEAST_EXPECT(vault->at(sfAssetsAvailable) == deposit.value()); } - auto const keylet = keylet::loanbroker(lender.id(), env.seq(lender)); + auto const keylet = keylet::loanBroker(lender.id(), env.seq(lender)); using namespace loanBroker; env(set(lender, vaultKeylet.key, params.flags), @@ -631,7 +631,7 @@ protected: bool canImpairLoan(jtx::Env const& env, BrokerInfo const& broker, LoanState const& state) { - if (auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle)) { if (auto const vaultSle = env.le(keylet::vault(brokerSle->at(sfVaultID))); @@ -802,7 +802,7 @@ protected: BrokerInfo const broker = createVaultAndBroker(env, asset, lender, brokerParams); auto const pseudoAcctOpt = [&]() -> std::optional { - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); if (!BEAST_EXPECT(brokerSle)) return std::nullopt; auto const brokerPseudo = brokerSle->at(sfAccount); @@ -813,7 +813,7 @@ protected: Account const& pseudoAcct = *pseudoAcctOpt; auto const loanKeyletOpt = [&]() -> std::optional { - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); if (!BEAST_EXPECT(brokerSle)) return std::nullopt; @@ -1287,7 +1287,7 @@ protected: toEndOfLife) { auto const [keylet, loanSequence] = [&]() { - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); if (!BEAST_EXPECT(brokerSle)) { // will be invalid @@ -1376,7 +1376,7 @@ protected: auto const startDate = env.current()->header().parentCloseTime.time_since_epoch().count(); - if (auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle)) { BEAST_EXPECT(brokerSle->at(sfOwnerCount) == 1); @@ -1557,7 +1557,7 @@ protected: borrowerStartingBalance.value() - adjustment); BEAST_EXPECT(env.ownerCount(borrower) == borrowerOwnerCount); - if (auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle)) { BEAST_EXPECT(brokerSle->at(sfOwnerCount) == 0); @@ -1633,7 +1633,7 @@ protected: auto const loanSetFee = Fee(env.current()->fees().base * 2); auto const pseudoAcct = [&]() { - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); if (!BEAST_EXPECT(brokerSle)) return Account{lender}; auto const brokerPseudo = brokerSle->at(sfAccount); @@ -1896,7 +1896,7 @@ protected: // XRP can not be frozen, but run through the loop anyway to test // the tecLIMIT_EXCEEDED case { - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); if (!BEAST_EXPECT(brokerSle)) return; @@ -2020,7 +2020,7 @@ protected: // Finally! Create a loan auto coverAvailable = [&env, this](uint256 const& brokerID, Number const& expected) { - if (auto const brokerSle = env.le(keylet::loanbroker(brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(brokerID)); BEAST_EXPECT(brokerSle)) { auto const available = brokerSle->at(sfCoverAvailable); @@ -2030,7 +2030,7 @@ protected: return Number{}; }; auto getDefaultInfo = [&env, this](LoanState const& state, BrokerInfo const& broker) { - if (auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle)) { BEAST_EXPECT( @@ -3149,7 +3149,7 @@ protected: env(pay(borrower, issuer, broker.asset(10'000))); env.close(); - auto const trustline = keylet::line(borrower, broker.asset.raw().get()); + auto const trustline = keylet::trustLine(borrower, broker.asset.raw().get()); auto const sleLine1 = env.le(trustline); BEAST_EXPECT(sleLine1 == nullptr); @@ -3242,7 +3242,7 @@ protected: env.trust(broker.asset(0), lender); env.close(); - auto const trustline = keylet::line(lender, broker.asset.raw().get()); + auto const trustline = keylet::trustLine(lender, broker.asset.raw().get()); auto const sleLine1 = env.le(trustline); BEAST_EXPECT(sleLine1 != nullptr); @@ -3552,7 +3552,7 @@ protected: } } - if (auto brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + if (auto brokerSle = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle)) { BEAST_EXPECT(brokerSle->at(sfOwnerCount) == 0); @@ -3563,7 +3563,7 @@ protected: lender, broker.brokerID, STAmount(broker.asset, coverAvailable))); env.close(); - brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + brokerSle = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle && brokerSle->at(sfCoverAvailable) == 0); } // Verify we can delete the loan broker @@ -3795,7 +3795,7 @@ protected: BrokerInfo const broker{createVaultAndBroker(env, xrpAsset, lender, brokerParams)}; - if (auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle)) { BEAST_EXPECT(brokerSle->at(sfDebtMaximum) == 0); @@ -3865,7 +3865,7 @@ protected: createJson["OverpaymentInterestRate"] = 1360; createJson["PaymentInterval"] = 727; - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -4208,11 +4208,11 @@ protected: Env env(*this); auto getCoverBalance = [&](BrokerInfo const& brokerInfo, auto const& accountField) { - if (auto const le = env.le(keylet::loanbroker(brokerInfo.brokerID)); + if (auto const le = env.le(keylet::loanBroker(brokerInfo.brokerID)); BEAST_EXPECT(le)) { auto const account = le->at(accountField); - if (auto const sleLine = env.le(keylet::line(account, iou)); + if (auto const sleLine = env.le(keylet::trustLine(account, iou)); BEAST_EXPECT(sleLine)) { STAmount balance = sleLine->at(sfBalance); @@ -4390,7 +4390,7 @@ protected: env.close(); auto const pseudoBroker = [&]() -> std::optional { - if (auto brokerSle = env.le(keylet::loanbroker(brokerInfo.brokerID)); + if (auto brokerSle = env.le(keylet::loanBroker(brokerInfo.brokerID)); BEAST_EXPECT(brokerSle)) { return Account{"pseudo", brokerSle->at(sfAccount)}; @@ -4620,7 +4620,7 @@ protected: createJson["PaymentTotal"] = "2891743748"; createJson["PrincipalRequested"] = "8516.98"; - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); createJson = env.json(createJson, Sig(sfCounterpartySignature, lender)); env(createJson, Ter(temINVALID)); @@ -4681,7 +4681,7 @@ protected: createJson["PaymentTotal"] = 5678; createJson["PrincipalRequested"] = "9924.81"; - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -4690,7 +4690,7 @@ protected: env.close(); auto const pseudoAcct = [&]() { - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); if (!BEAST_EXPECT(brokerSle)) return Account{lender}; auto const brokerPseudo = brokerSle->at(sfAccount); @@ -4771,7 +4771,7 @@ protected: createJson["PaymentTotal"] = 1; createJson["PrincipalRequested"] = "0.000763058"; - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -4840,7 +4840,7 @@ protected: // There are enough payments due on this loan that it only needs to be // created once, and can be paid on multiple times. Just don't create a // gazillion test cases. - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -4979,7 +4979,7 @@ protected: createJson["PaymentTotal"] = 5678; createJson["PrincipalRequested"] = "9924.81"; - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -5085,7 +5085,7 @@ protected: createJson["PaymentTotal"] = 5678; createJson["PrincipalRequested"] = "9924.81"; - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -5250,7 +5250,7 @@ protected: } { // Start date when the ledger is closed will be larger - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -5277,7 +5277,7 @@ protected: } { // Start date when the ledger is closed will be larger - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -5325,7 +5325,7 @@ protected: if (!BEAST_EXPECT(total != 0)) return; - auto const brokerState = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerState = env.le(keylet::loanBroker(broker.brokerID)); // Intentionally shadow the outer values auto const loanSequence = brokerState->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -5514,7 +5514,7 @@ protected: auto const loanSetFee = Fee(env.current()->fees().base * 2); - auto const brokerPreLoan = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerPreLoan = env.le(keylet::loanBroker(broker.brokerID)); if (BEAST_EXPECT(brokerPreLoan); !brokerPreLoan.has_value()) return; @@ -5549,7 +5549,7 @@ protected: auto const overdueClose = tp{d{state1.nextPaymentDate + state1.paymentInterval}}; env.close(overdueClose); - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSle = env.le(loanKeylet); if (!BEAST_EXPECT(brokerSle && loanSle)) return; @@ -5684,7 +5684,7 @@ protected: env(createTx); env.close(); - auto const brokerBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerBefore = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerBefore); if (!brokerBefore) return; @@ -5701,7 +5701,7 @@ protected: env(coverClawback(issuer, 0), loanBrokerID(broker.brokerID)); env.close(); - auto const brokerAfter = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerAfter = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerAfter); if (!brokerAfter) return; @@ -5793,7 +5793,7 @@ protected: kGracePeriod(grace), Fee(loanSetFee)); - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle); auto const loanSequence = brokerSle ? brokerSle->at(sfLoanSequence) : 0; auto const loanKeylet = keylet::loan(broker.brokerID, loanSequence); @@ -5825,7 +5825,7 @@ protected: auto after = getCurrentState(env, broker, loanKeylet); auto const loanSle = env.le(loanKeylet); BEAST_EXPECT(loanSle); - auto const brokerSle2 = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle2 = env.le(keylet::loanBroker(broker.brokerID)); BEAST_EXPECT(brokerSle2); auto const closePaymentFee = loanSle ? loanSle->at(sfClosePaymentFee) : Number{}; @@ -5987,7 +5987,7 @@ protected: auto broker = createVaultAndBroker(env, asset, lender, brokerParams); auto const loanKeyletOpt = [&]() -> std::optional { - auto const brokerSle = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(broker.brokerID)); if (!BEAST_EXPECT(brokerSle)) return std::nullopt; @@ -6258,7 +6258,7 @@ protected: txFee); env.close(); - auto const brokerKeyLet = keylet::loanbroker(lender.id(), env.seq(lender)); + auto const brokerKeyLet = keylet::loanBroker(lender.id(), env.seq(lender)); env(loanBroker::set(lender, vaultKeyLet.key), txFee); env.close(); @@ -6332,7 +6332,7 @@ protected: env.close(); // Verify DebtTotal is exactly 804 - if (auto const brokerSle = env.le(keylet::loanbroker(brokerInfo.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(brokerInfo.brokerID)); BEAST_EXPECT(brokerSle)) { log << *brokerSle << std::endl; @@ -6353,7 +6353,7 @@ protected: env.close(); // Validate CoverAvailable == 80 XRP and DebtTotal remains 804 - if (auto const brokerSle = env.le(keylet::loanbroker(brokerInfo.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(brokerInfo.brokerID)); BEAST_EXPECT(brokerSle)) { log << *brokerSle << std::endl; @@ -6463,7 +6463,7 @@ protected: txFee); env.close(); - auto const brokerKeylet = keylet::loanbroker(broker.id(), env.seq(broker)); + auto const brokerKeylet = keylet::loanBroker(broker.id(), env.seq(broker)); env(loanBroker::set(broker, vaultKeylet.key), txFee); env.close(); @@ -6747,7 +6747,7 @@ protected: env(loanBroker::coverDeposit(broker, brokerInfo.brokerID, STAmount{iou, additionalCover})); env.close(); // Verify broker owner has a trustline - auto const brokerTrustline = keylet::line(broker, iou); + auto const brokerTrustline = keylet::trustLine(broker, iou); BEAST_EXPECT(env.le(brokerTrustline) != nullptr); // Broker owner deletes their trustline // First, pay any positive balance to issuer to zero it out @@ -6766,7 +6766,7 @@ protected: // Verify trustline is still deleted BEAST_EXPECT(env.le(brokerTrustline) == nullptr); // Verify the service fee went to the broker pseudo-account - if (auto const brokerSle = env.le(keylet::loanbroker(brokerInfo.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(brokerInfo.brokerID)); BEAST_EXPECT(brokerSle)) { Account const pseudo("pseudo-account", brokerSle->at(sfAccount)); @@ -6847,7 +6847,7 @@ protected: // Verify the MPT is still unauthorized. BEAST_EXPECT(env.le(brokerMpt) == nullptr); // Verify the service fee went to the broker pseudo-account - if (auto const brokerSle = env.le(keylet::loanbroker(brokerInfo.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(brokerInfo.brokerID)); BEAST_EXPECT(brokerSle)) { Account const pseudo("pseudo-account", brokerSle->at(sfAccount)); @@ -6950,7 +6950,7 @@ protected: // Verify broker is still not authorized env(pay(issuer, broker, mpt(1'000)), Ter(tecNO_AUTH)); // Verify the service fee went to the broker pseudo-account - if (auto const brokerSle = env.le(keylet::loanbroker(brokerInfo.brokerID)); + if (auto const brokerSle = env.le(keylet::loanBroker(brokerInfo.brokerID)); BEAST_EXPECT(brokerSle)) { Account const pseudo("pseudo-account", brokerSle->at(sfAccount)); @@ -7186,7 +7186,7 @@ protected: .coverDeposit = 500'000, }); auto const [currentSeq, vaultKeylet] = [&]() { - auto const brokerSle = env.le(keylet::loanbroker(brokerInfo.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(brokerInfo.brokerID)); if (!BEAST_EXPECT(brokerSle)) return std::make_tuple(0u, keylet::unchecked(beast::kZero)); auto const currentSeq = brokerSle->at(sfLoanSequence); @@ -7358,7 +7358,7 @@ protected: env.close(); // Create a loan - auto const sleBroker = env.le(keylet::loanbroker(broker.brokerID)); + auto const sleBroker = env.le(keylet::loanBroker(broker.brokerID)); if (!BEAST_EXPECT(sleBroker)) return; @@ -7899,7 +7899,7 @@ protected: env(vault.deposit({.depositor = lender, .id = vaultKeylet.key, .amount = asset(5'000)})); env.close(); - auto const brokerKeylet = keylet::loanbroker(lender.id(), env.seq(lender)); + auto const brokerKeylet = keylet::loanBroker(lender.id(), env.seq(lender)); env(loanBroker::set(lender, vaultKeylet.key), loanBroker::kDebtMaximum(Number{100}), Fee(env.current()->fees().base * 2)); @@ -8006,7 +8006,7 @@ protected: createJson["PaymentTotal"] = 3; createJson["PaymentInterval"] = 600; - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const keylet = keylet::loan(broker.brokerID, loanSequence); @@ -8089,7 +8089,7 @@ protected: createJson["PaymentTotal"] = 3; createJson["PaymentInterval"] = 600; - auto const brokerStateBefore = env.le(keylet::loanbroker(broker.brokerID)); + auto const brokerStateBefore = env.le(keylet::loanBroker(broker.brokerID)); auto const loanSequence = brokerStateBefore->at(sfLoanSequence); auto const loanKeylet = keylet::loan(broker.brokerID, loanSequence); createJson = env.json(createJson, Sig(sfCounterpartySignature, lender)); @@ -8231,7 +8231,7 @@ protected: // Create the TINY loan first (while vaultScale is still // small). principal 0.01, 0% interest, 1 payment => // loanScale = vaultScale. - auto const brokerSle1 = env.le(keylet::loanbroker(c.broker.brokerID)); + auto const brokerSle1 = env.le(keylet::loanBroker(c.broker.brokerID)); if (!BEAST_EXPECT(brokerSle1)) return std::nullopt; auto const tinyLoanSeq = brokerSle1->at(sfLoanSequence); @@ -8248,7 +8248,7 @@ protected: // Create the BIG loan second. 100% annual interest over 20 // payments pushes totalValueOutstanding high enough that // loanScale > vaultScale. - auto const brokerSle2 = env.le(keylet::loanbroker(c.broker.brokerID)); + auto const brokerSle2 = env.le(keylet::loanBroker(c.broker.brokerID)); if (!BEAST_EXPECT(brokerSle2)) return std::nullopt; auto const bigLoanSeq = brokerSle2->at(sfLoanSequence); @@ -8299,7 +8299,7 @@ protected: kAmount(STAmount{asset, clawbackAmount})); env.close(); - auto const brokerSle = env.le(keylet::loanbroker(c.broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(c.broker.brokerID)); if (!BEAST_EXPECT(brokerSle) || !BEAST_EXPECT(brokerSle->at(sfCoverAvailable) == expectedCoverAfter)) return std::nullopt; @@ -8312,7 +8312,7 @@ protected: // than to the owner. auto feeGoesToPseudo = [&](Env& env, Ctx const& c, Keylet const& loanKeylet) -> bool { Asset const asset{c.iou}; - auto const brokerSle = env.le(keylet::loanbroker(c.broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(c.broker.brokerID)); if (!BEAST_EXPECT(brokerSle)) return false; auto const pseudoAcct = Account("pseudo", brokerSle->at(sfAccount)); @@ -8394,7 +8394,7 @@ protected: env.close(); // Read broker state and compute both old and new minimums. - auto const brokerSle = env.le(keylet::loanbroker(c.broker.brokerID)); + auto const brokerSle = env.le(keylet::loanBroker(c.broker.brokerID)); auto const vaultSle = env.le(keylet::vault(c.broker.vaultID)); if (!BEAST_EXPECT(brokerSle) || !BEAST_EXPECT(vaultSle)) return; diff --git a/src/test/app/MPToken_test.cpp b/src/test/app/MPToken_test.cpp index 2cab3e7c89..bfb80d3e36 100644 --- a/src/test/app/MPToken_test.cpp +++ b/src/test/app/MPToken_test.cpp @@ -4049,7 +4049,7 @@ class MPToken_test : public beast::unit_test::Suite // view may contain partial state and must be discarded. if (expectedOutstanding) { - auto const sle = av.peek(keylet::mptIssuance(mptTester.issuanceID())); + auto const sle = av.peek(keylet::mptokenIssuance(mptTester.issuanceID())); if (!BEAST_EXPECT(sle)) return; BEAST_EXPECTS(sle->getFieldU64(sfOutstandingAmount) == *expectedOutstanding, label); diff --git a/src/test/app/MultiSign_test.cpp b/src/test/app/MultiSign_test.cpp index f161226210..8fb1eb31ab 100644 --- a/src/test/app/MultiSign_test.cpp +++ b/src/test/app/MultiSign_test.cpp @@ -1511,7 +1511,7 @@ public: env.close(); // Verify that the SignerList object was created correctly. - auto const& sle = env.le(keylet::signers(alice.id())); + auto const& sle = env.le(keylet::signerList(alice.id())); BEAST_EXPECT(sle); BEAST_EXPECT(sle->getFieldArray(sfSignerEntries).size() == 2); if (features[fixIncludeKeyletFields]) diff --git a/src/test/app/NFTokenAuth_test.cpp b/src/test/app/NFTokenAuth_test.cpp index 4929cadd65..66716a13b7 100644 --- a/src/test/app/NFTokenAuth_test.cpp +++ b/src/test/app/NFTokenAuth_test.cpp @@ -43,7 +43,7 @@ class NFTokenAuth_test : public beast::unit_test::Suite env(token::mint(account, 0), token::XferFee(xfee), Txflags(tfTransferable)); env.close(); - auto const sellIdx = keylet::nftoffer(account, env.seq(account)).key; + auto const sellIdx = keylet::nftokenOffer(account, env.seq(account)).key; env(token::createOffer(account, nftID, currency), Txflags(tfSellNFToken)); env.close(); @@ -74,7 +74,7 @@ public: env(pay(g1, a1, usd(1000))); auto const [nftID, _] = mintAndOfferNFT(env, a2, drops(1)); - auto const buyIdx = keylet::nftoffer(a1, env.seq(a1)).key; + auto const buyIdx = keylet::nftokenOffer(a1, env.seq(a1)).key; // It should be possible to create a buy offer even if NFT owner is not // authorized @@ -130,7 +130,7 @@ public: // close ledger before running the actual tests against this trustline. // After ledger is closed, the trustline will not exist. auto const unauthTrustline = [&](OpenView& view, beast::Journal) -> bool { - auto const sleA1 = std::make_shared(keylet::line(a1, g1, g1["USD"].currency)); + auto const sleA1 = std::make_shared(keylet::trustLine(a1, g1, g1["USD"].currency)); sleA1->setFieldAmount(sfBalance, a1["USD"](-1000)); view.rawInsert(sleA1); return true; @@ -179,7 +179,7 @@ public: env(pay(g1, a2, usd(10))); env.close(); - auto const buyIdx = keylet::nftoffer(a1, env.seq(a1)).key; + auto const buyIdx = keylet::nftokenOffer(a1, env.seq(a1)).key; env(token::createOffer(a1, nftID, usd(10)), token::Owner(a2)); env.close(); @@ -193,7 +193,7 @@ public: // tests against this trustline. After ledger is closed, the trustline // will not exist. auto const unauthTrustline = [&](OpenView& view, beast::Journal) -> bool { - auto const sleA1 = std::make_shared(keylet::line(a1, g1, g1["USD"].currency)); + auto const sleA1 = std::make_shared(keylet::trustLine(a1, g1, g1["USD"].currency)); sleA1->setFieldAmount(sfBalance, a1["USD"](-1000)); view.rawInsert(sleA1); return true; @@ -244,7 +244,7 @@ public: // Authorizing trustline to make an offer creation possible env(trust(g1, usd(0), a2, tfSetfAuth)); env.close(); - auto const sellIdx = keylet::nftoffer(a2, env.seq(a2)).key; + auto const sellIdx = keylet::nftokenOffer(a2, env.seq(a2)).key; env(token::createOffer(a2, nftID, usd(10)), Txflags(tfSellNFToken)); env.close(); // @@ -268,7 +268,7 @@ public: } else { - auto const sellIdx = keylet::nftoffer(a2, env.seq(a2)).key; + auto const sellIdx = keylet::nftokenOffer(a2, env.seq(a2)).key; // Old behavior: sell offer can be created without authorization env(token::createOffer(a2, nftID, usd(10)), Txflags(tfSellNFToken)); @@ -313,7 +313,7 @@ public: // Creating an artificial unauth trustline auto const unauthTrustline = [&](OpenView& view, beast::Journal) -> bool { - auto const sleA1 = std::make_shared(keylet::line(a1, g1, g1["USD"].currency)); + auto const sleA1 = std::make_shared(keylet::trustLine(a1, g1, g1["USD"].currency)); sleA1->setFieldAmount(sfBalance, a1["USD"](-1000)); view.rawInsert(sleA1); return true; @@ -353,7 +353,7 @@ public: env.close(); auto const [nftID, sellIdx] = mintAndOfferNFT(env, a2, usd(10)); - auto const buyIdx = keylet::nftoffer(a1, env.seq(a1)).key; + auto const buyIdx = keylet::nftokenOffer(a1, env.seq(a1)).key; env(token::createOffer(a1, nftID, usd(11)), token::Owner(a2)); env.close(); @@ -422,7 +422,7 @@ public: env.close(); auto const [nftID, sellIdx] = mintAndOfferNFT(env, a2, usd(10)); - auto const buyIdx = keylet::nftoffer(a1, env.seq(a1)).key; + auto const buyIdx = keylet::nftokenOffer(a1, env.seq(a1)).key; env(token::createOffer(a1, nftID, usd(11)), token::Owner(a2)); env.close(); @@ -432,7 +432,7 @@ public: env.close(); auto const unauthTrustline = [&](OpenView& view, beast::Journal) -> bool { - auto const sleA1 = std::make_shared(keylet::line(a1, g1, g1["USD"].currency)); + auto const sleA1 = std::make_shared(keylet::trustLine(a1, g1, g1["USD"].currency)); sleA1->setFieldAmount(sfBalance, a1["USD"](-1000)); view.rawInsert(sleA1); return true; @@ -483,7 +483,7 @@ public: env.close(); auto const [nftID, sellIdx] = mintAndOfferNFT(env, a2, usd(10)); - auto const buyIdx = keylet::nftoffer(a1, env.seq(a1)).key; + auto const buyIdx = keylet::nftokenOffer(a1, env.seq(a1)).key; env(token::createOffer(a1, nftID, usd(11)), token::Owner(a2)); env.close(); @@ -559,7 +559,7 @@ public: auto const [nftID, minterSellIdx] = mintAndOfferNFT(env, minter, drops(1), 1); env(token::acceptSellOffer(a1, minterSellIdx)); - uint256 const sellIdx = keylet::nftoffer(a1, env.seq(a1)).key; + uint256 const sellIdx = keylet::nftokenOffer(a1, env.seq(a1)).key; env(token::createOffer(a1, nftID, usd(100)), Txflags(tfSellNFToken)); if (features[fixEnforceNFTokenTrustlineV2]) diff --git a/src/test/app/NFTokenBurn_test.cpp b/src/test/app/NFTokenBurn_test.cpp index 46b02d03cf..00667dc5ac 100644 --- a/src/test/app/NFTokenBurn_test.cpp +++ b/src/test/app/NFTokenBurn_test.cpp @@ -76,7 +76,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite for (uint32_t i = 0; i < tokenCancelCount; ++i) { // Create sell offer - offerIndexes.push_back(keylet::nftoffer(owner, env.seq(owner)).key); + offerIndexes.push_back(keylet::nftokenOffer(owner, env.seq(owner)).key); env(token::createOffer(owner, nftokenID, drops(1)), Txflags(tfSellNFToken)); env.close(); } @@ -235,7 +235,8 @@ class NFTokenBurn_test : public beast::unit_test::Suite { // We do the same work on alice and minter, so make a lambda. auto xferNFT = [&env, &becky](AcctStat& acct, auto& iter) { - uint256 const offerIndex = keylet::nftoffer(acct.acct, env.seq(acct.acct)).key; + uint256 const offerIndex = + keylet::nftokenOffer(acct.acct, env.seq(acct.acct)).key; env(token::createOffer(acct, *iter, XRP(0)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(becky, offerIndex)); @@ -472,19 +473,19 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify that that all three pages are present and remember the // indexes. - auto lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + auto lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); if (!BEAST_EXPECT(lastNFTokenPage)) return; uint256 const middleNFTokenPageIndex = lastNFTokenPage->at(sfPreviousPageMin); auto middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); if (!BEAST_EXPECT(middleNFTokenPage)) return; uint256 const firstNFTokenPageIndex = middleNFTokenPage->at(sfPreviousPageMin); auto firstNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), firstNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), firstNFTokenPageIndex)); if (!BEAST_EXPECT(firstNFTokenPage)) return; @@ -498,7 +499,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify that the last page is still present and contains just one // NFT. - lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); if (!BEAST_EXPECT(lastNFTokenPage)) return; @@ -517,21 +518,21 @@ class NFTokenBurn_test : public beast::unit_test::Suite // _previous_ page because we need to preserve that last // page as an anchor. The contents of the next-to-last page // are moved into the last page. - lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); BEAST_EXPECT(lastNFTokenPage); BEAST_EXPECT(lastNFTokenPage->at(~sfPreviousPageMin) == firstNFTokenPageIndex); BEAST_EXPECT(!lastNFTokenPage->isFieldPresent(sfNextPageMin)); BEAST_EXPECT(lastNFTokenPage->getFieldArray(sfNFTokens).size() == 32); // The "middle" page should be gone. - middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + middleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); BEAST_EXPECT(!middleNFTokenPage); // The "first" page should still be present and linked to // the last page. - firstNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), firstNFTokenPageIndex)); + firstNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), firstNFTokenPageIndex)); BEAST_EXPECT(firstNFTokenPage); BEAST_EXPECT(!firstNFTokenPage->isFieldPresent(sfPreviousPageMin)); BEAST_EXPECT(firstNFTokenPage->at(~sfNextPageMin) == lastNFTokenPage->key()); @@ -542,13 +543,13 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Removing the last token from the last page deletes the last // page. This is a bug. The contents of the next-to-last page // should have been moved into the last page. - lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); BEAST_EXPECT(!lastNFTokenPage); // The "middle" page is still present, but has lost the // NextPageMin field. - middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + middleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); if (!BEAST_EXPECT(middleNFTokenPage)) return; BEAST_EXPECT(middleNFTokenPage->isFieldPresent(sfPreviousPageMin)); @@ -576,19 +577,19 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify that that all three pages are present and remember the // indexes. - auto lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + auto lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); if (!BEAST_EXPECT(lastNFTokenPage)) return; uint256 const middleNFTokenPageIndex = lastNFTokenPage->at(sfPreviousPageMin); auto middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); if (!BEAST_EXPECT(middleNFTokenPage)) return; uint256 const firstNFTokenPageIndex = middleNFTokenPage->at(sfPreviousPageMin); auto firstNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), firstNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), firstNFTokenPageIndex)); if (!BEAST_EXPECT(firstNFTokenPage)) return; @@ -604,17 +605,17 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify that middle page is gone and the links in the two // remaining pages are correct. middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); BEAST_EXPECT(!middleNFTokenPage); - lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); BEAST_EXPECT(!lastNFTokenPage->isFieldPresent(sfNextPageMin)); BEAST_EXPECT(lastNFTokenPage->getFieldH256(sfPreviousPageMin) == firstNFTokenPageIndex); firstNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), firstNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), firstNFTokenPageIndex)); BEAST_EXPECT( - firstNFTokenPage->getFieldH256(sfNextPageMin) == keylet::nftpageMax(alice).key); + firstNFTokenPage->getFieldH256(sfNextPageMin) == keylet::nftokenPageMax(alice).key); BEAST_EXPECT(!firstNFTokenPage->isFieldPresent(sfPreviousPageMin)); // Burn the remaining nfts. @@ -637,19 +638,19 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify that that all three pages are present and remember the // indexes. - auto lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + auto lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); if (!BEAST_EXPECT(lastNFTokenPage)) return; uint256 const middleNFTokenPageIndex = lastNFTokenPage->at(sfPreviousPageMin); auto middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); if (!BEAST_EXPECT(middleNFTokenPage)) return; uint256 const firstNFTokenPageIndex = middleNFTokenPage->at(sfPreviousPageMin); auto firstNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), firstNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), firstNFTokenPageIndex)); if (!BEAST_EXPECT(firstNFTokenPage)) return; @@ -664,18 +665,18 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify the first page is gone. firstNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), firstNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), firstNFTokenPageIndex)); BEAST_EXPECT(!firstNFTokenPage); // Check the links in the other two pages. middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); if (!BEAST_EXPECT(middleNFTokenPage)) return; BEAST_EXPECT(!middleNFTokenPage->isFieldPresent(sfPreviousPageMin)); BEAST_EXPECT(middleNFTokenPage->isFieldPresent(sfNextPageMin)); - lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); if (!BEAST_EXPECT(lastNFTokenPage)) return; BEAST_EXPECT(lastNFTokenPage->isFieldPresent(sfPreviousPageMin)); @@ -696,20 +697,20 @@ class NFTokenBurn_test : public beast::unit_test::Suite // _previous_ page because we need to preserve that last // page as an anchor. The contents of the next-to-last page // are moved into the last page. - lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); BEAST_EXPECT(lastNFTokenPage); BEAST_EXPECT(!lastNFTokenPage->isFieldPresent(sfPreviousPageMin)); BEAST_EXPECT(!lastNFTokenPage->isFieldPresent(sfNextPageMin)); BEAST_EXPECT(lastNFTokenPage->getFieldArray(sfNFTokens).size() == 32); // The "middle" page should be gone. - middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + middleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); BEAST_EXPECT(!middleNFTokenPage); // The "first" page should still be gone. - firstNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), firstNFTokenPageIndex)); + firstNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), firstNFTokenPageIndex)); BEAST_EXPECT(!firstNFTokenPage); } else @@ -717,13 +718,13 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Removing the last token from the last page deletes the last // page. This is a bug. The contents of the next-to-last page // should have been moved into the last page. - lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); BEAST_EXPECT(!lastNFTokenPage); // The "middle" page is still present, but has lost the // NextPageMin field. - middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + middleNFTokenPage = env.le( + keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); if (!BEAST_EXPECT(middleNFTokenPage)) return; BEAST_EXPECT(!middleNFTokenPage->isFieldPresent(sfPreviousPageMin)); @@ -777,7 +778,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite env.app(), ov, tx, tesSUCCESS, env.current()->fees().base, TapNone, jlog}; // Verify that the last page is present and contains one NFT. - auto lastNFTokenPage = ac.view().peek(keylet::nftpageMax(alice)); + auto lastNFTokenPage = ac.view().peek(keylet::nftokenPageMax(alice)); if (!BEAST_EXPECT(lastNFTokenPage)) return; BEAST_EXPECT(lastNFTokenPage->getFieldArray(sfNFTokens).size() == 1); @@ -809,10 +810,10 @@ class NFTokenBurn_test : public beast::unit_test::Suite env.app(), ov, tx, tesSUCCESS, env.current()->fees().base, TapNone, jlog}; // Verify that the middle page is present. - auto lastNFTokenPage = ac.view().peek(keylet::nftpageMax(alice)); + auto lastNFTokenPage = ac.view().peek(keylet::nftokenPageMax(alice)); auto middleNFTokenPage = ac.view().peek( - keylet::nftpage( - keylet::nftpageMin(alice), + keylet::nftokenPage( + keylet::nftokenPageMin(alice), lastNFTokenPage->getFieldH256(sfPreviousPageMin))); BEAST_EXPECT(middleNFTokenPage); @@ -865,11 +866,11 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify all sell offers are present in the ledger. for (uint256 const& offerIndex : offerIndexes) { - BEAST_EXPECT(env.le(keylet::nftoffer(offerIndex))); + BEAST_EXPECT(env.le(keylet::nftokenOffer(offerIndex))); } // Becky creates a buy offer - uint256 const beckyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftokenID, drops(1)), token::Owner(alice)); env.close(); @@ -881,12 +882,12 @@ class NFTokenBurn_test : public beast::unit_test::Suite // that alice created for (uint256 const& offerIndex : offerIndexes) { - BEAST_EXPECT(!env.le(keylet::nftoffer(offerIndex))); + BEAST_EXPECT(!env.le(keylet::nftokenOffer(offerIndex))); } // Burning the token should also remove the one buy offer // that becky created - BEAST_EXPECT(!env.le(keylet::nftoffer(beckyOfferIndex))); + BEAST_EXPECT(!env.le(keylet::nftokenOffer(beckyOfferIndex))); // alice and becky should have ownerCounts of zero BEAST_EXPECT(ownerCount(env, alice) == 0); @@ -912,7 +913,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify all sell offers are present in the ledger. for (uint256 const& offerIndex : offerIndexes) { - BEAST_EXPECT(env.le(keylet::nftoffer(offerIndex))); + BEAST_EXPECT(env.le(keylet::nftokenOffer(offerIndex))); } // Burn the token @@ -923,7 +924,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Count the number of sell offers that have been deleted for (uint256 const& offerIndex : offerIndexes) { - if (!env.le(keylet::nftoffer(offerIndex))) + if (!env.le(keylet::nftokenOffer(offerIndex))) offerDeletedCount++; } @@ -956,7 +957,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify all sell offers are present in the ledger. for (uint256 const& offerIndex : offerIndexes) { - BEAST_EXPECT(env.le(keylet::nftoffer(offerIndex))); + BEAST_EXPECT(env.le(keylet::nftokenOffer(offerIndex))); } // becky creates 2 buy offers @@ -973,7 +974,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite // ledger. for (uint256 const& offerIndex : offerIndexes) { - BEAST_EXPECT(!env.le(keylet::nftoffer(offerIndex))); + BEAST_EXPECT(!env.le(keylet::nftokenOffer(offerIndex))); } // alice should have ownerCount of zero because all her @@ -1044,7 +1045,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite env.close(); // Minter creates an offer for the NFToken. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nfts.back(), XRP(0)), Txflags(tfSellNFToken)); env.close(); @@ -1091,19 +1092,19 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Verify that that all three pages are present and remember the // indexes. - auto lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + auto lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); if (!BEAST_EXPECT(lastNFTokenPage)) return; uint256 const middleNFTokenPageIndex = lastNFTokenPage->at(sfPreviousPageMin); auto middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); if (!BEAST_EXPECT(middleNFTokenPage)) return; uint256 const firstNFTokenPageIndex = middleNFTokenPage->at(sfPreviousPageMin); auto firstNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), firstNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), firstNFTokenPageIndex)); if (!BEAST_EXPECT(firstNFTokenPage)) return; @@ -1115,7 +1116,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite nfts.pop_back(); // alice creates an offer for the NFToken. - uint256 const aliceOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, last32NFTs.back(), XRP(0)), Txflags(tfSellNFToken)); env.close(); @@ -1127,14 +1128,14 @@ class NFTokenBurn_test : public beast::unit_test::Suite // Removing the last token from the last page deletes alice's last // page. This is a bug. The contents of the next-to-last page // should have been moved into the last page. - lastNFTokenPage = env.le(keylet::nftpageMax(alice)); + lastNFTokenPage = env.le(keylet::nftokenPageMax(alice)); BEAST_EXPECT(!lastNFTokenPage); BEAST_EXPECT(ownerCount(env, alice) == 2); // The "middle" page is still present, but has lost the // NextPageMin field. middleNFTokenPage = - env.le(keylet::nftpage(keylet::nftpageMin(alice), middleNFTokenPageIndex)); + env.le(keylet::nftokenPage(keylet::nftokenPageMin(alice), middleNFTokenPageIndex)); if (!BEAST_EXPECT(middleNFTokenPage)) return; BEAST_EXPECT(middleNFTokenPage->isFieldPresent(sfPreviousPageMin)); @@ -1149,7 +1150,7 @@ class NFTokenBurn_test : public beast::unit_test::Suite for (uint256 const nftID : last32NFTs) { // minter creates an offer for the NFToken. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, XRP(0)), Txflags(tfSellNFToken)); env.close(); diff --git a/src/test/app/NFTokenDir_test.cpp b/src/test/app/NFTokenDir_test.cpp index e24a524b81..19bf58f247 100644 --- a/src/test/app/NFTokenDir_test.cpp +++ b/src/test/app/NFTokenDir_test.cpp @@ -142,7 +142,7 @@ class NFTokenDir_test : public beast::unit_test::Suite std::vector offers; for (uint256 const& nftID : nftIDs) { - offers.emplace_back(keylet::nftoffer(issuer, env.seq(issuer)).key); + offers.emplace_back(keylet::nftokenOffer(issuer, env.seq(issuer)).key); env(token::createOffer(issuer, nftID, XRP(0)), Txflags(tfSellNFToken)); env.close(); } @@ -214,7 +214,7 @@ class NFTokenDir_test : public beast::unit_test::Suite env.close(); // Create an offer to give the NFT to buyer for free. - offers.emplace_back(keylet::nftoffer(account, env.seq(account)).key); + offers.emplace_back(keylet::nftokenOffer(account, env.seq(account)).key); env(token::createOffer(account, nftID, XRP(0)), token::Destination(buyer), Txflags(tfSellNFToken)); @@ -237,7 +237,7 @@ class NFTokenDir_test : public beast::unit_test::Suite // generates a non-tesSUCCESS error code. for (uint256 const& nftID : nftIDs) { - uint256 const offerID = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerID = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, XRP(100)), Txflags(tfSellNFToken)); env.close(); @@ -418,7 +418,7 @@ class NFTokenDir_test : public beast::unit_test::Suite env.close(); // Create an offer to give the NFT to buyer for free. - offers.emplace_back(keylet::nftoffer(account, env.seq(account)).key); + offers.emplace_back(keylet::nftokenOffer(account, env.seq(account)).key); env(token::createOffer(account, nftID, XRP(0)), token::Destination(buyer), Txflags(tfSellNFToken)); @@ -445,7 +445,7 @@ class NFTokenDir_test : public beast::unit_test::Suite // generates a non-tesSUCCESS error code. for (uint256 const& nftID : nftIDs) { - uint256 const offerID = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerID = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, XRP(100)), Txflags(tfSellNFToken)); env.close(); @@ -648,7 +648,7 @@ class NFTokenDir_test : public beast::unit_test::Suite env.close(); // Create an offer to give the NFT to buyer for free. - offers.emplace_back(keylet::nftoffer(account, env.seq(account)).key); + offers.emplace_back(keylet::nftokenOffer(account, env.seq(account)).key); env(token::createOffer(account, nftID, XRP(0)), token::Destination(buyer), Txflags(tfSellNFToken)); @@ -684,7 +684,7 @@ class NFTokenDir_test : public beast::unit_test::Suite // a non-tesSUCCESS error code. for (uint256 const& nftID : nftIDs) { - uint256 const offerID = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerID = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, XRP(100)), Txflags(tfSellNFToken)); env.close(); @@ -820,7 +820,7 @@ class NFTokenDir_test : public beast::unit_test::Suite env.close(); // Create an offer to give the NFT to buyer for free. - offers[i].emplace_back(keylet::nftoffer(account, env.seq(account)).key); + offers[i].emplace_back(keylet::nftokenOffer(account, env.seq(account)).key); env(token::createOffer(account, nftID, XRP(0)), token::Destination(buyer), Txflags(tfSellNFToken)); diff --git a/src/test/app/NFToken_test.cpp b/src/test/app/NFToken_test.cpp index cb92b23a4c..ef7c385acb 100644 --- a/src/test/app/NFToken_test.cpp +++ b/src/test/app/NFToken_test.cpp @@ -143,7 +143,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite Account const alice{"alice"}; env.fund(XRP(10000), alice); env.close(); - uint256 const aliceOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId1, XRP(1000)), token::Owner(master)); env.close(); @@ -861,7 +861,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ownerCount(env, alice) == 1); // This is the offer we'll try to cancel. - uint256 const buyerOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyerOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftAlice0ID, XRP(1)), token::Owner(alice), Ter(tesSUCCESS)); env.close(); BEAST_EXPECT(ownerCount(env, buyer) == 1); @@ -904,7 +904,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // List of offer IDs containing zero is invalid. // craftedIndex is not a valid offer index but it is not zero. - auto const craftedIndex = keylet::nftoffer(gw, env.seq(gw)).key; + auto const craftedIndex = keylet::nftokenOffer(gw, env.seq(gw)).key; env(token::cancelOffer(buyer, {buyerOfferIndex, uint256{}, craftedIndex}), Ter(temMALFORMED)); env.close(); @@ -1006,32 +1006,32 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ownerCount(env, alice) == aliceCount); // alice creates sell offers for her nfts. - uint256 const plainOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const plainOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftAlice0ID, XRP(10)), Txflags(tfSellNFToken)); env.close(); aliceCount++; BEAST_EXPECT(ownerCount(env, alice) == aliceCount); - uint256 const audOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const audOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftAlice0ID, gwAUD(30)), Txflags(tfSellNFToken)); env.close(); aliceCount++; BEAST_EXPECT(ownerCount(env, alice) == aliceCount); - uint256 const xrpOnlyOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const xrpOnlyOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftXrpOnlyID, XRP(20)), Txflags(tfSellNFToken)); env.close(); aliceCount++; BEAST_EXPECT(ownerCount(env, alice) == aliceCount); - uint256 const noXferOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const noXferOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftNoXferID, XRP(30)), Txflags(tfSellNFToken)); env.close(); aliceCount++; BEAST_EXPECT(ownerCount(env, alice) == aliceCount); // alice creates a sell offer that will expire soon. - uint256 const aliceExpOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceExpOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftNoXferID, XRP(40)), Txflags(tfSellNFToken), token::Expiration(lastClose(env) + 5)); @@ -1040,7 +1040,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ownerCount(env, alice) == aliceCount); // buyer creates a Buy offer that will expire soon. - uint256 const buyerExpOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyerExpOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftAlice0ID, XRP(40)), token::Owner(alice), token::Expiration(lastClose(env) + 5)); @@ -1108,7 +1108,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ownerCount(env, buyer) == buyerCount); // The buy offer must be present in the ledger. - uint256 const missingOfferIndex = keylet::nftoffer(alice, 1).key; + uint256 const missingOfferIndex = keylet::nftokenOffer(alice, 1).key; env(token::acceptBuyOffer(buyer, missingOfferIndex), Ter(tecOBJECT_NOT_FOUND)); env.close(); BEAST_EXPECT(ownerCount(env, buyer) == buyerCount); @@ -1120,7 +1120,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite if (features[fixCleanup3_1_3]) { buyerCount--; - BEAST_EXPECT(!env.closed()->exists(keylet::nftoffer(buyerExpOfferIndex))); + BEAST_EXPECT(!env.closed()->exists(keylet::nftokenOffer(buyerExpOfferIndex))); } BEAST_EXPECT(ownerCount(env, buyer) == buyerCount); @@ -1144,7 +1144,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite if (features[fixCleanup3_1_3]) { aliceCount--; - BEAST_EXPECT(!env.closed()->exists(keylet::nftoffer(aliceExpOfferIndex))); + BEAST_EXPECT(!env.closed()->exists(keylet::nftokenOffer(aliceExpOfferIndex))); } BEAST_EXPECT(ownerCount(env, alice) == aliceCount); BEAST_EXPECT(ownerCount(env, buyer) == buyerCount); @@ -1171,7 +1171,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // corresponding buy and sell offers. { // buyer creates a buy offer for one of alice's nfts. - uint256 const buyerOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyerOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftAlice0ID, gwAUD(29)), token::Owner(alice)); env.close(); buyerCount++; @@ -1204,7 +1204,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite } { // buyer creates a buy offer for one of alice's nfts. - uint256 const buyerOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyerOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftAlice0ID, gwAUD(31)), token::Owner(alice)); env.close(); buyerCount++; @@ -1243,7 +1243,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // preclaim buy { // buyer creates a buy offer for one of alice's nfts. - uint256 const buyerOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyerOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftAlice0ID, gwAUD(30)), token::Owner(alice)); env.close(); buyerCount++; @@ -1270,7 +1270,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // alice gives her NFT to gw, so alice no longer owns nftAlice0. { - uint256 const offerIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const offerIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftAlice0ID, XRP(0)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(gw, offerIndex)); @@ -1295,7 +1295,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // preclaim sell { // buyer creates a buy offer for one of alice's nfts. - uint256 const buyerOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyerOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftXrpOnlyID, XRP(30)), token::Owner(alice)); env.close(); buyerCount++; @@ -1323,7 +1323,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // buyer attempting to accept one of alice's offers with // insufficient funds. { - uint256 const offerIndex = keylet::nftoffer(gw, env.seq(gw)).key; + uint256 const offerIndex = keylet::nftokenOffer(gw, env.seq(gw)).key; env(token::createOffer(gw, nftAlice0ID, XRP(0)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(alice, offerIndex)); @@ -1376,7 +1376,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env(token::mint(minter1, 0u), token::Issuer(alice), Txflags(flags)); env.close(); - uint256 const offerIndex = keylet::nftoffer(minter1, env.seq(minter1)).key; + uint256 const offerIndex = keylet::nftokenOffer(minter1, env.seq(minter1)).key; env(token::createOffer(minter1, nftID, XRP(0)), Txflags(tfSellNFToken)); env.close(); @@ -1479,13 +1479,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); BEAST_EXPECT(ownerCount(env, alice) == 2); - uint256 const aliceOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftIOUsOkayID, gwAUD(50)), Txflags(tfSellNFToken)); env.close(); BEAST_EXPECT(ownerCount(env, alice) == 3); BEAST_EXPECT(ownerCount(env, buyer) == 1); - uint256 const buyerOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyerOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftIOUsOkayID, gwAUD(50)), token::Owner(alice)); env.close(); BEAST_EXPECT(ownerCount(env, buyer) == 2); @@ -1588,7 +1588,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // becky buys the nft for 1 drop. - uint256 const beckyBuyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftNoAutoTrustID, drops(1)), token::Owner(alice)); env.close(); env(token::acceptBuyOffer(alice, beckyBuyOfferIndex)); @@ -1596,14 +1596,14 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // becky attempts to sell the nft for AUD. TER const createOfferTER = (xferFee != 0u) ? TER(tecNO_LINE) : TER(tesSUCCESS); - uint256 const beckyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftNoAutoTrustID, gwAUD(100)), Txflags(tfSellNFToken), Ter(createOfferTER)); env.close(); // cheri offers to buy the nft for CAD. - uint256 const cheriOfferIndex = keylet::nftoffer(cheri, env.seq(cheri)).key; + uint256 const cheriOfferIndex = keylet::nftokenOffer(cheri, env.seq(cheri)).key; env(token::createOffer(cheri, nftNoAutoTrustID, gwCAD(100)), token::Owner(becky), Ter(createOfferTER)); @@ -1641,14 +1641,14 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite break; } // becky buys the nft for 1 drop. - uint256 const beckyBuyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAutoTrustID, drops(1)), token::Owner(alice)); env.close(); env(token::acceptBuyOffer(alice, beckyBuyOfferIndex)); env.close(); // becky sells the nft for AUD. - uint256 const beckySellOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckySellOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAutoTrustID, gwAUD(100)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(cheri, beckySellOfferIndex)); @@ -1658,7 +1658,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(env.balance(alice, gwAUD) == gwAUD(10)); // becky buys the nft back for CAD. - uint256 const beckyBuyBackOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyBackOfferIndex = + keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAutoTrustID, gwCAD(50)), token::Owner(cheri)); env.close(); env(token::acceptBuyOffer(cheri, beckyBuyBackOfferIndex)); @@ -1678,7 +1679,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // alice sells the nft using AUD. - uint256 const aliceSellOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceSellOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftNoAutoTrustID, gwAUD(200)), Txflags(tfSellNFToken)); env.close(); @@ -1695,7 +1696,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite Txflags(tfSellNFToken), Ter(tecNO_LINE)); env.close(); - uint256 const cheriSellOfferIndex = keylet::nftoffer(cheri, env.seq(cheri)).key; + uint256 const cheriSellOfferIndex = keylet::nftokenOffer(cheri, env.seq(cheri)).key; env(token::createOffer(cheri, nftNoAutoTrustID, gwCAD(100)), Txflags(tfSellNFToken)); env.close(); @@ -1742,7 +1743,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite Ter(tefNFTOKEN_IS_NOT_TRANSFERABLE)); // alice offers to sell the nft and becky accepts the offer. - uint256 const aliceSellOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceSellOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftAliceNoTransferID, XRP(20)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(becky, aliceSellOfferIndex)); @@ -1770,7 +1771,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // alice offers to buy the nft back from becky. becky accepts // the offer. - uint256 const aliceBuyOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceBuyOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftAliceNoTransferID, XRP(22)), token::Owner(becky)); env.close(); env(token::acceptBuyOffer(becky, aliceBuyOfferIndex)); @@ -1826,7 +1827,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // minter successfully offers their nft for sale. BEAST_EXPECT(ownerCount(env, minter) == 1); - uint256 const minterSellOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterSellOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftMinterNoTransferID, XRP(22)), Txflags(tfSellNFToken)); env.close(); BEAST_EXPECT(ownerCount(env, minter) == 2); @@ -1861,7 +1862,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // alice can create an offer to buy the nft. BEAST_EXPECT(ownerCount(env, alice) == 0); - uint256 const aliceBuyOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceBuyOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftMinterNoTransferID, XRP(25)), token::Owner(becky)); env.close(); BEAST_EXPECT(ownerCount(env, alice) == 1); @@ -1876,7 +1877,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Now minter can create an offer to buy the nft. BEAST_EXPECT(ownerCount(env, minter) == 0); - uint256 const minterBuyOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterBuyOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftMinterNoTransferID, XRP(26)), token::Owner(becky)); env.close(); BEAST_EXPECT(ownerCount(env, minter) == 1); @@ -1915,12 +1916,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ownerCount(env, alice) == 1); // Both alice and becky can make offers for alice's nft. - uint256 const aliceSellOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceSellOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftAliceID, XRP(20)), Txflags(tfSellNFToken)); env.close(); BEAST_EXPECT(ownerCount(env, alice) == 2); - uint256 const beckyBuyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAliceID, XRP(21)), token::Owner(alice)); env.close(); BEAST_EXPECT(ownerCount(env, alice) == 2); @@ -1932,7 +1933,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ownerCount(env, becky) == 2); // becky offers to sell the nft. - uint256 const beckySellOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckySellOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAliceID, XRP(22)), Txflags(tfSellNFToken)); env.close(); BEAST_EXPECT(ownerCount(env, alice) == 0); @@ -1947,7 +1948,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ownerCount(env, minter) == 1); // minter offers to sell the nft. - uint256 const minterSellOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterSellOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftAliceID, XRP(23)), Txflags(tfSellNFToken)); env.close(); BEAST_EXPECT(ownerCount(env, alice) == 0); @@ -2029,7 +2030,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // Becky buys the nft for XAU(10). Check balances. - uint256 const beckyBuyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftID, gwXAU(10)), token::Owner(alice)); env.close(); BEAST_EXPECT(env.balance(alice, gwXAU) == gwXAU(1000)); @@ -2041,7 +2042,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(env.balance(becky, gwXAU) == gwXAU(990)); // becky sells nft to carol. alice's balance should not change. - uint256 const beckySellOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckySellOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftID, gwXAU(10)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(carol, beckySellOfferIndex)); @@ -2051,7 +2052,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(env.balance(carol, gwXAU) == gwXAU(990)); // minter buys nft from carol. alice's balance should not change. - uint256 const minterBuyOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterBuyOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, gwXAU(10)), token::Owner(carol)); env.close(); env(token::acceptBuyOffer(carol, minterBuyOfferIndex)); @@ -2063,7 +2064,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // minter sells the nft to alice. gwXAU balances should finish // where they started. - uint256 const minterSellOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterSellOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, gwXAU(10)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(alice, minterSellOfferIndex)); @@ -2090,7 +2091,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // Becky buys the nft for XAU(10). Check balances. - uint256 const beckyBuyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftID, gwXAU(10)), token::Owner(alice)); env.close(); BEAST_EXPECT(env.balance(alice, gwXAU) == gwXAU(1000)); @@ -2102,7 +2103,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(env.balance(becky, gwXAU) == gwXAU(990)); // becky sells nft to carol. alice's balance goes up. - uint256 const beckySellOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckySellOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftID, gwXAU(10)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(carol, beckySellOfferIndex)); @@ -2113,7 +2114,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(env.balance(carol, gwXAU) == gwXAU(990)); // minter buys nft from carol. alice's balance goes up. - uint256 const minterBuyOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterBuyOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, gwXAU(10)), token::Owner(carol)); env.close(); env(token::acceptBuyOffer(carol, minterBuyOfferIndex)); @@ -2126,7 +2127,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // minter sells the nft to alice. Because alice is part of the // transaction no transfer fee is removed. - uint256 const minterSellOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterSellOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, gwXAU(10)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(alice, minterSellOfferIndex)); @@ -2171,7 +2172,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // Becky buys the nft for XAU(10). Check balances. - uint256 const beckyBuyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftID, gwXAU(10)), token::Owner(alice)); env.close(); BEAST_EXPECT(env.balance(alice, gwXAU) == gwXAU(1000)); @@ -2183,7 +2184,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(env.balance(becky, gwXAU) == gwXAU(990)); // becky sells nft to minter. alice's balance goes up. - uint256 const beckySellOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckySellOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftID, gwXAU(100)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(minter, beckySellOfferIndex)); @@ -2194,7 +2195,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(env.balance(minter, gwXAU) == gwXAU(900)); // carol buys nft from minter. alice's balance goes up. - uint256 const carolBuyOfferIndex = keylet::nftoffer(carol, env.seq(carol)).key; + uint256 const carolBuyOfferIndex = keylet::nftokenOffer(carol, env.seq(carol)).key; env(token::createOffer(carol, nftID, gwXAU(10)), token::Owner(minter)); env.close(); env(token::acceptBuyOffer(minter, carolBuyOfferIndex)); @@ -2207,7 +2208,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // carol sells the nft to alice. Because alice is part of the // transaction no transfer fee is removed. - uint256 const carolSellOfferIndex = keylet::nftoffer(carol, env.seq(carol)).key; + uint256 const carolSellOfferIndex = keylet::nftokenOffer(carol, env.seq(carol)).key; env(token::createOffer(carol, nftID, gwXAU(10)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(alice, carolSellOfferIndex)); @@ -2248,7 +2249,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // alice there should be no transfer fee. STAmount aliceBalance = env.balance(alice); STAmount minterBalance = env.balance(minter); - uint256 const minterBuyOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterBuyOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, XRP(1)), token::Owner(alice)); env.close(); env(token::acceptBuyOffer(alice, minterBuyOfferIndex)); @@ -2262,7 +2263,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // alice does not get any transfer fee. auto pmt = drops(50000); STAmount carolBalance = env.balance(carol); - uint256 const minterSellOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterSellOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, pmt), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(carol, minterSellOfferIndex)); @@ -2276,7 +2277,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // carol sells to becky. This is the smallest amount to pay for a // transfer that enables a transfer fee of 1 basis point. STAmount beckyBalance = env.balance(becky); - uint256 const beckyBuyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; pmt = drops(50001); env(token::createOffer(becky, nftID, pmt), token::Owner(carol)); env.close(); @@ -2321,7 +2322,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // alice there should be no transfer fee. STAmount aliceBalance = env.balance(alice, gwXAU); STAmount minterBalance = env.balance(minter, gwXAU); - uint256 const minterBuyOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterBuyOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, tinyXAU), token::Owner(alice)); env.close(); env(token::acceptBuyOffer(alice, minterBuyOfferIndex)); @@ -2333,7 +2334,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // minter sells to carol. STAmount carolBalance = env.balance(carol, gwXAU); - uint256 const minterSellOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterSellOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, tinyXAU), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(carol, minterSellOfferIndex)); @@ -2351,7 +2352,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite STAmount const cheapNFT(gwXAU, STAmount::kMinValue, STAmount::kMinOffset + 5); STAmount beckyBalance = env.balance(becky, gwXAU); - uint256 const beckyBuyOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftID, cheapNFT), token::Owner(carol)); env.close(); env(token::acceptBuyOffer(carol, beckyBuyOfferIndex)); @@ -2581,22 +2582,22 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Test how adding a Destination field to an offer affects permissions // for canceling offers. { - uint256 const offerMinterToIssuer = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterToIssuer = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Destination(issuer), Txflags(tfSellNFToken)); - uint256 const offerMinterToBuyer = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterToBuyer = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Destination(buyer), Txflags(tfSellNFToken)); - uint256 const offerIssuerToMinter = keylet::nftoffer(issuer, env.seq(issuer)).key; + uint256 const offerIssuerToMinter = keylet::nftokenOffer(issuer, env.seq(issuer)).key; env(token::createOffer(issuer, nftokenID, drops(1)), token::Owner(minter), token::Destination(minter)); - uint256 const offerIssuerToBuyer = keylet::nftoffer(issuer, env.seq(issuer)).key; + uint256 const offerIssuerToBuyer = keylet::nftokenOffer(issuer, env.seq(issuer)).key; env(token::createOffer(issuer, nftokenID, drops(1)), token::Owner(minter), token::Destination(buyer)); @@ -2637,7 +2638,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Test how adding a Destination field to a sell offer affects // accepting that offer. { - uint256 const offerMinterSellsToBuyer = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterSellsToBuyer = + keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Destination(buyer), Txflags(tfSellNFToken)); @@ -2665,7 +2667,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Test how adding a Destination field to a buy offer affects // accepting that offer. { - uint256 const offerMinterBuysFromBuyer = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterBuysFromBuyer = + keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Owner(buyer), token::Destination(buyer)); @@ -2692,7 +2695,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // If a destination other than the NFToken owner is set, that // destination must act as a broker. The NFToken owner may not // simply accept the offer. - uint256 const offerBuyerBuysFromMinter = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerBuyerBuysFromMinter = + keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID, drops(1)), token::Owner(minter), token::Destination(broker)); @@ -2715,12 +2719,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Show that a sell offer's Destination can broker that sell offer // to another account. { - uint256 const offerMinterToBroker = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterToBroker = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Destination(broker), Txflags(tfSellNFToken)); - uint256 const offerBuyerToMinter = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerBuyerToMinter = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID, drops(1)), token::Owner(minter)); env.close(); @@ -2752,15 +2756,15 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Destination doesn't match, but can complete if the Destination // does match. { - uint256 const offerBuyerToMinter = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerBuyerToMinter = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID, drops(1)), token::Destination(minter), Txflags(tfSellNFToken)); - uint256 const offerMinterToBuyer = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterToBuyer = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Owner(buyer)); - uint256 const offerIssuerToBuyer = keylet::nftoffer(issuer, env.seq(issuer)).key; + uint256 const offerIssuerToBuyer = keylet::nftokenOffer(issuer, env.seq(issuer)).key; env(token::createOffer(issuer, nftokenID, drops(1)), token::Owner(buyer)); env.close(); @@ -2808,12 +2812,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Show that if a buy and a sell offer both have the same destination, // then that destination can broker the offers. { - uint256 const offerMinterToBroker = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterToBroker = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Destination(broker), Txflags(tfSellNFToken)); - uint256 const offerBuyerToBroker = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerBuyerToBroker = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID, drops(1)), token::Owner(minter), token::Destination(broker)); @@ -2883,7 +2887,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // create offer (allowed now) then cancel { - uint256 const offerIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Destination(buyer), @@ -2896,7 +2900,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // create offer, enable flag, then cancel { - uint256 const offerIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Destination(buyer), @@ -2915,7 +2919,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // create offer then transfer { - uint256 const offerIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID, drops(1)), token::Destination(buyer), @@ -3002,23 +3006,23 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { std::uint32_t const expiration = lastClose(env) + 25; - uint256 const offerMinterToIssuer = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterToIssuer = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID0, drops(1)), token::Destination(issuer), token::Expiration(expiration), Txflags(tfSellNFToken)); - uint256 const offerMinterToAnyone = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offerMinterToAnyone = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID0, drops(1)), token::Expiration(expiration), Txflags(tfSellNFToken)); - uint256 const offerIssuerToMinter = keylet::nftoffer(issuer, env.seq(issuer)).key; + uint256 const offerIssuerToMinter = keylet::nftokenOffer(issuer, env.seq(issuer)).key; env(token::createOffer(issuer, nftokenID0, drops(1)), token::Owner(minter), token::Expiration(expiration)); - uint256 const offerBuyerToMinter = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerBuyerToMinter = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, drops(1)), token::Owner(minter), token::Expiration(expiration)); @@ -3078,13 +3082,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { std::uint32_t const expiration = lastClose(env) + 25; - uint256 const offer0 = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offer0 = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID0, drops(1)), token::Expiration(expiration), Txflags(tfSellNFToken)); minterCount++; - uint256 const offer1 = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const offer1 = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID1, drops(1)), token::Expiration(expiration), Txflags(tfSellNFToken)); @@ -3149,7 +3153,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Transfer nftokenID0 back to minter so we start the next test in // a simple place. - uint256 const offerSellBack = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerSellBack = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, XRP(0)), Txflags(tfSellNFToken), token::Destination(minter)); @@ -3168,13 +3172,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { std::uint32_t const expiration = lastClose(env) + 25; - uint256 const offer0 = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offer0 = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, drops(1)), token::Owner(minter), token::Expiration(expiration)); buyerCount++; - uint256 const offer1 = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offer1 = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID1, drops(1)), token::Owner(minter), token::Expiration(expiration)); @@ -3237,7 +3241,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Transfer nftokenID0 back to minter so we start the next test in // a simple place. - uint256 const offerSellBack = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerSellBack = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, XRP(0)), Txflags(tfSellNFToken), token::Destination(minter)); @@ -3256,23 +3260,23 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { std::uint32_t const expiration = lastClose(env) + 25; - uint256 const sellOffer0 = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const sellOffer0 = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID0, drops(1)), token::Expiration(expiration), Txflags(tfSellNFToken)); minterCount++; - uint256 const sellOffer1 = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const sellOffer1 = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID1, drops(1)), token::Expiration(expiration), Txflags(tfSellNFToken)); minterCount++; - uint256 const buyOffer0 = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOffer0 = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, drops(1)), token::Owner(minter)); buyerCount++; - uint256 const buyOffer1 = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOffer1 = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID1, drops(1)), token::Owner(minter)); buyerCount++; @@ -3331,7 +3335,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Transfer nftokenID0 back to minter so we start the next test in // a simple place. - uint256 const offerSellBack = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerSellBack = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, XRP(0)), Txflags(tfSellNFToken), token::Destination(minter)); @@ -3350,18 +3354,18 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { std::uint32_t const expiration = lastClose(env) + 25; - uint256 const sellOffer0 = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const sellOffer0 = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID0, drops(1)), Txflags(tfSellNFToken)); - uint256 const sellOffer1 = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const sellOffer1 = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID1, drops(1)), Txflags(tfSellNFToken)); - uint256 const buyOffer0 = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOffer0 = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, drops(1)), token::Expiration(expiration), token::Owner(minter)); - uint256 const buyOffer1 = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOffer1 = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID1, drops(1)), token::Expiration(expiration), token::Owner(minter)); @@ -3412,7 +3416,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Transfer nftokenID0 back to minter so we start the next test in // a simple place. - uint256 const offerSellBack = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerSellBack = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, XRP(0)), Txflags(tfSellNFToken), token::Destination(minter)); @@ -3431,22 +3435,22 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { std::uint32_t const expiration = lastClose(env) + 25; - uint256 const sellOffer0 = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const sellOffer0 = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID0, drops(1)), token::Expiration(expiration), Txflags(tfSellNFToken)); - uint256 const sellOffer1 = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const sellOffer1 = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftokenID1, drops(1)), token::Expiration(expiration), Txflags(tfSellNFToken)); - uint256 const buyOffer0 = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOffer0 = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, drops(1)), token::Expiration(expiration), token::Owner(minter)); - uint256 const buyOffer1 = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOffer1 = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID1, drops(1)), token::Expiration(expiration), token::Owner(minter)); @@ -3488,7 +3492,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Transfer nftokenID0 back to minter so we start the next test in // a simple place. - uint256 const offerSellBack = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerSellBack = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftokenID0, XRP(0)), Txflags(tfSellNFToken), token::Destination(minter)); @@ -3526,7 +3530,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // Anyone can cancel an expired offer. - uint256 const expiredOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const expiredOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftokenID, XRP(1000)), Txflags(tfSellNFToken), @@ -3548,7 +3552,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Create a couple of offers with a destination. Those offers // should be cancellable by the creator and the destination. - uint256 const dest1OfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const dest1OfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftokenID, XRP(1000)), token::Destination(becky), @@ -3566,7 +3570,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ownerCount(env, alice) == 1); // alice can cancel her own offer, even if becky is the destination. - uint256 const dest2OfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const dest2OfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftokenID, XRP(1000)), token::Destination(becky), @@ -3585,7 +3589,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env(token::mint(minter, 0), token::Issuer(alice), Txflags(tfTransferable)); env.close(); - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, mintersNFTokenID, XRP(1000)), Txflags(tfSellNFToken)); env.close(); @@ -3643,7 +3647,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env(token::mint(nftAcct, 0), token::Uri(uri), Txflags(tfTransferable)); env.close(); - offerIndexes.push_back(keylet::nftoffer(offerAcct, env.seq(offerAcct)).key); + offerIndexes.push_back(keylet::nftokenOffer(offerAcct, env.seq(offerAcct)).key); env(token::createOffer(offerAcct, nftokenID, drops(1)), token::Owner(nftAcct), token::Expiration(lastClose(env) + 5)); @@ -3656,7 +3660,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // All offers should be in the ledger. for (uint256 const& offerIndex : offerIndexes) { - BEAST_EXPECT(env.le(keylet::nftoffer(offerIndex))); + BEAST_EXPECT(env.le(keylet::nftokenOffer(offerIndex))); } // alice attempts to cancel all of the expired offers. There is one @@ -3669,7 +3673,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // Verify that offer is gone from the ledger. - BEAST_EXPECT(!env.le(keylet::nftoffer(offerIndexes.back()))); + BEAST_EXPECT(!env.le(keylet::nftokenOffer(offerIndexes.back()))); offerIndexes.pop_back(); // But alice adds a sell offer to the list... @@ -3678,7 +3682,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env(token::mint(alice, 0), token::Uri(uri), Txflags(tfTransferable)); env.close(); - offerIndexes.push_back(keylet::nftoffer(alice, env.seq(alice)).key); + offerIndexes.push_back(keylet::nftokenOffer(alice, env.seq(alice)).key); env(token::createOffer(alice, nftokenID, drops(1)), Txflags(tfSellNFToken)); env.close(); @@ -3708,7 +3712,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Verify that remaining offers are gone from the ledger. for (uint256 const& offerIndex : offerIndexes) { - BEAST_EXPECT(!env.le(keylet::nftoffer(offerIndex))); + BEAST_EXPECT(!env.le(keylet::nftokenOffer(offerIndex))); } } @@ -3789,13 +3793,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const nftID = mintNFT(); // minter creates their offer. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, XRP(0)), Txflags(tfSellNFToken)); env.close(); // buyer creates their offer. Note: a buy offer can never // offer zero. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, XRP(1)), token::Owner(minter)); env.close(); @@ -3831,13 +3835,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const nftID = mintNFT(); // minter creates their offer. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, XRP(0)), Txflags(tfSellNFToken)); env.close(); // buyer creates their offer. Note: a buy offer can never // offer zero. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, XRP(1)), token::Owner(minter)); env.close(); @@ -3880,13 +3884,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const nftID = mintNFT(kMaxTransferFee); // minter creates their offer. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, XRP(0)), Txflags(tfSellNFToken)); env.close(); // buyer creates their offer. Note: a buy offer can never // offer zero. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, XRP(1)), token::Owner(minter)); env.close(); @@ -3922,13 +3926,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const nftID = mintNFT(kMaxTransferFee); // minter creates their offer. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, XRP(0)), Txflags(tfSellNFToken)); env.close(); // buyer creates their offer. Note: a buy offer can never // offer zero. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, XRP(1)), token::Owner(minter)); env.close(); @@ -3995,14 +3999,14 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const nftID = mintNFT(); // minter creates their offer. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, gwXAU(1000)), Txflags(tfSellNFToken)); env.close(); { // buyer creates an offer for more XAU than they currently // own. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, gwXAU(1001)), token::Owner(minter)); env.close(); @@ -4019,7 +4023,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { // buyer creates an offer for less that what minter is // asking. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, gwXAU(999)), token::Owner(minter)); env.close(); @@ -4035,7 +4039,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite } // buyer creates a large enough offer. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, gwXAU(1000)), token::Owner(minter)); env.close(); @@ -4072,13 +4076,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const nftID = mintNFT(kMaxTransferFee); // minter creates their offer. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, gwXAU(900)), Txflags(tfSellNFToken)); env.close(); { // buyer creates an offer for more XAU than they currently // own. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, gwXAU(1001)), token::Owner(minter)); env.close(); @@ -4095,7 +4099,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { // buyer creates an offer for less that what minter is // asking. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, gwXAU(899)), token::Owner(minter)); env.close(); @@ -4110,7 +4114,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); } // buyer creates a large enough offer. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, gwXAU(1000)), token::Owner(minter)); env.close(); @@ -4150,12 +4154,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const nftID = mintNFT(kMaxTransferFee / 2); // 25% // minter creates their offer. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, gwXAU(900)), Txflags(tfSellNFToken)); env.close(); // buyer creates a large enough offer. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, gwXAU(1000)), token::Owner(minter)); env.close(); @@ -4187,12 +4191,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const nftID = mintNFT(kMaxTransferFee / 2); // 25% // minter creates their offer. - uint256 const minterOfferIndex = keylet::nftoffer(minter, env.seq(minter)).key; + uint256 const minterOfferIndex = keylet::nftokenOffer(minter, env.seq(minter)).key; env(token::createOffer(minter, nftID, gwXAU(900)), Txflags(tfSellNFToken)); env.close(); // buyer creates a large enough offer. - uint256 const buyOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID, gwXAU(1000)), token::Owner(minter)); env.close(); @@ -4242,9 +4246,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(nftCount(env, buyer2) == 0); // Both buyer1 and buyer2 create buy offers for nftId. - uint256 const buyer1OfferIndex = keylet::nftoffer(buyer1, env.seq(buyer1)).key; + uint256 const buyer1OfferIndex = keylet::nftokenOffer(buyer1, env.seq(buyer1)).key; env(token::createOffer(buyer1, nftId, XRP(100)), token::Owner(issuer)); - uint256 const buyer2OfferIndex = keylet::nftoffer(buyer2, env.seq(buyer2)).key; + uint256 const buyer2OfferIndex = keylet::nftokenOffer(buyer2, env.seq(buyer2)).key; env(token::createOffer(buyer2, nftId, XRP(100)), token::Owner(issuer)); env.close(); @@ -4332,7 +4336,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // NFTokenCreateOffer BEAST_EXPECT(ownerCount(env, buyer) == 10); - uint256 const offerIndex0 = keylet::nftoffer(buyer, buyerTicketSeq).key; + uint256 const offerIndex0 = keylet::nftokenOffer(buyer, buyerTicketSeq).key; env(token::createOffer(buyer, nftId, XRP(1)), token::Owner(issuer), ticket::Use(buyerTicketSeq++)); @@ -4347,7 +4351,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite BEAST_EXPECT(ticketCount(env, buyer) == 8); // NFTokenCreateOffer. buyer tries again. - uint256 const offerIndex1 = keylet::nftoffer(buyer, buyerTicketSeq).key; + uint256 const offerIndex1 = keylet::nftokenOffer(buyer, buyerTicketSeq).key; env(token::createOffer(buyer, nftId, XRP(2)), token::Owner(issuer), ticket::Use(buyerTicketSeq++)); @@ -4424,7 +4428,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env(token::createOffer(becky, nftId, XRP(2)), token::Owner(minter)); env.close(); - uint256 const carlaOfferIndex = keylet::nftoffer(carla, env.seq(carla)).key; + uint256 const carlaOfferIndex = keylet::nftokenOffer(carla, env.seq(carla)).key; env(token::createOffer(carla, nftId, XRP(3)), token::Owner(minter)); env.close(); @@ -4702,25 +4706,25 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite TER const offerCreateTER = temBAD_AMOUNT; // Make offers with negative amounts for the NFTs - uint256 const sellNegXrpOfferIndex = keylet::nftoffer(issuer, env.seq(issuer)).key; + uint256 const sellNegXrpOfferIndex = keylet::nftokenOffer(issuer, env.seq(issuer)).key; env(token::createOffer(issuer, nftID0, XRP(-2)), Txflags(tfSellNFToken), Ter(offerCreateTER)); env.close(); - uint256 const sellNegIouOfferIndex = keylet::nftoffer(issuer, env.seq(issuer)).key; + uint256 const sellNegIouOfferIndex = keylet::nftokenOffer(issuer, env.seq(issuer)).key; env(token::createOffer(issuer, nftID1, gwXAU(-2)), Txflags(tfSellNFToken), Ter(offerCreateTER)); env.close(); - uint256 const buyNegXrpOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyNegXrpOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID0, XRP(-1)), token::Owner(issuer), Ter(offerCreateTER)); env.close(); - uint256 const buyNegIouOfferIndex = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const buyNegIouOfferIndex = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::createOffer(buyer, nftID1, gwXAU(-1)), token::Owner(issuer), Ter(offerCreateTER)); @@ -4883,7 +4887,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const& nftID, STAmount const& amount, std::optional const terCode = {}) { - uint256 const offerID = keylet::nftoffer(offerer, env.seq(offerer)).key; + uint256 const offerID = keylet::nftokenOffer(offerer, env.seq(offerer)).key; env(token::createOffer(offerer, nftID, amount), token::Owner(owner), terCode ? Ter(*terCode) : Ter(static_cast(tesSUCCESS))); @@ -4896,7 +4900,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite uint256 const& nftID, STAmount const& amount, std::optional const terCode = {}) { - uint256 const offerID = keylet::nftoffer(offerer, env.seq(offerer)).key; + uint256 const offerID = keylet::nftokenOffer(offerer, env.seq(offerer)).key; env(token::createOffer(offerer, nftID, amount), Txflags(tfSellNFToken), terCode ? Ter(*terCode) : Ter(static_cast(tesSUCCESS))); @@ -5409,10 +5413,10 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Bob creates a buy offer for 5 XRP. Alice creates a sell offer // for 0 XRP. - uint256 const bobBuyOfferIndex = keylet::nftoffer(bob, env.seq(bob)).key; + uint256 const bobBuyOfferIndex = keylet::nftokenOffer(bob, env.seq(bob)).key; env(token::createOffer(bob, nftId, XRP(5)), token::Owner(alice)); - uint256 const aliceSellOfferIndex = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceSellOfferIndex = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId, XRP(0)), token::Destination(bob), Txflags(tfSellNFToken)); @@ -5423,10 +5427,10 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // Note that bob still has a buy offer on the books. - BEAST_EXPECT(env.le(keylet::nftoffer(bobBuyOfferIndex))); + BEAST_EXPECT(env.le(keylet::nftokenOffer(bobBuyOfferIndex))); // Bob creates a sell offer for the gift NFT from alice. - uint256 const bobSellOfferIndex = keylet::nftoffer(bob, env.seq(bob)).key; + uint256 const bobSellOfferIndex = keylet::nftokenOffer(bob, env.seq(bob)).key; env(token::createOffer(bob, nftId, XRP(4)), Txflags(tfSellNFToken)); env.close(); @@ -6043,7 +6047,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite token::Amount(XRP(10)), token::Destination(buyer), token::Expiration(lastClose(env) + 25)); - uint256 const offerAliceSellsToBuyer = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const offerAliceSellsToBuyer = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::cancelOffer(alice, {offerAliceSellsToBuyer})); env.close(); @@ -6052,7 +6056,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite token::Amount(XRP(10)), token::Destination(alice), token::Expiration(lastClose(env) + 25)); - uint256 const offerBuyerSellsToAlice = keylet::nftoffer(buyer, env.seq(buyer)).key; + uint256 const offerBuyerSellsToAlice = keylet::nftokenOffer(buyer, env.seq(buyer)).key; env(token::cancelOffer(alice, {offerBuyerSellsToAlice})); env.close(); @@ -6203,12 +6207,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Alice creates one sell offer for each NFT // Verify the offer indexes are correct in the NFTokenCreateOffer tx // meta - uint256 const aliceOfferIndex1 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex1 = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId1, drops(1)), Txflags(tfSellNFToken)); env.close(); verifyNFTokenOfferID(aliceOfferIndex1); - uint256 const aliceOfferIndex2 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex2 = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId2, drops(1)), Txflags(tfSellNFToken)); env.close(); verifyNFTokenOfferID(aliceOfferIndex2); @@ -6222,7 +6226,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // Bobs creates a buy offer for nftId1 // Verify the offer id is correct in the NFTokenCreateOffer tx meta - auto const bobBuyOfferIndex = keylet::nftoffer(bob, env.seq(bob)).key; + auto const bobBuyOfferIndex = keylet::nftokenOffer(bob, env.seq(bob)).key; env(token::createOffer(bob, nftId1, drops(1)), token::Owner(alice)); env.close(); verifyNFTokenOfferID(bobBuyOfferIndex); @@ -6243,7 +6247,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite verifyNFTokenID(nftId); // Alice creates sell offer and set broker as destination - uint256 const offerAliceToBroker = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const offerAliceToBroker = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId, drops(1)), token::Destination(broker), Txflags(tfSellNFToken)); @@ -6251,7 +6255,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite verifyNFTokenOfferID(offerAliceToBroker); // Bob creates buy offer - uint256 const offerBobToBroker = keylet::nftoffer(bob, env.seq(bob)).key; + uint256 const offerBobToBroker = keylet::nftokenOffer(bob, env.seq(bob)).key; env(token::createOffer(bob, nftId, drops(1)), token::Owner(alice)); env.close(); verifyNFTokenOfferID(offerBobToBroker); @@ -6272,12 +6276,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite verifyNFTokenID(nftId); // Alice creates 2 sell offers for the same NFT - uint256 const aliceOfferIndex1 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex1 = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId, drops(1)), Txflags(tfSellNFToken)); env.close(); verifyNFTokenOfferID(aliceOfferIndex1); - uint256 const aliceOfferIndex2 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex2 = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId, drops(1)), Txflags(tfSellNFToken)); env.close(); verifyNFTokenOfferID(aliceOfferIndex2); @@ -6291,7 +6295,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite if (features[featureNFTokenMintOffer]) { - uint256 const aliceMintWithOfferIndex1 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceMintWithOfferIndex1 = + keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::mint(alice), token::Amount(XRP(0))); env.close(); verifyNFTokenOfferID(aliceMintWithOfferIndex1); @@ -6314,7 +6319,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // acct makes an sell offer - uint256 const sellOfferIndex = keylet::nftoffer(acct, env.seq(acct)).key; + uint256 const sellOfferIndex = keylet::nftokenOffer(acct, env.seq(acct)).key; env(token::createOffer(acct, nftId, amt), Txflags(tfSellNFToken)); env.close(); @@ -6519,7 +6524,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // Bob makes a buy offer for 1 XRP - auto const buyOfferIndex = keylet::nftoffer(bob, env.seq(bob)).key; + auto const buyOfferIndex = keylet::nftokenOffer(bob, env.seq(bob)).key; env(token::createOffer(bob, nftId, XRP(1)), token::Owner(alice)); env.close(); @@ -6567,14 +6572,14 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); // Alice creates sell offer and set broker as destination - uint256 const offerAliceToBroker = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const offerAliceToBroker = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId, XRP(1)), token::Destination(broker), Txflags(tfSellNFToken)); env.close(); // Bob creates buy offer - uint256 const offerBobToBroker = keylet::nftoffer(bob, env.seq(bob)).key; + uint256 const offerBobToBroker = keylet::nftokenOffer(bob, env.seq(bob)).key; env(token::createOffer(bob, nftId, XRP(1)), token::Owner(alice)); env.close(); @@ -6668,10 +6673,10 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // becky buys the nfts for 1 drop each. { - uint256 const beckyBuyOfferIndex1 = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex1 = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAutoTrustID, drops(1)), token::Owner(issuer)); - uint256 const beckyBuyOfferIndex2 = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex2 = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftNoAutoTrustID, drops(1)), token::Owner(issuer)); env.close(); @@ -6681,7 +6686,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite } // becky creates offers to sell the nfts for AUD. - uint256 const beckyAutoTrustOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyAutoTrustOfferIndex = + keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAutoTrustID, gwAUD(100)), Txflags(tfSellNFToken)); env.close(); @@ -6699,7 +6705,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite env.close(); BEAST_EXPECT(ownerCount(env, issuer) == 1); - uint256 const beckyNoAutoTrustOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyNoAutoTrustOfferIndex = + keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftNoAutoTrustID, gwAUD(100)), Txflags(tfSellNFToken)); env.close(); @@ -6823,10 +6830,10 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // becky buys the nfts for 1 drop each. { - uint256 const beckyBuyOfferIndex1 = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex1 = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAutoTrustID, drops(1)), token::Owner(issuer)); - uint256 const beckyBuyOfferIndex2 = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyBuyOfferIndex2 = keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftNoAutoTrustID, drops(1)), token::Owner(issuer)); env.close(); @@ -6853,7 +6860,8 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite // However if the NFToken has the tfTrustLine flag set, // then becky can create the offer. - uint256 const beckyAutoTrustOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyAutoTrustOfferIndex = + keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAutoTrustID, isISU(100)), Txflags(tfSellNFToken)); env.close(); @@ -6870,10 +6878,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite { // With featureNFTokenMintOffer things go better. // becky creates offers to sell the nfts for ISU. - uint256 const beckyNoAutoTrustOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyNoAutoTrustOfferIndex = + keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftNoAutoTrustID, isISU(100)), Txflags(tfSellNFToken)); env.close(); - uint256 const beckyAutoTrustOfferIndex = keylet::nftoffer(becky, env.seq(becky)).key; + uint256 const beckyAutoTrustOfferIndex = + keylet::nftokenOffer(becky, env.seq(becky)).key; env(token::createOffer(becky, nftAutoTrustID, isISU(100)), Txflags(tfSellNFToken)); env.close(); @@ -7107,7 +7117,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::Suite checkURI(issuer, "uri", __LINE__); // Account != Owner - uint256 const offerID = keylet::nftoffer(issuer, env.seq(issuer)).key; + uint256 const offerID = keylet::nftokenOffer(issuer, env.seq(issuer)).key; env(token::createOffer(issuer, nftId, XRP(0)), Txflags(tfSellNFToken)); env.close(); env(token::acceptSellOffer(alice, offerID)); diff --git a/src/test/app/Offer_test.cpp b/src/test/app/Offer_test.cpp index 1a2f0b2b12..804bd9b86c 100644 --- a/src/test/app/Offer_test.cpp +++ b/src/test/app/Offer_test.cpp @@ -2196,7 +2196,7 @@ public: jtx::PrettyAmount const& expectBalance) { Issue const& issue = expectBalance.value().get(); - auto const sleTrust = env.le(keylet::line(account.id(), issue)); + auto const sleTrust = env.le(keylet::trustLine(account.id(), issue)); BEAST_EXPECT(sleTrust); if (sleTrust) { @@ -2363,7 +2363,7 @@ public: else { // Verify that no trustline was created. - auto const sleTrust = env.le(keylet::line(acct, usd)); + auto const sleTrust = env.le(keylet::trustLine(acct, usd)); BEAST_EXPECT(!sleTrust); } } @@ -2548,8 +2548,8 @@ public: env.require(offers(bob, 0)); // The two trustlines that were generated by offers should be gone. - BEAST_EXPECT(!env.le(keylet::line(alice.id(), eur))); - BEAST_EXPECT(!env.le(keylet::line(bob.id(), usd))); + BEAST_EXPECT(!env.le(keylet::trustLine(alice.id(), eur))); + BEAST_EXPECT(!env.le(keylet::trustLine(bob.id(), usd))); // Make two more offers that leave one of the offers non-dry. We // need to properly sequence the transactions: @@ -4484,7 +4484,7 @@ public: jtx::Account const& src, jtx::Account const& dst, Currency const& cur) -> bool { - return bool(env.le(keylet::line(src, dst, cur))); + return bool(env.le(keylet::trustLine(src, dst, cur))); }; Account const alice("alice"); diff --git a/src/test/app/Path_test.cpp b/src/test/app/Path_test.cpp index 4cfe938798..8f19a419a0 100644 --- a/src/test/app/Path_test.cpp +++ b/src/test/app/Path_test.cpp @@ -880,7 +880,7 @@ public: })", jv); - auto const jvL = env.le(keylet::line(Account("bob").id(), Account("alice")["USD"])) + auto const jvL = env.le(keylet::trustLine(Account("bob").id(), Account("alice")["USD"])) ->getJson(JsonOptions::Values::None); for (auto it = jv.begin(); it != jv.end(); ++it) BEAST_EXPECT(*it == jvL[it.memberName()]); @@ -922,14 +922,15 @@ public: })", jv); - auto const jvL = env.le(keylet::line(Account("bob").id(), Account("alice")["USD"])) + auto const jvL = env.le(keylet::trustLine(Account("bob").id(), Account("alice")["USD"])) ->getJson(JsonOptions::Values::None); for (auto it = jv.begin(); it != jv.end(); ++it) BEAST_EXPECT(*it == jvL[it.memberName()]); env.trust(Account("bob")["USD"](0), "alice"); env.trust(Account("alice")["USD"](0), "bob"); - BEAST_EXPECT(env.le(keylet::line(Account("bob").id(), Account("alice")["USD"])) == nullptr); + BEAST_EXPECT( + env.le(keylet::trustLine(Account("bob").id(), Account("alice")["USD"])) == nullptr); } void @@ -972,13 +973,14 @@ public: })", jv); - auto const jvL = env.le(keylet::line(Account("alice").id(), Account("bob")["USD"])) + auto const jvL = env.le(keylet::trustLine(Account("alice").id(), Account("bob")["USD"])) ->getJson(JsonOptions::Values::None); for (auto it = jv.begin(); it != jv.end(); ++it) BEAST_EXPECT(*it == jvL[it.memberName()]); env(pay("alice", "bob", Account("alice")["USD"](50))); - BEAST_EXPECT(env.le(keylet::line(Account("alice").id(), Account("bob")["USD"])) == nullptr); + BEAST_EXPECT( + env.le(keylet::trustLine(Account("alice").id(), Account("bob")["USD"])) == nullptr); } void diff --git a/src/test/app/PayChan_test.cpp b/src/test/app/PayChan_test.cpp index bb2d9636e6..fd2c7790d5 100644 --- a/src/test/app/PayChan_test.cpp +++ b/src/test/app/PayChan_test.cpp @@ -62,7 +62,7 @@ struct PayChan_test : public beast::unit_test::Suite auto const sle = view.read(keylet::account(account)); if (!sle) return {}; - auto const k = keylet::payChan(account, dst, (*sle)[sfSequence] - 1); + auto const k = keylet::payChannel(account, dst, (*sle)[sfSequence] - 1); return {k.key, view.read(k)}; } diff --git a/src/test/app/PayStrand_test.cpp b/src/test/app/PayStrand_test.cpp index 471c641f36..1f9290de63 100644 --- a/src/test/app/PayStrand_test.cpp +++ b/src/test/app/PayStrand_test.cpp @@ -80,7 +80,7 @@ getTrustFlag( Currency const& cur, TrustFlag flag) { - if (auto sle = env.le(keylet::line(src, dst, cur))) + if (auto sle = env.le(keylet::trustLine(src, dst, cur))) { auto const useHigh = src.id() > dst.id(); return sle->isFlag(trustFlag(flag, useHigh)); @@ -454,7 +454,7 @@ struct ExistingElementPool for (auto const& c : currencies) { // Line balance - auto const lk = keylet::line(*ai1, *ai2, c); + auto const lk = keylet::trustLine(*ai1, *ai2, c); auto const b1 = lineBalance(v1, lk); auto const b2 = lineBalance(v2, lk); if (b1 != b2) diff --git a/src/test/app/PermissionedDEX_test.cpp b/src/test/app/PermissionedDEX_test.cpp index 51ca321f7e..8578b8a9ba 100644 --- a/src/test/app/PermissionedDEX_test.cpp +++ b/src/test/app/PermissionedDEX_test.cpp @@ -144,7 +144,7 @@ class PermissionedDEX_test : public beast::unit_test::Suite static uint256 getBookDirKey(Book const& book, STAmount const& takerPays, STAmount const& takerGets) { - return keylet::quality(keylet::kBook(book), getRate(takerGets, takerPays)).key; + return keylet::quality(keylet::book(book), getRate(takerGets, takerPays)).key; } static std::optional diff --git a/src/test/app/RCLValidations_test.cpp b/src/test/app/RCLValidations_test.cpp index c3b0ddea9c..aaf84225a7 100644 --- a/src/test/app/RCLValidations_test.cpp +++ b/src/test/app/RCLValidations_test.cpp @@ -97,7 +97,7 @@ class RCLValidations_test : public beast::unit_test::Suite auto next = std::make_shared(*prev, env.app().getTimeKeeper().closeTime()); // Force a different hash on the first iteration next->updateSkipList(); - BEAST_EXPECT(next->read(keylet::fees())); + BEAST_EXPECT(next->read(keylet::feeSettings())); if (forceHash) { next->setImmutable(); diff --git a/src/test/app/SetAuth_test.cpp b/src/test/app/SetAuth_test.cpp index df0c6fe5d0..57526d0a0c 100644 --- a/src/test/app/SetAuth_test.cpp +++ b/src/test/app/SetAuth_test.cpp @@ -51,7 +51,7 @@ struct SetAuth_test : public beast::unit_test::Suite env(fset(gw, asfRequireAuth)); env.close(); env(auth(gw, "alice", "USD")); - BEAST_EXPECT(env.le(keylet::line(Account("alice").id(), gw.id(), usd.currency))); + BEAST_EXPECT(env.le(keylet::trustLine(Account("alice").id(), gw.id(), usd.currency))); env(trust("alice", usd(1000))); env(trust("bob", usd(1000))); env(pay(gw, "alice", usd(100))); diff --git a/src/test/app/Vault_test.cpp b/src/test/app/Vault_test.cpp index 065b6b0044..4643bc8555 100644 --- a/src/test/app/Vault_test.cpp +++ b/src/test/app/Vault_test.cpp @@ -113,7 +113,7 @@ class Vault_test : public beast::unit_test::Suite { BEAST_EXPECT(vault->at(sfScale) == 0); } - auto const shares = env.le(keylet::mptIssuance(vault->at(sfShareMPTID))); + auto const shares = env.le(keylet::mptokenIssuance(vault->at(sfShareMPTID))); BEAST_EXPECT(shares != nullptr); if (!asset.integral()) { @@ -1692,7 +1692,7 @@ class Vault_test : public beast::unit_test::Suite auto v = env.le(keylet); BEAST_EXPECT(v); MPTID const share = (*v)[sfShareMPTID]; - auto issuance = env.le(keylet::mptIssuance(share)); + auto issuance = env.le(keylet::mptokenIssuance(share)); BEAST_EXPECT(issuance); Number const outstandingShares = issuance->at(sfOutstandingAmount); BEAST_EXPECT(outstandingShares == 100); @@ -2794,7 +2794,7 @@ class Vault_test : public beast::unit_test::Suite env(vault.deposit({.depositor = owner, .id = keylet.key, .amount = asset(200)})); env.close(); - auto trustline = env.le(keylet::line(owner, asset.raw().get())); + auto trustline = env.le(keylet::trustLine(owner, asset.raw().get())); BEAST_EXPECT(trustline == nullptr); // Withdraw without trust line, will succeed @@ -2977,7 +2977,7 @@ class Vault_test : public beast::unit_test::Suite env(vault.deposit({.depositor = owner, .id = keylet.key, .amount = asset(200)})); env.close(); - auto trustline = env.le(keylet::line(owner, asset.raw().get())); + auto trustline = env.le(keylet::trustLine(owner, asset.raw().get())); BEAST_EXPECT(trustline == nullptr); env(ticket::create(owner, 1)); @@ -3405,7 +3405,7 @@ class Vault_test : public beast::unit_test::Suite return {vault->at(sfAccount), vault->at(sfShareMPTID)}; }(); BEAST_EXPECT(env.le(keylet::account(vaultAccount))); - BEAST_EXPECT(env.le(keylet::mptIssuance(issuanceId))); + BEAST_EXPECT(env.le(keylet::mptokenIssuance(issuanceId))); PrettyAsset const shares{issuanceId}; { @@ -3559,7 +3559,7 @@ class Vault_test : public beast::unit_test::Suite auto vault = sb.peek(keylet::vault(keylet.key)); if (!BEAST_EXPECT(vault)) return false; - auto shares = sb.peek(keylet::mptIssuance(vault->at(sfShareMPTID))); + auto shares = sb.peek(keylet::mptokenIssuance(vault->at(sfShareMPTID))); if (!BEAST_EXPECT(shares)) return false; if (fn(*vault, *shares)) @@ -4308,7 +4308,7 @@ class Vault_test : public beast::unit_test::Suite BEAST_EXPECT(env.balance(d.depositor, d.shares) == d.share(1000)); // Create a loan broker backed by this vault - auto const brokerKeylet = keylet::loanbroker(d.owner.id(), env.seq(d.owner)); + auto const brokerKeylet = keylet::loanBroker(d.owner.id(), env.seq(d.owner)); env(set(d.owner, d.keylet.key)); env.close(); @@ -4783,7 +4783,7 @@ class Vault_test : public beast::unit_test::Suite auto const sleVault = env.le(vaultKeylet); BEAST_EXPECT(sleVault != nullptr); - auto const sleIssuance = env.le(keylet::mptIssuance(sleVault->at(sfShareMPTID))); + auto const sleIssuance = env.le(keylet::mptokenIssuance(sleVault->at(sfShareMPTID))); BEAST_EXPECT(sleIssuance != nullptr); return sleIssuance->at(sfOutstandingAmount); @@ -4822,7 +4822,7 @@ class Vault_test : public beast::unit_test::Suite env.close(); auto const& sharesAvailable = vaultShareBalance(vaultKeylet); - auto const& brokerKeylet = keylet::loanbroker(owner.id(), env.seq(owner)); + auto const& brokerKeylet = keylet::loanBroker(owner.id(), env.seq(owner)); env(set(owner, vaultKeylet.key)); env.close(); @@ -5215,7 +5215,7 @@ class Vault_test : public beast::unit_test::Suite PrettyAsset const shares = MPTIssue(vaultSle->at(sfShareMPTID)); // Create a loan broker backed by this vault - auto const brokerKeylet = keylet::loanbroker(owner.id(), env.seq(owner)); + auto const brokerKeylet = keylet::loanBroker(owner.id(), env.seq(owner)); env(set(owner, vaultKeylet.key)); env.close(); @@ -5273,7 +5273,7 @@ class Vault_test : public beast::unit_test::Suite PrettyAsset const shares = MPTIssue(vaultSle->at(sfShareMPTID)); // Create a loan broker backed by this vault - auto const brokerKeylet = keylet::loanbroker(owner.id(), env.seq(owner)); + auto const brokerKeylet = keylet::loanBroker(owner.id(), env.seq(owner)); env(set(owner, vaultKeylet.key)); env.close(); @@ -5328,7 +5328,7 @@ class Vault_test : public beast::unit_test::Suite PrettyAsset const shares = MPTIssue(vaultSle->at(sfShareMPTID)); // Create a loan broker backed by this vault - auto const brokerKeylet = keylet::loanbroker(owner.id(), env.seq(owner)); + auto const brokerKeylet = keylet::loanBroker(owner.id(), env.seq(owner)); env(set(owner, vaultKeylet.key)); env.close(); @@ -5382,7 +5382,7 @@ class Vault_test : public beast::unit_test::Suite return; PrettyAsset const shares = MPTIssue(vaultSle->at(sfShareMPTID)); - auto const brokerKeylet = keylet::loanbroker(owner.id(), env.seq(owner)); + auto const brokerKeylet = keylet::loanBroker(owner.id(), env.seq(owner)); env(set(owner, vaultKeylet.key)); env.close(); @@ -5430,7 +5430,7 @@ class Vault_test : public beast::unit_test::Suite return; PrettyAsset const shares = MPTIssue(vaultSle->at(sfShareMPTID)); - auto const brokerKeylet = keylet::loanbroker(owner.id(), env.seq(owner)); + auto const brokerKeylet = keylet::loanBroker(owner.id(), env.seq(owner)); env(set(owner, vaultKeylet.key)); env.close(); @@ -5537,7 +5537,7 @@ class Vault_test : public beast::unit_test::Suite PrettyAsset const shares = MPTIssue(vaultSle->at(sfShareMPTID)); // Create a loan broker backed by this vault - auto const brokerKeylet = keylet::loanbroker(owner.id(), env.seq(owner)); + auto const brokerKeylet = keylet::loanBroker(owner.id(), env.seq(owner)); env(set(owner, vaultKeylet.key)); env.close(); @@ -6338,7 +6338,7 @@ class Vault_test : public beast::unit_test::Suite env.close(); // Loan broker: no cover, no management fee, debt cap 10x principal. - f.brokerID = keylet::loanbroker(f.lender.id(), env.seq(f.lender)).key; + f.brokerID = keylet::loanBroker(f.lender.id(), env.seq(f.lender)).key; { using namespace loanBroker; env(set(f.lender, vaultKeylet.key), @@ -6347,7 +6347,7 @@ class Vault_test : public beast::unit_test::Suite } // Loan: 3,333 USD principal, impaired immediately. - auto const sleBroker = env.le(keylet::loanbroker(f.brokerID)); + auto const sleBroker = env.le(keylet::loanBroker(f.brokerID)); if (!BEAST_EXPECT(sleBroker)) return f; f.loanKeylet = keylet::loan(f.brokerID, sleBroker->at(sfLoanSequence)); @@ -6392,7 +6392,7 @@ class Vault_test : public beast::unit_test::Suite return f; f.sharesLender = tokenLender->getFieldU64(sfMPTAmount); - auto const sleIssuance = env.le(keylet::mptIssuance(f.shareAsset)); + auto const sleIssuance = env.le(keylet::mptokenIssuance(f.shareAsset)); if (!BEAST_EXPECT(sleIssuance)) return f; BEAST_EXPECT(sleIssuance->getFieldU64(sfOutstandingAmount) == f.sharesLender); @@ -6482,7 +6482,7 @@ class Vault_test : public beast::unit_test::Suite auto const vaultAfter = env.le(vaultKey); if (!BEAST_EXPECT(vaultAfter)) return; - auto const issuanceAfter = env.le(keylet::mptIssuance(f.shareAsset)); + auto const issuanceAfter = env.le(keylet::mptokenIssuance(f.shareAsset)); if (!BEAST_EXPECT(issuanceAfter)) return; @@ -6580,7 +6580,7 @@ class Vault_test : public beast::unit_test::Suite auto const vaultAfter = env.le(vaultKey); if (!BEAST_EXPECT(vaultAfter)) return; - auto const issuanceAfter = env.le(keylet::mptIssuance(f.shareAsset)); + auto const issuanceAfter = env.le(keylet::mptokenIssuance(f.shareAsset)); if (!BEAST_EXPECT(issuanceAfter)) return; BEAST_EXPECT(issuanceAfter->getFieldU64(sfOutstandingAmount) == f.sharesLender); @@ -6671,7 +6671,7 @@ class Vault_test : public beast::unit_test::Suite auto const vaultFinal = env.le(vaultKey); if (!BEAST_EXPECT(vaultFinal)) return; - auto const issuanceFinal = env.le(keylet::mptIssuance(f.shareAsset)); + auto const issuanceFinal = env.le(keylet::mptokenIssuance(f.shareAsset)); if (!BEAST_EXPECT(issuanceFinal)) return; @@ -6753,7 +6753,7 @@ class Vault_test : public beast::unit_test::Suite auto const vaultFinal = env.le(vaultKeylet); if (!BEAST_EXPECT(vaultFinal)) return; - auto const issuanceFinal = env.le(keylet::mptIssuance(shareAsset)); + auto const issuanceFinal = env.le(keylet::mptokenIssuance(shareAsset)); if (!BEAST_EXPECT(issuanceFinal)) return; BEAST_EXPECT(issuanceFinal->getFieldU64(sfOutstandingAmount) == 0); @@ -6836,7 +6836,7 @@ class Vault_test : public beast::unit_test::Suite auto const vaultAfter = env.le(vaultKey); if (!BEAST_EXPECT(vaultAfter)) return; - auto const issuanceAfter = env.le(keylet::mptIssuance(f.shareAsset)); + auto const issuanceAfter = env.le(keylet::mptokenIssuance(f.shareAsset)); if (!BEAST_EXPECT(issuanceAfter)) return; @@ -7355,7 +7355,7 @@ class Vault_test : public beast::unit_test::Suite auto const sleVault = env.le(vaultKeylet); if (!sleVault) return std::nullopt; - auto const sleIssuance = env.le(keylet::mptIssuance(sleVault->at(sfShareMPTID))); + auto const sleIssuance = env.le(keylet::mptokenIssuance(sleVault->at(sfShareMPTID))); if (!sleIssuance || !sleIssuance->isFieldPresent(sfReferenceHolding)) return std::nullopt; return sleIssuance->getFieldH256(sfReferenceHolding); @@ -7415,13 +7415,13 @@ class Vault_test : public beast::unit_test::Suite auto const sleVault = env.le(keylet); BEAST_EXPECT(sleVault != nullptr); auto const pseudoId = sleVault->at(sfAccount); - auto const expected = keylet::line(pseudoId, asset.raw().get()).key; + auto const expected = keylet::trustLine(pseudoId, asset.raw().get()).key; auto const stored = readReferenceHolding(env, keylet); BEAST_EXPECT(stored.has_value()); BEAST_EXPECT(stored && *stored == expected); // The pointed-to RippleState must actually exist. - BEAST_EXPECT(env.le(keylet::line(pseudoId, asset.raw().get())) != nullptr); + BEAST_EXPECT(env.le(keylet::trustLine(pseudoId, asset.raw().get())) != nullptr); } // XRP-backed vaults leave the field absent: XRP has no separate @@ -7479,7 +7479,7 @@ class Vault_test : public beast::unit_test::Suite mptt.create({.flags = tfMPTCanTransfer | tfMPTCanLock}); env.close(); - auto const sleIssuance = env.le(keylet::mptIssuance(mptt.issuanceID())); + auto const sleIssuance = env.le(keylet::mptokenIssuance(mptt.issuanceID())); if (BEAST_EXPECT(sleIssuance)) BEAST_EXPECT(!sleIssuance->isFieldPresent(sfReferenceHolding)); } @@ -7505,7 +7505,7 @@ class Vault_test : public beast::unit_test::Suite auto const sleVault = env.le(vaultKeylet); if (!sleVault) return false; - auto const sleIssuance = env.le(keylet::mptIssuance(sleVault->at(sfShareMPTID))); + auto const sleIssuance = env.le(keylet::mptokenIssuance(sleVault->at(sfShareMPTID))); if (!sleIssuance || !sleIssuance->isFieldPresent(sfReferenceHolding)) return false; auto const holdingKey = sleIssuance->getFieldH256(sfReferenceHolding); @@ -7741,7 +7741,7 @@ class Vault_test : public beast::unit_test::Suite BEAST_EXPECT(env.le(keylet) == nullptr); BEAST_EXPECT(env.le(holdingKeylet) == nullptr); - BEAST_EXPECT(env.le(keylet::mptIssuance(sharedMptId)) == nullptr); + BEAST_EXPECT(env.le(keylet::mptokenIssuance(sharedMptId)) == nullptr); } } diff --git a/src/test/jtx/impl/Env.cpp b/src/test/jtx/impl/Env.cpp index 707e1338a7..db45deb6de 100644 --- a/src/test/jtx/impl/Env.cpp +++ b/src/test/jtx/impl/Env.cpp @@ -213,7 +213,7 @@ Env::balance(Account const& account, Asset const& asset) const [&](Issue const& issue) -> PrettyAmount { if (isXRP(issue.currency)) return balance(account); - auto const sle = le(keylet::line(account.id(), issue)); + auto const sle = le(keylet::trustLine(account.id(), issue)); if (!sle) return {STAmount(issue, 0), account.name()}; auto amount = sle->getFieldAmount(sfBalance); @@ -231,7 +231,7 @@ Env::balance(Account const& account, Asset const& asset) const if (account.id() == issuer) { // Issuer balance - auto const sle = le(keylet::mptIssuance(id)); + auto const sle = le(keylet::mptokenIssuance(id)); if (!sle) return {STAmount(mptIssue, 0), account.name()}; @@ -253,7 +253,7 @@ Env::balance(Account const& account, Asset const& asset) const PrettyAmount Env::limit(Account const& account, Issue const& issue) const { - auto const sle = le(keylet::line(account.id(), issue)); + auto const sle = le(keylet::trustLine(account.id(), issue)); if (!sle) return {STAmount(issue, 0), account.name()}; auto const aHigh = account.id() > issue.account; diff --git a/src/test/jtx/impl/TestHelpers.cpp b/src/test/jtx/impl/TestHelpers.cpp index a8ec899c8a..95c8a68436 100644 --- a/src/test/jtx/impl/TestHelpers.cpp +++ b/src/test/jtx/impl/TestHelpers.cpp @@ -338,7 +338,7 @@ xrpMinusFee(Env const& env, std::int64_t xrpAmount) [[nodiscard]] bool expectHolding(Env& env, AccountID const& account, STAmount const& value, bool defaultLimits) { - if (auto const sle = env.le(keylet::line(account, value.get()))) + if (auto const sle = env.le(keylet::trustLine(account, value.get()))) { Issue const issue = value.get(); bool const accountLow = account < issue.account; @@ -368,7 +368,7 @@ expectHolding(Env& env, AccountID const& account, STAmount const& value, bool de [[nodiscard]] bool expectHolding(Env& env, AccountID const& account, None const&, Issue const& issue) { - return !env.le(keylet::line(account, issue)); + return !env.le(keylet::trustLine(account, issue)); } [[nodiscard]] bool @@ -388,7 +388,7 @@ expectHolding(Env& env, AccountID const& account, None const& value) [[nodiscard]] bool expectMPT(Env& env, AccountID const& account, STAmount const& value) { - auto const mptIssuanceID = keylet::mptIssuance(value.asset().get()); + auto const mptIssuanceID = keylet::mptokenIssuance(value.asset().get()); auto const mptToken = env.le(keylet::mptoken(mptIssuanceID.key, account)); return mptToken && (*mptToken)[sfMPTAmount] == value.mpt().value(); } @@ -553,7 +553,7 @@ claim( uint256 channel(AccountID const& account, AccountID const& dst, std::uint32_t seqProxyValue) { - auto const k = keylet::payChan(account, dst, seqProxyValue); + auto const k = keylet::payChannel(account, dst, seqProxyValue); return k.key; } diff --git a/src/test/jtx/impl/balance.cpp b/src/test/jtx/impl/balance.cpp index ddb45a8a97..9d1b812641 100644 --- a/src/test/jtx/impl/balance.cpp +++ b/src/test/jtx/impl/balance.cpp @@ -36,7 +36,7 @@ doBalance(Env& env, AccountID const& account, bool kNone, STAmount const& value, } else { - auto const sle = env.le(keylet::line(account, issue)); + auto const sle = env.le(keylet::trustLine(account, issue)); if (kNone) { TEST_EXPECT(!sle); diff --git a/src/test/jtx/impl/mpt.cpp b/src/test/jtx/impl/mpt.cpp index 7da3305eec..84c5b5fbec 100644 --- a/src/test/jtx/impl/mpt.cpp +++ b/src/test/jtx/impl/mpt.cpp @@ -201,8 +201,8 @@ MPTTester::create(MPTCreate const& arg) if (!isTesSuccess(submit(arg, jv))) { // Verify issuance doesn't exist - env_.require( - RequireAny([&]() -> bool { return env_.le(keylet::mptIssuance(*id_)) == nullptr; })); + env_.require(RequireAny( + [&]() -> bool { return env_.le(keylet::mptokenIssuance(*id_)) == nullptr; })); id_.reset(); } @@ -465,7 +465,7 @@ MPTTester::forObject( { if (!id_) Throw("MPT has not been created"); - auto const key = holder ? keylet::mptoken(*id_, holder->id()) : keylet::mptIssuance(*id_); + auto const key = holder ? keylet::mptoken(*id_, holder->id()) : keylet::mptokenIssuance(*id_); if (auto const sle = env_.le(key)) return cb(sle); return false; @@ -630,7 +630,7 @@ MPTTester::getBalance(Account const& account) const Throw("MPT has not been created"); if (account == issuer_) { - if (auto const sle = env_.le(keylet::mptIssuance(*id_))) + if (auto const sle = env_.le(keylet::mptokenIssuance(*id_))) return sle->getFieldU64(sfOutstandingAmount); } else diff --git a/src/test/rpc/AccountTx_test.cpp b/src/test/rpc/AccountTx_test.cpp index 421f6bd1fa..bd7b07e936 100644 --- a/src/test/rpc/AccountTx_test.cpp +++ b/src/test/rpc/AccountTx_test.cpp @@ -589,7 +589,7 @@ class AccountTx_test : public beast::unit_test::Suite env(payChanCreate, Sig(alie)); env.close(); - std::string const payChanIndex{strHex(keylet::payChan(alice, gw, payChanSeq).key)}; + std::string const payChanIndex{strHex(keylet::payChannel(alice, gw, payChanSeq).key)}; { json::Value payChanFund; diff --git a/src/test/rpc/LedgerEntry_test.cpp b/src/test/rpc/LedgerEntry_test.cpp index dd9eb1c119..14908cf72a 100644 --- a/src/test/rpc/LedgerEntry_test.cpp +++ b/src/test/rpc/LedgerEntry_test.cpp @@ -1476,7 +1476,7 @@ class LedgerEntry_test : public beast::unit_test::Suite // positive test { - Keylet const keylet = keylet::fees(); + Keylet const keylet = keylet::feeSettings(); json::Value jvParams; jvParams[jss::fee] = to_string(keylet.key); json::Value const jrr = @@ -1526,7 +1526,7 @@ class LedgerEntry_test : public beast::unit_test::Suite uint256 const nftokenID0 = token::getNextID(env, issuer, 0, tfTransferable); env(token::mint(issuer, 0), Txflags(tfTransferable)); env.close(); - uint256 const offerID = keylet::nftoffer(issuer, env.seq(issuer)).key; + uint256 const offerID = keylet::nftokenOffer(issuer, env.seq(issuer)).key; env(token::createOffer(issuer, nftokenID0, drops(1)), token::Destination(buyer), Txflags(tfSellNFToken)); @@ -1560,7 +1560,7 @@ class LedgerEntry_test : public beast::unit_test::Suite env(token::mint(issuer, 0), Txflags(tfTransferable)); env.close(); - auto const nftpage = keylet::nftpageMax(issuer); + auto const nftpage = keylet::nftokenPageMax(issuer); BEAST_EXPECT(env.le(nftpage) != nullptr); { @@ -1710,7 +1710,7 @@ class LedgerEntry_test : public beast::unit_test::Suite std::string const ledgerHash{to_string(env.closed()->header().hash)}; - uint256 const payChanIndex{keylet::payChan(alice, env.master, env.seq(alice) - 1).key}; + uint256 const payChanIndex{keylet::payChannel(alice, env.master, env.seq(alice) - 1).key}; { // Request the payment channel using its index. json::Value jvParams; @@ -2421,7 +2421,7 @@ class LedgerEntry_test : public beast::unit_test::Suite }; test(jss::amendments, jss::Amendments, keylet::amendments(), true); - test(jss::fee, jss::FeeSettings, keylet::fees(), true); + test(jss::fee, jss::FeeSettings, keylet::feeSettings(), true); // There won't be an nunl test(jss::nunl, jss::NegativeUNL, keylet::negativeUNL(), false); // Can only get the short skip list this way diff --git a/src/test/rpc/Subscribe_test.cpp b/src/test/rpc/Subscribe_test.cpp index 5c519f3869..97c5290947 100644 --- a/src/test/rpc/Subscribe_test.cpp +++ b/src/test/rpc/Subscribe_test.cpp @@ -1452,12 +1452,12 @@ public: // Alice creates one sell offer for each NFT // Verify the offer indexes are correct in the NFTokenCreateOffer tx // meta - uint256 const aliceOfferIndex1 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex1 = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId1, drops(1)), Txflags(tfSellNFToken)); BEAST_EXPECT(env.syncClose()); verifyNFTokenOfferID(aliceOfferIndex1); - uint256 const aliceOfferIndex2 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex2 = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId2, drops(1)), Txflags(tfSellNFToken)); BEAST_EXPECT(env.syncClose()); verifyNFTokenOfferID(aliceOfferIndex2); @@ -1471,7 +1471,7 @@ public: // Bobs creates a buy offer for nftId1 // Verify the offer id is correct in the NFTokenCreateOffer tx meta - auto const bobBuyOfferIndex = keylet::nftoffer(bob, env.seq(bob)).key; + auto const bobBuyOfferIndex = keylet::nftokenOffer(bob, env.seq(bob)).key; env(token::createOffer(bob, nftId1, drops(1)), token::Owner(alice)); BEAST_EXPECT(env.syncClose()); verifyNFTokenOfferID(bobBuyOfferIndex); @@ -1492,7 +1492,7 @@ public: verifyNFTokenID(nftId); // Alice creates sell offer and set broker as destination - uint256 const offerAliceToBroker = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const offerAliceToBroker = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId, drops(1)), token::Destination(broker), Txflags(tfSellNFToken)); @@ -1500,7 +1500,7 @@ public: verifyNFTokenOfferID(offerAliceToBroker); // Bob creates buy offer - uint256 const offerBobToBroker = keylet::nftoffer(bob, env.seq(bob)).key; + uint256 const offerBobToBroker = keylet::nftokenOffer(bob, env.seq(bob)).key; env(token::createOffer(bob, nftId, drops(1)), token::Owner(alice)); BEAST_EXPECT(env.syncClose()); verifyNFTokenOfferID(offerBobToBroker); @@ -1521,12 +1521,12 @@ public: verifyNFTokenID(nftId); // Alice creates 2 sell offers for the same NFT - uint256 const aliceOfferIndex1 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex1 = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId, drops(1)), Txflags(tfSellNFToken)); BEAST_EXPECT(env.syncClose()); verifyNFTokenOfferID(aliceOfferIndex1); - uint256 const aliceOfferIndex2 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceOfferIndex2 = keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::createOffer(alice, nftId, drops(1)), Txflags(tfSellNFToken)); BEAST_EXPECT(env.syncClose()); verifyNFTokenOfferID(aliceOfferIndex2); @@ -1540,7 +1540,8 @@ public: if (features[featureNFTokenMintOffer]) { - uint256 const aliceMintWithOfferIndex1 = keylet::nftoffer(alice, env.seq(alice)).key; + uint256 const aliceMintWithOfferIndex1 = + keylet::nftokenOffer(alice, env.seq(alice)).key; env(token::mint(alice), token::Amount(XRP(0))); BEAST_EXPECT(env.syncClose()); verifyNFTokenOfferID(aliceMintWithOfferIndex1); diff --git a/src/tests/libxrpl/helpers/TxTest.cpp b/src/tests/libxrpl/helpers/TxTest.cpp index aeaa805b27..86e36b8abf 100644 --- a/src/tests/libxrpl/helpers/TxTest.cpp +++ b/src/tests/libxrpl/helpers/TxTest.cpp @@ -231,13 +231,13 @@ TxTest::getCloseTime() const STAmount TxTest::getBalance(AccountID const& account, IOU const& iou) const { - auto const sle = openLedger_->read(keylet::line(account, iou.issue())); + auto const sle = openLedger_->read(keylet::trustLine(account, iou.issue())); if (!sle) return STAmount{iou.issue(), 0}; - auto const rippleState = ledger_entries::RippleState{sle}; + auto const trustLine = ledger_entries::RippleState{sle}; - auto balance = rippleState.getBalance(); + auto balance = trustLine.getBalance(); if (iou.issue().account == account) { throw std::logic_error("TxTest::getBalance: account is issuer"); diff --git a/src/tests/libxrpl/tx/AccountSet.cpp b/src/tests/libxrpl/tx/AccountSet.cpp index 726e6e9024..46b298dde8 100644 --- a/src/tests/libxrpl/tx/AccountSet.cpp +++ b/src/tests/libxrpl/tx/AccountSet.cpp @@ -619,7 +619,7 @@ TEST(AccountSet, Ticket) // Verify alice has 1 owner object (the ticket) EXPECT_EQ(env.getAccountRoot(alice.id()).getOwnerCount(), 1u); // Verify ticket exists - EXPECT_TRUE(env.getClosedLedger().exists(keylet::kTicket(alice.id(), ticketSeq))); + EXPECT_TRUE(env.getClosedLedger().exists(keylet::ticket(alice.id(), ticketSeq))); // Try using a ticket that alice doesn't have EXPECT_EQ( @@ -629,7 +629,7 @@ TEST(AccountSet, Ticket) env.close(); // Verify ticket still exists - EXPECT_TRUE(env.getClosedLedger().exists(keylet::kTicket(alice.id(), ticketSeq))); + EXPECT_TRUE(env.getClosedLedger().exists(keylet::ticket(alice.id(), ticketSeq))); // Get alice's sequence before using the ticket std::uint32_t const aliceSeq = env.getAccountRoot(alice.id()).getSequence(); @@ -642,7 +642,7 @@ TEST(AccountSet, Ticket) // Verify ticket is consumed (no owner objects) EXPECT_EQ(env.getAccountRoot(alice.id()).getOwnerCount(), 0u); - EXPECT_FALSE(env.getClosedLedger().exists(keylet::kTicket(alice.id(), ticketSeq))); + EXPECT_FALSE(env.getClosedLedger().exists(keylet::ticket(alice.id(), ticketSeq))); // Verify alice's sequence did NOT advance (ticket use doesn't increment seq) EXPECT_EQ(env.getAccountRoot(alice.id()).getSequence(), aliceSeq); diff --git a/src/xrpld/app/ledger/detail/BuildLedger.cpp b/src/xrpld/app/ledger/detail/BuildLedger.cpp index 2a4121ede9..2eb64ecaf9 100644 --- a/src/xrpld/app/ledger/detail/BuildLedger.cpp +++ b/src/xrpld/app/ledger/detail/BuildLedger.cpp @@ -73,7 +73,7 @@ buildLedgerImpl( // Accept ledger XRPL_ASSERT( - built->header().seq < kXrpLedgerEarliestFees || built->read(keylet::fees()), + built->header().seq < kXrpLedgerEarliestFees || built->read(keylet::feeSettings()), "xrpl::buildLedgerImpl : valid ledger fees"); built->setAccepted(closeTime, closeResolution, closeTimeCorrect); diff --git a/src/xrpld/app/ledger/detail/InboundLedger.cpp b/src/xrpld/app/ledger/detail/InboundLedger.cpp index 5a9f24cc2e..e4df126ee8 100644 --- a/src/xrpld/app/ledger/detail/InboundLedger.cpp +++ b/src/xrpld/app/ledger/detail/InboundLedger.cpp @@ -109,7 +109,7 @@ InboundLedger::init(ScopedLockType& collectionLock) JLOG(journal_.debug()) << "Acquiring ledger we already have in " << " local store. " << hash_; XRPL_ASSERT( - ledger_->header().seq < kXrpLedgerEarliestFees || ledger_->read(keylet::fees()), + ledger_->header().seq < kXrpLedgerEarliestFees || ledger_->read(keylet::feeSettings()), "xrpl::InboundLedger::init : valid ledger fees"); ledger_->setImmutable(); @@ -331,7 +331,7 @@ InboundLedger::tryDB(NodeStore::Database& srcDB) JLOG(journal_.debug()) << "Had everything locally"; complete_ = true; XRPL_ASSERT( - ledger_->header().seq < kXrpLedgerEarliestFees || ledger_->read(keylet::fees()), + ledger_->header().seq < kXrpLedgerEarliestFees || ledger_->read(keylet::feeSettings()), "xrpl::InboundLedger::tryDB : valid ledger fees"); ledger_->setImmutable(); } @@ -427,7 +427,7 @@ InboundLedger::done() if (complete_ && !failed_ && ledger_) { XRPL_ASSERT( - ledger_->header().seq < kXrpLedgerEarliestFees || ledger_->read(keylet::fees()), + ledger_->header().seq < kXrpLedgerEarliestFees || ledger_->read(keylet::feeSettings()), "xrpl::InboundLedger::done : valid ledger fees"); ledger_->setImmutable(); switch (reason_) diff --git a/src/xrpld/app/ledger/detail/LedgerPersistence.cpp b/src/xrpld/app/ledger/detail/LedgerPersistence.cpp index 579f66063c..3561b66951 100644 --- a/src/xrpld/app/ledger/detail/LedgerPersistence.cpp +++ b/src/xrpld/app/ledger/detail/LedgerPersistence.cpp @@ -122,7 +122,7 @@ finishLoadByIndexOrHash(std::shared_ptr const& ledger, beast::Journal j) return; XRPL_ASSERT( - ledger->header().seq < kXrpLedgerEarliestFees || ledger->read(keylet::fees()), + ledger->header().seq < kXrpLedgerEarliestFees || ledger->read(keylet::feeSettings()), "xrpl::finishLoadByIndexOrHash : valid ledger fees"); ledger->setImmutable(); diff --git a/src/xrpld/app/ledger/detail/LocalTxs.cpp b/src/xrpld/app/ledger/detail/LocalTxs.cpp index d843acfe44..5bfe8684f0 100644 --- a/src/xrpld/app/ledger/detail/LocalTxs.cpp +++ b/src/xrpld/app/ledger/detail/LocalTxs.cpp @@ -163,7 +163,7 @@ public: // Ticket should have been created by now. Remove if ticket // does not exist. - return !view.exists(keylet::kTicket(acctID, seqProx)); + return !view.exists(keylet::ticket(acctID, seqProx)); }); } diff --git a/src/xrpld/app/main/Application.cpp b/src/xrpld/app/main/Application.cpp index c2fb78ce79..08d84636f6 100644 --- a/src/xrpld/app/main/Application.cpp +++ b/src/xrpld/app/main/Application.cpp @@ -1681,7 +1681,7 @@ ApplicationImp::startGenesisLedger() auto const next = std::make_shared(*genesis, getTimeKeeper().closeTime()); next->updateSkipList(); XRPL_ASSERT( - next->header().seq < kXrpLedgerEarliestFees || next->read(keylet::fees()), + next->header().seq < kXrpLedgerEarliestFees || next->read(keylet::feeSettings()), "xrpl::ApplicationImp::startGenesisLedger : valid ledger fees"); next->setImmutable(); openLedger_.emplace(next, cachedSLEs_, logs_->journal("OpenLedger")); @@ -1703,7 +1703,7 @@ ApplicationImp::getLastFullLedger() return ledger; XRPL_ASSERT( - ledger->header().seq < kXrpLedgerEarliestFees || ledger->read(keylet::fees()), + ledger->header().seq < kXrpLedgerEarliestFees || ledger->read(keylet::feeSettings()), "xrpl::ApplicationImp::getLastFullLedger : valid ledger fees"); ledger->setImmutable(); @@ -1854,7 +1854,8 @@ ApplicationImp::loadLedgerFromFile(std::string const& name) loadLedger->stateMap().flushDirty(NodeObjectType::AccountNode); XRPL_ASSERT( - loadLedger->header().seq < kXrpLedgerEarliestFees || loadLedger->read(keylet::fees()), + loadLedger->header().seq < kXrpLedgerEarliestFees || + loadLedger->read(keylet::feeSettings()), "xrpl::ApplicationImp::loadLedgerFromFile : valid ledger fees"); loadLedger->setAccepted(closeTime, closeTimeResolution, !closeTimeEstimated); diff --git a/src/xrpld/app/misc/detail/TxQ.cpp b/src/xrpld/app/misc/detail/TxQ.cpp index 0326828a70..9022095ea8 100644 --- a/src/xrpld/app/misc/detail/TxQ.cpp +++ b/src/xrpld/app/misc/detail/TxQ.cpp @@ -760,7 +760,7 @@ TxQ::apply( // If the transaction needs a Ticket is that Ticket in the ledger? SeqProxy const acctSeqProx = SeqProxy::sequence((*sleAccount)[sfSequence]); SeqProxy const txSeqProx = tx->getSeqProxy(); - if (txSeqProx.isTicket() && !view.exists(keylet::kTicket(account, txSeqProx))) + if (txSeqProx.isTicket() && !view.exists(keylet::ticket(account, txSeqProx))) { if (txSeqProx.value() < acctSeqProx.value()) { diff --git a/src/xrpld/rpc/detail/AssetCache.cpp b/src/xrpld/rpc/detail/AssetCache.cpp index 23cc31252d..e29f5659f9 100644 --- a/src/xrpld/rpc/detail/AssetCache.cpp +++ b/src/xrpld/rpc/detail/AssetCache.cpp @@ -136,7 +136,7 @@ AssetCache::getMPTs(xrpl::AccountID const& account) auto const mptID = sle->getFieldH192(sfMPTokenIssuanceID); bool const zeroBalance = sle->at(sfMPTAmount) == 0; bool const maxedOut = [&] { - if (auto const sleIssuance = ledger_->read(keylet::mptIssuance(mptID))) + if (auto const sleIssuance = ledger_->read(keylet::mptokenIssuance(mptID))) { return sleIssuance->at(sfOutstandingAmount) == maxMPTAmount(*sleIssuance); } diff --git a/src/xrpld/rpc/detail/Pathfinder.cpp b/src/xrpld/rpc/detail/Pathfinder.cpp index e1a2a4acf6..d7566622e8 100644 --- a/src/xrpld/rpc/detail/Pathfinder.cpp +++ b/src/xrpld/rpc/detail/Pathfinder.cpp @@ -951,7 +951,7 @@ Pathfinder::isNoRipple( AccountID const& toAccount, Currency const& currency) { - auto sleRipple = ledger_->read(keylet::line(toAccount, fromAccount, currency)); + auto sleRipple = ledger_->read(keylet::trustLine(toAccount, fromAccount, currency)); auto const flag((toAccount > fromAccount) ? lsfHighNoRipple : lsfLowNoRipple); diff --git a/src/xrpld/rpc/detail/RPCHelpers.cpp b/src/xrpld/rpc/detail/RPCHelpers.cpp index 7ab2468b75..1764375812 100644 --- a/src/xrpld/rpc/detail/RPCHelpers.cpp +++ b/src/xrpld/rpc/detail/RPCHelpers.cpp @@ -86,7 +86,7 @@ isRelatedToAccount(ReadView const& ledger, SLE::const_ref sle, AccountID const& } if (sle->getType() == ltSIGNER_LIST) { - Keylet const accountSignerList = keylet::signers(accountID); + Keylet const accountSignerList = keylet::signerList(accountID); return sle->key() == accountSignerList.key; } if (sle->getType() == ltNFTOKEN_OFFER) diff --git a/src/xrpld/rpc/handlers/VaultInfo.cpp b/src/xrpld/rpc/handlers/VaultInfo.cpp index 2c00205131..b6d2fe259f 100644 --- a/src/xrpld/rpc/handlers/VaultInfo.cpp +++ b/src/xrpld/rpc/handlers/VaultInfo.cpp @@ -79,7 +79,7 @@ doVaultInfo(RPC::JsonContext& context) auto const sleVault = lpLedger->read(keylet::vault(uNodeIndex)); auto const sleIssuance = sleVault == nullptr // ? nullptr - : lpLedger->read(keylet::mptIssuance(sleVault->at(sfShareMPTID))); + : lpLedger->read(keylet::mptokenIssuance(sleVault->at(sfShareMPTID))); if (!sleVault || !sleIssuance) { jvResult[jss::error] = "entryNotFound"; diff --git a/src/xrpld/rpc/handlers/account/AccountInfo.cpp b/src/xrpld/rpc/handlers/account/AccountInfo.cpp index d0f45cbc6f..fba48ea93e 100644 --- a/src/xrpld/rpc/handlers/account/AccountInfo.cpp +++ b/src/xrpld/rpc/handlers/account/AccountInfo.cpp @@ -222,7 +222,7 @@ doAccountInfo(RPC::JsonContext& context) // This code will need to be revisited if in the future we support // multiple SignerLists on one account. - auto const sleSigners = ledger->read(keylet::signers(accountID)); + auto const sleSigners = ledger->read(keylet::signerList(accountID)); if (sleSigners) jvSignerList.append(sleSigners->getJson(JsonOptions::Values::None)); diff --git a/src/xrpld/rpc/handlers/account/AccountNFTs.cpp b/src/xrpld/rpc/handlers/account/AccountNFTs.cpp index 0eb91206f3..0249963908 100644 --- a/src/xrpld/rpc/handlers/account/AccountNFTs.cpp +++ b/src/xrpld/rpc/handlers/account/AccountNFTs.cpp @@ -74,8 +74,8 @@ doAccountNFTs(RPC::JsonContext& context) return RPC::invalidFieldError(jss::marker); } - auto const first = keylet::nftpage(keylet::nftpageMin(accountID), marker); - auto const last = keylet::nftpageMax(accountID); + auto const first = keylet::nftokenPage(keylet::nftokenPageMin(accountID), marker); + auto const last = keylet::nftokenPageMax(accountID); auto cp = ledger->read( Keylet(ltNFTOKEN_PAGE, ledger->succ(first.key, last.key.next()).value_or(last.key))); @@ -134,7 +134,7 @@ doAccountNFTs(RPC::JsonContext& context) obj[sfFlags.jsonName] = nft::getFlags(nftokenID); obj[sfIssuer.jsonName] = to_string(nft::getIssuer(nftokenID)); obj[sfNFTokenTaxon.jsonName] = nft::toUInt32(nft::getTaxon(nftokenID)); - obj[jss::nft_serial] = nft::getSerial(nftokenID); + obj[jss::nft_serial] = nft::getSequence(nftokenID); if (std::uint16_t const xferFee = {nft::getTransferFee(nftokenID)}) obj[sfTransferFee.jsonName] = xferFee; } diff --git a/src/xrpld/rpc/handlers/account/AccountObjects.cpp b/src/xrpld/rpc/handlers/account/AccountObjects.cpp index 08a7fbe44a..8375feb4e7 100644 --- a/src/xrpld/rpc/handlers/account/AccountObjects.cpp +++ b/src/xrpld/rpc/handlers/account/AccountObjects.cpp @@ -61,7 +61,7 @@ getAccountObjects( (!typeFilter.has_value() || typeMatchesFilter(typeFilter.value(), ltNFTOKEN_PAGE)) && dirIndex.isZero(); - Keylet const firstNFTPage = keylet::nftpageMin(account); + Keylet const firstNFTPage = keylet::nftokenPageMin(account); // we need to check the marker to see if it is an NFTTokenPage index. if (iterateNFTPages && entryIndex.isNonZero()) @@ -85,7 +85,7 @@ getAccountObjects( Keylet const first = entryIndex.isZero() ? firstNFTPage : Keylet{ltNFTOKEN_PAGE, entryIndex}; - Keylet const last = keylet::nftpageMax(account); + Keylet const last = keylet::nftokenPageMax(account); auto currentKey = ledger.succ(first.key, last.key.next()).value_or(last.key); diff --git a/src/xrpld/rpc/handlers/ledger/LedgerEntry.cpp b/src/xrpld/rpc/handlers/ledger/LedgerEntry.cpp index 236712f0c2..2dd7ae34d4 100644 --- a/src/xrpld/rpc/handlers/ledger/LedgerEntry.cpp +++ b/src/xrpld/rpc/handlers/ledger/LedgerEntry.cpp @@ -82,7 +82,7 @@ parseIndex(json::Value const& params, json::StaticString const fieldName, unsign if (index == jss::amendments.cStr()) return keylet::amendments().key; if (index == jss::fee.cStr()) - return keylet::fees().key; + return keylet::feeSettings().key; if (index == jss::nunl) return keylet::negativeUNL().key; if (index == jss::hashes) @@ -434,7 +434,7 @@ parseEscrow( return keylet::escrow(*id, *seq).key; } -auto const parseFeeSettings = fixed(keylet::fees()); +auto const parseFeeSettings = fixed(keylet::feeSettings()); static std::expected parseFixed( @@ -493,7 +493,7 @@ parseLoanBroker( if (!seq) return std::unexpected(seq.error()); - return keylet::loanbroker(*id, *seq).key; + return keylet::loanBroker(*id, *seq).key; } static std::expected @@ -555,7 +555,7 @@ parseMPTokenIssuance( "malformedMPTokenIssuance", fieldName, "Hash192"); } - return keylet::mptIssuance(*mptIssuanceID).key; + return keylet::mptokenIssuance(*mptIssuanceID).key; } static std::expected @@ -707,7 +707,7 @@ parseRippleState( "malformedCurrency", jss::currency, "Currency"); } - return keylet::line(*id1, *id2, uCurrency).key; + return keylet::trustLine(*id1, *id2, uCurrency).key; } static std::expected diff --git a/src/xrpld/rpc/handlers/orderbook/NFTOffersHelpers.h b/src/xrpld/rpc/handlers/orderbook/NFTOffersHelpers.h index 8529ec2d2c..42b99a0009 100644 --- a/src/xrpld/rpc/handlers/orderbook/NFTOffersHelpers.h +++ b/src/xrpld/rpc/handlers/orderbook/NFTOffersHelpers.h @@ -78,7 +78,7 @@ enumerateNFTOffers(RPC::JsonContext& context, uint256 const& nftId, Keylet const if (!startAfter.parseHex(marker.asString())) return rpcError(RpcInvalidParams); - auto const sle = ledger->read(keylet::nftoffer(startAfter)); + auto const sle = ledger->read(keylet::nftokenOffer(startAfter)); if (!sle || nftId != sle->getFieldH256(sfNFTokenID)) return rpcError(RpcInvalidParams);