From b3ef351fedb24e81fab57f433d25d70e9f5c25ba Mon Sep 17 00:00:00 2001
From: Bart <11445373+bthomee@users.noreply.github.com>
Date: Sun, 7 Jun 2026 17:09:18 -0400
Subject: [PATCH] Clang-tidy changes

---
 src/libxrpl/crypto/RFC1751.cpp                  |  1 +
 src/libxrpl/ledger/CanonicalTXSet.cpp           |  2 +-
 src/test/server/Server_test.cpp                 |  1 +
 src/xrpld/app/ledger/AcceptedLedger.cpp         | 17 ++++++-----------
 src/xrpld/app/ledger/detail/OpenLedger.cpp      |  1 +
 src/xrpld/overlay/detail/Cluster.cpp            |  1 +
 .../peerfinder/detail/PeerfinderManager.cpp     |  1 +
 7 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/libxrpl/crypto/RFC1751.cpp b/src/libxrpl/crypto/RFC1751.cpp
index 249b1c96d3..16482945d2 100644
--- a/src/libxrpl/crypto/RFC1751.cpp
+++ b/src/libxrpl/crypto/RFC1751.cpp
@@ -13,6 +13,7 @@
 #include <cstdint>
 #include <cstring>
 #include <string>
+#include <string_view>
 #include <vector>
 
 namespace xrpl {
diff --git a/src/libxrpl/ledger/CanonicalTXSet.cpp b/src/libxrpl/ledger/CanonicalTXSet.cpp
index ffb50adf40..d8a90292f7 100644
--- a/src/libxrpl/ledger/CanonicalTXSet.cpp
+++ b/src/libxrpl/ledger/CanonicalTXSet.cpp
@@ -43,7 +43,7 @@ void
 CanonicalTXSet::insert(std::shared_ptr<STTx const> txn)
 {
     Key key(accountKey(txn->getAccountID(sfAccount)), txn->getSeqProxy(), txn->getTransactionID());
-    map_.insert(std::make_pair(std::move(key), std::move(txn)));
+    map_.insert(std::make_pair(key, std::move(txn)));
 }
 
 std::shared_ptr<STTx const>
diff --git a/src/test/server/Server_test.cpp b/src/test/server/Server_test.cpp
index b969521a66..79b398bc0a 100644
--- a/src/test/server/Server_test.cpp
+++ b/src/test/server/Server_test.cpp
@@ -33,6 +33,7 @@
 #include <ostream>
 #include <stdexcept>
 #include <string>
+#include <string_view>
 #include <thread>
 #include <utility>
 #include <vector>
diff --git a/src/xrpld/app/ledger/AcceptedLedger.cpp b/src/xrpld/app/ledger/AcceptedLedger.cpp
index 400cb1256b..6da869198b 100644
--- a/src/xrpld/app/ledger/AcceptedLedger.cpp
+++ b/src/xrpld/app/ledger/AcceptedLedger.cpp
@@ -5,23 +5,18 @@
 
 #include <algorithm>
 #include <memory>
+#include <utility>
 
 namespace xrpl {
 
 AcceptedLedger::AcceptedLedger(std::shared_ptr<ReadView const> ledger) : ledger_(std::move(ledger))
 {
     transactions_.reserve(256);
-
-    auto insertAll = [&](auto const& txns) {
-        for (auto const& item : txns)
-        {
-            transactions_.emplace_back(
-                std::make_unique<AcceptedLedgerTx>(ledger_, item.first, item.second));
-        }
-    };
-
-    transactions_.reserve(256);
-    insertAll(ledger_->txs);
+    for (auto const& item : ledger_->txs)
+    {
+        transactions_.emplace_back(
+            std::make_unique<AcceptedLedgerTx>(ledger_, item.first, item.second));
+    }
 
     std::ranges::sort(transactions_, [](auto const& a, auto const& b) {
         return a->getTxnSeq() < b->getTxnSeq();
diff --git a/src/xrpld/app/ledger/detail/OpenLedger.cpp b/src/xrpld/app/ledger/detail/OpenLedger.cpp
index 20ea165366..60599c80d3 100644
--- a/src/xrpld/app/ledger/detail/OpenLedger.cpp
+++ b/src/xrpld/app/ledger/detail/OpenLedger.cpp
@@ -32,6 +32,7 @@
 #include <mutex>
 #include <sstream>
 #include <string>
+#include <string_view>
 #include <utility>
 #include <vector>
 
diff --git a/src/xrpld/overlay/detail/Cluster.cpp b/src/xrpld/overlay/detail/Cluster.cpp
index 3262f70bc6..7855c9647d 100644
--- a/src/xrpld/overlay/detail/Cluster.cpp
+++ b/src/xrpld/overlay/detail/Cluster.cpp
@@ -19,6 +19,7 @@
 #include <mutex>
 #include <optional>
 #include <string>
+#include <utility>
 
 namespace xrpl {
 
diff --git a/src/xrpld/peerfinder/detail/PeerfinderManager.cpp b/src/xrpld/peerfinder/detail/PeerfinderManager.cpp
index 9faeccf4ac..f51f3630eb 100644
--- a/src/xrpld/peerfinder/detail/PeerfinderManager.cpp
+++ b/src/xrpld/peerfinder/detail/PeerfinderManager.cpp
@@ -25,6 +25,7 @@
 #include <mutex>
 #include <optional>
 #include <string>
+#include <string_view>
 #include <utility>
 #include <vector>