ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize SQL query composition

Browse Source
This commit is contained in:
Nik Bougalis
2014-05-26 02:07:25 -07:00
parent 9ad9845d69
commit b35eabe161
1 changed files with 30 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/ripple_app/ledger/Ledger.cpp
View File

@@ -649,24 +649,37 @@ bool Ledger::saveValidatedLedger (bool current)
DeprecatedScopedLock dbLock (getApp().getTxnDB ()->getDBLock ()); DeprecatedScopedLock dbLock (getApp().getTxnDB ()->getDBLock ());
db->executeSQL ("BEGIN TRANSACTION;"); db->executeSQL ("BEGIN TRANSACTION;");
db->executeSQL (boost::str (deleteTrans1 % mLedgerSeq)); db->executeSQL (boost::str (deleteTrans1 % getLedgerSeq ()));
db->executeSQL (boost::str (deleteTrans2 % mLedgerSeq)); db->executeSQL (boost::str (deleteTrans2 % getLedgerSeq ()));
std::string const ledgerSeq (std::to_string (getLedgerSeq ()));
for (auto const& vt : aLedger->getMap ()) for (auto const& vt : aLedger->getMap ())
{ {
uint256 txID = vt.second->getTransactionID (); uint256 transactionID = vt.second->getTransactionID ();
getApp().getMasterTransaction ().inLedger (txID, mLedgerSeq);
db->executeSQL (boost::str (deleteAcctTrans % to_string (txID))); getApp().getMasterTransaction ().inLedger (
transactionID, getLedgerSeq ());
const std::vector<RippleAddress>& accts = vt.second->getAffected (); std::string const txnId (to_string (transactionID));
std::string const txnSeq (std::to_string (vt.second->getTxnSeq ()));
db->executeSQL (boost::str (deleteAcctTrans % transactionID));
auto const& accts = vt.second->getAffected ();
if (!accts.empty ()) if (!accts.empty ())
{ {
std::string sql = "INSERT INTO AccountTransactions (TransID, Account, LedgerSeq, TxnSeq) VALUES "; std::string sql ("INSERT INTO AccountTransactions "
bool first = true; "(TransID, Account, LedgerSeq, TxnSeq) VALUES ");
for (auto it = accts.begin (), end = accts.end (); it != end; ++it) // Try to make an educated guess on how much space we'll need
// for our arguments. In argument order we have:
// 64 + 34 + 10 + 10 = 118 + 10 extra = 128 bytes
sql.reserve (sql.length () + (accts.size () * 128));
bool first = true;
for (auto const& it : accts)
{ {
if (!first) if (!first)
sql += ", ('"; sql += ", ('";
@@ -676,18 +689,20 @@ bool Ledger::saveValidatedLedger (bool current)
first = false; first = false;
} }
sql += to_string (txID); sql += txnId;
sql += "','"; sql += "','";
sql += it->humanAccountID (); sql += it.humanAccountID ();
sql += "',"; sql += "',";
sql += beast::lexicalCastThrow <std::string> (getLedgerSeq ()); sql += ledgerSeq;
sql += ","; sql += ",";
sql += beast::lexicalCastThrow <std::string> (vt.second->getTxnSeq ()); sql += txnSeq;
sql += ")"; sql += ")";
} }
sql += ";"; sql += ";";
WriteLog (lsTRACE, Ledger) << "ActTx: " << sql; if (ShouldLog (lsTRACE, Ledger))
{
WriteLog (lsTRACE, Ledger) << "ActTx: " << sql;
}
db->executeSQL (sql); db->executeSQL (sql);
} }
else else