ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-07 02:36:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Align identifier naming with develop

Browse Source 
Restore NOLINT-protected headers and apply develop's identifier naming
conventions to files modified in this branch.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-05-05 15:30:12 +01:00
parent 875911f156
commit afc3835d0a
14 changed files with 1144 additions and 1116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libxrpl/tx/apply.cpp
View File

@@ -40,7 +40,7 @@ checkValidity(HashRouter& router, STTx const& tx, Rules const& rules)
auto const flags = router.getFlags(id);
// Ignore signature check on batch inner transactions
if (tx.isFlag(kTF_INNER_BATCH_TXN) && rules.enabled(featureBatch))
if (tx.isFlag(tfInnerBatchTxn) && rules.enabled(featureBatch))
{
// Defensive Check: These values are also checked in Batch::preflight
if (tx.isFieldPresent(sfTxnSignature) || !tx.getSigningPubKey().empty() ||
@@ -203,13 +203,13 @@ applyBatchTransactions(
if (!isTesSuccess(result.ter))
{
if ((mode & kTF_ALL_OR_NOTHING) != 0u)
if ((mode & tfAllOrNothing) != 0u)
return false;
if ((mode & kTF_UNTIL_FAILURE) != 0u)
if ((mode & tfUntilFailure) != 0u)
break;
}
else if ((mode & kTF_ONLY_ONE) != 0u)
else if ((mode & tfOnlyOne) != 0u)
{
break;
}

56
src/test/jtx/flags.h
View File

@@ -22,48 +22,48 @@ private:
{
switch (flag)
{
case kASF_REQUIRE_DEST:
mask_ |= LsfRequireDestTag;
case asfRequireDest:
mask_ |= lsfRequireDestTag;
break;
case kASF_REQUIRE_AUTH:
mask_ |= LsfRequireAuth;
case asfRequireAuth:
mask_ |= lsfRequireAuth;
break;
case kASF_DISALLOW_XRP:
mask_ |= LsfDisallowXrp;
case asfDisallowXRP:
mask_ |= lsfDisallowXRP;
break;
case kASF_DISABLE_MASTER:
mask_ |= LsfDisableMaster;
case asfDisableMaster:
mask_ |= lsfDisableMaster;
break;
// case asfAccountTxnID: // ???
case kASF_NO_FREEZE:
mask_ |= LsfNoFreeze;
case asfNoFreeze:
mask_ |= lsfNoFreeze;
break;
case kASF_GLOBAL_FREEZE:
mask_ |= LsfGlobalFreeze;
case asfGlobalFreeze:
mask_ |= lsfGlobalFreeze;
break;
case kASF_DEFAULT_RIPPLE:
mask_ |= LsfDefaultRipple;
case asfDefaultRipple:
mask_ |= lsfDefaultRipple;
break;
case kASF_DEPOSIT_AUTH:
mask_ |= LsfDepositAuth;
case asfDepositAuth:
mask_ |= lsfDepositAuth;
break;
case kASF_ALLOW_TRUST_LINE_CLAWBACK:
mask_ |= LsfAllowTrustLineClawback;
case asfAllowTrustLineClawback:
mask_ |= lsfAllowTrustLineClawback;
break;
case kASF_DISALLOW_INCOMING_CHECK:
mask_ |= LsfDisallowIncomingCheck;
case asfDisallowIncomingCheck:
mask_ |= lsfDisallowIncomingCheck;
break;
case kASF_DISALLOW_INCOMING_NF_TOKEN_OFFER:
mask_ |= LsfDisallowIncomingNfTokenOffer;
case asfDisallowIncomingNFTokenOffer:
mask_ |= lsfDisallowIncomingNFTokenOffer;
break;
case kASF_DISALLOW_INCOMING_PAY_CHAN:
mask_ |= LsfDisallowIncomingPayChan;
case asfDisallowIncomingPayChan:
mask_ |= lsfDisallowIncomingPayChan;
break;
case kASF_DISALLOW_INCOMING_TRUSTLINE:
mask_ |= LsfDisallowIncomingTrustline;
case asfDisallowIncomingTrustline:
mask_ |= lsfDisallowIncomingTrustline;
break;
case kASF_ALLOW_TRUST_LINE_LOCKING:
mask_ |= LsfAllowTrustLineLocking;
case asfAllowTrustLineLocking:
mask_ |= lsfAllowTrustLineLocking;
break;
default:
Throw<std::runtime_error>("unknown flag");

2
src/test/jtx/rpc.h
View File

@@ -35,7 +35,7 @@ public:
operator()(Env&, JTx& jt) const
{
// The RPC request should fail. RPC errors result in telENV_RPC_FAILED.
jt.ter = TelEnvRpcFailed;
jt.ter = telENV_RPC_FAILED;
if (code_)
{
auto const& errorInfo = RPC::getErrorInfo(*code_);