From ae475793d57dc62cc348524c035a53845dd9ef85 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 27 Apr 2026 14:45:12 +0100 Subject: [PATCH] docs(telemetry): mark Phase 5 deferred tasks and fix stale macro reference MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Mark Tasks 5.3 (alert definitions) and 5.6 (training materials) as "Deferred — post-MVP" in the implementation phases document to accurately reflect current delivery scope. Add status column to the Phase 5 task table. Also fix stale reference to XRPL_TRACE_* macros in Phase 4a section — the implementation uses SpanGuard factory methods. Co-Authored-By: Claude Opus 4.6 (1M context) --- OpenTelemetryPlan/06-implementation-phases.md | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/OpenTelemetryPlan/06-implementation-phases.md b/OpenTelemetryPlan/06-implementation-phases.md index 83a64a3cd1..c12fb8c211 100644 --- a/OpenTelemetryPlan/06-implementation-phases.md +++ b/OpenTelemetryPlan/06-implementation-phases.md @@ -224,8 +224,8 @@ See [Phase4_taskList.md](./Phase4_taskList.md) for the full spec and implementat **Objective**: Fill tracing gaps in the establish phase and establish cross-node correlation using deterministic trace IDs derived from `previousLedger.id()`. -**Approach**: Direct instrumentation in `Consensus.h`. Long-lived spans use -direct SpanGuard members; short-lived scoped spans use `XRPL_TRACE_*` macros. +**Approach**: Direct instrumentation in `Consensus.h` and `RCLConsensus.cpp`. +All spans use `SpanGuard` factory methods with `TraceCategory::Consensus` gating. ### Tasks @@ -288,15 +288,15 @@ See [Phase4_taskList.md § Phase 4b](./Phase4_taskList.md) for full design. ### Tasks -| Task | Description | -| ---- | ----------------------------- | -| 5.1 | Operator runbook | -| 5.2 | Grafana dashboards | -| 5.3 | Alert definitions | -| 5.4 | Collector deployment examples | -| 5.5 | Developer documentation | -| 5.6 | Training materials | -| 5.7 | Final integration testing | +| Task | Description | Status | +| ---- | ----------------------------- | ------------------- | +| 5.1 | Operator runbook | Complete | +| 5.2 | Grafana dashboards | Complete | +| 5.3 | Alert definitions | Deferred — post-MVP | +| 5.4 | Collector deployment examples | Complete | +| 5.5 | Developer documentation | Complete | +| 5.6 | Training materials | Deferred — post-MVP | +| 5.7 | Final integration testing | Complete | ---