ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-26 14:05:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unneeded copies in range some range for loops:

Browse Source 
clang 10 warns about an unneeded copy for these range for
loops (range-loop-construct warnings)
This commit is contained in:
seelabs
2020-03-24 22:25:41 -07:00
committed by manojsdoshi
parent d097819c52
commit ade5eb71cf
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/app/PayChan_test.cpp
View File

@@ -946,7 +946,7 @@ struct PayChan_test : public beast::unit_test::suite
Env env(*this); Env env(*this);
env.fund(XRP(10000), alice); env.fund(XRP(10000), alice);
for (auto const a : bobs) for (auto const& a : bobs)
{ {
env.fund(XRP(10000), a); env.fund(XRP(10000), a);
env.close(); env.close();
@@ -956,7 +956,7 @@ struct PayChan_test : public beast::unit_test::suite
// create a channel from alice to every bob account // create a channel from alice to every bob account
auto const settleDelay = 3600s; auto const settleDelay = 3600s;
auto const channelFunds = XRP(1); auto const channelFunds = XRP(1);
for (auto const b : bobs) for (auto const& b : bobs)
{ {
env(create(alice, b, channelFunds, settleDelay, alice.pk())); env(create(alice, b, channelFunds, settleDelay, alice.pk()));
} }
@@ -990,7 +990,7 @@ struct PayChan_test : public beast::unit_test::suite
auto const bobsB58 = [&bobs]() -> std::set<std::string> { auto const bobsB58 = [&bobs]() -> std::set<std::string> {
std::set<std::string> r; std::set<std::string> r;
for (auto const a : bobs) for (auto const& a : bobs)
r.insert(a.human()); r.insert(a.human());
return r; return r;
}(); }();

2
src/test/rpc/AccountCurrencies_test.cpp
View File

@@ -153,7 +153,7 @@ class AccountCurrencies_test : public beast::unit_test::suite
// does not change // does not change
env(trust(alice, gw["USD"](100), tfSetFreeze)); env(trust(alice, gw["USD"](100), tfSetFreeze));
result = env.rpc ("account_lines", alice.human()); result = env.rpc ("account_lines", alice.human());
for (auto const l : result[jss::lines]) for (auto const& l : result[jss::lines])
BEAST_EXPECT( BEAST_EXPECT(
l[jss::freeze].asBool() == (l[jss::currency] == "USD")); l[jss::freeze].asBool() == (l[jss::currency] == "USD"));
result = env.rpc ("json", "account_currencies", result = env.rpc ("json", "account_currencies",