ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-20 11:05:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor NodeStore

Browse Source
This commit is contained in:
Vinnie Falco
2013-07-16 08:07:18 -07:00
parent 664ed784e5
commit ad933bae9c
8 changed files with 202 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
modules/ripple_app/node/ripple_NodeStore.cpp
View File

@@ -193,7 +193,7 @@ NodeObject::pointer NodeStore::retrieve (uint256 const& hash)
if (m_fastBackend)
{
obj = m_fastBackend->retrieve (hash);
obj = retrieve (m_fastBackend, hash);
if (obj)
{
@@ -203,16 +203,26 @@ NodeObject::pointer NodeStore::retrieve (uint256 const& hash)
}
{
LoadEvent::autoptr event (getApp().getJobQueue ().getLoadEventAP (jtHO_READ, "HOS::retrieve"));
obj = m_backend->retrieve(hash);
// m_hooks->onRetrieveBegin ()
if (!obj)
// VFALCO TODO Why is this an autoptr? Why can't it just be a plain old object?
//
LoadEvent::autoptr event (getApp().getJobQueue ().getLoadEventAP (jtHO_READ, "HOS::retrieve"));
obj = retrieve (m_backend, hash);
if (obj == nullptr)
{
m_negativeCache.add (hash);
return obj;
// VFALCO TODO Eliminate return from middle of function
return obj; // VFALCO NOTE This is nullptr, why return obj?
}
}
// VFALCO NOTE What does this do?
m_cache.canonicalize (hash, obj);
if (m_fastBackend)
@@ -223,6 +233,13 @@ NodeObject::pointer NodeStore::retrieve (uint256 const& hash)
return obj;
}
//------------------------------------------------------------------------------
NodeObject::pointer NodeStore::retrieve (Backend* backend, uint256 const& hash)
{
return backend->retrieve (hash);
}
void NodeStore::importVisitor (
std::vector <NodeObject::pointer>& objects,
NodeObject::pointer object)