ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix mishandling of zero values. Must add to unit test!

Browse Source
This commit is contained in:
JoelKatz
2012-04-10 13:22:16 -07:00
parent b093110890
commit ad1ae6af23
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Amount.cpp
View File

@@ -33,7 +33,6 @@ STAmount* STAmount::construct(SerializerIterator& sit, const char *name)
{ {
uint64 value = sit.get64(); uint64 value = sit.get64();
int offset = static_cast<int>(value>>(64-8)); int offset = static_cast<int>(value>>(64-8));
offset-=142;
value&=~(255ull<<(64-8)); value&=~(255ull<<(64-8));
if(value==0) if(value==0)
{ {
@@ -42,6 +41,7 @@ STAmount* STAmount::construct(SerializerIterator& sit, const char *name)
} }
else else
{ {
offset-=142;
if( (value<cMinValue) || (value>cMaxValue) || (offset<cMinOffset) || (offset>cMaxOffset) ) if( (value<cMinValue) || (value>cMaxValue) || (offset<cMinOffset) || (offset>cMaxOffset) )
throw std::runtime_error("invalid currency value"); throw std::runtime_error("invalid currency value");
} }
@@ -58,7 +58,7 @@ std::string STAmount::getText() const
void STAmount::add(Serializer& s) const void STAmount::add(Serializer& s) const
{ {
uint64 v=value; uint64 v=value;
v+=(static_cast<uint64>(offset+142) << (64-8)); if(v!=0) v+=(static_cast<uint64>(offset+142) << (64-8));
s.add64(v); s.add64(v);
} }