From aa329d5084e59b4a32023ab07a4c1ae10bc35d4a Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 31 Mar 2026 13:48:05 +0100 Subject: [PATCH] fix(telemetry): move quorum/proposers attributes to consensus.accept span Move validation_quorum and proposers_validated attributes from consensus.accept.apply to consensus.accept span to match the design spec. Both values are available in onAccept() scope. Co-Authored-By: Claude Opus 4.6 (1M context) --- src/xrpld/app/consensus/RCLConsensus.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/xrpld/app/consensus/RCLConsensus.cpp b/src/xrpld/app/consensus/RCLConsensus.cpp index cc0077b364..021ad12aaf 100644 --- a/src/xrpld/app/consensus/RCLConsensus.cpp +++ b/src/xrpld/app/consensus/RCLConsensus.cpp @@ -455,6 +455,10 @@ RCLConsensus::Adaptor::onAccept( XRPL_TRACE_SET_ATTR("xrpl.consensus.proposers", static_cast(result.proposers)); XRPL_TRACE_SET_ATTR( "xrpl.consensus.round_time_ms", static_cast(result.roundTime.read().count())); + XRPL_TRACE_SET_ATTR( + "xrpl.consensus.validation_quorum", static_cast(app_.getValidators().quorum())); + XRPL_TRACE_SET_ATTR( + "xrpl.consensus.proposers_validated", static_cast(result.proposers)); app_.getJobQueue().addJob( jtACCEPT, @@ -536,10 +540,6 @@ RCLConsensus::Adaptor::doAccept( XRPL_TRACE_SET_ATTR("xrpl.consensus.proposing", proposing); XRPL_TRACE_SET_ATTR( "xrpl.consensus.round_time_ms", static_cast(result.roundTime.read().count())); - XRPL_TRACE_SET_ATTR( - "xrpl.consensus.validation_quorum", static_cast(app_.getValidators().quorum())); - XRPL_TRACE_SET_ATTR( - "xrpl.consensus.proposers_validated", static_cast(result.proposers)); // Parent ledger's close time — enables computing close-time deltas across // consecutive rounds without correlating separate spans. XRPL_TRACE_SET_ATTR(