From a9e4006591d76e588eacce0c283e8bf5a80380ca Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Wed, 13 May 2026 18:16:16 +0100
Subject: [PATCH] fix(telemetry): address clang-tidy CI failures on phase10
 beast test

- Add missing direct includes (contract.h, Log.h, Journal.h, uint256.h,
  suite.h, io_context.hpp, optional, stdexcept, string).
- Replace broad unit_test.h with specific unit_test/suite.h.
- Concatenate nested namespaces (xrpl::test).
- Add [[nodiscard]] to getOpenLedger/isStopping/getTrapTxID overrides.
- Make const-eligible variables const (Journal j, registry in
  disabled_construction test).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../scripts/levelization/results/ordering.txt |  1 +
 src/test/telemetry/MetricsRegistry_test.cpp   | 36 +++++++++++--------
 2 files changed, 23 insertions(+), 14 deletions(-)

diff --git a/.github/scripts/levelization/results/ordering.txt b/.github/scripts/levelization/results/ordering.txt
index b829510b60..0759def1dc 100644
--- a/.github/scripts/levelization/results/ordering.txt
+++ b/.github/scripts/levelization/results/ordering.txt
@@ -186,6 +186,7 @@ test.shamap > xrpl.basics
 test.shamap > xrpl.nodestore
 test.shamap > xrpl.protocol
 test.shamap > xrpl.shamap
+test.telemetry > xrpl.basics
 test.telemetry > xrpl.core
 test.telemetry > xrpld.telemetry
 test.toplevel > test.csf
diff --git a/src/test/telemetry/MetricsRegistry_test.cpp b/src/test/telemetry/MetricsRegistry_test.cpp
index d05709daf7..421c2e27ec 100644
--- a/src/test/telemetry/MetricsRegistry_test.cpp
+++ b/src/test/telemetry/MetricsRegistry_test.cpp
@@ -20,11 +20,20 @@
 
 #include <xrpld/telemetry/MetricsRegistry.h>
 
-#include <xrpl/beast/unit_test.h>
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/unit_test/suite.h>
+#include <xrpl/beast/utility/Journal.h>
 #include <xrpl/core/ServiceRegistry.h>
 
-namespace xrpl {
-namespace test {
+#include <boost/asio/io_context.hpp>
+
+#include <optional>
+#include <stdexcept>
+#include <string>
+
+namespace xrpl::test {
 
 /** Minimal mock ServiceRegistry for MetricsRegistry testing.
 
@@ -194,12 +203,12 @@ public:
     {
         throwUnimplemented();
     }
-    OpenLedger&
+    [[nodiscard]] OpenLedger&
     getOpenLedger() override
     {
         throwUnimplemented();
     }
-    OpenLedger const&
+    [[nodiscard]] OpenLedger const&
     getOpenLedger() const override
     {
         throwUnimplemented();
@@ -249,7 +258,7 @@ public:
     {
         return nullptr;
     }
-    bool
+    [[nodiscard]] bool
     isStopping() const override
     {
         return false;
@@ -269,7 +278,7 @@ public:
     {
         throwUnimplemented();
     }
-    std::optional<uint256> const&
+    [[nodiscard]] std::optional<uint256> const&
     getTrapTxID() const override
     {
         static std::optional<uint256> const empty;
@@ -295,10 +304,10 @@ class MetricsRegistry_test : public beast::unit_test::suite
         testcase("Disabled construction");
 
         MockServiceRegistry mockApp;
-        beast::Journal j(beast::Journal::getNullSink());
+        beast::Journal const j(beast::Journal::getNullSink());
 
         // Construct with enabled=false; should be a no-op.
-        telemetry::MetricsRegistry registry(false, mockApp, j);
+        telemetry::MetricsRegistry const registry(false, mockApp, j);
         BEAST_EXPECT(!registry.isEnabled());
     }
 
@@ -308,7 +317,7 @@ class MetricsRegistry_test : public beast::unit_test::suite
         testcase("Disabled start/stop");
 
         MockServiceRegistry mockApp;
-        beast::Journal j(beast::Journal::getNullSink());
+        beast::Journal const j(beast::Journal::getNullSink());
 
         telemetry::MetricsRegistry registry(false, mockApp, j);
 
@@ -328,7 +337,7 @@ class MetricsRegistry_test : public beast::unit_test::suite
         testcase("Disabled recording methods");
 
         MockServiceRegistry mockApp;
-        beast::Journal j(beast::Journal::getNullSink());
+        beast::Journal const j(beast::Journal::getNullSink());
 
         telemetry::MetricsRegistry registry(false, mockApp, j);
         registry.start("http://localhost:4318/v1/metrics");
@@ -352,7 +361,7 @@ class MetricsRegistry_test : public beast::unit_test::suite
         testcase("Destructor calls stop");
 
         MockServiceRegistry mockApp;
-        beast::Journal j(beast::Journal::getNullSink());
+        beast::Journal const j(beast::Journal::getNullSink());
 
         {
             // Let the destructor handle cleanup.
@@ -377,5 +386,4 @@ public:
 
 BEAST_DEFINE_TESTSUITE(MetricsRegistry, telemetry, xrpl);
 
-}  // namespace test
-}  // namespace xrpl
+}  // namespace xrpl::test