ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better error messages for out of range integral values

Browse Source 
* This change passes detailed error messages from the JSON parser
  on the server side, back to the client for inclusion into the
  reply's error message.

* Errors originating from the server's inability to parse are
  reclassified from rpcINTERNAL to rpcINVALID_PARAMS.
This commit is contained in:
Howard Hinnant
2018-01-17 17:48:58 -05:00
committed by seelabs
parent 35cc341544
commit a8481e369d
4 changed files with 34 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/rpc/LedgerRPC_test.cpp
View File

@@ -121,6 +121,20 @@ class LedgerRPC_test : public beast::unit_test::suite
checkErrorValue(jrr, "invalidParams", "Invalid parameters.");
}
{
// Request a ledger with a very large (double) sequence.
auto const ret = env.rpc (
"json", "ledger", "{ \"ledger_index\" : 2e15 }");
BEAST_EXPECT (RPC::contains_error(ret));
BEAST_EXPECT (ret[jss::error_message] == "Invalid parameters.");
}
{
// Request a ledger with very large (integer) sequence.
auto const ret = env.rpc (
"json", "ledger", "{ \"ledger_index\" : 1000000000000000 }");
checkErrorValue(ret, "invalidParams", "Invalid parameters.");
}
}
void testLedgerCurrent()

2
src/test/server/ServerStatus_test.cpp
View File

@@ -893,7 +893,7 @@ class ServerStatus_test :
boost::beast::http::response<boost::beast::http::string_body> resp;
doHTTPRequest(env, yield, false, resp, ec, "{}");
BEAST_EXPECT(resp.result() == boost::beast::http::status::bad_request);
BEAST_EXPECT(resp.body() == "Unable to parse request\r\n");
BEAST_EXPECT(resp.body() == "Unable to parse request: \r\n");
}
Json::Value jv;