From a789f6ccf588341d27b58baabf7bce24b2462a18 Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Thu, 14 May 2026 16:53:40 +0100
Subject: [PATCH] docs(telemetry): fix stale rpc.request refs + drop unparsed
 exporter key in TESTING.md

Follow-up to the dashboard cleanup on this branch. Caught additional sites
in TESTING.md that still reference the never-emitted `rpc.request` span:

- TraceQL query examples in Step 5 "Verify traces in Tempo" now filter on
  `name="rpc.http_request"` (the real emitted name).
- Expected-spans table replaces `rpc.request` with `rpc.http_request`.
- Query loop under the Prometheus verification section now iterates over
  the full set of emitted RPC entry-point names
  (`rpc.http_request`, `rpc.ws_upgrade`, `rpc.ws_message`, `rpc.process`).

Also drop `exporter=otlp_http` from the sample telemetry config block.
`TelemetryConfig.cpp` does not parse an `exporter` key in any phase through
Phase 8; only OTLP/HTTP is wired up, so the line is either a silently
ignored no-op or misleading documentation.
---
 docker/telemetry/TESTING.md | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/docker/telemetry/TESTING.md b/docker/telemetry/TESTING.md
index 1346f2d49c..fd20121f4b 100644
--- a/docker/telemetry/TESTING.md
+++ b/docker/telemetry/TESTING.md
@@ -123,7 +123,7 @@ curl -s "$TEMPO/api/v2/search/tag/resource.service.name/values" | jq '.tagValues
 
 # Check RPC spans
 curl -s "$TEMPO/api/search" \
-  --data-urlencode 'q={resource.service.name="xrpld" && name="rpc.request"}' \
+  --data-urlencode 'q={resource.service.name="xrpld" && name="rpc.http_request"}' \
   --data-urlencode 'limit=5' | jq '.traces | length'
 
 curl -s "$TEMPO/api/search" \
@@ -159,7 +159,7 @@ rm -rf data/
 
 | Span Name                   | Expected | Notes                         |
 | --------------------------- | -------- | ----------------------------- |
-| `rpc.request`               | Yes      | Every HTTP RPC call           |
+| `rpc.http_request`          | Yes      | Every HTTP RPC call           |
 | `rpc.process`               | Yes      | Every RPC processing          |
 | `rpc.command.server_info`   | Yes      | server_info RPC               |
 | `rpc.command.server_state`  | Yes      | server_state RPC              |
@@ -285,7 +285,6 @@ online_delete=256
 [telemetry]
 enabled=1
 endpoint=http://localhost:4318/v1/traces
-exporter=otlp_http
 sampling_ratio=1.0
 batch_size=512
 batch_delay_ms=2000
@@ -412,7 +411,7 @@ TEMPO="http://localhost:3200"
 curl -s "$TEMPO/api/v2/search/tag/resource.service.name/values" | jq '.tagValues[].value'
 
 # Query traces by operation
-for op in "rpc.request" "rpc.process" \
+for op in "rpc.http_request" "rpc.ws_upgrade" "rpc.ws_message" "rpc.process" \
           "rpc.command.server_info" "rpc.command.server_state" "rpc.command.ledger" \
           "tx.process" "tx.receive" "tx.apply" \
           "consensus.proposal.send" "consensus.ledger_close" \