Port test/transaction_ordering_test.js to C++

src/ripple/app/tests/Transaction_ordering_test.cpp

@@ -0,0 +1,179 @@
+//------------------------------------------------------------------------------
+/*
+    This file is part of rippled: https://github.com/ripple/rippled
+    Copyright (c) 2012, 2013 Ripple Labs Inc.
+    Permission to use, copy, modify, and/or distribute this software for any
+    purpose  with  or without fee is hereby granted, provided that the above
+    copyright notice and this permission notice appear in all copies.
+    THE  SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+    WITH  REGARD  TO  THIS  SOFTWARE  INCLUDING  ALL  IMPLIED  WARRANTIES  OF
+    MERCHANTABILITY  AND  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+    ANY  SPECIAL ,  DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+    WHATSOEVER  RESULTING  FROM  LOSS  OF USE, DATA OR PROFITS, WHETHER IN AN
+    ACTION  OF  CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+*/
+//==============================================================================
+
+#include <BeastConfig.h>
+#include <ripple/core/JobQueue.h>
+#include <ripple/protocol/ErrorCodes.h>
+#include <ripple/test/jtx.h>
+
+namespace ripple {
+namespace test {
+
+struct Transaction_ordering_test : public beast::unit_test::suite
+{
+    template <class Ftest>
+    void submitWait(jtx::Env& env, jtx::JTx const& tx, Ftest&& test)
+    {
+        using namespace std::chrono_literals;
+
+        std::condition_variable cv;
+        env.app().getJobQueue().postCoro(
+            jtCLIENT, "Coroutine-Test",
+            [&](std::shared_ptr<JobCoro> jc)
+        {
+            env(tx);
+            cv.notify_one();
+        });
+
+        {
+            std::mutex m;
+            std::unique_lock<std::mutex> lk(m);
+            // If stepping through this test in a debugger,
+            // make the timeout much longer, or use
+            //cv.wait(lk, test);
+            expect(cv.wait_for(lk, 2s, test));
+        }
+    }
+
+    void testCorrectOrder()
+    {
+        using namespace jtx;
+
+        Env env(*this);
+        auto const alice = Account("alice");
+        env.fund(XRP(1000), noripple(alice));
+
+        auto const aliceSequence = env.seq(alice);
+
+        auto const tx1 = env.jt(noop(alice), seq(aliceSequence));
+        auto const tx2 = env.jt(noop(alice), seq(aliceSequence + 1),
+            json(R"({"LastLedgerSequence":7})"));
+
+        env(tx1);
+        env.close();
+        expect(env.seq(alice) == aliceSequence + 1);
+        env(tx2);
+        env.close();
+        expect(env.seq(alice) == aliceSequence + 2);
+
+        env.close();
+
+        {
+            auto const result = env.rpc("tx", to_string(tx1.stx->getTransactionID()));
+            expect(result.first == rpcSUCCESS);
+            expect(result.second["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+        {
+            auto const result = env.rpc("tx", to_string(tx2.stx->getTransactionID()));
+            expect(result.first == rpcSUCCESS);
+            expect(result.second["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+    }
+
+    void testIncorrectOrder()
+    {
+        using namespace jtx;
+
+        Env env(*this);
+        env.app().getJobQueue().setThreadCount(0, false);
+        auto const alice = Account("alice");
+        env.fund(XRP(1000), noripple(alice));
+
+        auto const aliceSequence = env.seq(alice);
+
+        auto const tx1 = env.jt(noop(alice), seq(aliceSequence));
+        auto const tx2 = env.jt(noop(alice), seq(aliceSequence + 1),
+            json(R"({"LastLedgerSequence":7})"));
+
+        env(tx2, ter(terPRE_SEQ));
+        expect(env.seq(alice) == aliceSequence);
+        submitWait(env, tx1,
+            [&]()
+            {
+                return env.seq(alice) == aliceSequence + 2;
+            });
+        expect(env.seq(alice) == aliceSequence + 2);
+
+        env.close();
+
+        {
+            auto const result = env.rpc("tx", to_string(tx1.stx->getTransactionID()));
+            expect(result.first == rpcSUCCESS);
+            expect(result.second["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+        {
+            auto const result = env.rpc("tx", to_string(tx2.stx->getTransactionID()));
+            expect(result.first == rpcSUCCESS);
+            expect(result.second["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+    }
+
+    void testIncorrectOrderMultipleIntermediaries()
+    {
+        using namespace jtx;
+
+        Env env(*this);
+        env.app().getJobQueue().setThreadCount(0, false);
+        auto const alice = Account("alice");
+        env.fund(XRP(1000), noripple(alice));
+
+        auto const aliceSequence = env.seq(alice);
+
+        std::vector<JTx> tx;
+        for (auto i = 0; i < 5; ++i)
+        {
+            tx.emplace_back(
+                env.jt(noop(alice), seq(aliceSequence + i),
+                    json(R"({"LastLedgerSequence":7})"))
+            );
+        }
+
+        for (auto i = 1; i < 5; ++i)
+        {
+            env(tx[i], ter(terPRE_SEQ));
+            expect(env.seq(alice) == aliceSequence);
+        }
+
+        submitWait(env, tx[0],
+            [&]()
+            {
+                return env.seq(alice) == aliceSequence + 5;
+            });
+        expect(env.seq(alice) == aliceSequence + 5);
+
+        env.close();
+
+        for (auto i = 0; i < 5; ++i)
+        {
+            auto const result = env.rpc("tx", to_string(tx[i].stx->getTransactionID()));
+            expect(result.first == rpcSUCCESS);
+            expect(result.second["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+    }
+
+    void run() override
+    {
+        testCorrectOrder();
+        testIncorrectOrder();
+        testIncorrectOrderMultipleIntermediaries();
+    }
+};
+
+BEAST_DEFINE_TESTSUITE(Transaction_ordering,app,ripple);
+
+} // test
+} // ripple

src/ripple/unity/app_tests.cpp

@@ -33,5 +33,6 @@
 #include <ripple/app/tests/SetAuth_test.cpp>
 #include <ripple/app/tests/OversizeMeta_test.cpp>
 #include <ripple/app/tests/Taker.test.cpp>
+#include <ripple/app/tests/Transaction_ordering_test.cpp>
 #include <ripple/app/tests/TxQ_test.cpp>
 #include <ripple/app/tests/ValidatorList_test.cpp>