ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-24 04:55:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: change error for invalid feature param in feature RPC (#5063)

Browse Source 
* Returns an "Invalid parameters" error if the `feature` parameter is provided and is not a string.
This commit is contained in:
Mayukha Vadari
2024-07-30 11:18:25 -04:00
committed by GitHub
parent 2820feb02a
commit a39720e94a
2 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/test/rpc/Feature_test.cpp
View File

@@ -229,9 +229,28 @@ class Feature_test : public beast::unit_test::suite
using namespace test::jtx; using namespace test::jtx;
Env env{*this}; Env env{*this};
auto testInvalidParam = [&](auto const& param) {
Json::Value params;
params[jss::feature] = param;
auto jrr =
env.rpc("json", "feature", to_string(params))[jss::result];
BEAST_EXPECT(jrr[jss::error] == "invalidParams");
BEAST_EXPECT(jrr[jss::error_message] == "Invalid parameters.");
};
testInvalidParam(1);
testInvalidParam(1.1);
testInvalidParam(true);
testInvalidParam(Json::Value(Json::nullValue));
testInvalidParam(Json::Value(Json::objectValue));
testInvalidParam(Json::Value(Json::arrayValue));
{
auto jrr = env.rpc("feature", "AllTheThings")[jss::result]; auto jrr = env.rpc("feature", "AllTheThings")[jss::result];
BEAST_EXPECT(jrr[jss::error] == "badFeature"); BEAST_EXPECT(jrr[jss::error] == "badFeature");
BEAST_EXPECT(jrr[jss::error_message] == "Feature unknown or invalid."); BEAST_EXPECT(
jrr[jss::error_message] == "Feature unknown or invalid.");
}
} }
void void

9
src/xrpld/rpc/handlers/Feature1.cpp
View File

@@ -38,6 +38,15 @@ doFeature(RPC::JsonContext& context)
if (context.app.config().reporting()) if (context.app.config().reporting())
return rpcError(rpcREPORTING_UNSUPPORTED); return rpcError(rpcREPORTING_UNSUPPORTED);
if (context.params.isMember(jss::feature))
{
// ensure that the `feature` param is a string
if (!context.params[jss::feature].isString())
{
return rpcError(rpcINVALID_PARAMS);
}
}
bool const isAdmin = context.role == Role::ADMIN; bool const isAdmin = context.role == Role::ADMIN;
// Get majority amendment status // Get majority amendment status
majorityAmendments_t majorities; majorityAmendments_t majorities;