ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Redesign stoppable object pattern

Browse Source
This commit is contained in:
John Freeman
2021-05-26 17:45:41 -05:00
committed by manojsdoshi
parent c10c0be11b
commit a2a37a928a
92 changed files with 781 additions and 2460 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/test/app/LedgerReplay_test.cpp
View File

@@ -169,7 +169,7 @@ public:
}
virtual void
onStop() override
stop() override
{
}
@@ -564,7 +564,6 @@ public:
inboundBhvr)
, serverMsgHandler(server.app, server.app.getLedgerReplayer())
, clientMsgHandler(env.app(), replayer)
, stopableParent("replayerStopParent")
, replayer(
env.app(),
inboundLedgers,
@@ -572,8 +571,7 @@ public:
clientMsgHandler,
serverMsgHandler,
behavior,
peerFeature),
stopableParent)
peerFeature))
{
}
@@ -800,7 +798,6 @@ public:
MagicInboundLedgers inboundLedgers;
LedgerReplayMsgHandler serverMsgHandler;
LedgerReplayMsgHandler clientMsgHandler;
RootStoppable stopableParent;
LedgerReplayer replayer;
};
@@ -848,7 +845,7 @@ struct NetworkOfTwo
* -- replay a range of ledgers and fallback to InboundLedgers because
* peers do not support ProtocolFeature::LedgerReplay
* -- replay a range of ledgers and the network drops or repeats messages
* -- call onStop() and the tasks and subtasks are removed
* -- call stop() and the tasks and subtasks are removed
* -- process a bad skip list
* -- process a bad ledger delta
* -- replay ledger ranges with different overlaps
@@ -1229,9 +1226,9 @@ struct LedgerReplayer_test : public beast::unit_test::suite
}
void
testOnStop()
testStop()
{
testcase("onStop before timeout");
testcase("stop before timeout");
int totalReplay = 3;
NetworkOfTwo net(
*this,
@@ -1253,9 +1250,8 @@ struct LedgerReplayer_test : public beast::unit_test::suite
TaskStatus::NotDone,
deltaStatuses));
// onStop
BEAST_EXPECT(net.client.countsAsExpected(1, 1, 0));
net.client.replayer.onStop();
net.client.replayer.stop();
BEAST_EXPECT(net.client.countsAsExpected(0, 0, 0));
}
@@ -1441,7 +1437,7 @@ struct LedgerReplayer_test : public beast::unit_test::suite
testPeerSetBehavior(PeerSetBehavior::Good);
testPeerSetBehavior(PeerSetBehavior::Drop50);
testPeerSetBehavior(PeerSetBehavior::Repeat);
testOnStop();
testStop();
testSkipListBadReply();
testLedgerDeltaBadReply();
testLedgerReplayOverlap();