From a0eeb8eb9e77fcdd57f05b56d9400885ac1b40fc Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Tue, 31 Mar 2026 20:15:46 +0100
Subject: [PATCH] fix(telemetry): fix Windows WinSock.h header ordering in
 MetricsRegistry test

Pre-include boost/asio/detail/socket_types.hpp on Windows before OTel
SDK headers to ensure WinSock2.h is included before WinSock.h.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src/test/telemetry/MetricsRegistry_test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/test/telemetry/MetricsRegistry_test.cpp b/src/test/telemetry/MetricsRegistry_test.cpp
index 6b0b02cfce..d05709daf7 100644
--- a/src/test/telemetry/MetricsRegistry_test.cpp
+++ b/src/test/telemetry/MetricsRegistry_test.cpp
@@ -11,6 +11,13 @@
     unconditionally.
 */
 
+// On Windows, WinSock2.h must be included before WinSock.h.  OTel SDK
+// headers transitively pull in WinSock.h, so we pre-include Boost.Asio's
+// socket header to establish the correct ordering.
+#ifdef _WIN32
+#include <boost/asio/detail/socket_types.hpp>
+#endif
+
 #include <xrpld/telemetry/MetricsRegistry.h>
 
 #include <xrpl/beast/unit_test.h>