From 9e4bc87146ab7c1fd1f244d9bcc3939bf4d53e9e Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Thu, 9 Oct 2025 16:05:45 -0400 Subject: [PATCH] clean up --- src/test/app/NFToken_test.cpp | 5 ++--- src/xrpld/app/tx/detail/NFTokenAcceptOffer.cpp | 7 +++---- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/test/app/NFToken_test.cpp b/src/test/app/NFToken_test.cpp index 08e18804bd..5cd9eff4f5 100644 --- a/src/test/app/NFToken_test.cpp +++ b/src/test/app/NFToken_test.cpp @@ -3453,14 +3453,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite { std::uint32_t const expiration = lastClose(env) + 25; - auto const buyerSeq0 = env.seq(buyer); - uint256 const offer0 = keylet::nftoffer(buyer, buyerSeq0).key; + uint256 const offer0 = keylet::nftoffer(buyer, env.seq(buyer);).key; env(token::createOffer(buyer, nftokenID0, drops(1)), token::owner(minter), token::expiration(expiration)); buyerCount++; - auto const buyerSeq1 = env.seq(buyer); + uint256 const offer1 = keylet::nftoffer(buyer, env.seq(buyer)).key; uint256 const offer1 = keylet::nftoffer(buyer, buyerSeq1).key; env(token::createOffer(buyer, nftokenID1, drops(1)), token::owner(minter), diff --git a/src/xrpld/app/tx/detail/NFTokenAcceptOffer.cpp b/src/xrpld/app/tx/detail/NFTokenAcceptOffer.cpp index 7448677a00..5b737c8665 100644 --- a/src/xrpld/app/tx/detail/NFTokenAcceptOffer.cpp +++ b/src/xrpld/app/tx/detail/NFTokenAcceptOffer.cpp @@ -539,7 +539,7 @@ NFTokenAcceptOffer::doApply() bool foundExpired = false; auto const deleteOfferIfExpired = - [this, &foundExpired](std::shared_ptr offer) -> TER { + [this, &foundExpired](std::shared_ptr const& offer) -> TER { if (offer && hasExpired(view(), (*offer)[~sfExpiration])) { JLOG(j_.trace()) @@ -547,9 +547,8 @@ NFTokenAcceptOffer::doApply() if (!nft::deleteTokenOffer(view(), offer)) { // LCOV_EXCL_START - JLOG(j_.fatal()) - << "Unable to delete expired offer '" - << to_string(offer->key()) << "': ignoring"; + JLOG(j_.fatal()) << "Unable to delete expired offer '" + << offer->key() << "': ignoring"; return tecINTERNAL; // LCOV_EXCL_STOP }