diff --git a/.github/scripts/strategy-matrix/README.md b/.github/scripts/strategy-matrix/README.md index fc1ff9b2f2..1bf2e48bb2 100644 --- a/.github/scripts/strategy-matrix/README.md +++ b/.github/scripts/strategy-matrix/README.md @@ -44,7 +44,7 @@ Also note that to create a Docker image we ideally build on both AMD64 and ARM64 to create a multi-arch image. Both configs should therefore be triggered by the same event. However, as the script outputs individual configs, the workflow must be able to run both builds separately and then merge the -single-arch images afterwards into a multi-arch image. +single-arch images afterward into a multi-arch image. ### MacOS diff --git a/.github/scripts/strategy-matrix/generate_test.py b/.github/scripts/strategy-matrix/generate_test.py index 7746c41816..615c81e65a 100644 --- a/.github/scripts/strategy-matrix/generate_test.py +++ b/.github/scripts/strategy-matrix/generate_test.py @@ -458,9 +458,7 @@ def test_generate_configs(macos_distro, windows_distro, linux_distro): ] -def test_generate_configs_raises_on_duplicate_configs( - macos_distro, windows_distro, linux_distro -): +def test_generate_configs_raises_on_duplicate_configs(macos_distro): trigger = Trigger.COMMIT distros = [macos_distro, macos_distro] diff --git a/.github/scripts/strategy-matrix/helpers/unique.py b/.github/scripts/strategy-matrix/helpers/unique.py index 469f60f839..4cabd744ea 100644 --- a/.github/scripts/strategy-matrix/helpers/unique.py +++ b/.github/scripts/strategy-matrix/helpers/unique.py @@ -6,7 +6,7 @@ from typing import Any def is_unique(items: list[Any]) -> bool: """Check if a list of dataclass objects contains only unique items. - As the items may not be hashable, we convert them to json strings first, and + As the items may not be hashable, we convert them to JSON strings first, and then check if the list of strings is the same size as the set of strings. Args: