address review comments

.github/workflows/manual-package.yml

@@ -11,10 +11,6 @@ on:
           - deb
           - rpm
           - both
-      artifact_run_id:
-        description: "Run ID to download binary artifact from (leave empty for latest on this branch)"
-        required: false
-        type: string
       version:
         description: "Version override (leave empty to auto-detect)"
         required: false

.github/workflows/on-trigger.yml

@@ -79,7 +79,7 @@ jobs:
     strategy:
       fail-fast: ${{ github.event_name == 'merge_group' }}
       matrix:
-        os: [linux]
+        os: [linux, macos, windows]
     with:
       # Enable ccache only for events targeting the XRPLF repository, since
       # other accounts will not have access to our remote cache storage.

.github/workflows/reusable-package.yml

@@ -45,25 +45,32 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Download pre-built binary
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@fa0a91b85d4f404e444306234e96a603a47e3d4d # v4.1.8
         with:
           name: ${{ inputs.artifact_name }}
           path: ${{ env.BUILD_DIR }}
 
       - name: Make binary executable
-        run: chmod +x ${{ env.BUILD_DIR }}/xrpld
+        run: chmod +x "${BUILD_DIR}/xrpld"
 
       - name: Generate RPM spec from template
         if: ${{ inputs.pkg_type == 'rpm' }}
+        env:
+          PKG_VERSION: ${{ inputs.version }}
+          PKG_RELEASE: ${{ inputs.pkg_release }}
         run: |
-          mkdir -p ${{ env.BUILD_DIR }}/package/rpm
-          sed -e "s/@xrpld_version@/${{ inputs.version }}/" \
-              -e "s/@pkg_release@/${{ inputs.pkg_release }}/" \
-            package/rpm/xrpld.spec.in > ${{ env.BUILD_DIR }}/package/rpm/xrpld.spec
+          mkdir -p "${BUILD_DIR}/package/rpm"
+          sed -e "s/@xrpld_version@/${PKG_VERSION}/" \
+              -e "s/@pkg_release@/${PKG_RELEASE}/" \
+            package/rpm/xrpld.spec.in > "${BUILD_DIR}/package/rpm/xrpld.spec"
 
       - name: Build package
+        env:
+          PKG_TYPE: ${{ inputs.pkg_type }}
+          PKG_VERSION: ${{ inputs.version }}
+          PKG_RELEASE: ${{ inputs.pkg_release }}
         run: |
-          ./package/build_pkg.sh ${{ inputs.pkg_type }} . ${{ env.BUILD_DIR }} "${{ inputs.version }}" "${{ inputs.pkg_release }}"
+          ./package/build_pkg.sh "$PKG_TYPE" . "$BUILD_DIR" "$PKG_VERSION" "$PKG_RELEASE"
 
       - name: Upload package artifact
         uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0