From 9b3d0d73aa2cf687bcce2e52ba62430e67c5e533 Mon Sep 17 00:00:00 2001 From: Vinnie Falco Date: Mon, 5 Aug 2013 09:19:34 -0700 Subject: [PATCH] Fatal error in ~Thread if thread still running (undefined behavior) --- Subtrees/beast/modules/beast_core/threads/beast_Thread.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Subtrees/beast/modules/beast_core/threads/beast_Thread.cpp b/Subtrees/beast/modules/beast_core/threads/beast_Thread.cpp index b2c0184892..eb6167740d 100644 --- a/Subtrees/beast/modules/beast_core/threads/beast_Thread.cpp +++ b/Subtrees/beast/modules/beast_core/threads/beast_Thread.cpp @@ -40,10 +40,7 @@ Thread::~Thread() To avoid this type of nastiness, always make sure you call stopThread() before or during your subclass's destructor. */ - bassert (! isThreadRunning()); - - if (isThreadRunning()) - FatalError ("Thread is still running", __FILE__, __LINE__); + fatal_require (! isThreadRunning()); } //==============================================================================