From b1af0a9511e45562e3a26b9d440eac219e8bd92e Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 7 Jul 2026 19:43:40 +0100 Subject: [PATCH 1/5] docs(telemetry): remove Phase reference from tempo.yaml base-filter comment Reviewer noted implementation-phase references should not appear in shipped config comments. Drop the "Phase 1b" token, keep the filter description. Co-Authored-By: Claude Opus 4.8 --- docker/telemetry/grafana/provisioning/datasources/tempo.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index 4214c72494..46ea429167 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -5,7 +5,7 @@ # # Search filters provide pre-configured dropdowns in the Explore UI. # Each phase adds filters for the span attributes it introduces. -# Phase 1b (infra): Base filters — node identity, service, span name, status. +# Base filters — node identity, service, span name, status. apiVersion: 1 From 9879780dd8675798b5c85a2fb8f744100915ebe8 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 7 Jul 2026 19:43:53 +0100 Subject: [PATCH 2/5] docs(telemetry): remove Phase references from tempo.yaml RPC filter comments Reviewer noted implementation-phase references should not appear in shipped config comments. Drop the "Phase 2" tokens, keep descriptions. Co-Authored-By: Claude Opus 4.8 --- docker/telemetry/grafana/provisioning/datasources/tempo.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index b77f3e9b31..f1eddb1eca 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -6,7 +6,7 @@ # Search filters provide pre-configured dropdowns in the Explore UI. # Each phase adds filters for the span attributes it introduces. # Phase 1b (infra): Base filters — node identity, service, span name, status. -# Phase 2 (RPC): RPC command, status, role filters. +# RPC command, status, role filters. apiVersion: 1 @@ -90,7 +90,7 @@ datasources: operator: ">" scope: intrinsic type: dynamic - # Phase 2: RPC tracing filters + # RPC tracing filters - id: rpc-command tag: command operator: "=" From 36c08fdc6641a6e0ccd5532b8fdb6afc8cbd4a36 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 7 Jul 2026 19:43:59 +0100 Subject: [PATCH 3/5] docs(telemetry): remove Phase references from tempo.yaml TX filter comments Reviewer noted implementation-phase references should not appear in shipped config comments. Drop the "Phase 3" tokens, keep descriptions. Co-Authored-By: Claude Opus 4.8 --- docker/telemetry/grafana/provisioning/datasources/tempo.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index a79b6b5561..aff934989c 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -7,7 +7,7 @@ # Each phase adds filters for the span attributes it introduces. # Phase 1b (infra): Base filters — node identity, service, span name, status. # Phase 2 (RPC): RPC command, status, role filters. -# Phase 3 (TX): Transaction hash, local/peer origin, status. +# Transaction hash, local/peer origin, status. apiVersion: 1 @@ -107,7 +107,7 @@ datasources: operator: "=" scope: span type: dynamic - # Phase 3: Transaction tracing filters + # Transaction tracing filters - id: tx-hash tag: tx_hash operator: "=" From b54e0e50c064cb011b2673304819951f44302a84 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 7 Jul 2026 19:44:00 +0100 Subject: [PATCH 4/5] docs(telemetry): remove Phase references from tempo.yaml consensus filter comments Reviewer noted implementation-phase references should not appear in shipped config comments. Drop the "Phase 4" tokens, keep descriptions. Co-Authored-By: Claude Opus 4.8 --- docker/telemetry/grafana/provisioning/datasources/tempo.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index 7e6f2e4481..7cb2e8c1dc 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -8,7 +8,7 @@ # Phase 1b (infra): Base filters — node identity, service, span name, status. # Phase 2 (RPC): RPC command, status, role filters. # Phase 3 (TX): Transaction hash, local/peer origin, status. -# Phase 4 (Cons): Consensus mode, round, ledger sequence, close time. +# Consensus mode, round, ledger sequence, close time. apiVersion: 1 @@ -124,7 +124,7 @@ datasources: operator: "=" scope: span type: dynamic - # Phase 4: Consensus tracing filters + # Consensus tracing filters - id: consensus-mode tag: consensus_mode operator: "=" From 40b457669edacce92bc35cf85ef2c96bab49b0c3 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 7 Jul 2026 19:44:44 +0100 Subject: [PATCH 5/5] docs(telemetry): remove Phase reference from tempo.yaml additional-filter comment Reviewer noted implementation-phase references should not appear in shipped config comments. Drop the "Phase 3/4" token, keep the description. Co-Authored-By: Claude Opus 4.8 --- docker/telemetry/grafana/provisioning/datasources/tempo.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index 56c0d9df65..48dba90c0a 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -180,7 +180,7 @@ datasources: operator: "=" scope: span type: static - # Phase 3/4: Additional transaction and queue filters + # Additional transaction and queue filters - id: tx-path tag: path operator: "="