mirror of
https://github.com/XRPLF/rippled.git
synced 2025-11-27 22:45:52 +00:00
Review feedback from @dangell7
- Cleaned up some of the `LEDGER_ENTRY` macros by eliding unnecessary parameters. - Define the transaction privileges in one place (InvariantCheck.cpp). - Give `EscrowFinish` the `mayAuthorizeMPT` privilege. - Rename the test helper `expectLine` to `expectHolding` since it handles both trust lines and MPTs. - Restructure the ""pseudo-account has 2 pseudo-account fields set" invariant test to loop over all defined pseudo-account fields. - Fix `operator<<` for `PrettyAmount` to handle `MPTIssue`s. - Add enforcement of the `AccountRootsDeletedClean` invariant if SAV is enabled, and clarify the comment for the pseudo-account field check. - Delete the 100% redundant `ttMPTOKEN_ISSUANCE_SET` check in `ValidMPTIssuance`.
This commit is contained in:
@@ -56,7 +56,7 @@ enum LedgerEntryType : std::uint16_t
|
||||
#pragma push_macro("LEDGER_ENTRY")
|
||||
#undef LEDGER_ENTRY
|
||||
|
||||
#define LEDGER_ENTRY(tag, value, name, rpcName, fields) tag = value,
|
||||
#define LEDGER_ENTRY(tag, value, ...) tag = value,
|
||||
|
||||
#include <xrpl/protocol/detail/ledger_entries.macro>
|
||||
|
||||
|
||||
Reference in New Issue
Block a user