ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-20 11:05:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

ledger_request index must be positive

Browse Source
This commit is contained in:
Edward Hennis
2016-01-19 15:53:12 -05:00
committed by Nik Bougalis
parent 040d7ebb46
commit 9786e432f8
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ripple/rpc/handlers/LedgerRequest.cpp
View File

@@ -52,13 +52,13 @@ Json::Value doLedgerRequest (RPC::Context& context)
{ {
auto const& jsonHash = context.params[jss::ledger_hash]; auto const& jsonHash = context.params[jss::ledger_hash];
if (!jsonHash.isString() || !ledgerHash.SetHex (jsonHash.asString ())) if (!jsonHash.isString() || !ledgerHash.SetHex (jsonHash.asString ()))
return RPC::invalid_field_message (jss::ledger_hash); return RPC::invalid_field_error (jss::ledger_hash);
} }
else else
{ {
auto const& jsonIndex = context.params[jss::ledger_index]; auto const& jsonIndex = context.params[jss::ledger_index];
if (!jsonIndex.isNumeric ()) if (!jsonIndex.isNumeric ())
return RPC::invalid_field_message (jss::ledger_index); return RPC::invalid_field_error (jss::ledger_index);
// We need a validated ledger to get the hash from the sequence // We need a validated ledger to get the hash from the sequence
if (ledgerMaster.getValidatedLedgerAge() > if (ledgerMaster.getValidatedLedgerAge() >
@@ -70,6 +70,8 @@ Json::Value doLedgerRequest (RPC::Context& context)
if (ledgerIndex >= ledger->info().seq) if (ledgerIndex >= ledger->info().seq)
return RPC::make_param_error("Ledger index too large"); return RPC::make_param_error("Ledger index too large");
if (ledgerIndex <= 0)
return RPC::make_param_error("Ledger index too small");
auto const j = context.app.journal("RPCHandler"); auto const j = context.app.journal("RPCHandler");
// Try to get the hash of the desired ledger from the validated ledger // Try to get the hash of the desired ledger from the validated ledger