ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

deploy: 7aad6e5127

Browse Source
This commit is contained in:
intelliot
2023-03-24 05:32:31 +00:00
parent 3477e4e497
commit 950aebe690
295 changed files with 30501 additions and 29856 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Feature.html
View File

@@ -66,8 +66,8 @@ $(function() {
</div><!--header-->
<div class="contents">
<div class="textblock"><p>Steps required to add new features to the code:</p>
<p>1) In this file, increment <code>numFeatures</code> and add a uint256 declaration for the feature at the bottom 2) Add a uint256 definition for the feature to the corresponding source file (<a class="el" href="Feature_8cpp_source.html">Feature.cpp</a>). Use <code>registerFeature</code> to create the feature with the feature's name, <code>Supported::no</code>, and <code>DefaultVote::no</code>. This should be the only place the feature's name appears in code as a string. 3) Use the uint256 as the parameter to <code>view.rules.enabled()</code> to control flow into new code that this feature limits. 4) If the feature development is COMPLETE, and the feature is ready to be SUPPORTED, change the <code>registerFeature</code> parameter to Supported::yes. 5) When the feature is ready to be ENABLED, change the <code>registerFeature</code> parameter to <code>DefaultVote::yes</code>. In general, any newly supported amendments (<code>Supported::yes</code>) should have a <code>DefaultVote::no</code> for at least one full release cycle. High priority bug fixes can be an exception to this rule of thumb.</p>
<p>When a feature has been enabled for several years, the conditional code may be removed, and the feature "retired". To retire a feature: 1) Remove the uint256 declaration from this file. 2) MOVE the uint256 definition in <a class="el" href="Feature_8cpp_source.html">Feature.cpp</a> to the "retired features" section at the end of the file. 3) CHANGE the name of the variable to start with "retired". 4) CHANGE the parameters of the <code>registerFeature</code> call to <code>Supported::yes</code> and <code>DefaultVote::no</code>. The feature must remain registered and supported indefinitely because it still exists in the ledger, but there is no need to vote for it because there's nothing to vote for. If it is removed completely from the code, any instances running that code will get amendment blocked. Removing the feature from the ledger is beyond the scope of these instructions. </p>
<p>1) In this file, increment <code>numFeatures</code> and add a uint256 declaration for the feature at the bottom 2) Add a uint256 definition for the feature to the corresponding source file (<a class="el" href="Feature_8cpp_source.html">Feature.cpp</a>). Use <code>registerFeature</code> to create the feature with the feature's name, <code>Supported::no</code>, and <code>VoteBehavior::DefaultNo</code>. This should be the only place the feature's name appears in code as a string. 3) Use the uint256 as the parameter to <code>view.rules.enabled()</code> to control flow into new code that this feature limits. 4) If the feature development is COMPLETE, and the feature is ready to be SUPPORTED, change the <code>registerFeature</code> parameter to Supported::yes. 5) When the feature is ready to be ENABLED, change the <code>registerFeature</code> parameter to <code>VoteBehavior::DefaultYes</code>. In general, any newly supported amendments (<code>Supported::yes</code>) should have a <code>VoteBehavior::DefaultNo</code> for at least one full release cycle. High priority bug fixes can be an exception to this rule of thumb.</p>
<p>When a feature has been enabled for several years, the conditional code may be removed, and the feature "retired". To retire a feature: 1) Remove the uint256 declaration from this file. 2) MOVE the uint256 definition in <a class="el" href="Feature_8cpp_source.html">Feature.cpp</a> to the "retired features" section at the end of the file. 3) CHANGE the name of the variable to start with "retired". 4) CHANGE the parameters of the <code>registerFeature</code> call to <code>Supported::yes</code> and <code>VoteBehavior::DefaultNo</code>. The feature must remain registered and supported indefinitely because it still exists in the ledger, but there is no need to vote for it because there's nothing to vote for. If it is removed completely from the code, any instances running that code will get amendment blocked. Removing the feature from the ledger is beyond the scope of these instructions. </p>
</div></div><!-- contents -->
</div><!-- PageDoc -->
<!-- start footer part -->