From 945b4f77cd7c7e2d6b65d4678d46fea415bd0310 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Fri, 3 Apr 2026 10:42:51 -0400 Subject: [PATCH] roll back unrelated changes --- src/test/app/LedgerReplay_test.cpp | 98 ------------------------------ 1 file changed, 98 deletions(-) diff --git a/src/test/app/LedgerReplay_test.cpp b/src/test/app/LedgerReplay_test.cpp index 38080bce20..b30dce4756 100644 --- a/src/test/app/LedgerReplay_test.cpp +++ b/src/test/app/LedgerReplay_test.cpp @@ -1287,102 +1287,6 @@ struct LedgerReplayer_test : public beast::unit_test::suite TaskStatus::Failed); } - void - testMalformedProofPathResponse() - { - testcase("Malformed ProofPath response"); - LedgerServer server(*this, {1}); - auto const l = server.ledgerMaster.getClosedLedger(); - - // Build a valid reply first - auto request = std::make_shared(); - request->set_ledgerhash(l->header().hash.data(), l->header().hash.size()); - request->set_type(protocol::TMLedgerMapType::lmACCOUNT_STATE); - request->set_key(keylet::skip().key.data(), keylet::skip().key.size()); - auto goodReply = std::make_shared( - server.msgHandler.processProofPathRequest(request)); - BEAST_EXPECT(!goodReply->has_error()); - BEAST_EXPECT(server.msgHandler.processProofPathResponse(goodReply)); - - { - // BUG-G001: truncated ledger header should not crash - auto reply = std::make_shared(*goodReply); - reply->set_ledgerheader("short"); // too short to deserialize - BEAST_EXPECT(!server.msgHandler.processProofPathResponse(reply)); - } - { - // BUG-G001: empty ledger header - auto reply = std::make_shared(*goodReply); - reply->set_ledgerheader(""); - BEAST_EXPECT(!server.msgHandler.processProofPathResponse(reply)); - } - { - // BUG-G002: missing ledgerhash field - auto reply = std::make_shared(*goodReply); - reply->clear_ledgerhash(); - BEAST_EXPECT(!server.msgHandler.processProofPathResponse(reply)); - } - { - // BUG-G002: undersized ledgerhash - auto reply = std::make_shared(*goodReply); - reply->set_ledgerhash("tooshort"); - BEAST_EXPECT(!server.msgHandler.processProofPathResponse(reply)); - } - { - // BUG-G002: undersized key - auto reply = std::make_shared(*goodReply); - reply->set_key("tooshort"); - BEAST_EXPECT(!server.msgHandler.processProofPathResponse(reply)); - } - { - // BUG-G002: missing key field - auto reply = std::make_shared(*goodReply); - reply->clear_key(); - BEAST_EXPECT(!server.msgHandler.processProofPathResponse(reply)); - } - } - - void - testMalformedReplayDeltaResponse() - { - testcase("Malformed ReplayDelta response"); - LedgerServer server(*this, {1}); - auto const l = server.ledgerMaster.getClosedLedger(); - - // Build a valid reply first - auto request = std::make_shared(); - request->set_ledgerhash(l->header().hash.data(), l->header().hash.size()); - auto goodReply = std::make_shared( - server.msgHandler.processReplayDeltaRequest(request)); - BEAST_EXPECT(!goodReply->has_error()); - BEAST_EXPECT(server.msgHandler.processReplayDeltaResponse(goodReply)); - - { - // BUG-G001: truncated ledger header should not crash - auto reply = std::make_shared(*goodReply); - reply->set_ledgerheader("short"); - BEAST_EXPECT(!server.msgHandler.processReplayDeltaResponse(reply)); - } - { - // BUG-G001: empty ledger header - auto reply = std::make_shared(*goodReply); - reply->set_ledgerheader(""); - BEAST_EXPECT(!server.msgHandler.processReplayDeltaResponse(reply)); - } - { - // BUG-G002: missing ledgerhash field - auto reply = std::make_shared(*goodReply); - reply->clear_ledgerhash(); - BEAST_EXPECT(!server.msgHandler.processReplayDeltaResponse(reply)); - } - { - // BUG-G002: undersized ledgerhash - auto reply = std::make_shared(*goodReply); - reply->set_ledgerhash("tooshort"); - BEAST_EXPECT(!server.msgHandler.processReplayDeltaResponse(reply)); - } - } - void testLedgerReplayOverlap() { @@ -1475,8 +1379,6 @@ struct LedgerReplayer_test : public beast::unit_test::suite testStop(); testSkipListBadReply(); testLedgerDeltaBadReply(); - testMalformedProofPathResponse(); - testMalformedReplayDeltaResponse(); testLedgerReplayOverlap(); } };