ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing 'else' when handling sfMessageKey:

Browse Source 
When clearing out a message key the transactor would incorrectly
create an empty `sfMessageKey` field instead of simply deleting
the field.

Clarify logic by reordering checks.
This commit is contained in:
Nik Bougalis
2014-11-02 00:07:33 -07:00
parent 3ccbd7c9b2
commit 93b7599b1c
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/ripple/app/transactors/SetAccount.cpp
View File

@@ -265,18 +265,19 @@ public:
if (mTxn.isFieldPresent (sfMessageKey))
{
Blob messageKey = mTxn.getFieldVL (sfMessageKey);
Blob const messageKey = mTxn.getFieldVL (sfMessageKey);
if (messageKey.size () > PUBLIC_BYTES_MAX)
{
m_journal.trace << "message key too long";
return telBAD_PUBLIC_KEY;
}
if (messageKey.empty ())
{
m_journal.debug << "set message key";
mTxnAccount->makeFieldAbsent (sfMessageKey);
}
if (messageKey.size () > PUBLIC_BYTES_MAX)
{
m_journal.trace << "message key too long";
return telBAD_PUBLIC_KEY;
}
else
{
m_journal.debug << "set message key";