Consolidate transaction signature checking.

* All checks flow through ripple::checkValidity, which transparently caches result flags.
* All external transaction submission code paths use checkValidity.
* SF_SIGGOOD flag no longer appears outside of HashRouter / checkValidity.
* Validity can be forced in known or trusted scenarios.
This commit is contained in:
Edward Hennis
2015-08-04 18:56:57 -04:00
committed by Nik Bougalis
parent 66b55f91ba
commit 9154cbf8e1
33 changed files with 643 additions and 361 deletions

View File

@@ -378,13 +378,8 @@ public:
for (auto const& it : mHeldTransactions)
{
ApplyFlags flags = tapNONE;
if (app_.getHashRouter().addSuppressionFlags (
it.first.getTXID (), SF_SIGGOOD))
flags = flags | tapNO_CHECK_SIGN;
auto const result = apply(app_, view,
*it.second, flags, app_.getHashRouter(
).sigVerify(), app_.config(), j);
*it.second, flags, j);
if (result.second)
any = true;
}