From 90d2eb839a9c11f466d7822501d8a6d222142191 Mon Sep 17 00:00:00 2001 From: Denis Angell Date: Thu, 26 Feb 2026 22:27:24 +0100 Subject: [PATCH] reverse negated else --- src/libxrpl/tx/transactors/Batch.cpp | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/libxrpl/tx/transactors/Batch.cpp b/src/libxrpl/tx/transactors/Batch.cpp index 5b30f85a59..595d097a9d 100644 --- a/src/libxrpl/tx/transactors/Batch.cpp +++ b/src/libxrpl/tx/transactors/Batch.cpp @@ -496,14 +496,7 @@ Batch::checkBatchSign(PreclaimContext const& ctx) auto const idSigner = calcAccountID(PublicKey(makeSlice(pkSigner))); auto const sleAccount = ctx.view.read(keylet::account(idAccount)); - // A batch can include transactions from an un-created account ONLY - // when the account master key is the signer - if (!sleAccount) - { - if (idAccount != idSigner) - return tefBAD_AUTH; - } - else + if (sleAccount) { if (isPseudoAccount(sleAccount)) return tefBAD_AUTH; @@ -512,6 +505,14 @@ Batch::checkBatchSign(PreclaimContext const& ctx) !isTesSuccess(ret)) return ret; } + else + { + if (idAccount != idSigner) + return tefBAD_AUTH; + + // A batch can include transactions from an un-created account ONLY + // when the account master key is the signer + } } } return ret;