ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix 'getAffectedAccount' -- logic was totally wrong.

Browse Source 
You can't get this from the transaction because which accounts a transaction
affects depends on things like which offers it winds up taking. And you
can't build it with the metadata because you don't always build the metadata
locally -- consider fetching a ledger after a network split. The only
rational way to do this is to build the affected account vector from the
metadata.
This commit is contained in:
JoelKatz
2013-01-17 10:46:12 -08:00
parent a87768ead5
commit 8da284705f
6 changed files with 58 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
src/cpp/ripple/TransactionMeta.cpp
View File

@@ -7,6 +7,9 @@
#include <boost/foreach.hpp>
#include "Log.h"
#include "SerializedObject.h"
SETUP_LOG();
TransactionMetaSet::TransactionMetaSet(const uint256& txid, uint32 ledger, const std::vector<unsigned char>& vec) :
mTransactionID(txid), mLedger(ledger), mNodes(sfAffectedNodes, 32)
@@ -52,33 +55,58 @@ void TransactionMetaSet::setAffectedNode(const uint256& node, SField::ref type,
obj.setFieldU16(sfLedgerEntryType, nodeType);
}
/*
static void addIfUnique(std::vector<RippleAddress>& vector, const RippleAddress& address)
{
BOOST_FOREACH(const RippleAddress& a, vector)
if (a == address)
return;
vector.push_back(address);
}
std::vector<RippleAddress> TransactionMetaSet::getAffectedAccounts()
{
std::vector<RippleAddress> accounts;
accounts.reserve(10);
BOOST_FOREACH(STObject& object, mNodes.getValue() )
BOOST_FOREACH(const STObject& it, mNodes)
{
const STAccount* sa = dynamic_cast<const STAccount*>(&it);
if (sa != NULL)
int index = it.getFieldIndex((it.getFName() == sfCreatedNode) ? sfNewFields : sfFinalFields);
if (index != -1)
{
bool found = false;
RippleAddress na = sa->getValueNCA();
BOOST_FOREACH(const RippleAddress& it, accounts)
const STObject *inner = dynamic_cast<const STObject*>(&it.peekAtIndex(index));
if (inner)
{
if (it == na)
BOOST_FOREACH(const SerializedType& field, inner->peekData())
{
found = true;
break;
const STAccount* sa = dynamic_cast<const STAccount*>(&it);
if (sa)
addIfUnique(accounts, sa->getValueNCA());
else if ((field.getFName() == sfLowLimit) || (field.getFName() == sfHighLimit))
{
const STAmount* lim = dynamic_cast<const STAmount*>(&field);
if (lim != NULL)
{
uint160 issuer = lim->getIssuer();
if (issuer.isNonZero())
{
RippleAddress na;
na.setAccountID(issuer);
addIfUnique(accounts, na);
}
}
else
{
cLog(lsFATAL) << "limit is not amount " << field.getJson(0);
}
}
}
}
if (!found)
accounts.push_back(na);
else assert(false);
}
}
return accounts;
}
*/
STObject& TransactionMetaSet::getAffectedNode(SLE::ref node, SField::ref type)
{