test: Run unit tests regardless of 'Supported' amendment status (#5537)

src/test/rpc/AMMInfo_test.cpp

@@ -359,7 +359,7 @@ public:
     run() override
     {
         using namespace jtx;
-        auto const all = supported_amendments();
+        auto const all = testable_amendments();
         testErrors();
         testSimpleRpc();
         testVoteAndBid(all);

src/test/rpc/AccountInfo_test.cpp

@@ -710,7 +710,7 @@ public:
         testSignerListsV2();
 
         FeatureBitset const allFeatures{
-            ripple::test::jtx::supported_amendments()};
+            ripple::test::jtx::testable_amendments()};
         testAccountFlags(allFeatures);
         testAccountFlags(allFeatures - featureDisallowIncoming);
         testAccountFlags(

src/test/rpc/AccountObjects_test.cpp

@@ -577,7 +577,7 @@ public:
         Account const gw{"gateway"};
         auto const USD = gw["USD"];
 
-        auto const features = supported_amendments() | featureXChainBridge |
+        auto const features = testable_amendments() | featureXChainBridge |
             featurePermissionedDomains;
         Env env(*this, features);
 

src/test/rpc/AccountSet_test.cpp

@@ -53,7 +53,7 @@ public:
         Account const alice("alice");
 
         // Test without DepositAuth enabled initially.
-        Env env(*this, supported_amendments() - featureDepositAuth);
+        Env env(*this, testable_amendments() - featureDepositAuth);
         env.fund(XRP(10000), noripple(alice));
 
         // Give alice a regular key so she can legally set and clear
@@ -357,7 +357,7 @@ public:
         };
 
         doTests(
-            supported_amendments(),
+            testable_amendments(),
             {{1.0, tesSUCCESS, 1.0},
              {1.1, tesSUCCESS, 1.1},
              {2.0, tesSUCCESS, 2.0},

src/test/rpc/BookChanges_test.cpp

@@ -94,7 +94,7 @@ public:
         using namespace jtx;
 
         FeatureBitset const all{
-            jtx::supported_amendments() | featurePermissionedDomains |
+            jtx::testable_amendments() | featurePermissionedDomains |
             featureCredentials | featurePermissionedDEX};
 
         Env env(*this, all);

src/test/rpc/Book_test.cpp

@@ -1737,7 +1737,7 @@ public:
         using namespace jtx;
 
         FeatureBitset const all{
-            jtx::supported_amendments() | featurePermissionedDomains |
+            jtx::testable_amendments() | featurePermissionedDomains |
             featureCredentials | featurePermissionedDEX};
 
         Env env(*this, all);
@@ -1868,7 +1868,7 @@ public:
         using namespace jtx;
 
         FeatureBitset const all{
-            jtx::supported_amendments() | featurePermissionedDomains |
+            jtx::testable_amendments() | featurePermissionedDomains |
             featureCredentials | featurePermissionedDEX};
 
         Env env(*this, all);

src/test/rpc/GatewayBalances_test.cpp

@@ -251,7 +251,7 @@ public:
     run() override
     {
         using namespace jtx;
-        auto const sa = supported_amendments();
+        auto const sa = testable_amendments();
         for (auto feature : {sa - featurePermissionedDEX, sa})
         {
             testGWB(feature);

src/test/rpc/LedgerData_test.cpp

@@ -304,8 +304,8 @@ public:
 
         // Make sure fixInnerObjTemplate2 doesn't break amendments.
         for (FeatureBitset const& features :
-             {supported_amendments() - fixInnerObjTemplate2,
-              supported_amendments() | fixInnerObjTemplate2})
+             {testable_amendments() - fixInnerObjTemplate2,
+              testable_amendments() | fixInnerObjTemplate2})
         {
             using namespace std::chrono;
             Env env{*this, envconfig(validator, ""), features};

src/test/rpc/LedgerEntry_test.cpp

@@ -2221,7 +2221,7 @@ class LedgerEntry_test : public beast::unit_test::suite
 
         using namespace test::jtx;
 
-        Env env(*this, supported_amendments() | featurePermissionedDomains);
+        Env env(*this, testable_amendments() | featurePermissionedDomains);
         Account const issuer{"issuer"};
         Account const alice{"alice"};
         Account const bob{"bob"};

src/test/rpc/NoRipple_test.cpp

@@ -293,7 +293,7 @@ public:
             testPairwise(features);
         };
         using namespace jtx;
-        auto const sa = supported_amendments();
+        auto const sa = testable_amendments();
         withFeatsTests(sa - featurePermissionedDEX);
         withFeatsTests(sa);
     }

src/test/rpc/Subscribe_test.cpp

@@ -1307,7 +1307,7 @@ public:
         using namespace jtx;
         using namespace std::chrono_literals;
         FeatureBitset const all{
-            jtx::supported_amendments() | featurePermissionedDomains |
+            jtx::testable_amendments() | featurePermissionedDomains |
             featureCredentials | featurePermissionedDEX};
 
         Env env(*this, all);
@@ -1577,7 +1577,7 @@ public:
     run() override
     {
         using namespace test::jtx;
-        FeatureBitset const all{supported_amendments()};
+        FeatureBitset const all{testable_amendments()};
         FeatureBitset const xrpFees{featureXRPFees};
 
         testServer();

src/test/rpc/Transaction_test.cpp

@@ -941,7 +941,7 @@ public:
         forAllApiVersions(
             std::bind_front(&Transaction_test::testBinaryRequest, this));
 
-        FeatureBitset const all{supported_amendments()};
+        FeatureBitset const all{testable_amendments()};
         testWithFeats(all);
     }