ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-23 20:45:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Run unit tests regardless of 'Supported' amendment status (#5537)

Browse Source
This commit is contained in:
Vlad
2025-07-16 12:47:54 +01:00
committed by GitHub
parent c9135a63cd
commit 8bfaa7fe0a
66 changed files with 167 additions and 165 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/test/app/AMM_test.cpp
View File

@@ -66,7 +66,7 @@ private:
{},
0,
{},
{supported_amendments() | featureSingleAssetVault});
{testable_amendments() | featureSingleAssetVault});
// XRP to IOU, without featureSingleAssetVault
testAMM(
@@ -77,7 +77,7 @@ private:
{},
0,
{},
{supported_amendments() - featureSingleAssetVault});
{testable_amendments() - featureSingleAssetVault});
// IOU to IOU
testAMM(
@@ -1385,7 +1385,7 @@ private:
testcase("Deposit");
using namespace jtx;
auto const all = supported_amendments();
auto const all = testable_amendments();
// Equal deposit: 1000000 tokens, 10% of the current pool
testAMM([&](AMM& ammAlice, Env& env) {
@@ -1687,7 +1687,7 @@ private:
testcase("Invalid Withdraw");
using namespace jtx;
auto const all = supported_amendments();
auto const all = testable_amendments();
testAMM(
[&](AMM& ammAlice, Env& env) {
@@ -2267,7 +2267,7 @@ private:
testcase("Withdraw");
using namespace jtx;
auto const all = supported_amendments();
auto const all = testable_amendments();
// Equal withdrawal by Carol: 1000000 of tokens, 10% of the current
// pool
@@ -2688,7 +2688,7 @@ private:
{
testcase("Fee Vote");
using namespace jtx;
auto const all = supported_amendments();
auto const all = testable_amendments();
// One vote sets fee to 1%.
testAMM([&](AMM& ammAlice, Env& env) {
@@ -4855,7 +4855,7 @@ private:
{
testcase("Amendment");
using namespace jtx;
FeatureBitset const all{supported_amendments()};
FeatureBitset const all{testable_amendments()};
FeatureBitset const noAMM{all - featureAMM};
FeatureBitset const noNumber{all - fixUniversalNumber};
FeatureBitset const noAMMAndNumber{
@@ -5646,7 +5646,7 @@ private:
testcase("Auto Delete");
using namespace jtx;
FeatureBitset const all{supported_amendments()};
FeatureBitset const all{testable_amendments()};
{
Env env(
@@ -6306,7 +6306,7 @@ private:
{
testcase("Fix Default Inner Object");
using namespace jtx;
FeatureBitset const all{supported_amendments()};
FeatureBitset const all{testable_amendments()};
auto test = [&](FeatureBitset features,
TER const& err1,
@@ -7043,7 +7043,7 @@ private:
{{xrpPool, iouPool}},
889,
std::nullopt,
{jtx::supported_amendments() | fixAMMv1_1});
{jtx::testable_amendments() | fixAMMv1_1});
}
void
@@ -7322,7 +7322,8 @@ private:
}
// If featureAMMClawback is enabled, AMMCreate is allowed for
// clawback-enabled issuer. Clawback from the AMM Account is not
// allowed, which will return tecAMM_ACCOUNT. We can only use
// allowed, which will return tecAMM_ACCOUNT or tecPSEUDO_ACCOUNT,
// depending on whether SingleAssetVault is enabled. We can only use
// AMMClawback transaction to claw back from AMM Account.
else
{
@@ -7333,13 +7334,16 @@ private:
// By doing this, we make the clawback transaction's Amount field's
// subfield `issuer` to be the AMM account, which means
// we are clawing back from an AMM account. This should return an
// tecAMM_ACCOUNT error because regular Clawback transaction is not
// error because regular Clawback transaction is not
// allowed for clawing back from an AMM account. Please notice the
// `issuer` subfield represents the account being clawed back, which
// is confusing.
auto const error = features[featureSingleAssetVault]
? ter{tecPSEUDO_ACCOUNT}
: ter{tecAMM_ACCOUNT};
Issue usd(USD.issue().currency, amm.ammAccount());
auto amount = amountFromString(usd, "10");
env(claw(gw, amount), ter(tecAMM_ACCOUNT));
env(claw(gw, amount), error);
}
}
@@ -7513,10 +7517,10 @@ private:
};
testCase(
"tecDUPLICATE", supported_amendments() - featureSingleAssetVault);
"tecDUPLICATE", testable_amendments() - featureSingleAssetVault);
testCase(
"terADDRESS_COLLISION",
supported_amendments() | featureSingleAssetVault);
testable_amendments() | featureSingleAssetVault);
}
void
@@ -7894,7 +7898,7 @@ private:
void
run() override
{
FeatureBitset const all{jtx::supported_amendments()};
FeatureBitset const all{jtx::testable_amendments()};
testInvalidInstance();
testInstanceCreate();
testInvalidDeposit(all);
@@ -7945,6 +7949,8 @@ private:
testLPTokenBalance(all - fixAMMv1_3);
testLPTokenBalance(all - fixAMMv1_1 - fixAMMv1_3);
testAMMClawback(all);
testAMMClawback(all - featureSingleAssetVault);
testAMMClawback(all - featureAMMClawback - featureSingleAssetVault);
testAMMClawback(all - featureAMMClawback);
testAMMClawback(all - fixAMMv1_1 - fixAMMv1_3 - featureAMMClawback);
testAMMDepositWithFrozenAssets(all);