Refactor Serializer, SerialIter, SHAMapItem, NodeObject:

* Make LessThan private
* Make NodeObject::isSame private
* Remove hotTRANSACTION
* Remove some Serializer members
* Remove unused SHAMapItem::getRaw
* Remove unused STLedgerEntry::getOwners
* Remove Serializer constructors
* Remove unused Serializer members
* Remove SerialIter ctor

src/ripple/app/ledger/TransactionStateSF.cpp

@@ -31,6 +31,7 @@ TransactionStateSF::TransactionStateSF()
 {
 }
 
+// VFALCO This might be better as Blob&&
 void TransactionStateSF::gotNode (bool fromFilter,
                                   SHAMapNodeID const& id,
                                   uint256 const& nodeHash,
@@ -40,10 +41,11 @@ void TransactionStateSF::gotNode (bool fromFilter,
     // VFALCO SHAMapSync filters should be passed the SHAMap, the
     //        SHAMap should provide an accessor to get the injected Database,
     //        and this should use that Database instad of getNodeStore
-    getApp().getNodeStore ().store (
-        (type == SHAMapTreeNode::tnTRANSACTION_NM) ? hotTRANSACTION : hotTRANSACTION_NODE,
-        std::move (nodeData),
-        nodeHash);
+    assert(type !=
+        SHAMapTreeNode::tnTRANSACTION_NM);
+    getApp().getNodeStore().store(
+        hotTRANSACTION_NODE,
+            std::move (nodeData), nodeHash);
 }
 
 bool TransactionStateSF::haveNode (SHAMapNodeID const& id,