Merge remote-tracking branch 'XRPLF/develop' into ximinez/fix-getledger

* XRPLF/develop:
  chore: Enable clang-tidy include cleaner (6947)
  fix: Change AMMClawback return code to tecNO_PERMISSION (6946)
  ci: [DEPENDABOT] bump actions/upload-pages-artifact from 4.0.0 to 5.0.0 (6927)
  ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 (6928)
  chore: Enable clang-tidy readability checks (6930)

src/libxrpl/basics/Archive.cpp

@@ -1,4 +1,5 @@
 #include <xrpl/basics/Archive.h>
+
 #include <xrpl/basics/contract.h>
 
 #include <boost/filesystem/operations.hpp>

src/libxrpl/basics/BasicConfig.cpp

@@ -1,9 +1,9 @@
 #include <xrpl/basics/BasicConfig.h>
+
 #include <xrpl/basics/StringUtilities.h>
 
 #include <boost/regex/v5/regbase.hpp>
 #include <boost/regex/v5/regex.hpp>
-#include <boost/regex/v5/regex_fwd.hpp>
 #include <boost/regex/v5/regex_match.hpp>
 
 #include <ostream>

src/libxrpl/basics/FileUtilities.cpp

@@ -1,6 +1,5 @@
 #include <xrpl/basics/FileUtilities.h>
 
-#include <boost/filesystem/fstream.hpp>
 #include <boost/filesystem/operations.hpp>
 #include <boost/filesystem/path.hpp>
 #include <boost/system/detail/errc.hpp>

src/libxrpl/basics/Log.cpp

@@ -1,4 +1,5 @@
 #include <xrpl/basics/Log.h>
+
 #include <xrpl/basics/chrono.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/beast/utility/instrumentation.h>

src/libxrpl/basics/MallocTrim.cpp

@@ -1,13 +1,11 @@
-#include <xrpl/basics/Log.h>
 #include <xrpl/basics/MallocTrim.h>
 
+#include <xrpl/basics/Log.h>
+#include <xrpl/beast/utility/Journal.h>
+
 #include <boost/predef.h>
 
-#include <chrono>
-#include <cstdint>
-#include <cstdio>
-#include <fstream>
-#include <sstream>
+#include <string_view>
 
 #if defined(__GLIBC__) && BOOST_OS_LINUX
 #include <sys/resource.h>
@@ -15,6 +13,14 @@
 #include <malloc.h>
 #include <unistd.h>
 
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <fstream>
+#include <ios>
+#include <sstream>
+#include <string>
+
 // Require RUSAGE_THREAD for thread-scoped page fault tracking
 #ifndef RUSAGE_THREAD
 #error "MallocTrim rusage instrumentation requires RUSAGE_THREAD on Linux/glibc"

src/libxrpl/basics/Number.cpp

@@ -1,11 +1,12 @@
 #include <xrpl/basics/Number.h>
-// Keep Number.h first to ensure it can build without hidden dependencies
+
 #include <xrpl/basics/contract.h>
 #include <xrpl/beast/utility/instrumentation.h>
 
 #include <algorithm>
 #include <cstddef>
 #include <cstdint>
+#include <functional>
 #include <iterator>
 #include <limits>
 #include <numeric>

src/libxrpl/basics/ResolverAsio.cpp

@@ -1,15 +1,19 @@
+#include <xrpl/basics/ResolverAsio.h>
+
 #include <xrpl/basics/Log.h>
 #include <xrpl/basics/Resolver.h>
-#include <xrpl/basics/ResolverAsio.h>
 #include <xrpl/beast/net/IPAddressConversion.h>
 #include <xrpl/beast/net/IPEndpoint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/beast/utility/instrumentation.h>
 
 #include <boost/asio/bind_executor.hpp>
+#include <boost/asio/dispatch.hpp>
 #include <boost/asio/error.hpp>
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/ip/tcp.hpp>
+#include <boost/asio/post.hpp>
+#include <boost/asio/strand.hpp>
 #include <boost/system/detail/error_code.hpp>
 
 #include <algorithm>

src/libxrpl/basics/StringUtilities.cpp

@@ -1,5 +1,6 @@
-#include <xrpl/basics/Blob.h>
 #include <xrpl/basics/StringUtilities.h>
+
+#include <xrpl/basics/Blob.h>
 #include <xrpl/beast/core/LexicalCast.h>
 #include <xrpl/beast/net/IPEndpoint.h>
 
@@ -8,7 +9,6 @@
 #include <boost/algorithm/string/trim.hpp>
 #include <boost/regex/v5/regbase.hpp>
 #include <boost/regex/v5/regex.hpp>
-#include <boost/regex/v5/regex_fwd.hpp>
 #include <boost/regex/v5/regex_match.hpp>
 
 #include <cstdint>

src/libxrpl/basics/contract.cpp

@@ -1,5 +1,6 @@
-#include <xrpl/basics/Log.h>
 #include <xrpl/basics/contract.h>
+
+#include <xrpl/basics/Log.h>
 #include <xrpl/beast/utility/instrumentation.h>
 
 #include <cstdlib>

src/libxrpl/basics/make_SSLContext.cpp

@@ -1,6 +1,7 @@
-#include <xrpl/basics/contract.h>
 #include <xrpl/basics/make_SSLContext.h>
 
+#include <xrpl/basics/contract.h>
+
 #include <boost/asio/ssl/context.hpp>
 #include <boost/asio/ssl/verify_mode.hpp>
 #include <boost/system/detail/error_code.hpp>
@@ -8,8 +9,9 @@
 
 #include <openssl/asn1.h>
 #include <openssl/bn.h>
+#include <openssl/crypto.h>
 #include <openssl/evp.h>
-#include <openssl/objects.h>
+#include <openssl/objects.h>  // IWYU pragma: keep
 #include <openssl/ossl_typ.h>
 #include <openssl/pem.h>
 #include <openssl/rsa.h>

src/libxrpl/basics/mulDiv.cpp

@@ -1,8 +1,6 @@
 #include <xrpl/basics/mulDiv.h>
 
-#include <boost/multiprecision/cpp_int.hpp>
-#include <boost/multiprecision/detail/default_ops.hpp>
-#include <boost/multiprecision/fwd.hpp>
+#include <boost/multiprecision/cpp_int.hpp>  // IWYU pragma: keep
 
 #include <cstdint>
 #include <optional>

src/libxrpl/beast/clock/basic_seconds_clock.cpp

@@ -1,4 +1,5 @@
 #include <xrpl/beast/clock/basic_seconds_clock.h>
+
 #include <xrpl/beast/utility/instrumentation.h>
 
 #include <atomic>

src/libxrpl/beast/core/CurrentThreadName.cpp

@@ -1,5 +1,4 @@
 #include <xrpl/beast/core/CurrentThreadName.h>
-#include <xrpl/beast/utility/instrumentation.h>
 
 #include <string>
 #include <string_view>
@@ -72,7 +71,8 @@ setCurrentThreadNameImpl(std::string_view name)
 #if BOOST_OS_LINUX
 #include <pthread.h>
 
-#include <iostream>
+#include <cstdio>
+#include <iostream>  // IWYU pragma: keep
 
 namespace beast::detail {
 

src/libxrpl/beast/core/SemanticVersion.cpp

@@ -1,5 +1,6 @@
-#include <xrpl/beast/core/LexicalCast.h>
 #include <xrpl/beast/core/SemanticVersion.h>
+
+#include <xrpl/beast/core/LexicalCast.h>
 #include <xrpl/beast/utility/instrumentation.h>
 
 #include <algorithm>
@@ -8,6 +9,7 @@
 #include <locale>
 #include <stdexcept>
 #include <string>
+#include <string_view>
 
 namespace beast {
 

src/libxrpl/beast/insight/Groups.cpp

@@ -1,10 +1,11 @@
+#include <xrpl/beast/insight/Groups.h>
+
 #include <xrpl/beast/hash/uhash.h>
 #include <xrpl/beast/insight/Collector.h>
 #include <xrpl/beast/insight/Counter.h>
 #include <xrpl/beast/insight/Event.h>
 #include <xrpl/beast/insight/Gauge.h>
 #include <xrpl/beast/insight/Group.h>
-#include <xrpl/beast/insight/Groups.h>
 #include <xrpl/beast/insight/Hook.h>
 #include <xrpl/beast/insight/HookImpl.h>
 #include <xrpl/beast/insight/Meter.h>

src/libxrpl/beast/insight/Hook.cpp

@@ -1,4 +1,5 @@
 #include <xrpl/beast/insight/Hook.h>
+
 #include <xrpl/beast/insight/HookImpl.h>
 
 namespace beast {

src/libxrpl/beast/insight/NullCollector.cpp

@@ -1,3 +1,5 @@
+#include <xrpl/beast/insight/NullCollector.h>
+
 #include <xrpl/beast/insight/Collector.h>
 #include <xrpl/beast/insight/Counter.h>
 #include <xrpl/beast/insight/CounterImpl.h>
@@ -9,7 +11,6 @@
 #include <xrpl/beast/insight/HookImpl.h>
 #include <xrpl/beast/insight/Meter.h>
 #include <xrpl/beast/insight/MeterImpl.h>
-#include <xrpl/beast/insight/NullCollector.h>
 
 #include <memory>
 #include <string>

src/libxrpl/beast/insight/StatsDCollector.cpp

@@ -1,3 +1,5 @@
+#include <xrpl/beast/insight/StatsDCollector.h>
+
 #include <xrpl/beast/core/List.h>
 #include <xrpl/beast/insight/CounterImpl.h>
 #include <xrpl/beast/insight/EventImpl.h>
@@ -5,7 +7,6 @@
 #include <xrpl/beast/insight/Hook.h>
 #include <xrpl/beast/insight/HookImpl.h>
 #include <xrpl/beast/insight/MeterImpl.h>
-#include <xrpl/beast/insight/StatsDCollector.h>
 #include <xrpl/beast/net/IPEndpoint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/beast/utility/instrumentation.h>
@@ -13,12 +14,14 @@
 #include <boost/asio/basic_waitable_timer.hpp>
 #include <boost/asio/bind_executor.hpp>
 #include <boost/asio/buffer.hpp>
+#include <boost/asio/dispatch.hpp>
 #include <boost/asio/error.hpp>
 #include <boost/asio/executor_work_guard.hpp>
 #include <boost/asio/io_context.hpp>
 #include <boost/asio/ip/udp.hpp>
 #include <boost/asio/strand.hpp>
 #include <boost/system/detail/error_code.hpp>
+#include <boost/system/system_error.hpp>
 
 #include <chrono>
 #include <cstddef>

src/libxrpl/beast/net/IPAddressConversion.cpp

@@ -1,4 +1,5 @@
 #include <xrpl/beast/net/IPAddressConversion.h>
+
 #include <xrpl/beast/net/IPEndpoint.h>
 
 #include <boost/asio/ip/address.hpp>

src/libxrpl/beast/net/IPAddressV6.cpp

@@ -1,7 +1,8 @@
-#include <xrpl/beast/net/IPAddressV4.h>
 #include <xrpl/beast/net/IPAddressV6.h>
 
-#include <boost/asio/ip/address_v4.hpp>
+#include <xrpl/beast/net/IPAddressV4.h>
+
+#include <boost/asio/ip/address_v6.hpp>
 
 namespace beast {
 namespace IP {

src/libxrpl/beast/net/IPEndpoint.cpp

@@ -1,9 +1,9 @@
-#include <xrpl/beast/net/IPAddress.h>
 #include <xrpl/beast/net/IPEndpoint.h>
 
+#include <xrpl/beast/net/IPAddress.h>
+
 #include <boost/algorithm/string/trim.hpp>
 #include <boost/asio/ip/address.hpp>
-#include <boost/asio/ip/address_v4.hpp>
 #include <boost/system/detail/error_code.hpp>
 
 #include <cctype>

src/libxrpl/beast/utility/beast_PropertyStream.cpp

@@ -1,3 +1,4 @@
+#include <xrpl/beast/core/List.h>
 #include <xrpl/beast/utility/PropertyStream.h>
 #include <xrpl/beast/utility/instrumentation.h>
 
@@ -15,7 +16,7 @@ namespace beast {
 //
 //------------------------------------------------------------------------------
 
-PropertyStream::Item::Item(Source* source) : ListNode(), m_source(source)
+PropertyStream::Item::Item(Source* source) : m_source(source)
 {
 }
 

src/libxrpl/conditions/Condition.cpp

@@ -1,7 +1,17 @@
 #include <xrpl/conditions/Condition.h>
+
+#include <xrpl/basics/Buffer.h>
+#include <xrpl/basics/Slice.h>
 #include <xrpl/conditions/detail/PreimageSha256.h>
+#include <xrpl/conditions/detail/error.h>
 #include <xrpl/conditions/detail/utils.h>
 
+#include <cstddef>
+#include <cstdint>
+#include <memory>
+#include <system_error>
+#include <utility>
+
 namespace xrpl {
 namespace cryptoconditions {
 

src/libxrpl/conditions/Fulfillment.cpp

@@ -1,9 +1,15 @@
+#include <xrpl/conditions/Fulfillment.h>
+
+#include <xrpl/basics/Slice.h>
 #include <xrpl/basics/safe_cast.h>
 #include <xrpl/conditions/Condition.h>
-#include <xrpl/conditions/Fulfillment.h>
 #include <xrpl/conditions/detail/PreimageSha256.h>
+#include <xrpl/conditions/detail/error.h>
 #include <xrpl/conditions/detail/utils.h>
 
+#include <memory>
+#include <system_error>
+
 namespace xrpl {
 namespace cryptoconditions {
 

src/libxrpl/conditions/error.cpp

@@ -1,7 +1,10 @@
-#include <xrpl/basics/safe_cast.h>
 #include <xrpl/conditions/detail/error.h>
 
+#include <xrpl/basics/safe_cast.h>
+
 #include <string>
+#include <system_error>
+#include <type_traits>
 
 namespace xrpl {
 namespace cryptoconditions {

src/libxrpl/core/HashRouter.cpp

@@ -1,5 +1,17 @@
 #include <xrpl/core/HashRouter.h>
 
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/chrono.h>
+#include <xrpl/beast/container/detail/aged_unordered_container.h>
+#include <xrpl/beast/utility/instrumentation.h>
+
+#include <chrono>
+#include <functional>
+#include <mutex>
+#include <optional>
+#include <set>
+#include <utility>
+
 namespace xrpl {
 
 auto

src/libxrpl/core/detail/Job.cpp

@@ -1,6 +1,14 @@
-#include <xrpl/beast/core/CurrentThreadName.h>
 #include <xrpl/core/Job.h>
 
+#include <xrpl/beast/core/CurrentThreadName.h>
+#include <xrpl/core/LoadEvent.h>
+#include <xrpl/core/LoadMonitor.h>
+
+#include <cstdint>
+#include <functional>
+#include <memory>
+#include <string>
+
 namespace xrpl {
 
 Job::Job() : mType(jtINVALID), mJobIndex(0)

src/libxrpl/core/detail/JobQueue.cpp

@@ -1,8 +1,23 @@
-#include <xrpl/basics/contract.h>
 #include <xrpl/core/JobQueue.h>
-#include <xrpl/core/PerfLog.h>
 
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/insight/Collector.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/core/Job.h>
+#include <xrpl/core/JobTypeInfo.h>
+#include <xrpl/core/LoadEvent.h>
+#include <xrpl/core/PerfLog.h>
+#include <xrpl/json/json_value.h>
+
+#include <algorithm>
+#include <chrono>
+#include <functional>
+#include <memory>
 #include <mutex>
+#include <set>
+#include <tuple>
+#include <utility>
 
 namespace xrpl {
 

src/libxrpl/core/detail/LoadEvent.cpp

@@ -1,7 +1,11 @@
-#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/core/LoadEvent.h>
+
+#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/core/LoadMonitor.h>
 
+#include <chrono>
+#include <string>
+
 namespace xrpl {
 
 LoadEvent::LoadEvent(LoadMonitor& monitor, std::string const& name, bool shouldStart)

src/libxrpl/core/detail/LoadMonitor.cpp

@@ -1,6 +1,12 @@
+#include <xrpl/core/LoadMonitor.h>
+
 #include <xrpl/basics/Log.h>
 #include <xrpl/basics/UptimeClock.h>
-#include <xrpl/core/LoadMonitor.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/core/LoadEvent.h>
+
+#include <chrono>
+#include <mutex>
 
 namespace xrpl {
 

src/libxrpl/core/detail/Workers.cpp

@@ -1,7 +1,12 @@
-#include <xrpl/beast/core/CurrentThreadName.h>
-#include <xrpl/core/PerfLog.h>
 #include <xrpl/core/detail/Workers.h>
 
+#include <xrpl/beast/core/CurrentThreadName.h>
+#include <xrpl/beast/core/LockFreeStack.h>
+#include <xrpl/core/PerfLog.h>
+
+#include <mutex>
+#include <string>
+
 namespace xrpl {
 
 Workers::Workers(

src/libxrpl/crypto/RFC1751.cpp

@@ -1,6 +1,7 @@
-#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/crypto/RFC1751.h>
 
+#include <xrpl/beast/utility/instrumentation.h>
+
 #include <boost/algorithm/string/classification.hpp>
 #include <boost/algorithm/string/constants.hpp>
 #include <boost/algorithm/string/split.hpp>

src/libxrpl/crypto/csprng.cpp

@@ -1,8 +1,9 @@
-#include <xrpl/basics/contract.h>
 #include <xrpl/crypto/csprng.h>
 
+#include <xrpl/basics/contract.h>
+
+#include <openssl/opensslv.h>
 #include <openssl/rand.h>
-#include <openssl/ssl.h>
 
 #include <array>
 #include <cstddef>

src/libxrpl/git/Git.cpp

@@ -1,4 +1,4 @@
-#include "xrpl/git/Git.h"
+#include <xrpl/git/Git.h>
 
 #include <string>
 

src/libxrpl/json/JsonPropertyStream.cpp

@@ -1,4 +1,5 @@
 #include <xrpl/json/JsonPropertyStream.h>
+
 #include <xrpl/json/json_value.h>
 
 #include <string>

src/libxrpl/json/Output.cpp

@@ -1,4 +1,5 @@
 #include <xrpl/json/Output.h>
+
 #include <xrpl/json/Writer.h>
 #include <xrpl/json/json_value.h>
 

src/libxrpl/json/Writer.cpp

@@ -1,11 +1,12 @@
+#include <xrpl/json/Writer.h>
+
 #include <xrpl/basics/ToString.h>
 #include <xrpl/json/Output.h>
-#include <xrpl/json/Writer.h>
 
 #include <cstddef>
 #include <map>
 #include <memory>
-#include <set>
+#include <set>  // IWYU pragma: keep
 #include <stack>
 #include <string>
 #include <utility>

src/libxrpl/json/json_reader.cpp

@@ -1,5 +1,6 @@
-#include <xrpl/basics/contract.h>
 #include <xrpl/json/json_reader.h>
+
+#include <xrpl/basics/contract.h>
 #include <xrpl/json/json_value.h>
 
 #include <algorithm>

src/libxrpl/json/json_value.cpp

@@ -1,13 +1,17 @@
+#include <xrpl/json/json_value.h>
+
+#include <xrpl/basics/Number.h>
 #include <xrpl/beast/core/LexicalCast.h>
 #include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/json/detail/json_assert.h>
 #include <xrpl/json/json_forwards.h>
-#include <xrpl/json/json_value.h>
 #include <xrpl/json/json_writer.h>
 
 #include <cmath>
+#include <cstdint>
 #include <cstdlib>
 #include <cstring>
+#include <limits>
 #include <string>
 #include <utility>
 

src/libxrpl/json/json_writer.cpp

@@ -1,7 +1,8 @@
+#include <xrpl/json/json_writer.h>
+
 #include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/json/json_forwards.h>
 #include <xrpl/json/json_value.h>
-#include <xrpl/json/json_writer.h>
 
 #include <cstdio>
 #include <cstring>

src/libxrpl/json/to_string.cpp

@@ -1,6 +1,7 @@
-#include <xrpl/json/json_writer.h>
 #include <xrpl/json/to_string.h>
 
+#include <xrpl/json/json_writer.h>
+
 #include <string>
 
 namespace Json {

src/libxrpl/ledger/AcceptedLedgerTx.cpp

@@ -1,11 +1,24 @@
-#include <xrpl/basics/Log.h>
-#include <xrpl/basics/StringUtilities.h>
 #include <xrpl/ledger/AcceptedLedgerTx.h>
-#include <xrpl/ledger/View.h>
-#include <xrpl/ledger/helpers/RippleStateHelpers.h>
-#include <xrpl/protocol/UintTypes.h>
+
+#include <xrpl/basics/StringUtilities.h>
+#include <xrpl/basics/strHex.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/json/json_value.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/ledger/helpers/TokenHelpers.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STObject.h>
+#include <xrpl/protocol/STTx.h>
+#include <xrpl/protocol/Serializer.h>
+#include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/TxFormats.h>
 #include <xrpl/protocol/jss.h>
 
+#include <memory>
+#include <string>
+#include <utility>
+
 namespace xrpl {
 
 AcceptedLedgerTx::AcceptedLedgerTx(

src/libxrpl/ledger/ApplyStateTable.cpp

@@ -1,11 +1,36 @@
-#include <xrpl/basics/Log.h>
-#include <xrpl/beast/utility/instrumentation.h>
-#include <xrpl/json/to_string.h>
 #include <xrpl/ledger/detail/ApplyStateTable.h>
-#include <xrpl/protocol/Feature.h>
-#include <xrpl/protocol/st.h>
 
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/json/to_string.h>  // IWYU pragma: keep
+#include <xrpl/ledger/OpenView.h>
+#include <xrpl/ledger/RawView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/Protocol.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STAmount.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/STTx.h>
+#include <xrpl/protocol/Serializer.h>
+#include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/TxMeta.h>
+#include <xrpl/protocol/XRPAmount.h>
+
+#include <cstddef>
+#include <cstdint>
+#include <functional>
+#include <memory>
+#include <optional>
 #include <stdexcept>
+#include <tuple>
+#include <utility>
 
 namespace xrpl {
 namespace detail {

src/libxrpl/ledger/ApplyView.cpp

@@ -1,10 +1,25 @@
+#include <xrpl/ledger/ApplyView.h>
+
+#include <xrpl/basics/base_uint.h>
 #include <xrpl/basics/contract.h>
 #include <xrpl/beast/utility/instrumentation.h>
-#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/protocol/Feature.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/Protocol.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/STVector256.h>
 
+#include <algorithm>
+#include <cstdint>
+#include <functional>
 #include <limits>
+#include <memory>
+#include <optional>
 #include <stdexcept>
+#include <tuple>
 #include <type_traits>
 
 namespace xrpl {
@@ -41,8 +56,10 @@ findPreviousPage(ApplyView& view, Keylet const& directory, SLE::ref start)
     {
         node = view.peek(keylet::page(directory, page));
         if (!node)
+        {
             Throw<std::logic_error>(
                 "Directory chain: root back-pointer broken.");  // LCOV_EXCL_LINE
+        }
     }
 
     auto indexes = node->getFieldV256(sfIndexes);

src/libxrpl/ledger/ApplyViewBase.cpp

@@ -1,5 +1,18 @@
 #include <xrpl/ledger/detail/ApplyViewBase.h>
 
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/protocol/Fees.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/LedgerHeader.h>
+#include <xrpl/protocol/Rules.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/XRPAmount.h>
+
+#include <memory>
+#include <optional>
+
 namespace xrpl {
 namespace detail {
 

src/libxrpl/ledger/ApplyViewImpl.cpp

@@ -1,5 +1,21 @@
 #include <xrpl/ledger/ApplyViewImpl.h>
 
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/OpenView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/ledger/detail/ApplyViewBase.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/STTx.h>
+#include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/TxMeta.h>
+
+#include <cstddef>
+#include <functional>
+#include <memory>
+#include <optional>
+
 namespace xrpl {
 
 ApplyViewImpl::ApplyViewImpl(ReadView const* base, ApplyFlags flags) : ApplyViewBase(base, flags)

src/libxrpl/ledger/BookDirs.cpp

@@ -1,8 +1,15 @@
 #include <xrpl/ledger/BookDirs.h>
-#include <xrpl/ledger/View.h>
+
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/DirectoryHelpers.h>
+#include <xrpl/protocol/Book.h>
 #include <xrpl/protocol/Indexes.h>
 
+#include <optional>
+
 namespace xrpl {
 
 BookDirs::BookDirs(ReadView const& view, Book const& book)

src/libxrpl/ledger/BookListeners.cpp

@@ -1,5 +1,13 @@
 #include <xrpl/ledger/BookListeners.h>
 
+#include <xrpl/basics/UnorderedContainers.h>
+#include <xrpl/json/json_value.h>
+#include <xrpl/protocol/MultiApiJson.h>
+#include <xrpl/server/InfoSub.h>
+
+#include <cstdint>
+#include <mutex>
+
 namespace xrpl {
 
 void

src/libxrpl/ledger/CachedView.cpp

@@ -1,6 +1,16 @@
-#include <xrpl/basics/TaggedCache.ipp>
 #include <xrpl/ledger/CachedView.h>
 
+#include <xrpl/basics/CountedObject.h>
+#include <xrpl/basics/TaggedCache.ipp>  // IWYU pragma: keep
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+
+#include <memory>
+#include <mutex>
+#include <optional>
+
 namespace xrpl {
 namespace detail {
 

src/libxrpl/ledger/CanonicalTXSet.cpp

@@ -1,5 +1,15 @@
 #include <xrpl/ledger/CanonicalTXSet.h>
 
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STTx.h>
+
+#include <cstring>
+#include <memory>
+#include <utility>
+
 namespace xrpl {
 
 bool

src/libxrpl/ledger/Dir.cpp

@@ -1,5 +1,16 @@
 #include <xrpl/ledger/Dir.h>
 
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/SField.h>
+
+#include <cstddef>
+#include <iterator>
+#include <optional>
+
 namespace xrpl {
 
 using const_iterator = Dir::const_iterator;

src/libxrpl/ledger/Ledger.cpp

@@ -1,17 +1,48 @@
-#include <xrpl/basics/Log.h>
-#include <xrpl/basics/contract.h>
-#include <xrpl/beast/utility/instrumentation.h>
-#include <xrpl/json/to_string.h>
 #include <xrpl/ledger/Ledger.h>
+
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/Slice.h>
+#include <xrpl/basics/UnorderedContainers.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/chrono.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/ledger/LedgerTiming.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/nodestore/NodeObject.h>
 #include <xrpl/protocol/Feature.h>
+#include <xrpl/protocol/Fees.h>
 #include <xrpl/protocol/HashPrefix.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/KeyType.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/LedgerHeader.h>
+#include <xrpl/protocol/Protocol.h>
 #include <xrpl/protocol/PublicKey.h>
+#include <xrpl/protocol/Rules.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STArray.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/STObject.h>
+#include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/SecretKey.h>
+#include <xrpl/protocol/Seed.h>
+#include <xrpl/protocol/Serializer.h>
+#include <xrpl/protocol/SystemParameters.h>
 #include <xrpl/protocol/digest.h>
-#include <xrpl/protocol/jss.h>
+#include <xrpl/shamap/Family.h>
+#include <xrpl/shamap/SHAMap.h>
+#include <xrpl/shamap/SHAMapItem.h>
+#include <xrpl/shamap/SHAMapMissingNode.h>
+#include <xrpl/shamap/SHAMapTreeNode.h>
 
+#include <algorithm>
+#include <cstdint>
+#include <exception>
+#include <memory>
+#include <optional>
 #include <stdexcept>
 #include <utility>
 #include <vector>

src/libxrpl/ledger/OpenView.cpp

@@ -1,7 +1,26 @@
-#include <xrpl/basics/contract.h>
 #include <xrpl/ledger/OpenView.h>
 
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/ledger/RawView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/protocol/Fees.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/STObject.h>
+#include <xrpl/protocol/STTx.h>
+#include <xrpl/protocol/Serializer.h>
+#include <xrpl/protocol/XRPAmount.h>
+
+#include <boost/container/pmr/monotonic_buffer_resource.hpp>
+
+#include <cstddef>
+#include <memory>
+#include <optional>
 #include <stdexcept>
+#include <tuple>
+#include <utility>
 
 namespace xrpl {
 

src/libxrpl/ledger/PaymentSandbox.cpp

@@ -1,9 +1,25 @@
-#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/ledger/PaymentSandbox.h>
-#include <xrpl/ledger/View.h>
+
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/RawView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/MPTIssue.h>
 #include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/UintTypes.h>
+#include <xrpl/protocol/XRPAmount.h>
 
 #include <algorithm>
+#include <cstdint>
+#include <map>
+#include <memory>
+#include <optional>
+#include <tuple>
+#include <utility>
 
 namespace xrpl {
 
@@ -239,7 +255,7 @@ DeferredCredits::apply(DeferredCredits& to)
             toVal.selfDebit += fromVal.selfDebit;
             for (auto& [k, v] : fromVal.holders)
             {
-                if (toVal.holders.find(k) == toVal.holders.end())
+                if (!toVal.holders.contains(k))
                 {
                     toVal.holders[k] = v;
                 }

src/libxrpl/ledger/RawStateTable.cpp

@@ -1,7 +1,19 @@
-#include <xrpl/basics/contract.h>
 #include <xrpl/ledger/detail/RawStateTable.h>
 
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/RawView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/XRPAmount.h>
+
+#include <memory>
+#include <optional>
 #include <stdexcept>
+#include <tuple>
+#include <utility>
 
 namespace xrpl {
 namespace detail {

src/libxrpl/ledger/ReadView.cpp

@@ -1,5 +1,16 @@
 #include <xrpl/ledger/ReadView.h>
 
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/hash/uhash.h>
+#include <xrpl/ledger/detail/ReadViewFwdRange.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/Rules.h>
+#include <xrpl/protocol/SField.h>
+
+#include <optional>
+#include <unordered_set>
+
 namespace xrpl {
 
 ReadView::sles_type::sles_type(ReadView const& view) : ReadViewFwdRange(view)

src/libxrpl/ledger/View.cpp

@@ -1,26 +1,39 @@
-#include <xrpl/basics/Expected.h>
-#include <xrpl/basics/Log.h>
-#include <xrpl/basics/chrono.h>
-#include <xrpl/beast/utility/instrumentation.h>
-#include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/View.h>
+
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/chrono.h>
+#include <xrpl/basics/safe_cast.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
 #include <xrpl/ledger/helpers/CredentialHelpers.h>
 #include <xrpl/ledger/helpers/DirectoryHelpers.h>
 #include <xrpl/ledger/helpers/RippleStateHelpers.h>
+#include <xrpl/ledger/helpers/TokenHelpers.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/Asset.h>
 #include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Issue.h>
+#include <xrpl/protocol/Keylet.h>
 #include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/MPTIssue.h>
 #include <xrpl/protocol/Protocol.h>
-#include <xrpl/protocol/Quality.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STAmount.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/TER.h>
-#include <xrpl/protocol/TxFlags.h>
-#include <xrpl/protocol/digest.h>
-#include <xrpl/protocol/st.h>
+#include <xrpl/protocol/XRPAmount.h>
 
-#include <type_traits>
-#include <variant>
+#include <cstdint>
+#include <memory>
+#include <optional>
+#include <set>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/AMMHelpers.cpp

@@ -1,6 +1,44 @@
 #include <xrpl/ledger/helpers/AMMHelpers.h>
-//
+
+#include <xrpl/basics/Expected.h>
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/Number.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/safe_cast.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/ledger/Sandbox.h>
 #include <xrpl/ledger/View.h>
+#include <xrpl/ledger/helpers/RippleStateHelpers.h>
+#include <xrpl/ledger/helpers/TokenHelpers.h>
+#include <xrpl/protocol/AMMCore.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/AmountConversions.h>
+#include <xrpl/protocol/Asset.h>
+#include <xrpl/protocol/Feature.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Issue.h>
+#include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/MPTIssue.h>
+#include <xrpl/protocol/Protocol.h>
+#include <xrpl/protocol/Rules.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STAmount.h>
+#include <xrpl/protocol/STArray.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/TER.h>
+
+#include <algorithm>
+#include <chrono>
+#include <cstdint>
+#include <functional>
+#include <memory>
+#include <optional>
+#include <tuple>
+#include <utility>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/AccountRootHelpers.cpp

@@ -1,14 +1,33 @@
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
-//
+
+#include <xrpl/basics/Expected.h>
 #include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/Zero.h>
 #include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Feature.h>
+#include <xrpl/protocol/Indexes.h>
 #include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/Rate.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/XRPAmount.h>
 #include <xrpl/protocol/digest.h>
 
 #include <algorithm>
+#include <cstdint>
 #include <limits>
+#include <memory>
+#include <optional>
+#include <set>
 #include <stdexcept>
+#include <vector>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/CredentialHelpers.cpp

@@ -1,11 +1,32 @@
 #include <xrpl/ledger/helpers/CredentialHelpers.h>
-//
-#include <xrpl/ledger/View.h>
+
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/Slice.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/chrono.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/Protocol.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STArray.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/STTx.h>
+#include <xrpl/protocol/STVector256.h>
 #include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/digest.h>
 
+#include <cstdint>
+#include <limits>
+#include <memory>
+#include <set>
 #include <unordered_set>
+#include <utility>
+#include <vector>
 
 namespace xrpl {
 namespace credentials {

src/libxrpl/ledger/helpers/DirectoryHelpers.cpp

@@ -1,6 +1,19 @@
 #include <xrpl/ledger/helpers/DirectoryHelpers.h>
-//
+
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Keylet.h>
 #include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+
+#include <cstdint>
+#include <functional>
+#include <memory>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/MPTokenHelpers.cpp

@@ -1,15 +1,40 @@
 #include <xrpl/ledger/helpers/MPTokenHelpers.h>
-//
+
 #include <xrpl/basics/Log.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/View.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
 #include <xrpl/ledger/helpers/CredentialHelpers.h>
 #include <xrpl/ledger/helpers/DirectoryHelpers.h>
+#include <xrpl/ledger/helpers/TokenHelpers.h>
+#include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/MPTIssue.h>
+#include <xrpl/protocol/Protocol.h>
+#include <xrpl/protocol/Rate.h>
 #include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STAmount.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
+#include <xrpl/protocol/TxFormats.h>
+#include <xrpl/protocol/UintTypes.h>
+#include <xrpl/protocol/XRPAmount.h>
+
+#include <cstdint>
+#include <initializer_list>
+#include <limits>
+#include <memory>
+#include <optional>
+#include <stdexcept>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/NFTokenHelpers.cpp

@@ -1,19 +1,42 @@
+#include <xrpl/ledger/helpers/NFTokenHelpers.h>
+
 #include <xrpl/basics/Log.h>
-#include <xrpl/basics/algorithm.h>
-#include <xrpl/ledger/Dir.h>
-#include <xrpl/ledger/View.h>
+#include <xrpl/basics/Slice.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
 #include <xrpl/ledger/helpers/DirectoryHelpers.h>
-#include <xrpl/ledger/helpers/NFTokenHelpers.h>
 #include <xrpl/ledger/helpers/RippleStateHelpers.h>
 #include <xrpl/ledger/helpers/TokenHelpers.h>
+#include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Feature.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Issue.h>
+#include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/Protocol.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STAmount.h>
 #include <xrpl/protocol/STArray.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/SeqProxy.h>
+#include <xrpl/protocol/TER.h>
 #include <xrpl/protocol/TxFlags.h>
+#include <xrpl/protocol/XRPAmount.h>
+#include <xrpl/protocol/nft.h>
 #include <xrpl/protocol/nftPageMask.h>
 
+#include <algorithm>
+#include <cstddef>
+#include <cstdint>
 #include <functional>
+#include <iterator>
 #include <memory>
+#include <optional>
+#include <stdexcept>
+#include <utility>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/OfferHelpers.cpp

@@ -1,9 +1,17 @@
 #include <xrpl/ledger/helpers/OfferHelpers.h>
-//
+
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
 #include <xrpl/protocol/Indexes.h>
-#include <xrpl/protocol/LedgerFormats.h>
-#include <xrpl/protocol/st.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STArray.h>  // IWYU pragma: keep
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/TER.h>
+
+#include <memory>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/PaymentChannelHelpers.cpp

@@ -1,8 +1,18 @@
-#include <xrpl/basics/Log.h>
-#include <xrpl/ledger/View.h>
-#include <xrpl/ledger/helpers/AccountRootHelpers.h>
 #include <xrpl/ledger/helpers/PaymentChannelHelpers.h>
+
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/helpers/AccountRootHelpers.h>
+#include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/TER.h>
+
+#include <memory>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp

@@ -1,6 +1,18 @@
-#include <xrpl/ledger/helpers/CredentialHelpers.h>
 #include <xrpl/ledger/helpers/PermissionedDEXHelpers.h>
 
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/ledger/ReadView.h>
+#include <xrpl/ledger/helpers/CredentialHelpers.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/UintTypes.h>
+
+#include <algorithm>
+
 namespace xrpl {
 namespace permissioned_dex {
 

src/libxrpl/ledger/helpers/RippleStateHelpers.cpp

@@ -1,15 +1,34 @@
 #include <xrpl/ledger/helpers/RippleStateHelpers.h>
-//
+
 #include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/Zero.h>
+#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
 #include <xrpl/ledger/helpers/DirectoryHelpers.h>
+#include <xrpl/ledger/helpers/TokenHelpers.h>
+#include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/AmountConversions.h>
 #include <xrpl/protocol/Feature.h>
+#include <xrpl/protocol/IOUAmount.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/Rules.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STAmount.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/TER.h>
+#include <xrpl/protocol/UintTypes.h>
+#include <xrpl/protocol/XRPAmount.h>
+
+#include <algorithm>
+#include <cstdint>
+#include <memory>
+#include <optional>
 
 namespace xrpl {
 

src/libxrpl/ledger/helpers/TokenHelpers.cpp

@@ -1,19 +1,34 @@
 #include <xrpl/ledger/helpers/TokenHelpers.h>
-//
+
 #include <xrpl/basics/Log.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/Zero.h>
 #include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/ledger/ApplyView.h>
+#include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
 #include <xrpl/ledger/helpers/MPTokenHelpers.h>
 #include <xrpl/ledger/helpers/RippleStateHelpers.h>
+#include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/Asset.h>
+#include <xrpl/protocol/Concepts.h>
 #include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/MPTIssue.h>
 #include <xrpl/protocol/Protocol.h>
-#include <xrpl/protocol/Quality.h>
+#include <xrpl/protocol/Rate.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STAmount.h>
+#include <xrpl/protocol/STLedgerEntry.h>
 #include <xrpl/protocol/TER.h>
-#include <xrpl/protocol/st.h>
+#include <xrpl/protocol/UintTypes.h>
+#include <xrpl/protocol/XRPAmount.h>
 
-#include <type_traits>
+#include <cstdint>
+#include <initializer_list>
+#include <string>
 #include <variant>
 
 namespace xrpl {

src/libxrpl/ledger/helpers/VaultHelpers.cpp

@@ -1,8 +1,14 @@
 #include <xrpl/ledger/helpers/VaultHelpers.h>
-//
+
 #include <xrpl/basics/Number.h>
-#include <xrpl/protocol/LedgerFormats.h>
-#include <xrpl/protocol/st.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/protocol/SField.h>
+#include <xrpl/protocol/STAmount.h>
+#include <xrpl/protocol/STLedgerEntry.h>
+#include <xrpl/protocol/STNumber.h>  // IWYU pragma: keep
+
+#include <memory>
+#include <optional>
 
 namespace xrpl {
 

src/libxrpl/net/HTTPClient.cpp

@@ -1,16 +1,35 @@
+#include <xrpl/net/HTTPClient.h>
+
 #include <xrpl/basics/Log.h>
 #include <xrpl/beast/core/LexicalCast.h>
+#include <xrpl/beast/utility/Journal.h>
 #include <xrpl/net/AutoSocket.h>
-#include <xrpl/net/HTTPClient.h>
 #include <xrpl/net/HTTPClientSSLContext.h>
 
-#include <boost/asio.hpp>
+#include <boost/asio/basic_waitable_timer.hpp>
+#include <boost/asio/completion_condition.hpp>
+#include <boost/asio/connect.hpp>
+#include <boost/asio/error.hpp>
+#include <boost/asio/io_context.hpp>
 #include <boost/asio/ip/resolver_query_base.hpp>
 #include <boost/asio/ip/tcp.hpp>
-#include <boost/asio/ssl.hpp>
-#include <boost/regex.hpp>
+#include <boost/regex/v5/regex.hpp>
+#include <boost/regex/v5/regex_match.hpp>
+#include <boost/system/detail/errc.hpp>
+#include <boost/system/detail/error_code.hpp>
+#include <boost/system/detail/system_category.hpp>
+#include <boost/system/system_error.hpp>
 
+#include <chrono>
+#include <cstddef>
+#include <cstdlib>
+#include <deque>
+#include <functional>
+#include <iterator>
+#include <memory>
 #include <optional>
+#include <ostream>
+#include <string>
 
 namespace xrpl {
 
@@ -184,7 +203,7 @@ public:
             JLOG(j_.trace()) << "Deadline error: " << mDeqSites[0] << ": " << ecResult.message();
 
             // Can't do anything sound.
-            abort();
+            std::abort();
         }
         else
         {

src/libxrpl/net/RegisterSSLCerts.cpp

@@ -1,5 +1,10 @@
 #include <xrpl/net/RegisterSSLCerts.h>
 
+#include <xrpl/beast/utility/Journal.h>
+
+#include <boost/asio/ssl/context.hpp>
+#include <boost/system/detail/error_code.hpp>
+
 #if BOOST_OS_WINDOWS
 #include <boost/asio/ssl/error.hpp>
 #include <boost/system/error_code.hpp>

src/libxrpl/nodestore/BatchWriter.cpp

@@ -1,5 +1,16 @@
 #include <xrpl/nodestore/detail/BatchWriter.h>
 
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Types.h>
+
+#include <algorithm>
+#include <chrono>
+#include <memory>
+#include <mutex>
+#include <vector>
+
 namespace xrpl {
 namespace NodeStore {
 

src/libxrpl/nodestore/Database.cpp

@@ -1,11 +1,33 @@
-#include <xrpl/basics/chrono.h>
-#include <xrpl/beast/core/CurrentThreadName.h>
-#include <xrpl/json/json_value.h>
 #include <xrpl/nodestore/Database.h>
-#include <xrpl/protocol/HashPrefix.h>
+
+#include <xrpl/basics/BasicConfig.h>
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/core/CurrentThreadName.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/json/json_forwards.h>
+#include <xrpl/json/json_value.h>
+#include <xrpl/nodestore/Backend.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Types.h>
+#include <xrpl/protocol/SystemParameters.h>
 #include <xrpl/protocol/jss.h>
 
+#include <algorithm>
+#include <atomic>
 #include <chrono>
+#include <cstdint>
+#include <exception>
+#include <functional>
+#include <memory>
+#include <mutex>
+#include <stdexcept>
+#include <string>
+#include <thread>
+#include <utility>
 
 namespace xrpl {
 namespace NodeStore {

src/libxrpl/nodestore/DatabaseNodeImp.cpp

@@ -1,5 +1,25 @@
 #include <xrpl/nodestore/detail/DatabaseNodeImp.h>
 
+#include <xrpl/basics/Blob.h>
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/basics/strHex.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/nodestore/Database.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Types.h>
+
+#include <chrono>
+#include <cstddef>
+#include <cstdint>
+#include <exception>
+#include <functional>
+#include <memory>
+#include <utility>
+#include <vector>
+
 namespace xrpl {
 namespace NodeStore {
 

src/libxrpl/nodestore/DatabaseRotatingImp.cpp

@@ -1,5 +1,26 @@
 #include <xrpl/nodestore/detail/DatabaseRotatingImp.h>
 
+#include <xrpl/basics/BasicConfig.h>
+#include <xrpl/basics/Blob.h>
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/nodestore/Backend.h>
+#include <xrpl/nodestore/Database.h>
+#include <xrpl/nodestore/DatabaseRotating.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Types.h>
+
+#include <cstdint>
+#include <exception>
+#include <functional>
+#include <memory>
+#include <mutex>
+#include <string>
+#include <utility>
+
 namespace xrpl {
 namespace NodeStore {
 

src/libxrpl/nodestore/DecodedBlob.cpp

@@ -1,8 +1,14 @@
-#include <xrpl/basics/safe_cast.h>
-#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/nodestore/detail/DecodedBlob.h>
 
+#include <xrpl/basics/Blob.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/basics/safe_cast.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/nodestore/NodeObject.h>
+
 #include <algorithm>
+#include <memory>
+#include <utility>
 
 namespace xrpl {
 namespace NodeStore {

src/libxrpl/nodestore/DummyScheduler.cpp

@@ -1,5 +1,8 @@
 #include <xrpl/nodestore/DummyScheduler.h>
 
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Task.h>
+
 namespace xrpl {
 namespace NodeStore {
 

src/libxrpl/nodestore/ManagerImp.cpp

@@ -1,8 +1,26 @@
-#include <xrpl/nodestore/detail/DatabaseNodeImp.h>
 #include <xrpl/nodestore/detail/ManagerImp.h>
 
+#include <xrpl/basics/BasicConfig.h>
+#include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/nodestore/Backend.h>
+#include <xrpl/nodestore/Database.h>
+#include <xrpl/nodestore/Manager.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/detail/DatabaseNodeImp.h>
+
 #include <boost/algorithm/string/predicate.hpp>
 
+#include <algorithm>
+#include <cstddef>
+#include <memory>
+#include <mutex>
+#include <stdexcept>
+#include <string>
+#include <utility>
+
 namespace xrpl {
 
 namespace NodeStore {

src/libxrpl/nodestore/NodeObject.cpp

@@ -1,6 +1,10 @@
 #include <xrpl/nodestore/NodeObject.h>
 
+#include <xrpl/basics/Blob.h>
+#include <xrpl/basics/base_uint.h>
+
 #include <memory>
+#include <utility>
 
 namespace xrpl {
 

src/libxrpl/nodestore/backend/MemoryFactory.cpp

@@ -1,13 +1,28 @@
+#include <xrpl/basics/BasicConfig.h>
+#include <xrpl/basics/base_uint.h>
 #include <xrpl/basics/contract.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/nodestore/Backend.h>
 #include <xrpl/nodestore/Factory.h>
 #include <xrpl/nodestore/Manager.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Types.h>
 
 #include <boost/beast/core/string.hpp>
 #include <boost/core/ignore_unused.hpp>
 
+#include <cstddef>
+#include <functional>
 #include <map>
 #include <memory>
 #include <mutex>
+#include <stdexcept>
+#include <string>
+#include <tuple>
+#include <utility>
+#include <vector>
 
 namespace xrpl {
 namespace NodeStore {

src/libxrpl/nodestore/backend/NuDBFactory.cpp

@@ -1,21 +1,48 @@
+#include <xrpl/basics/BasicConfig.h>
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
 #include <xrpl/basics/contract.h>
 #include <xrpl/beast/core/LexicalCast.h>
+#include <xrpl/beast/utility/Journal.h>
 #include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/nodestore/Backend.h>
 #include <xrpl/nodestore/Factory.h>
 #include <xrpl/nodestore/Manager.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Types.h>
 #include <xrpl/nodestore/detail/DecodedBlob.h>
 #include <xrpl/nodestore/detail/EncodedBlob.h>
 #include <xrpl/nodestore/detail/codec.h>
 
-#include <boost/filesystem.hpp>
+#include <boost/filesystem/operations.hpp>
+#include <boost/filesystem/path.hpp>
+#include <boost/system/detail/errc.hpp>
 
-#include <nudb/nudb.hpp>
+#include <nudb/context.hpp>
+#include <nudb/create.hpp>  // IWYU pragma: keep
+#include <nudb/detail/buffer.hpp>
+#include <nudb/error.hpp>
+#include <nudb/file.hpp>
+#include <nudb/progress.hpp>
+#include <nudb/store.hpp>
+#include <nudb/verify.hpp>  // IWYU pragma: keep
+#include <nudb/visit.hpp>   // IWYU pragma: keep
+#include <nudb/xxhasher.hpp>
 
+#include <atomic>
 #include <chrono>
 #include <cstdint>
 #include <cstdio>
 #include <exception>
+#include <functional>
 #include <memory>
+#include <optional>
+#include <sstream>
+#include <stdexcept>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace xrpl {
 namespace NodeStore {

src/libxrpl/nodestore/backend/NullFactory.cpp

@@ -1,7 +1,19 @@
+#include <xrpl/basics/BasicConfig.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/nodestore/Backend.h>
 #include <xrpl/nodestore/Factory.h>
 #include <xrpl/nodestore/Manager.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Types.h>
 
+#include <cstddef>
+#include <functional>
 #include <memory>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace xrpl {
 namespace NodeStore {

src/libxrpl/nodestore/backend/RocksDBFactory.cpp

@@ -1,4 +1,36 @@
-#include <xrpl/basics/rocksdb.h>
+#include <xrpl/basics/BasicConfig.h>
+#include <xrpl/basics/Log.h>
+#include <xrpl/basics/base_uint.h>
+#include <xrpl/beast/utility/Journal.h>
+#include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/nodestore/Backend.h>
+#include <xrpl/nodestore/NodeObject.h>
+#include <xrpl/nodestore/Scheduler.h>
+#include <xrpl/nodestore/Types.h>
+
+#include <boost/filesystem/operations.hpp>
+#include <boost/filesystem/path.hpp>
+
+#include <rocksdb/advanced_options.h>
+#include <rocksdb/cache.h>
+#include <rocksdb/compression_type.h>
+#include <rocksdb/convenience.h>
+#include <rocksdb/db.h>
+#include <rocksdb/env.h>
+#include <rocksdb/filter_policy.h>
+#include <rocksdb/iterator.h>
+#include <rocksdb/options.h>
+#include <rocksdb/slice.h>
+#include <rocksdb/table.h>
+#include <rocksdb/write_batch.h>
+
+#include <bit>
+#include <cstddef>
+#include <functional>
+#include <stdexcept>
+#include <string>
+#include <utility>
+#include <vector>
 
 #if XRPL_ROCKSDB_AVAILABLE
 #include <xrpl/basics/ByteUtilities.h>

src/libxrpl/protocol/AMMCore.cpp

@@ -1,10 +1,14 @@
+#include <xrpl/protocol/AMMCore.h>
+
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Zero.h>
 #include <xrpl/beast/utility/instrumentation.h>
-#include <xrpl/protocol/AMMCore.h>
 #include <xrpl/protocol/AccountID.h>
+#include <xrpl/protocol/Asset.h>
+#include <xrpl/protocol/Concepts.h>
 #include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/Issue.h>
+#include <xrpl/protocol/MPTIssue.h>
 #include <xrpl/protocol/Rules.h>
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/STAmount.h>
@@ -17,6 +21,7 @@
 #include <cstdint>
 #include <optional>
 #include <utility>
+#include <variant>
 
 namespace xrpl {
 

src/libxrpl/protocol/AccountID.cpp

@@ -1,8 +1,9 @@
+#include <xrpl/protocol/AccountID.h>
+
 #include <xrpl/basics/hardened_hash.h>
 #include <xrpl/basics/spinlock.h>
 #include <xrpl/beast/utility/Zero.h>
 #include <xrpl/beast/utility/instrumentation.h>
-#include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/PublicKey.h>
 #include <xrpl/protocol/digest.h>
 #include <xrpl/protocol/tokens.h>

src/libxrpl/protocol/Asset.cpp

@@ -1,12 +1,16 @@
+#include <xrpl/protocol/Asset.h>
+
+#include <xrpl/basics/Number.h>
 #include <xrpl/basics/contract.h>
 #include <xrpl/json/json_value.h>
 #include <xrpl/protocol/AccountID.h>
-#include <xrpl/protocol/Asset.h>
+#include <xrpl/protocol/Concepts.h>
 #include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/MPTIssue.h>
 #include <xrpl/protocol/STAmount.h>
 #include <xrpl/protocol/jss.h>
 
+#include <ostream>
 #include <stdexcept>
 #include <string>
 #include <variant>

src/libxrpl/protocol/Book.cpp

@@ -1,5 +1,6 @@
 #include <xrpl/protocol/Book.h>
-#include <xrpl/protocol/Issue.h>
+
+#include <xrpl/protocol/Asset.h>
 
 #include <ostream>
 #include <string>

src/libxrpl/protocol/BuildInfo.cpp

@@ -1,11 +1,12 @@
+#include <xrpl/protocol/BuildInfo.h>
+
 #include <xrpl/basics/contract.h>
 #include <xrpl/beast/core/LexicalCast.h>
 #include <xrpl/beast/core/SemanticVersion.h>
-#include <xrpl/git/Git.h>
-#include <xrpl/protocol/BuildInfo.h>
+#include <xrpl/git/Git.h>  // IWYU pragma: keep
 #include <xrpl/protocol/SystemParameters.h>
 
-#include <boost/preprocessor/stringize.hpp>
+#include <boost/preprocessor/stringize.hpp>  // IWYU pragma: keep
 
 #include <algorithm>
 #include <cstdint>

src/libxrpl/protocol/ErrorCodes.cpp

@@ -1,6 +1,7 @@
+#include <xrpl/protocol/ErrorCodes.h>
+
 #include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/json/json_value.h>
-#include <xrpl/protocol/ErrorCodes.h>
 #include <xrpl/protocol/jss.h>
 
 #include <array>

src/libxrpl/protocol/Feature.cpp

@@ -1,8 +1,9 @@
+#include <xrpl/protocol/Feature.h>
+
 #include <xrpl/basics/Slice.h>
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/basics/contract.h>
 #include <xrpl/beast/utility/instrumentation.h>
-#include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/digest.h>
 
 #include <boost/container_hash/hash.hpp>

src/libxrpl/protocol/IOUAmount.cpp

@@ -1,20 +1,18 @@
 #include <xrpl/protocol/IOUAmount.h>
-// Do not remove. Forces IOUAmount.h to stay first, to verify it can compile
-// without any hidden dependencies
+
 #include <xrpl/basics/LocalValue.h>
 #include <xrpl/basics/Number.h>
 #include <xrpl/basics/contract.h>
 #include <xrpl/beast/utility/Zero.h>
 #include <xrpl/protocol/STAmount.h>
 
-#include <boost/multiprecision/cpp_int.hpp>
-
 #include <algorithm>
 #include <cstdint>
 #include <iterator>
 #include <limits>
 #include <stdexcept>
 #include <string>
+#include <tuple>
 #include <vector>
 
 namespace xrpl {

src/libxrpl/protocol/Indexes.cpp

@@ -1,3 +1,5 @@
+#include <xrpl/protocol/Indexes.h>
+
 #include <xrpl/basics/Slice.h>
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/basics/safe_cast.h>
@@ -5,8 +7,10 @@
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Asset.h>
 #include <xrpl/protocol/Book.h>
-#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/Concepts.h>
+#include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/LedgerFormats.h>
+#include <xrpl/protocol/MPTIssue.h>
 #include <xrpl/protocol/Protocol.h>
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/STXChainBridge.h>
@@ -23,6 +27,7 @@
 #include <cstring>
 #include <set>
 #include <utility>
+#include <variant>
 #include <vector>
 
 namespace xrpl {

src/libxrpl/protocol/InnerObjectFormats.cpp

@@ -1,4 +1,5 @@
 #include <xrpl/protocol/InnerObjectFormats.h>
+
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/SOTemplate.h>
 

src/libxrpl/protocol/Issue.cpp

@@ -1,8 +1,9 @@
+#include <xrpl/protocol/Issue.h>
+
 #include <xrpl/basics/contract.h>
 #include <xrpl/json/json_errors.h>
 #include <xrpl/json/json_value.h>
 #include <xrpl/protocol/AccountID.h>
-#include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/UintTypes.h>
 #include <xrpl/protocol/jss.h>
 

src/libxrpl/protocol/Keylet.cpp

@@ -1,5 +1,6 @@
-#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/protocol/Keylet.h>
+
+#include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/STLedgerEntry.h>
 

src/libxrpl/protocol/LedgerFormats.cpp

@@ -1,7 +1,8 @@
 #include <xrpl/protocol/LedgerFormats.h>
+
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/SOTemplate.h>
-#include <xrpl/protocol/jss.h>
+#include <xrpl/protocol/jss.h>  // IWYU pragma: keep
 
 #include <vector>
 

src/libxrpl/protocol/LedgerHeader.cpp

@@ -1,10 +1,13 @@
+#include <xrpl/protocol/LedgerHeader.h>
+
 #include <xrpl/basics/Slice.h>
 #include <xrpl/basics/chrono.h>
 #include <xrpl/protocol/HashPrefix.h>
-#include <xrpl/protocol/LedgerHeader.h>
 #include <xrpl/protocol/Serializer.h>
 #include <xrpl/protocol/digest.h>
 
+#include <cstdint>
+
 namespace xrpl {
 
 void

src/libxrpl/protocol/MPTIssue.cpp

@@ -1,12 +1,16 @@
+#include <xrpl/protocol/MPTIssue.h>
+
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/basics/contract.h>
 #include <xrpl/json/json_errors.h>
 #include <xrpl/json/json_value.h>
+#include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
-#include <xrpl/protocol/MPTIssue.h>
+#include <xrpl/protocol/UintTypes.h>
 #include <xrpl/protocol/jss.h>
 
 #include <cstdint>
+#include <ostream>
 #include <stdexcept>
 #include <string>
 

src/libxrpl/protocol/NFTSyntheticSerializer.cpp

@@ -1,5 +1,6 @@
-#include <xrpl/json/json_value.h>
 #include <xrpl/protocol/NFTSyntheticSerializer.h>
+
+#include <xrpl/json/json_value.h>
 #include <xrpl/protocol/NFTokenID.h>
 #include <xrpl/protocol/NFTokenOfferID.h>
 #include <xrpl/protocol/STTx.h>

src/libxrpl/protocol/NFTokenID.cpp

@@ -1,7 +1,8 @@
+#include <xrpl/protocol/NFTokenID.h>
+
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/json/json_value.h>
 #include <xrpl/protocol/LedgerFormats.h>
-#include <xrpl/protocol/NFTokenID.h>
 #include <xrpl/protocol/SField.h>
 #include <xrpl/protocol/STArray.h>
 #include <xrpl/protocol/STObject.h>