From 8ae1d99db9ac4a3597b6b974483630e11fb8ce45 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Sat, 15 Aug 2026 17:49:06 +0100 Subject: [PATCH] fix(telemetry): remove duplicate [insight] section from integration test The generated node config carried two [insight] blocks. Duplicate ini sections do not replace one another: parseIniFile emplaces the section name (a no-op when it already exists) and appends the lines to the same vector, then Section::append writes each key with insert_or_assign. The effective section was therefore server=statsd with the first block's endpoint and service_instance_id surviving but unused. CollectorManager selects StatsDCollector for that value, so the nodes emitted beast::insight metrics over UDP to 8125, which has no receiver in the collector pipeline and no published port. The script's own check asserts that 8125 is not listening, and its insight metric assertions fail on zero series. Keep only the server=otel block so the config matches what the script verifies. --- docker/telemetry/integration-test.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/docker/telemetry/integration-test.sh b/docker/telemetry/integration-test.sh index 42b6b5de55..af92135da6 100755 --- a/docker/telemetry/integration-test.sh +++ b/docker/telemetry/integration-test.sh @@ -382,11 +382,6 @@ endpoint=http://localhost:4318/v1/metrics prefix=rippled service_instance_id=Node-${i} -[insight] -server=statsd -address=127.0.0.1:8125 -prefix=rippled - [rpc_startup] { "command": "log_level", "severity": "warning" }