refactor: Retire fixUniversalNumber amendment (#5962)

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-06-10 11:16:03 +01:00
committed by GitHub
parent 742aa0878b
commit 8a4bf2dee6
17 changed files with 55 additions and 379 deletions

View File

@@ -1973,54 +1973,36 @@ public:
using namespace jtx;
for (auto numberSwitchOver : {false, true})
{
Env env{*this, features};
if (numberSwitchOver)
{
env.enableFeature(fixUniversalNumber);
}
else
{
env.disableFeature(fixUniversalNumber);
}
Env env{*this, features};
auto const gw = Account{"gateway"};
auto const alice = Account{"alice"};
auto const bob = Account{"bob"};
auto const usd = gw["USD"];
auto const gw = Account{"gateway"};
auto const alice = Account{"alice"};
auto const bob = Account{"bob"};
auto const usd = gw["USD"];
env.fund(XRP(10000), gw, alice, bob);
env.close();
env.fund(XRP(10000), gw, alice, bob);
env.close();
env(rate(gw, 1.005));
env(rate(gw, 1.005));
env(trust(alice, usd(1000)));
env(trust(bob, usd(1000)));
env(trust(gw, alice["USD"](50)));
env(trust(alice, usd(1000)));
env(trust(bob, usd(1000)));
env(trust(gw, alice["USD"](50)));
env(pay(gw, bob, bob["USD"](1)));
env(pay(alice, gw, usd(50)));
env(pay(gw, bob, bob["USD"](1)));
env(pay(alice, gw, usd(50)));
env(trust(gw, alice["USD"](0)));
env(trust(gw, alice["USD"](0)));
env(offer(alice, usd(50), XRP(150000)));
env(offer(bob, XRP(100), usd(0.1)));
env(offer(alice, usd(50), XRP(150000)));
env(offer(bob, XRP(100), usd(0.1)));
auto jrr = ledgerEntryState(env, alice, gw, "USD");
BEAST_EXPECT(jrr[jss::node][sfBalance.fieldName][jss::value] == "49.96666666666667");
auto jrr = ledgerEntryState(env, alice, gw, "USD");
BEAST_EXPECT(jrr[jss::node][sfBalance.fieldName][jss::value] == "49.96666666666667");
jrr = ledgerEntryState(env, bob, gw, "USD");
json::Value const bobUSD = jrr[jss::node][sfBalance.fieldName][jss::value];
if (!numberSwitchOver)
{
BEAST_EXPECT(bobUSD == "-0.966500000033334");
}
else
{
BEAST_EXPECT(bobUSD == "-0.9665000000333333");
}
}
jrr = ledgerEntryState(env, bob, gw, "USD");
json::Value const bobUSD = jrr[jss::node][sfBalance.fieldName][jss::value];
BEAST_EXPECT(bobUSD == "-0.9665000000333333");
}
void