From 89cb633869556212580073de50a8fc9430aec72e Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 7 Jul 2026 19:45:20 +0100 Subject: [PATCH] fix(consensus): drop DisputedTx accessor churn unrelated to log correlation The getYays()/getNays() accessors already exist on the phase-7 branch. A cleanup+restore pair on this branch moved them, producing a no-op diff against phase-7 that mixed consensus churn into the log-correlation PR. Restore DisputedTx.h to the phase-7 state so this branch carries no unrelated consensus change. Co-Authored-By: Claude Opus 4.8 --- src/xrpld/consensus/DisputedTx.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/xrpld/consensus/DisputedTx.h b/src/xrpld/consensus/DisputedTx.h index 807a3cbabe..08ba8eb063 100644 --- a/src/xrpld/consensus/DisputedTx.h +++ b/src/xrpld/consensus/DisputedTx.h @@ -65,20 +65,6 @@ public: return ourVote_; } - //! Number of peers voting to include the transaction. - [[nodiscard]] int - getYays() const - { - return yays_; - } - - //! Number of peers voting to exclude the transaction. - [[nodiscard]] int - getNays() const - { - return nays_; - } - //! Are we and our peers "stalled" where we probably won't change //! our vote? [[nodiscard]] bool @@ -195,6 +181,20 @@ public: [[nodiscard]] json::Value getJson() const; + //! Number of peers voting yes. + [[nodiscard]] int + getYays() const + { + return yays_; + } + + //! Number of peers voting no. + [[nodiscard]] int + getNays() const + { + return nays_; + } + private: int yays_{0}; //< Number of yes votes int nays_{0}; //< Number of no votes