refactor: Enable clang-tidy readability-identifier-naming check (#6571)

This commit is contained in:
Alex Kremer
2026-05-03 11:31:53 +01:00
committed by GitHub
parent 182d844996
commit 8995564ed6
1498 changed files with 58858 additions and 58914 deletions

View File

@@ -30,7 +30,7 @@
namespace xrpl::test {
class ValidatorRPC_test : public beast::unit_test::suite
class ValidatorRPC_test : public beast::unit_test::Suite
{
using Validator = TrustedPublisherServer::Validator;
@@ -44,8 +44,8 @@ public:
{
for (std::string const cmd : {"validators", "validator_list_sites"})
{
Env env{*this, isAdmin ? envconfig() : envconfig(no_admin)};
env.set_retries(isAdmin ? 5 : 0);
Env env{*this, isAdmin ? envconfig() : envconfig(noAdmin)};
env.setRetries(isAdmin ? 5 : 0);
auto const jrr = env.rpc(cmd)[jss::result];
if (isAdmin)
{
@@ -63,14 +63,14 @@ public:
}
{
Env env{*this, isAdmin ? envconfig() : envconfig(no_admin)};
Env env{*this, isAdmin ? envconfig() : envconfig(noAdmin)};
auto const jrr = env.rpc("server_info")[jss::result];
BEAST_EXPECT(jrr[jss::status] == "success");
BEAST_EXPECT(jrr[jss::info].isMember(jss::validator_list) == isAdmin);
}
{
Env env{*this, isAdmin ? envconfig() : envconfig(no_admin)};
Env env{*this, isAdmin ? envconfig() : envconfig(noAdmin)};
auto const jrr = env.rpc("server_state")[jss::result];
BEAST_EXPECT(jrr[jss::status] == "success");
BEAST_EXPECT(jrr[jss::state].isMember(jss::validator_list_expires) == isAdmin);
@@ -133,8 +133,8 @@ public:
// Negative UNL update
{
hash_set<PublicKey> disabledKeys;
auto k1 = randomKeyPair(KeyType::ed25519).first;
auto k2 = randomKeyPair(KeyType::ed25519).first;
auto k1 = randomKeyPair(KeyType::Ed25519).first;
auto k2 = randomKeyPair(KeyType::Ed25519).first;
disabledKeys.insert(k1);
disabledKeys.insert(k2);
env.app().getValidators().setNegativeUNL(disabledKeys);
@@ -181,8 +181,8 @@ public:
NetClock::time_point const validUntil{3600s};
NetClock::time_point const validFrom2{validUntil - 60s};
NetClock::time_point const validUntil2{validFrom2 + 3600s};
auto server = make_TrustedPublisherServer(
worker.get_io_context(),
auto server = makeTrustedPublisherServer(
worker.getIoContext(),
validators,
validUntil,
{{validFrom2, validUntil2}},
@@ -317,7 +317,7 @@ public:
// Publisher list site available v1
{
std::stringstream uri;
uri << "http://" << server->local_endpoint() << "/validators";
uri << "http://" << server->localEndpoint() << "/validators";
auto siteURI = uri.str();
Env env{
@@ -410,7 +410,7 @@ public:
// Publisher list site available v2
{
std::stringstream uri;
uri << "http://" << server->local_endpoint() << "/validators2";
uri << "http://" << server->localEndpoint() << "/validators2";
auto siteURI = uri.str();
Env env{
@@ -522,7 +522,7 @@ public:
}
void
test_validation_create()
testValidationCreate()
{
using namespace test::jtx;
Env env{*this};
@@ -539,7 +539,7 @@ public:
testPrivileges();
testStaticUNL();
testDynamicUNL();
test_validation_create();
testValidationCreate();
}
};