ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 08:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Enable clang-tidy readability-identifier-naming check (#6571)

Browse Source
This commit is contained in:
Alex Kremer
2026-05-03 11:31:53 +01:00
committed by GitHub
parent 182d844996
commit 8995564ed6
1498 changed files with 58858 additions and 58914 deletions
Download Patch File Download Diff File Expand all files Collapse all files

130
src/test/rpc/ServerDefinitions_test.cpp
View File

@@ -10,7 +10,7 @@
namespace xrpl::test {
class ServerDefinitions_test : public beast::unit_test::suite
class ServerDefinitions_test : public beast::unit_test::Suite
{
public:
void
@@ -88,7 +88,7 @@ public:
// test the properties of the LEDGER_ENTRY_FLAGS section
{
BEAST_EXPECT(result[jss::result].isMember(jss::LEDGER_ENTRY_FLAGS));
Json::Value const& leFlags = result[jss::result][jss::LEDGER_ENTRY_FLAGS];
json::Value const& leFlags = result[jss::result][jss::LEDGER_ENTRY_FLAGS];
// sanity test the mapped value of a few arbitrarily chosen flags
BEAST_EXPECT(leFlags["AccountRoot"]["lsfDisallowXRP"] == 0x00080000);
@@ -109,7 +109,7 @@ public:
// validate the correctness of few chosen transaction flags
{
BEAST_EXPECT(result[jss::result].isMember(jss::TRANSACTION_FLAGS));
Json::Value const& txFlags = result[jss::result][jss::TRANSACTION_FLAGS];
json::Value const& txFlags = result[jss::result][jss::TRANSACTION_FLAGS];
BEAST_EXPECT(txFlags["universal"]["tfFullyCanonicalSig"] == 0x80000000);
BEAST_EXPECT(txFlags["universal"]["tfInnerBatchTxn"] == 0x40000000);
@@ -127,7 +127,7 @@ public:
// validate the correctness of the AccountSpecificFlags section
{
BEAST_EXPECT(result[jss::result].isMember(jss::ACCOUNT_SET_FLAGS));
Json::Value const& asFlags = result[jss::result][jss::ACCOUNT_SET_FLAGS];
json::Value const& asFlags = result[jss::result][jss::ACCOUNT_SET_FLAGS];
BEAST_EXPECT(asFlags["asfDisallowXRP"] == 3);
BEAST_EXPECT(asFlags["asfGlobalFreeze"] == 7);
@@ -138,139 +138,139 @@ public:
// test the response fields of the TRANSACTION_FORMATS section
{
BEAST_EXPECT(result[jss::result].isMember(jss::TRANSACTION_FORMATS));
Json::Value const& txnFormats = result[jss::result][jss::TRANSACTION_FORMATS];
json::Value const& txnFormats = result[jss::result][jss::TRANSACTION_FORMATS];
// first validate the contents of "common"
{
BEAST_EXPECT(txnFormats.isMember("common"));
Json::Value const& section = txnFormats["common"];
json::Value const& section = txnFormats["common"];
BEAST_EXPECT(section[0u][jss::name] == "TransactionType");
BEAST_EXPECT(section[0u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[0u][jss::optionality] == SoeRequired);
BEAST_EXPECT(section[1u][jss::name] == "Flags");
BEAST_EXPECT(section[1u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[1u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[2u][jss::name] == "SourceTag");
BEAST_EXPECT(section[2u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[2u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[3u][jss::name] == "Account");
BEAST_EXPECT(section[3u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[3u][jss::optionality] == SoeRequired);
BEAST_EXPECT(section[4u][jss::name] == "Sequence");
BEAST_EXPECT(section[4u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[4u][jss::optionality] == SoeRequired);
BEAST_EXPECT(section[5u][jss::name] == "PreviousTxnID");
BEAST_EXPECT(section[5u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[5u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[6u][jss::name] == "LastLedgerSequence");
BEAST_EXPECT(section[6u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[6u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[7u][jss::name] == "AccountTxnID");
BEAST_EXPECT(section[7u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[7u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[8u][jss::name] == "Fee");
BEAST_EXPECT(section[8u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[8u][jss::optionality] == SoeRequired);
BEAST_EXPECT(section[9u][jss::name] == "OperationLimit");
BEAST_EXPECT(section[9u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[9u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[10u][jss::name] == "Memos");
BEAST_EXPECT(section[10u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[10u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[11u][jss::name] == "SigningPubKey");
BEAST_EXPECT(section[11u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[11u][jss::optionality] == SoeRequired);
BEAST_EXPECT(section[12u][jss::name] == "TicketSequence");
BEAST_EXPECT(section[12u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[12u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[13u][jss::name] == "TxnSignature");
BEAST_EXPECT(section[13u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[13u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[14u][jss::name] == "Signers");
BEAST_EXPECT(section[14u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[14u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[15u][jss::name] == "NetworkID");
BEAST_EXPECT(section[15u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[15u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[16u][jss::name] == "Delegate");
BEAST_EXPECT(section[16u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[16u][jss::optionality] == SoeOptional);
}
// validate the contents of four arbitrarily selected transactions validate the
// format of the OracleSet transaction
{
BEAST_EXPECT(txnFormats.isMember("OracleSet"));
Json::Value const& section = txnFormats["OracleSet"];
json::Value const& section = txnFormats["OracleSet"];
BEAST_EXPECT(section[0u][jss::name] == "OracleDocumentID");
BEAST_EXPECT(section[0u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[0u][jss::optionality] == SoeRequired);
BEAST_EXPECT(section[1u][jss::name] == "Provider");
BEAST_EXPECT(section[1u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[1u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[2u][jss::name] == "URI");
BEAST_EXPECT(section[2u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[2u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[3u][jss::name] == "AssetClass");
BEAST_EXPECT(section[3u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[3u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[4u][jss::name] == "LastUpdateTime");
BEAST_EXPECT(section[4u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[4u][jss::optionality] == SoeRequired);
BEAST_EXPECT(section[5u][jss::name] == "PriceDataSeries");
BEAST_EXPECT(section[5u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[5u][jss::optionality] == SoeRequired);
}
// validate the format of the PermissionedDomainDelete transaction
{
BEAST_EXPECT(txnFormats.isMember("PermissionedDomainDelete"));
Json::Value const& section = txnFormats["PermissionedDomainDelete"];
json::Value const& section = txnFormats["PermissionedDomainDelete"];
BEAST_EXPECT(section[0u][jss::name] == "DomainID");
BEAST_EXPECT(section[0u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[0u][jss::optionality] == SoeRequired);
}
// validate the format of the Clawback transaction
{
BEAST_EXPECT(txnFormats.isMember("Clawback"));
Json::Value const& section = txnFormats["Clawback"];
json::Value const& section = txnFormats["Clawback"];
BEAST_EXPECT(section[0u][jss::name] == "Amount");
BEAST_EXPECT(section[0u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(section[0u][jss::optionality] == SoeRequired);
BEAST_EXPECT(section[1u][jss::name] == "Holder");
BEAST_EXPECT(section[1u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[1u][jss::optionality] == SoeOptional);
}
// validate the format of the SetFee transaction
{
BEAST_EXPECT(txnFormats.isMember("SetFee"));
Json::Value const& section = txnFormats["SetFee"];
json::Value const& section = txnFormats["SetFee"];
BEAST_EXPECT(section[0u][jss::name] == "LedgerSequence");
BEAST_EXPECT(section[0u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[0u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[1u][jss::name] == "BaseFee");
BEAST_EXPECT(section[1u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[1u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[2u][jss::name] == "ReferenceFeeUnits");
BEAST_EXPECT(section[2u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[2u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[3u][jss::name] == "ReserveBase");
BEAST_EXPECT(section[3u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[3u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[4u][jss::name] == "ReserveIncrement");
BEAST_EXPECT(section[4u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[4u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[5u][jss::name] == "BaseFeeDrops");
BEAST_EXPECT(section[5u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[5u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[6u][jss::name] == "ReserveBaseDrops");
BEAST_EXPECT(section[6u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[6u][jss::optionality] == SoeOptional);
BEAST_EXPECT(section[7u][jss::name] == "ReserveIncrementDrops");
BEAST_EXPECT(section[7u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(section[7u][jss::optionality] == SoeOptional);
}
}
@@ -284,72 +284,72 @@ public:
// check "common" first
{
Json::Value const& observedCommonLedgerEntry =
json::Value const& observedCommonLedgerEntry =
result[jss::result][jss::LEDGER_ENTRY_FORMATS]["common"];
BEAST_EXPECT(observedCommonLedgerEntry[0u][jss::name] == "LedgerIndex");
BEAST_EXPECT(observedCommonLedgerEntry[0u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedCommonLedgerEntry[0u][jss::optionality] == SoeOptional);
BEAST_EXPECT(observedCommonLedgerEntry[1u][jss::name] == "LedgerEntryType");
BEAST_EXPECT(observedCommonLedgerEntry[1u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(observedCommonLedgerEntry[1u][jss::optionality] == SoeRequired);
BEAST_EXPECT(observedCommonLedgerEntry[2u][jss::name] == "Flags");
BEAST_EXPECT(observedCommonLedgerEntry[2u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(observedCommonLedgerEntry[2u][jss::optionality] == SoeRequired);
}
// test the contents of an arbitrary ledger-entry (DID)
{
Json::Value const& observedDIDLedgerEntry =
json::Value const& observedDIDLedgerEntry =
result[jss::result][jss::LEDGER_ENTRY_FORMATS]["DID"];
BEAST_EXPECT(observedDIDLedgerEntry[0u][jss::name] == "Account");
BEAST_EXPECT(observedDIDLedgerEntry[0u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(observedDIDLedgerEntry[0u][jss::optionality] == SoeRequired);
BEAST_EXPECT(observedDIDLedgerEntry[1u][jss::name] == "DIDDocument");
BEAST_EXPECT(observedDIDLedgerEntry[1u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedDIDLedgerEntry[1u][jss::optionality] == SoeOptional);
BEAST_EXPECT(observedDIDLedgerEntry[2u][jss::name] == "URI");
BEAST_EXPECT(observedDIDLedgerEntry[2u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedDIDLedgerEntry[2u][jss::optionality] == SoeOptional);
BEAST_EXPECT(observedDIDLedgerEntry[3u][jss::name] == "Data");
BEAST_EXPECT(observedDIDLedgerEntry[3u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedDIDLedgerEntry[3u][jss::optionality] == SoeOptional);
BEAST_EXPECT(observedDIDLedgerEntry[4u][jss::name] == "OwnerNode");
BEAST_EXPECT(observedDIDLedgerEntry[4u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(observedDIDLedgerEntry[4u][jss::optionality] == SoeRequired);
BEAST_EXPECT(observedDIDLedgerEntry[5u][jss::name] == "PreviousTxnID");
BEAST_EXPECT(observedDIDLedgerEntry[5u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(observedDIDLedgerEntry[5u][jss::optionality] == SoeRequired);
BEAST_EXPECT(observedDIDLedgerEntry[6u][jss::name] == "PreviousTxnLgrSeq");
BEAST_EXPECT(observedDIDLedgerEntry[6u][jss::optionality] == soeREQUIRED);
BEAST_EXPECT(observedDIDLedgerEntry[6u][jss::optionality] == SoeRequired);
}
// test the contents of an arbitrary ledger-entry (NegativeUNL)
{
Json::Value const& observedNunlLedgerEntry =
json::Value const& observedNunlLedgerEntry =
result[jss::result][jss::LEDGER_ENTRY_FORMATS]["NegativeUNL"];
BEAST_EXPECT(observedNunlLedgerEntry[0u][jss::name] == "DisabledValidators");
BEAST_EXPECT(observedNunlLedgerEntry[0u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedNunlLedgerEntry[0u][jss::optionality] == SoeOptional);
BEAST_EXPECT(observedNunlLedgerEntry[1u][jss::name] == "ValidatorToDisable");
BEAST_EXPECT(observedNunlLedgerEntry[1u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedNunlLedgerEntry[1u][jss::optionality] == SoeOptional);
BEAST_EXPECT(observedNunlLedgerEntry[2u][jss::name] == "ValidatorToReEnable");
BEAST_EXPECT(observedNunlLedgerEntry[2u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedNunlLedgerEntry[2u][jss::optionality] == SoeOptional);
BEAST_EXPECT(observedNunlLedgerEntry[3u][jss::name] == "PreviousTxnID");
BEAST_EXPECT(observedNunlLedgerEntry[3u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedNunlLedgerEntry[3u][jss::optionality] == SoeOptional);
BEAST_EXPECT(observedNunlLedgerEntry[4u][jss::name] == "PreviousTxnLgrSeq");
BEAST_EXPECT(observedNunlLedgerEntry[4u][jss::optionality] == soeOPTIONAL);
BEAST_EXPECT(observedNunlLedgerEntry[4u][jss::optionality] == SoeOptional);
}
}
// Exhaustive test: verify all transaction flags from getAllTxFlags() appear in the
// output
{
Json::Value const& txFlags = result[jss::result][jss::TRANSACTION_FLAGS];
json::Value const& txFlags = result[jss::result][jss::TRANSACTION_FLAGS];
for (auto const& [txName, flagMap] : getAllTxFlags())
{
@@ -371,7 +371,7 @@ public:
// Exhaustive test: verify all ledger entry flags from getAllLedgerFlags() appear in the
// output
{
Json::Value const& leFlags = result[jss::result][jss::LEDGER_ENTRY_FLAGS];
json::Value const& leFlags = result[jss::result][jss::LEDGER_ENTRY_FLAGS];
for (auto const& [ledgerType, flagMap] : getAllLedgerFlags())
{
@@ -393,7 +393,7 @@ public:
// Exhaustive test: verify all AccountSet flags from getAsfFlagMap() appear in the
// output
{
Json::Value const& asFlags = result[jss::result][jss::ACCOUNT_SET_FLAGS];
json::Value const& asFlags = result[jss::result][jss::ACCOUNT_SET_FLAGS];
for (auto const& [flagName, flagValue] : getAsfFlagMap())
{