refactor: Enable clang-tidy readability-identifier-naming check (#6571)

This commit is contained in:
Alex Kremer
2026-05-03 11:31:53 +01:00
committed by GitHub
parent 182d844996
commit 8995564ed6
1498 changed files with 58858 additions and 58914 deletions

View File

@@ -17,7 +17,7 @@
namespace xrpl::test {
class BookChanges_test : public beast::unit_test::suite
class BookChanges_test : public beast::unit_test::Suite
{
public:
void
@@ -25,7 +25,7 @@ public:
{
testcase("Specify well-known strings as ledger input");
jtx::Env env(*this);
Json::Value params, resp;
json::Value params, resp;
// As per convention in XRPL, ledgers can be specified with strings
// "closed", "validated" or "current"
@@ -68,7 +68,7 @@ public:
// As per convention in XRPL, ledgers can be specified with strings
// "closed", "validated" or "current"
Json::Value const resp = env.rpc("json", "book_changes", to_string(Json::Value{}));
json::Value const resp = env.rpc("json", "book_changes", to_string(json::Value{}));
BEAST_EXPECT(!resp[jss::result].isMember(jss::error));
BEAST_EXPECT(resp[jss::result][jss::status] == "success");
@@ -84,7 +84,7 @@ public:
using namespace jtx;
FeatureBitset const all{
jtx::testable_amendments() | featurePermissionedDomains | featureCredentials |
jtx::testableAmendments() | featurePermissionedDomains | featureCredentials |
featurePermissionedDEX};
Env env(*this, all);
@@ -93,18 +93,18 @@ public:
auto wsc = makeWSClient(env.app().config());
env(offer(alice, XRP(10), USD(10)), domain(domainID));
env(offer(alice, XRP(10), USD(10)), Domain(domainID));
env.close();
env(pay(bob, carol, USD(10)), path(~USD), sendmax(XRP(10)), domain(domainID));
env(pay(bob, carol, USD(10)), Path(~USD), Sendmax(XRP(10)), Domain(domainID));
env.close();
std::string const txHash{env.tx()->getJson(JsonOptions::none)[jss::hash].asString()};
std::string const txHash{env.tx()->getJson(JsonOptions::KNone)[jss::hash].asString()};
Json::Value const txResult = env.rpc("tx", txHash)[jss::result];
json::Value const txResult = env.rpc("tx", txHash)[jss::result];
auto const ledgerIndex = txResult[jss::ledger_index].asInt();
Json::Value jvParams;
json::Value jvParams;
jvParams[jss::ledger_index] = ledgerIndex;
auto jv = wsc->invoke("book_changes", jvParams);