ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-25 08:00:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Enable clang-tidy readability-identifier-naming check (#6571)

Browse Source
This commit is contained in:
Alex Kremer
2026-05-03 11:31:53 +01:00
committed by GitHub
parent 182d844996
commit 8995564ed6
1498 changed files with 58858 additions and 58914 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/test/protocol/STNumber_test.cpp
View File

@@ -18,7 +18,7 @@
namespace xrpl {
struct STNumber_test : public beast::unit_test::suite
struct STNumber_test : public beast::unit_test::Suite
{
void
testCombo(Number number)
@@ -55,7 +55,7 @@ struct STNumber_test : public beast::unit_test::suite
testCombo(Number{mantissa});
std::initializer_list<std::int32_t> const exponents = {
Number::minExponent, -1, 0, 1, Number::maxExponent - 1};
Number::kMIN_EXPONENT, -1, 0, 1, Number::kMAX_EXPONENT - 1};
for (std::int32_t const exponent : exponents)
testCombo(Number{123, exponent});
@@ -69,10 +69,10 @@ struct STNumber_test : public beast::unit_test::suite
}
{
BEAST_EXPECT(numberFromJson(sfNumber, Json::Value(42)) == STNumber(sfNumber, 42));
BEAST_EXPECT(numberFromJson(sfNumber, Json::Value(-42)) == STNumber(sfNumber, -42));
BEAST_EXPECT(numberFromJson(sfNumber, json::Value(42)) == STNumber(sfNumber, 42));
BEAST_EXPECT(numberFromJson(sfNumber, json::Value(-42)) == STNumber(sfNumber, -42));
BEAST_EXPECT(numberFromJson(sfNumber, Json::UInt(42)) == STNumber(sfNumber, 42));
BEAST_EXPECT(numberFromJson(sfNumber, json::UInt(42)) == STNumber(sfNumber, 42));
BEAST_EXPECT(numberFromJson(sfNumber, "-123") == STNumber(sfNumber, -123));
@@ -101,12 +101,12 @@ struct STNumber_test : public beast::unit_test::suite
BEAST_EXPECT(numberFromJson(sfNumber, "-0.000e6") == STNumber(sfNumber, 0));
{
NumberRoundModeGuard const mg(Number::rounding_mode::towards_zero);
NumberRoundModeGuard const mg(Number::RoundingMode::TowardsZero);
// maxint64 9,223,372,036,854,775,807
auto const maxInt = std::to_string(std::numeric_limits<std::int64_t>::max());
// minint64 -9,223,372,036,854,775,808
auto const minInt = std::to_string(std::numeric_limits<std::int64_t>::min());
if (Number::getMantissaScale() == MantissaRange::mantissa_scale::small)
if (Number::getMantissaScale() == MantissaRange::MantissaScale::Small)
{
BEAST_EXPECT(
numberFromJson(sfNumber, maxInt) ==
@@ -124,27 +124,27 @@ struct STNumber_test : public beast::unit_test::suite
numberFromJson(sfNumber, minInt) ==
STNumber(
sfNumber,
Number{true, 9'223'372'036'854'775'808ULL, 0, Number::normalized{}}));
Number{true, 9'223'372'036'854'775'808ULL, 0, Number::Normalized{}}));
}
}
constexpr auto imin = std::numeric_limits<int>::min();
BEAST_EXPECT(numberFromJson(sfNumber, imin) == STNumber(sfNumber, Number(imin, 0)));
constexpr auto kIMIN = std::numeric_limits<int>::min();
BEAST_EXPECT(numberFromJson(sfNumber, kIMIN) == STNumber(sfNumber, Number(kIMIN, 0)));
BEAST_EXPECT(
numberFromJson(sfNumber, std::to_string(imin)) ==
STNumber(sfNumber, Number(imin, 0)));
numberFromJson(sfNumber, std::to_string(kIMIN)) ==
STNumber(sfNumber, Number(kIMIN, 0)));
constexpr auto imax = std::numeric_limits<int>::max();
BEAST_EXPECT(numberFromJson(sfNumber, imax) == STNumber(sfNumber, Number(imax, 0)));
constexpr auto kIMAX = std::numeric_limits<int>::max();
BEAST_EXPECT(numberFromJson(sfNumber, kIMAX) == STNumber(sfNumber, Number(kIMAX, 0)));
BEAST_EXPECT(
numberFromJson(sfNumber, std::to_string(imax)) ==
STNumber(sfNumber, Number(imax, 0)));
numberFromJson(sfNumber, std::to_string(kIMAX)) ==
STNumber(sfNumber, Number(kIMAX, 0)));
constexpr auto umax = std::numeric_limits<unsigned int>::max();
BEAST_EXPECT(numberFromJson(sfNumber, umax) == STNumber(sfNumber, Number(umax, 0)));
constexpr auto kUMAX = std::numeric_limits<unsigned int>::max();
BEAST_EXPECT(numberFromJson(sfNumber, kUMAX) == STNumber(sfNumber, Number(kUMAX, 0)));
BEAST_EXPECT(
numberFromJson(sfNumber, std::to_string(umax)) ==
STNumber(sfNumber, Number(umax, 0)));
numberFromJson(sfNumber, std::to_string(kUMAX)) ==
STNumber(sfNumber, Number(kUMAX, 0)));
// Obvious non-numbers tested here
try
@@ -193,7 +193,7 @@ struct STNumber_test : public beast::unit_test::suite
try
{
auto _ = numberFromJson(sfNumber, Json::Value());
auto _ = numberFromJson(sfNumber, json::Value());
BEAST_EXPECT(false);
}
catch (std::runtime_error const& e)
@@ -281,7 +281,7 @@ struct STNumber_test : public beast::unit_test::suite
static_assert(!std::is_convertible_v<STNumber*, Number*>);
for (auto const scale :
{MantissaRange::mantissa_scale::small, MantissaRange::mantissa_scale::large})
{MantissaRange::MantissaScale::Small, MantissaRange::MantissaScale::Large})
{
NumberMantissaScaleGuard const sg(scale);
testcase << to_string(Number::getMantissaScale());