refactor: Enable clang-tidy readability-identifier-naming check (#6571)

This commit is contained in:
Alex Kremer
2026-05-03 11:31:53 +01:00
committed by GitHub
parent 182d844996
commit 8995564ed6
1498 changed files with 58858 additions and 58914 deletions

View File

@@ -11,7 +11,7 @@
namespace xrpl {
class Quality_test : public beast::unit_test::suite
class Quality_test : public beast::unit_test::Suite
{
public:
// Create a raw, non-integral amount from mantissa and exponent
@@ -47,26 +47,26 @@ public:
template <class In1, class Out1, class Int, class In2, class Out2>
void
ceil_in(Quality const& q, In1 in, Out1 out, Int limit, In2 in_expected, Out2 out_expected)
ceilIn(Quality const& q, In1 in, Out1 out, Int limit, In2 inExpected, Out2 outExpected)
{
auto expect_result(amounts(in_expected, out_expected));
auto actual_result(q.ceil_in(amounts(in, out), amount(limit)));
auto expectResult(amounts(inExpected, outExpected));
auto actualResult(q.ceilIn(amounts(in, out), amount(limit)));
BEAST_EXPECT(actual_result == expect_result);
BEAST_EXPECT(actualResult == expectResult);
}
template <class In1, class Out1, class Int, class In2, class Out2>
void
ceil_out(Quality const& q, In1 in, Out1 out, Int limit, In2 in_expected, Out2 out_expected)
ceilOut(Quality const& q, In1 in, Out1 out, Int limit, In2 inExpected, Out2 outExpected)
{
auto const expect_result(amounts(in_expected, out_expected));
auto const actual_result(q.ceil_out(amounts(in, out), amount(limit)));
auto const expectResult(amounts(inExpected, outExpected));
auto const actualResult(q.ceilOut(amounts(in, out), amount(limit)));
BEAST_EXPECT(actual_result == expect_result);
BEAST_EXPECT(actualResult == expectResult);
}
void
test_ceil_in()
testCeilIn()
{
testcase("ceil_in");
@@ -74,7 +74,7 @@ public:
// 1 in, 1 out:
Quality const q(Amounts(amount(1), amount(1)));
ceil_in(
ceilIn(
q,
1,
1, // 1 in, 1 out
@@ -82,7 +82,7 @@ public:
1,
1); // 1 in, 1 out
ceil_in(
ceilIn(
q,
10,
10, // 10 in, 10 out
@@ -90,7 +90,7 @@ public:
5,
5); // 5 in, 5 out
ceil_in(
ceilIn(
q,
5,
5, // 5 in, 5 out
@@ -103,7 +103,7 @@ public:
// 1 in, 2 out:
Quality const q(Amounts(amount(1), amount(2)));
ceil_in(
ceilIn(
q,
40,
80, // 40 in, 80 out
@@ -111,7 +111,7 @@ public:
40,
80); // 40 in, 20 out
ceil_in(
ceilIn(
q,
40,
80, // 40 in, 80 out
@@ -119,7 +119,7 @@ public:
20,
40); // 20 in, 40 out
ceil_in(
ceilIn(
q,
40,
80, // 40 in, 80 out
@@ -132,7 +132,7 @@ public:
// 2 in, 1 out:
Quality const q(Amounts(amount(2), amount(1)));
ceil_in(
ceilIn(
q,
40,
20, // 40 in, 20 out
@@ -140,7 +140,7 @@ public:
20,
10); // 20 in, 10 out
ceil_in(
ceilIn(
q,
40,
20, // 40 in, 20 out
@@ -148,7 +148,7 @@ public:
40,
20); // 40 in, 20 out
ceil_in(
ceilIn(
q,
40,
20, // 40 in, 20 out
@@ -159,7 +159,7 @@ public:
}
void
test_ceil_out()
testCeilOut()
{
testcase("ceil_out");
@@ -167,7 +167,7 @@ public:
// 1 in, 1 out:
Quality const q(Amounts(amount(1), amount(1)));
ceil_out(
ceilOut(
q,
1,
1, // 1 in, 1 out
@@ -175,7 +175,7 @@ public:
1,
1); // 1 in, 1 out
ceil_out(
ceilOut(
q,
10,
10, // 10 in, 10 out
@@ -183,7 +183,7 @@ public:
5,
5); // 5 in, 5 out
ceil_out(
ceilOut(
q,
10,
10, // 10 in, 10 out
@@ -196,7 +196,7 @@ public:
// 1 in, 2 out:
Quality const q(Amounts(amount(1), amount(2)));
ceil_out(
ceilOut(
q,
40,
80, // 40 in, 80 out
@@ -204,7 +204,7 @@ public:
20,
40); // 20 in, 40 out
ceil_out(
ceilOut(
q,
40,
80, // 40 in, 80 out
@@ -212,7 +212,7 @@ public:
40,
80); // 40 in, 80 out
ceil_out(
ceilOut(
q,
40,
80, // 40 in, 80 out
@@ -225,7 +225,7 @@ public:
// 2 in, 1 out:
Quality const q(Amounts(amount(2), amount(1)));
ceil_out(
ceilOut(
q,
40,
20, // 40 in, 20 out
@@ -233,7 +233,7 @@ public:
40,
20); // 40 in, 20 out
ceil_out(
ceilOut(
q,
40,
20, // 40 in, 20 out
@@ -241,7 +241,7 @@ public:
40,
20); // 40 in, 20 out
ceil_out(
ceilOut(
q,
40,
20, // 40 in, 20 out
@@ -252,7 +252,7 @@ public:
}
void
test_raw()
testRaw()
{
testcase("raw");
@@ -262,13 +262,13 @@ public:
amount(349469768), // 349.469768 XRP
raw(2755280000000000ull, -15)); // 2.75528
STAmount const limit(raw(4131113916555555, -16)); // .4131113916555555
Amounts const result(q.ceil_out(value, limit));
BEAST_EXPECT(result.in != beast::zero);
Amounts const result(q.ceilOut(value, limit));
BEAST_EXPECT(result.in != beast::kZERO);
}
}
void
test_round()
testRound()
{
testcase("round");
@@ -290,7 +290,7 @@ public:
}
void
test_comparisons()
testComparisons()
{
testcase("comparisons");
@@ -327,7 +327,7 @@ public:
}
void
test_composition()
testComposition()
{
testcase("composition");
@@ -341,17 +341,17 @@ public:
Quality const q21(Amounts(amount2, amount1));
Quality const q31(Amounts(amount3, amount1));
BEAST_EXPECT(composed_quality(q12, q21) == q11);
BEAST_EXPECT(composedQuality(q12, q21) == q11);
Quality const q13_31(composed_quality(q13, q31));
Quality const q31_13(composed_quality(q31, q13));
Quality const q1331(composedQuality(q13, q31));
Quality const q3113(composedQuality(q31, q13));
BEAST_EXPECT(q13_31 == q31_13);
BEAST_EXPECT(q13_31 == q11);
BEAST_EXPECT(q1331 == q3113);
BEAST_EXPECT(q1331 == q11);
}
void
test_operations()
testOperations()
{
testcase("operations");
@@ -374,13 +374,13 @@ public:
void
run() override
{
test_comparisons();
test_composition();
test_operations();
test_ceil_in();
test_ceil_out();
test_raw();
test_round();
testComparisons();
testComposition();
testOperations();
testCeilIn();
testCeilOut();
testRaw();
testRound();
}
};