refactor: Enable clang-tidy readability-identifier-naming check (#6571)

This commit is contained in:
Alex Kremer
2026-05-03 11:31:53 +01:00
committed by GitHub
parent 182d844996
commit 8995564ed6
1498 changed files with 58858 additions and 58914 deletions

View File

@@ -16,14 +16,14 @@
namespace xrpl {
class PublicKey_test : public beast::unit_test::suite
class PublicKey_test : public beast::unit_test::Suite
{
public:
using blob = std::vector<std::uint8_t>;
template <class FwdIter, class Container>
static void
hex_to_binary(FwdIter first, FwdIter last, Container& out)
hexToBinary(FwdIter first, FwdIter last, Container& out)
{
struct Table
{
@@ -46,12 +46,12 @@ public:
}
};
static Table lut;
static Table kLUT;
out.reserve(std::distance(first, last) / 2);
while (first != last)
{
auto const hi(lut[(*first++)]);
auto const lo(lut[(*first++)]);
auto const hi(kLUT[(*first++)]);
auto const lo(kLUT[(*first++)]);
out.push_back((hi * 16) + lo);
}
}
@@ -60,7 +60,7 @@ public:
sig(std::string const& hex)
{
blob b;
hex_to_binary(hex.begin(), hex.end(), b);
hexToBinary(hex.begin(), hex.end(), b);
return b;
}
@@ -77,35 +77,35 @@ public:
// Fully canonical
BEAST_EXPECT(check(
ECDSACanonicality::fullyCanonical,
ECDSACanonicality::FullyCanonical,
"3045"
"022100FF478110D1D4294471EC76E0157540C2181F47DEBD25D7F9E7DDCCCD47EE"
"E905"
"0220078F07CDAE6C240855D084AD91D1479609533C147C93B0AEF19BC9724D003F"
"28"));
BEAST_EXPECT(check(
ECDSACanonicality::fullyCanonical,
ECDSACanonicality::FullyCanonical,
"3045"
"0221009218248292F1762D8A51BE80F8A7F2CD288D810CE781D5955700DA1684DF"
"1D2D"
"022041A1EE1746BFD72C9760CC93A7AAA8047D52C8833A03A20EAAE92EA19717B4"
"54"));
BEAST_EXPECT(check(
ECDSACanonicality::fullyCanonical,
ECDSACanonicality::FullyCanonical,
"3044"
"02206A9E43775F73B6D1EC420E4DDD222A80D4C6DF5D1BEECC431A91B63C928B75"
"81"
"022023E9CC2D61DDA6F73EAA6BCB12688BEB0F434769276B3127E4044ED895C9D9"
"6B"));
BEAST_EXPECT(check(
ECDSACanonicality::fullyCanonical,
ECDSACanonicality::FullyCanonical,
"3044"
"022056E720007221F3CD4EFBB6352741D8E5A0968D48D8D032C2FBC4F6304AD1D0"
"4E"
"02201F39EB392C20D7801C3E8D81D487E742FA84A1665E923225BD6323847C7187"
"9F"));
BEAST_EXPECT(check(
ECDSACanonicality::fullyCanonical,
ECDSACanonicality::FullyCanonical,
"3045"
"022100FDFD5AD05518CEA0017A2DCB5C4DF61E7C73B6D3A38E7AE93210A1564E8C"
"2F12"
@@ -114,28 +114,28 @@ public:
// Canonical but not fully canonical
BEAST_EXPECT(check(
ECDSACanonicality::canonical,
ECDSACanonicality::Canonical,
"3046"
"022100F477B3FA6F31C7CB3A0D1AD94A231FDD24B8D78862EE334CEA7CD08F6CBC"
"0A1B"
"022100928E6BCF1ED2684679730C5414AEC48FD62282B090041C41453C1D064AF5"
"97A1"));
BEAST_EXPECT(check(
ECDSACanonicality::canonical,
ECDSACanonicality::Canonical,
"3045"
"022063E7C7CA93CB2400E413A342C027D00665F8BAB9C22EF0A7B8AE3AAF092230"
"B6"
"0221008F2E8BB7D09521ABBC277717B14B93170AE6465C5A1B36561099319C4BEB"
"254C"));
BEAST_EXPECT(check(
ECDSACanonicality::canonical,
ECDSACanonicality::Canonical,
"3046"
"02210099DCA1188663DDEA506A06A7B20C2B7D8C26AFF41DECE69D6C5F7C967D32"
"625F"
"022100897658A6B1F9EEE5D140D7A332DA0BD73BB98974EA53F6201B01C1B594F2"
"86EA"));
BEAST_EXPECT(check(
ECDSACanonicality::canonical,
ECDSACanonicality::Canonical,
"3045"
"02200855DE366E4E323AA2CE2A25674401A7D11F72EC432770D07F7B57DF7387AE"
"C0"
@@ -144,26 +144,26 @@ public:
// valid
BEAST_EXPECT(check(
ECDSACanonicality::fullyCanonical,
ECDSACanonicality::FullyCanonical,
"3006"
"020101"
"020102"));
BEAST_EXPECT(check(
ECDSACanonicality::fullyCanonical,
ECDSACanonicality::FullyCanonical,
"3044"
"02203932c892e2e550f3af8ee4ce9c215a87f9bb831dcac87b2838e2c2eaa891df"
"0c"
"022030b61dd36543125d56b9f9f3a1f53189e5af33cdda8d77a5209aec03978fa0"
"01"));
BEAST_EXPECT(check(
ECDSACanonicality::canonical,
ECDSACanonicality::Canonical,
"3045"
"0220076045be6f9eca28ff1ec606b833d0b87e70b2a630f5e3a496b110967a40f9"
"0a"
"0221008fffd599910eefe00bc803c688eca1d2ba7f6b180620eaa03488e6585db6"
"ba01"));
BEAST_EXPECT(check(
ECDSACanonicality::canonical,
ECDSACanonicality::Canonical,
"3046"
"022100876045be6f9eca28ff1ec606b833d0b87e70b2a630f5e3a496b110967a40"
"f90a"
@@ -393,8 +393,8 @@ public:
{
auto const pk1 = derivePublicKey(
KeyType::secp256k1,
generateSecretKey(KeyType::secp256k1, generateSeed("masterpassphrase")));
KeyType::Secp256k1,
generateSecretKey(KeyType::Secp256k1, generateSeed("masterpassphrase")));
auto const pk2 = parseBase58<PublicKey>(
TokenType::NodePublic, "n94a1u4jAz288pZLtw6yFWVbi89YamiC6JBXPVUj5zmExe5fTVg9");
@@ -403,14 +403,14 @@ public:
BEAST_EXPECT(pk1 == *pk2); // NOLINT(bugprone-unchecked-optional-access)
}
testBase58(KeyType::secp256k1);
testBase58(KeyType::Secp256k1);
testcase("Base58: ed25519");
{
auto const pk1 = derivePublicKey(
KeyType::ed25519,
generateSecretKey(KeyType::ed25519, generateSeed("masterpassphrase")));
KeyType::Ed25519,
generateSecretKey(KeyType::Ed25519, generateSeed("masterpassphrase")));
auto const pk2 = parseBase58<PublicKey>(
TokenType::NodePublic, "nHUeeJCSY2dM71oxM8Cgjouf5ekTuev2mwDpc374aLMxzDLXNmjf");
@@ -419,7 +419,7 @@ public:
BEAST_EXPECT(pk1 == *pk2); // NOLINT(bugprone-unchecked-optional-access)
}
testBase58(KeyType::ed25519);
testBase58(KeyType::Ed25519);
}
void
@@ -428,16 +428,16 @@ public:
testcase("Miscellaneous operations");
auto const pk1 = derivePublicKey(
KeyType::secp256k1,
generateSecretKey(KeyType::secp256k1, generateSeed("masterpassphrase")));
KeyType::Secp256k1,
generateSecretKey(KeyType::Secp256k1, generateSeed("masterpassphrase")));
PublicKey const pk2(pk1);
BEAST_EXPECT(pk1 == pk2);
BEAST_EXPECT(pk2 == pk1);
PublicKey pk3 = derivePublicKey(
KeyType::secp256k1,
generateSecretKey(KeyType::secp256k1, generateSeed("arbitraryPassPhrase")));
KeyType::Secp256k1,
generateSecretKey(KeyType::Secp256k1, generateSeed("arbitraryPassPhrase")));
// Testing the copy assignment operation of PublicKey class
pk3 = pk2;
BEAST_EXPECT(pk3 == pk2);