mirror of
https://github.com/XRPLF/rippled.git
synced 2026-06-03 08:46:46 +00:00
refactor: Enable clang-tidy readability-identifier-naming check (#6571)
This commit is contained in:
@@ -23,7 +23,7 @@
|
||||
|
||||
namespace xrpl {
|
||||
|
||||
class SetRegularKey_test : public beast::unit_test::suite
|
||||
class SetRegularKey_test : public beast::unit_test::Suite
|
||||
{
|
||||
public:
|
||||
void
|
||||
@@ -32,31 +32,31 @@ public:
|
||||
using namespace test::jtx;
|
||||
|
||||
testcase("Set regular key");
|
||||
Env env{*this, testable_amendments()};
|
||||
Env env{*this, testableAmendments()};
|
||||
Account const alice("alice");
|
||||
Account const bob("bob");
|
||||
env.fund(XRP(10000), alice, bob);
|
||||
|
||||
env(regkey(alice, bob));
|
||||
env(noop(alice), sig(bob));
|
||||
env(noop(alice), sig(alice));
|
||||
env(noop(alice), Sig(bob));
|
||||
env(noop(alice), Sig(alice));
|
||||
|
||||
testcase("Disable master key");
|
||||
env(fset(alice, asfDisableMaster), sig(alice));
|
||||
env(noop(alice), sig(bob));
|
||||
env(noop(alice), sig(alice), ter(tefMASTER_DISABLED));
|
||||
env(fset(alice, asfDisableMaster), Sig(alice));
|
||||
env(noop(alice), Sig(bob));
|
||||
env(noop(alice), Sig(alice), Ter(tefMASTER_DISABLED));
|
||||
|
||||
testcase("Re-enable master key");
|
||||
env(fclear(alice, asfDisableMaster), sig(alice), ter(tefMASTER_DISABLED));
|
||||
env(fclear(alice, asfDisableMaster), Sig(alice), Ter(tefMASTER_DISABLED));
|
||||
|
||||
env(fclear(alice, asfDisableMaster), sig(bob));
|
||||
env(noop(alice), sig(bob));
|
||||
env(noop(alice), sig(alice));
|
||||
env(fclear(alice, asfDisableMaster), Sig(bob));
|
||||
env(noop(alice), Sig(bob));
|
||||
env(noop(alice), Sig(alice));
|
||||
|
||||
testcase("Revoke regular key");
|
||||
env(regkey(alice, disabled));
|
||||
env(noop(alice), sig(bob), ter(tefBAD_AUTH));
|
||||
env(noop(alice), sig(alice));
|
||||
env(regkey(alice, kDISABLED));
|
||||
env(noop(alice), Sig(bob), Ter(tefBAD_AUTH));
|
||||
env(noop(alice), Sig(alice));
|
||||
}
|
||||
|
||||
void
|
||||
@@ -65,11 +65,11 @@ public:
|
||||
using namespace test::jtx;
|
||||
|
||||
testcase("Set regular key to master key");
|
||||
Env env{*this, testable_amendments()};
|
||||
Env env{*this, testableAmendments()};
|
||||
Account const alice("alice");
|
||||
env.fund(XRP(10000), alice);
|
||||
|
||||
env(regkey(alice, alice), ter(temBAD_REGKEY));
|
||||
env(regkey(alice, alice), Ter(temBAD_REGKEY));
|
||||
}
|
||||
|
||||
void
|
||||
@@ -87,7 +87,7 @@ public:
|
||||
BEAST_EXPECT(
|
||||
ar->isFieldPresent(sfFlags) && ((ar->getFieldU32(sfFlags) & lsfPasswordSpent) == 0));
|
||||
|
||||
env(regkey(alice, bob), sig(alice), fee(0));
|
||||
env(regkey(alice, bob), Sig(alice), Fee(0));
|
||||
|
||||
ar = env.le(alice);
|
||||
BEAST_EXPECT(
|
||||
@@ -95,7 +95,7 @@ public:
|
||||
((ar->getFieldU32(sfFlags) & lsfPasswordSpent) == lsfPasswordSpent));
|
||||
|
||||
// The second SetRegularKey transaction with Fee=0 should fail.
|
||||
env(regkey(alice, bob), sig(alice), fee(0), ter(telINSUF_FEE_P));
|
||||
env(regkey(alice, bob), Sig(alice), Fee(0), Ter(telINSUF_FEE_P));
|
||||
|
||||
env.trust(bob["USD"](1), alice);
|
||||
env(pay(bob, alice, bob["USD"](1)));
|
||||
@@ -117,7 +117,7 @@ public:
|
||||
|
||||
auto jv = regkey(alice, bob);
|
||||
jv[sfFlags.fieldName] = tfUniversalMask;
|
||||
env(jv, ter(temINVALID_FLAG));
|
||||
env(jv, Ter(temINVALID_FLAG));
|
||||
}
|
||||
|
||||
void
|
||||
@@ -127,7 +127,7 @@ public:
|
||||
|
||||
testcase("Ticket regular key");
|
||||
Env env{*this};
|
||||
Account const alice{"alice", KeyType::ed25519};
|
||||
Account const alice{"alice", KeyType::Ed25519};
|
||||
env.fund(XRP(1000), alice);
|
||||
env.close();
|
||||
|
||||
@@ -137,34 +137,34 @@ public:
|
||||
std::uint32_t ticketSeq{env.seq(alice)};
|
||||
|
||||
// Make sure we can give a regular key using a ticket.
|
||||
Account const alie{"alie", KeyType::secp256k1};
|
||||
env(regkey(alice, alie), ticket::use(--ticketSeq));
|
||||
Account const alie{"alie", KeyType::Secp256k1};
|
||||
env(regkey(alice, alie), ticket::Use(--ticketSeq));
|
||||
env.close();
|
||||
|
||||
// Disable alice's master key using a ticket.
|
||||
env(fset(alice, asfDisableMaster), sig(alice), ticket::use(--ticketSeq));
|
||||
env(fset(alice, asfDisableMaster), Sig(alice), ticket::Use(--ticketSeq));
|
||||
env.close();
|
||||
|
||||
// alice should be able to sign using the regular key but not the
|
||||
// master key.
|
||||
std::uint32_t const aliceSeq{env.seq(alice)};
|
||||
env(noop(alice), sig(alice), ter(tefMASTER_DISABLED));
|
||||
env(noop(alice), sig(alie), ter(tesSUCCESS));
|
||||
env(noop(alice), Sig(alice), Ter(tefMASTER_DISABLED));
|
||||
env(noop(alice), Sig(alie), Ter(tesSUCCESS));
|
||||
env.close();
|
||||
BEAST_EXPECT(env.seq(alice) == aliceSeq + 1);
|
||||
|
||||
// Re-enable the master key using a ticket.
|
||||
env(fclear(alice, asfDisableMaster), sig(alie), ticket::use(--ticketSeq));
|
||||
env(fclear(alice, asfDisableMaster), Sig(alie), ticket::Use(--ticketSeq));
|
||||
env.close();
|
||||
|
||||
// Disable the regular key using a ticket.
|
||||
env(regkey(alice, disabled), sig(alie), ticket::use(--ticketSeq));
|
||||
env(regkey(alice, kDISABLED), Sig(alie), ticket::Use(--ticketSeq));
|
||||
env.close();
|
||||
|
||||
// alice should be able to sign using the master key but not the
|
||||
// regular key.
|
||||
env(noop(alice), sig(alice), ter(tesSUCCESS));
|
||||
env(noop(alice), sig(alie), ter(tefBAD_AUTH));
|
||||
env(noop(alice), Sig(alice), Ter(tesSUCCESS));
|
||||
env(noop(alice), Sig(alie), Ter(tefBAD_AUTH));
|
||||
env.close();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user