From 88361aa9ed810721a14bbafc045a96ecad20c866 Mon Sep 17 00:00:00 2001
From: Bart Thomee <11445373+bthomee@users.noreply.github.com>
Date: Sat, 2 Aug 2025 13:01:23 -0400
Subject: [PATCH] Remove unnecessary authentication for read-only remote
 access, and update remote name

---
 .github/actions/dependencies/action.yml |  8 --------
 .github/workflows/libxrpl.yml           | 14 +++++++-------
 .github/workflows/macos.yml             |  2 --
 .github/workflows/nix.yml               |  2 --
 .github/workflows/windows.yml           |  2 --
 5 files changed, 7 insertions(+), 21 deletions(-)

diff --git a/.github/actions/dependencies/action.yml b/.github/actions/dependencies/action.yml
index b353664573..527d626f0d 100644
--- a/.github/actions/dependencies/action.yml
+++ b/.github/actions/dependencies/action.yml
@@ -16,14 +16,6 @@ runs:
         fi
         conan remote add --index 0 xrplf "${CONAN_URL}"
         echo "Added conan remote xrplf at ${CONAN_URL}"
-    - name: try to authenticate to Conan remote
-      if: env.CONAN_LOGIN_USERNAME_XRPLF != '' && env.CONAN_PASSWORD_XRPLF != ''
-      id: remote
-      shell: bash
-      run: |
-        echo "Authenticating to xrplf remote..."
-        conan remote auth xrplf --force
-        conan remote list-users
     - name: list missing binaries
       id: binaries
       shell: bash
diff --git a/.github/workflows/libxrpl.yml b/.github/workflows/libxrpl.yml
index 4a2af4ac45..a8746fe297 100644
--- a/.github/workflows/libxrpl.yml
+++ b/.github/workflows/libxrpl.yml
@@ -1,8 +1,8 @@
 name: Check libXRPL compatibility with Clio
 env:
   CONAN_URL: https://conan.ripplex.io
-  CONAN_LOGIN_USERNAME_RIPPLE: ${{ secrets.CONAN_USERNAME }}
-  CONAN_PASSWORD_RIPPLE: ${{ secrets.CONAN_TOKEN }}
+  CONAN_LOGIN_USERNAME_XRPLF: ${{ secrets.CONAN_USERNAME }}
+  CONAN_PASSWORD_XRPLF: ${{ secrets.CONAN_TOKEN }}
 on:
   pull_request:
     paths:
@@ -43,20 +43,20 @@ jobs:
         shell: bash
         run: |
           conan export . ${{ steps.channel.outputs.channel }}
-      - name: Add Ripple Conan remote
+      - name: Add Conan remote
         shell: bash
         run: |
           conan remote list
-          conan remote remove ripple || true
+          conan remote remove xrplf || true
           # Do not quote the URL. An empty string will be accepted (with a non-fatal warning), but a missing argument will not.
-          conan remote add ripple ${{ env.CONAN_URL }} --insert 0
+          conan remote add xrplf ${{ env.CONAN_URL }} --insert 0
       - name: Parse new version
         id: version
         shell: bash
         run: |
           echo version="$(cat src/libxrpl/protocol/BuildInfo.cpp | grep "versionString =" \
             | awk -F '"' '{print $2}')" | tee ${GITHUB_OUTPUT}
-      - name: Try to authenticate to Ripple Conan remote
+      - name: Try to authenticate to Conan remote
         id: remote
         shell: bash
         run: |
@@ -64,7 +64,7 @@ jobs:
           # https://docs.conan.io/1/reference/commands/misc/user.html#using-environment-variables
           # https://docs.conan.io/1/reference/env_vars.html#conan-login-username-conan-login-username-remote-name
           # https://docs.conan.io/1/reference/env_vars.html#conan-password-conan-password-remote-name
-          echo outcome=$(conan user --remote ripple --password >&2 \
+          echo outcome=$(conan user --remote xrplf --password >&2 \
             && echo success || echo failure) | tee ${GITHUB_OUTPUT}
       - name: Upload new package
         id: upload
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
index 5e986fd443..60fb386248 100644
--- a/.github/workflows/macos.yml
+++ b/.github/workflows/macos.yml
@@ -19,8 +19,6 @@ concurrency:
 # to pollute conan/profiles directory with settings which might not work for others
 env:
   CONAN_URL: https://conan.ripplex.io
-  CONAN_LOGIN_USERNAME_RIPPLE: ${{ secrets.CONAN_USERNAME }}
-  CONAN_PASSWORD_RIPPLE: ${{ secrets.CONAN_TOKEN }}
   CONAN_GLOBAL_CONF: |
     core.download:parallel={{os.cpu_count()}}
     core.upload:parallel={{os.cpu_count()}}
diff --git a/.github/workflows/nix.yml b/.github/workflows/nix.yml
index c28ea76e5f..14e98e3fb0 100644
--- a/.github/workflows/nix.yml
+++ b/.github/workflows/nix.yml
@@ -20,8 +20,6 @@ concurrency:
 # to pollute conan/profiles directory with settings which might not work for others
 env:
   CONAN_URL: https://conan.ripplex.io
-  CONAN_LOGIN_USERNAME_RIPPLE: ${{ secrets.CONAN_USERNAME }}
-  CONAN_PASSWORD_RIPPLE: ${{ secrets.CONAN_TOKEN }}
   CONAN_GLOBAL_CONF: |
     core.download:parallel={{ os.cpu_count() }}
     core.upload:parallel={{ os.cpu_count() }}
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index 885e7d3701..729b8d7b63 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -22,8 +22,6 @@ concurrency:
 # to pollute conan/profiles directory with settings which might not work for others
 env:
   CONAN_URL: https://conan.ripplex.io
-  CONAN_LOGIN_USERNAME_RIPPLE: ${{ secrets.CONAN_USERNAME }}
-  CONAN_PASSWORD_RIPPLE: ${{ secrets.CONAN_TOKEN }}
   CONAN_GLOBAL_CONF: |
     core.download:parallel={{os.cpu_count()}}
     core.upload:parallel={{os.cpu_count()}}