ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-26 22:15:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Convert throws and catch alls (RIPD-1046)

Browse Source
This commit is contained in:
Miguel Portilla
2015-11-11 10:47:21 -05:00
committed by Nik Bougalis
parent 0633ef1ba1
commit 880f354b90
127 changed files with 786 additions and 710 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/ripple/app/ledger/impl/LedgerConsensusImp.cpp
View File

@@ -35,6 +35,7 @@
#include <ripple/app/misc/TxQ.h>
#include <ripple/app/misc/Validations.h>
#include <ripple/app/tx/apply.h>
#include <ripple/basics/contract.h>
#include <ripple/basics/CountedObject.h>
#include <ripple/basics/Log.h>
#include <ripple/core/Config.h>
@@ -531,7 +532,7 @@ void LedgerConsensusImp::mapComplete (
leaveConsensus();
JLOG (j_.error) <<
"Missing node processing complete map " << mn;
throw;
Throw();
}
}
@@ -731,7 +732,7 @@ void LedgerConsensusImp::timerEntry ()
leaveConsensus ();
JLOG (j_.error) <<
"Missing node during consensus process " << mn;
throw;
Throw();
}
}
@@ -1167,7 +1168,7 @@ void LedgerConsensusImp::accept (std::shared_ptr<SHAMap> set)
anyDisputes = true;
}
catch (...)
catch (std::exception const&)
{
JLOG (j_.debug)
<< "Failed to apply transaction we voted NO on";
@@ -1857,7 +1858,7 @@ applyTransaction (Application& app, OpenView& view,
<< "Transaction retry: " << transHuman (result.first);
return LedgerConsensusImp::resultRetry;
}
catch (...)
catch (std::exception const&)
{
JLOG (j.warning) << "Throws";
return LedgerConsensusImp::resultFail;
@@ -1889,7 +1890,7 @@ void applyTransactions (
{
txn = std::make_shared<STTx const>(SerialIter{item.slice()});
}
catch (...)
catch (std::exception const&)
{
JLOG (j.warning) << " Throws";
}
@@ -1933,7 +1934,7 @@ void applyTransactions (
++it;
}
}
catch (...)
catch (std::exception const&)
{
JLOG (j.warning)
<< "Transaction throws";